During the finalization of Mp initialization before booting into the OS,
depending on whether Mwait is supported or not, AsmRelocateApLoop
places Aps in MWAIT-loop or HLT-loop.
Since paging is necessary for long mode, the original implementation of
moving APs to 32-bit was to disable paging to e
AsmRelocateApLoop is replicated for future Intel Logic Extraction,
further brings AP into 64-bit, and enables paging.
Signed-off-by: Yuanhao Xie
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 51
+++
UefiCpuPkg/Library/MpInitLib/MpEqu.inc
Yuanhao Xie (2):
UefiCpuPkg: Duplicated AsmRelocateApLoop as AsmRelocateApLoopAmd
UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS.
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 168
+++
Reviewed-by: Gua Guo
-Original Message-
From: Sravanthi, K KavyaX
Sent: Wednesday, December 14, 2022 3:20 PM
To: devel@edk2.groups.io
Cc: Sravanthi, K KavyaX ; Dong, Guo
; Ni, Ray ; Lu, James
; Guo, Gua
Subject: [PATCH] UefiPayloadPkg/SerialPortLib: Enhance multi port behaviour
Ad
Add condition to return success if mUartCount is greater
than zero in SerialPortInitialize() to avoid filling mUartInfo
with the same hob data when SerialPortInitialize() is called
multiple times. Also add proper conditions in SerialPortRead
function to read the data properly from multiple UART's.
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4179
According to UEFI Spec 2.10 it is supposed to return the mapping from PCR
index to CC MR index:
//
// In the current version, we use the below mapping for TDX:
//
// TPM PCR Index | CC Measurement Register Index | TDX-measure
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4179
TDVF has the feature to do RTMR measurement in SEC phase. In the same time
it builds a GUID hob which carries the hash value of the measurement so
that in DXE phase a td event can be created based on this GUID Hob. There
is a
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4184
According to the Uefi spec 2.10 Section 38.2.2.
EFI_CC_MEASUREMENT_PROTOCOL.GetCapability, the minor version of
StructureVersion and ProtocolVersion should be 0.
Cc: Erdem Aktas [ruleof2]
Cc: James Bottomley [jejb]
Cc: Jie
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4179
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4184
This patch-set fix the incorrect implementation in CcMeasurement.
Patch#1:
Incorrect protocol and structure version
Patch#2/3:
Incorrect mapping between TPM PCR index and TDX Measu
Hey
Good catch!
I think we need handle below valid cases:
1. VAR_HEADER_VALID_ONLY (0x7F) <-- Header added (*)
2. VAR_ADDED (0x3F) <-- Header + data added
3. VAR_ADDED & VAR_IN_DELETED_TRANSITION (0x3E) <-- marked as deleted, but
still valid, before new data is added. (*)
4. VAR_ADDED & VAR_IN_DE
Hi,
> When the variable store has those variables, then system booting/rebooting
> will
> hangs in a ASSERT:
>
> NvVarStore Variable header State was invalid.
> ASSERT
> /mnt/working/source_code-git/edk2/OvmfPkg/Library/PlatformInitLib/Platform.c(819):
> ((BOOLEAN)(0==1))
I'm wondering how yo
On Mon, Dec 12, 2022 at 10:38:46PM -0500, Michael Kubacki wrote:
> Hi all,
>
> I still need reviews on this series. It should only take a few minutes of
> your time.
>
> The TianoCore wiki changes that these changes link to are available now -
> https://github.com/tianocore/tianocore.github.io/wi
Hi Gaoliming,
I have updated the commit message title with the package name.
Commit Message Title - " *ShellPkg: Displaying SMBIOS Type38 fields in
formatted manner":*
**
Kindly let us know if we need to make any changes.
**
Thanks,
Prakash K
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You r
From: Gua Guo
For Windows add below tool for code coverage
1. OpenCppCoverage: parsing pdb file to generate coverage
data
2. pycobertura: show up html format data for coverage data
For Linux add below tool for code coverage
1. lcov: parsing gcda gcno file to generate coverage data
2. lcov-cobert
From: Gua Guo
For GCC, use lcov to generate Unit Test code coverage
report
For VS2019, use OpenCppCoverage to generate code
coverage report
Cc: Bob Feng
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner.py
From: Gua Guo
V1: Add coverage option for GCC
V2: Add ReadMe.md for how to generate coverage report
V3: Add VS2019 and GCC code coverage support
V4: Add VS2019 and GCC Azure CI/CD support
V5: Fix some typo and some flow issue
V6: Remove html coverage information
- Due to python 3.11 install lxm
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
Reviewed-by: Michael Kubacki
On 12/12/2022 2:32 AM, Zhiguang Liu wrote:
Hi UnitTestFrameworkPkg Maintainers and reviewers,
Could you help review this patch?
Thanks
Zhiguang
-Original Message-
From: devel@edk2.groups.io On Behalf Of
Zhiguang Liu
Sent: Tuesday, December 6, 2022 1:26
On December 14, 2022 12:04 AM, Lendacky, Thomas wrote:
>
> On 12/12/22 23:48, Min Xu wrote:
> > From: Min M Xu
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171
> >
>
> This patch causes crashes for SEV guests and breaks bisect-ability of the
> EDK2 tree. See below...
>
> > /**
> >
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Liu, Zhiguang
> Sent: Sunday, December 11, 2022 11:33 PM
> To: devel@edk2.groups.io; Liu, Zhiguang ; Kinney,
> Michael D ; Michael
> Kubacki ; Sean Brogan
>
> Cc: Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] UnitTestFram
On December 14, 2022 12:05 AM, Lendacky, Thomas wrote:
> On 12/12/22 23:48, Min Xu wrote:
> > From: Tom Lendacky
> >
> > Add support to use the reserved shared memory within the IoMmu library.
> > This improves boot times for all SEV guests, with SEV-SNP benefiting
> > the most as it avoids the pa
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Liu, Zhiguang
> Sent: Sunday, December 11, 2022 11:34 PM
> To: devel@edk2.groups.io; Liu, Zhiguang ; Gao, Liming
> ; Kinney, Michael
> D
> Cc: Ni, Ray
> Subject: RE: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: R
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Liu, Zhiguang
> Sent: Sunday, December 11, 2022 11:30 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Kinney, Michael D
> ; Gao, Liming
> ; Ni, Ray
> Subject: [PATCH v2] MdePkg/BaseCpuLib: Remove assembly for CpuFlush
From: "Simon Wang"
BIOS feature driver cannot recognize "@Redfish.Settings",
decode it and get pending setting URI. So BIOS feature
driver can consume pending setting from correct place.
Signed-off-by: Simon Wang
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Red
[AMD Official Use Only - General]
Hi Abner,
Thanks for quick review. I'll create a new library and submit
the patch.
Thanks
AbduL
From: abner.chang via groups.io
Sent: 08 December 2022 10:38
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Subject: Re: [edk2-devel]
From: "Simon Wang"
BIOS feature driver cannot recognize "@Redfish.Settings",
decode it and get pending setting URI. So BIOS feature
driver can consume pending setting from correct place.
Signed-off-by: Simon Wang
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
[AMD Official Use Only - General]
Hi Abner,
I’ll drop this patch from the patch list. We will investigate
and submit a separate patch for handling the S3 save stage.
Thanks
AbduL
From: abner.chang via groups.io
Sent: 08 December 2022 11:17
To: Attar, AbdulLateef (Abdul Lateef) ;
In the commit 4f173db8b4 "OvmfPkg/PlatformInitLib: Add functions for
EmuVariableNvStore"
, it introduced a PlatformValidateNvVarStore() function for checking the
integrity of NvVarStore.
In some cases when the VariableHeader->StartId is VARIABLE_DATA, the
VariableHeader->State
is not just one of
From: "Simon Wang"
BIOS feature driver cannot recognize "@Redfish.Settings", decode it and get
pending setting URI. So BIOS feature driver can consume pending setting from
correct place.
Signed-off-by: Simon Wang
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
R
Ping. Can I get a review and/or some comments on this patch, please?
Thanks,
-Jan
Jan Bobek writes:
> Based on whether the DER-encoded ContentInfo structure is present in
> authenticated SetVariable payload or not, the SHA-256 OID can be
> located at different places.
>
> UEFI specification expl
Merged: https://github.com/tianocore/edk2/pull/3761
Commit:
https://github.com/tianocore/edk2/commit/804e8c656643642894a26a2ce3652ad4567b658f
Mike
> -Original Message-
> From: Anthony PERARD
> Sent: Tuesday, December 13, 2022 8:06 AM
> To: Kinney, Michael D
> Cc: devel@edk2.groups.io;
Hi Pawel,
Let's add Ray and Vincent to this topic to help pick the best option.
If everything is rebuilt from sources, then just removing the union
member will work.
The challenge is that the non-Itanium CPU archs that may depend on the
current binary layout of these structures. This could be a
Merged: https://github.com/tianocore/edk2/pull/3744
Commit:
https://github.com/tianocore/edk2/commit/592bf33a29360e8a447ed8b75daefe94c0888642
Mike
> -Original Message-
> From: Gao, Zhichao
> Sent: Sunday, December 11, 2022 11:17 PM
> To: Ard Biesheuvel ; Kinney, Michael D
>
> Cc: dev
Thanks, Konstantin,
I approve this version.
Thanks,
Jake
From: Konstantin Aladyshev
Sent: Tuesday, December 13, 2022 11:22 AM
To: devel@edk2.groups.io
Cc: bob.c.f...@intel.com ; gaolim...@byosoft.com.cn
; yuwei.c...@intel.com ; Jake
Garver ; Konstantin Aladysh
Merged as 11ce7a2de754..1fd8d08970a9
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97318): https://edk2.groups.io/g/devel/message/97318
Mute This Topic: https://groups.io/mt/94808914/21656
Group Owner: de
Merged as 11ce7a2de754..1fd8d08970a9
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97317): https://edk2.groups.io/g/devel/message/97317
Mute This Topic: https://groups.io/mt/94808915/21656
Group Owner: de
Thanks Jake!
I've also verified that this change is enough to fix the cycle dependency issue.
I've sent an updated patch to the mailing list.
Best regards,
Konstantin Aladyshev
On Tue, Dec 13, 2022 at 6:42 PM Jake Garver wrote:
>
> Hi, Konstantin,
>
> Thanks for working with me offline to repro
EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
...
PCI_VENDOR_ID = <...>
PCI_DEVICE_ID = <...>
PCI_CLASS_CODE = <...>
PCI_REVISION = <...>
``
On Mon, Sep 19, 2022 at 05:01:48PM +, Kinney, Michael D wrote:
> Reviewed-by: Michael D Kinney
Hi,
Could this patch be merged, or is something missing?
Cheers,
--
Anthony PERARD
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#973
On 12/12/22 23:48, Min Xu wrote:
From: Tom Lendacky
Add support to use the reserved shared memory within the IoMmu library.
This improves boot times for all SEV guests, with SEV-SNP benefiting the
most as it avoids the page state change call to the hypervisor.
Thanks for including the patch,
On 12/12/22 23:48, Min Xu wrote:
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171
A typical QEMU fw_cfg read bytes with IOMMU for td guest is that:
(QemuFwCfgReadBytes@QemuFwCfgLib.c is the example)
1) Allocate DMA Access buffer
2) Map actual data buffer
3) start the tran
Hi, Konstantin,
Thanks for working with me offline to reproduce this.
Short answer: We can live without the "$(DEBUG_DIR)(+)$(MODULE_NAME).efi"
output and I think removing that will resolve your issue. Rather than revert
the original change, can you submit a new patch that removes just that l
On 12/12/22 23:52, Xu, Min M wrote:
Hi, Tom
I cannot apply the patch extracted from your mail with the git am command. So I
have to manually port the patch. Please check and test if the patch is correct.
Thanks, Min! Will do. I'll report back once I'm done.
Thanks,
Tom
Thanks
Min
-Or
Merged as df870c7beaee..425cce541517
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97309): https://edk2.groups.io/g/devel/message/97309
Mute This Topic: https://groups.io/mt/94568084/21656
Group Owner: de
Merged as 5890a18409a0..11ce7a2de754
Thanks.
Regards,
Sami Mujawar
On 06/09/2022 09:28 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Pierre
On 12/13/2022 12:25 AM, Rebecca Cran wrote:
According to
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections,
it looks like normal markdown _should_ apply within collapsed sections?
It did not work consistent
Merged as f0385722832d..df870c7beaee
Thanks.
Regards,
Sami Mujawar
On 08/12/2022 12:51 pm, Sami Mujawar via groups.io wrote:
HI Sahil,
Thank you for the updated patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 08/12/2022, 12:07, "sahil" wrote:
Thanks Ray. 😊
-Original Message-
From: Ni, Ray
Sent: Tuesday, December 13, 2022 5:05 PM
To: Zeng, Star ; devel@edk2.groups.io; Wu, Jiaxin
; Guenzel, Robert
Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling
Star,
It has been merged last week.
> -Original Mes
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/05/2022 01:13 am, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
The SpellCheck plugin began reporting new typos that were previously
missed. This change
Hi Michael,
Thank you for this patch.
these changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/05/2022 01:13 am, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929
The SpellCheck plugin began repo
Hi Michael,
I just noted that 'interfacer' is no longer required in the
'ExtendWords' list. Please find my response inline marked [SAMI].
With the comment below fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/05/2022 01:13 am, mikub...@linux.microsoft.com wrote:
From: Michael
Star,
It has been merged last week.
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, December 13, 2022 4:41 PM
> To: devel@edk2.groups.io; Wu, Jiaxin ; Ni, Ray
> ; Guenzel, Robert
>
> Cc: Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling
>
>
Hi,
When could the patch be merged ?
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin
Sent: Wednesday, November 30, 2022 8:47 AM
To: devel@edk2.groups.io; Ni, Ray ; Guenzel, Robert
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handlin
53 matches
Mail list logo
