Attached is the report for Coverity issues identified in ShellPkg based
on edk2-stable202205.
Cc: Vasudevan Sambandan
Cc: Sundaresan Selvaraj
Cc: Arun k
Cc: Sainadh N
Signed-off-by: Kalaivani P
---
ShellPkg/Application/Shell/ShellManParser.c | 6 +-
ShellPkg/Application/Shell/ShellPro
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sunil V L
> 发送时间: 2022年11月11日 19:21
> 收件人: devel@edk2.groups.io
> 抄送: Abner Chang ; Zhihao Li
> ; Michael D Kinney ;
> Liming Gao ; Zhiguang Liu
> ; Daniel Schaefer
> 主题: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix
Hi Gaoliming,
Link for Pull Request -> https://github.com/tianocore/edk2/pull/3656
Thanks,
Prakash K
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96667): https://edk2.groups.io/g/devel/message/96667
Mute This Topic: https://groups.io/
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, November 29, 2022
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344
Thanks. RPi4 and Juno use EmbeddedPkg/MetronomeDxe
(https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/MetronomeDxe/Metronome.c#L54)
which uses the PCD PcdMetronomeTickPeriod.
JunoPkg overrides that to 1000, while RPi4 uses the default of 100.
Given that the clocks run at 50MHz and 54MH
*Tools, CI, Code base construction meeting series*
*When:*
Monday, November 28, 2022
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623296 )
*Description:*
TianoCore com
On 11/28/22 15:59, Kun Qin wrote:
Hi Rebecca/Ard,
I was trying to reach out regarding the original patches earlier (see
below) but it might fell off your stacks
due to high traffic on the mailing list. Could you please kindly review
the questions when you have a chance?
In addition, I found
Sorry, I missed this originally. I've added my replies inline.][
On 9/29/22 12:45, Kun Qin wrote:
Hi Rebecca,
Thanks for sending this patch. I have a few questions inline "[KQ]".
Could you please help me to
understand the patch better? Thanks in advance.
Regards,
Kun
On 8/29/2022 8:59 AM, R
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, November 28, 2022
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623296 )
*Description:*
Tia
Hi Rebecca/Ard,
I was trying to reach out regarding the original patches earlier (see
below) but it might fell off your stacks
due to high traffic on the mailing list. Could you please kindly review
the questions when you have a chance?
In addition, I found another edge case of the MP service
After discussing this a bit more internally, I think I'm actually coming
around to removing the compiler external dependencies. Leaving behind
the unused external dependencies is likely to lead to them collecting
dust, so it would probably be better left for consumers to define at the
platform
Rebecca,
gBS->Stall() is built on top [1] of the Metronome Architectural Protocol [2].
You should look at how the platform implements the Metronome Architectural
Protocol.
It looks like most platform implement a generic Metronome Driver[3] that just
sits on top of the platforms TimerLib [4]
I've been doing some work on USB and ended up realizing that
gBS->Stall(1) is taking much longer than it should: on my Juno R2 it's
stalling for 100 us, while on my Raspberry Pi 4 it's 10 us.
This appears to be causing a USB bulk transfer request that asks for a
1ms timeout taking 100ms on the
On Mon, Sep 26, 2022 at 10:24:58AM +0200, Ard Biesheuvel wrote:
> When the memory protections were implemented and enabled on ArmVirtQemu
> 5+ years ago, we had to work around the fact that GRUB at the time
> expected EFI_LOADER_DATA to be executable, as that is the memory type it
> allocates when
Ard,
I agree it should be a strong recommendation for all of these reasons.
There is a patch review for this spec for use of 'static'. Can you
please provide feedback with your recommended content?
Thanks,
Mike
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, November 28,
Quoting Chris Fernald (2022-11-28 06:20:36)
> Over-all I think this change is good to go. My only outstanding concern
> would be around deleting these yaml files for the compilers. I fear
> deleting them may break others work-flows and wonder if instead we
> should update the python files to first
Hello Ard,
On 11/26/22 15:33, Ard Biesheuvel wrote:
On Thu, 24 Nov 2022 at 17:18, wrote:
From: Pierre Gondois
v1:
- https://edk2.groups.io/g/devel/message/96356
v2:
- https://edk2.groups.io/g/devel/message/96434
- Reformulate commit message.
- Do not warn if no algorithm is found as the mes
Hi Sahil,
Please split the license update out into a separate patch.
/
Leif
On 2022-11-24 15:55, sa...@arm.com wrote:
There is no need for a separate ID for CCIX host bridge,
therefore reusing PCIe PNP ID for CCIX.
Also, updating the file's license to resolve error during
ECC checks.
Sign
Hi all,
Could you please help to review this patch? Thanks a lot!
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Tuesday, November 22, 2022 7:48 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Ni, Ra
Hi all,
Could you please help to review this patch? Thanks a lot!
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Tuesday, November 22, 2022 7:48 PM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Michael Kubacki
; Kinney, Michael D ;
Gao, Liming ; Ni, Ra
Hi all,
Could you please help to review this patch? Thanks a lot!
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan
Sent: Tuesday, November 22, 2022 7:48 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Justen, Jordan L ; Gerd
Hoffmann ; Ni, Ra
On Tue, 22 Nov 2022 at 19:10, Michael D Kinney
wrote:
>
> Hi Abner,
>
> Removing that section 5.4.2.2 is required to close this bug.
>
> Meaning of 'static' is covered by the ANSI C standards.
>
> Use of 'static' for non-public variable/functions in EDK II
> libraries/modules is recommended.
>
> H
On Mon, 28 Nov 2022 at 05:35, Paweł Poławski wrote:
>
> This is re-submission of original patches written by Laszlo Ersek.
> When mode will be changed in the EFI - xterm resolution will
> change too. Tested with xterm, Gnome terminal and XFCE4 terminal.
>
I think I know why this is a good thing,
23 matches
Mail list logo
