Re: [edk2-devel] [PATCH v5 17/19] SecurityPkg: Add EncryptionVariable lib with AES

2022-11-21 Thread Wang, Jian J
Judah, Just some typos found. See inline comments below starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jie

Re: [edk2-devel] [PATCH v5 15/19] SecurityPkg: Add null encryption variable libs

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v5 15/19] SecurityPkg: Add null encryption variable libs > > RE

Re: [edk2-devel] [PATCH v5 11/19] SecurityPkg: Add new KeyService types and defines

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v5 11/19] SecurityPkg: Add new KeyService types and defines >

Re: [edk2-devel] [PATCH v5 09/19] MdeModulePkg: Reference Null ProtectedVariableLib

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v5 09/19] MdeModulePkg: Reference Null ProtectedVariableLib >

Re: [edk2-devel] [PATCH v5 06/19] MdeModulePkg: Add Null ProtectedVariable Library

2022-11-21 Thread Wang, Jian J
Judah, Just some typos. See inline comments starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistr

Re: [edk2-devel] [PATCH v5 04/19] MdeModulePkg: Add new include files

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v5 04/19] MdeModulePkg: Add new include files > > REF: https:

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-21 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Ray, >From the last week edk2 Bug triage meeting, my understanding from Mike was to >remove the entire 5.4.2.2 section and no need to add anything because we >already mention at the beginning in CCS to follow C dialect. @Kinney, Michael D and @Liming Gao, is

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-21 Thread Ni, Ray
Abner, >From what I read, the idea of BZ1766 is to add recommendations to use static >for local symbols. "Add recommendations to the EDK II C Coding Standards Specification to use 'static' for all functions and global variables that are not referenced outside the current C file." Do you want to

[edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-21 Thread Chang, Abner via groups.io
From: Abner Chang BZ #1766 Remove the entire 5.4.2.2 section. We are not allowed to use upper-case STATIC in the source file now. Just follow C standard and use the lower-case 'static'. Leave the macro "#deifne STATIC static" there without removing it to keep the backward compatable. Signed-of

Re: [edk2-devel] [edk2-platforms: PATCH] BIOS needs to present cores in order of relative performance in MADT

2022-11-21 Thread Ni, Ray
Pedro. Thanks for the comments. I agree that detailed commit message helps to explain that this MADT order change is to help some legacy APPs that assume the high performance cores are before low performance ones in MADT and use OS APIs to explicitly request running on certain target cpu cores t

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 22, 2022 #cal-reminder

2022-11-21 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, November 22, 2022 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, November 21, 2022 #cal-notice

2022-11-21 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, November 21, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623295 ) *Description:* TianoCore com

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, November 21, 2022 #cal-reminder

2022-11-21 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, November 21, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623295 ) *Description:* Tia

Re: [edk2-devel] [PATCH] Silicon/Intel/FitGen:FitGen Supporting MultiFIT 2 rc

2022-11-21 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Kumar, Rahul R Sent: Wednesday, November 16, 2022 9:58 AM To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; West, Catharine Cc: Kumar, Rahul R Subject: [PATCH] Silicon/Intel/

Re: [edk2-devel] EmulatorPkg: fixes for NetBSD compilation

2022-11-21 Thread Pedro Falcato
On Mon, Nov 21, 2022 at 9:21 PM wrote: > diff --git a/EmulatorPkg/Unix/Host/BlockIo.c > b/EmulatorPkg/Unix/Host/BlockIo.c > index cf2d6b4cda..c0c694be55 100644 > --- a/EmulatorPkg/Unix/Host/BlockIo.c > +++ b/EmulatorPkg/Unix/Host/BlockIo.c > @@ -133,6 +133,20 @@ EmuBlockIoOpenDevice ( > >

Re: [edk2-devel] edksetup.sh: fix for non POSIX whereis(1)

2022-11-21 Thread Pedro Falcato
On Mon, Nov 21, 2022 at 9:21 PM wrote: > diff --git a/edksetup.sh b/edksetup.sh > index 06d2f041e6..46b295c430 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -105,6 +105,19 @@ function SetupEnv() >fi > } > > +# whereis(1) is not a POSIX utility and, for example, its implementation > +#

[edk2-devel] EmulatorPkg: fixes for NetBSD compilation

2022-11-21 Thread tlaronde
diff --git a/EmulatorPkg/Unix/Host/BlockIo.c b/EmulatorPkg/Unix/Host/BlockIo.c index cf2d6b4cda..c0c694be55 100644 --- a/EmulatorPkg/Unix/Host/BlockIo.c +++ b/EmulatorPkg/Unix/Host/BlockIo.c @@ -133,6 +133,20 @@ EmuBlockIoOpenDevice ( ioctl (Private->fd, DKIOCGETMAXBLOCKCOUNTWRITE, &Priva

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

2022-11-21 Thread Hongbin1 Zhang
Add StandaloneMmIplPei IA32/X64 driver at PEI stage. FSP will use this driver to load Standalone MM code to dispatch other Standalone MM drivers. Signed-off-by: Hongbin1 Zhang Cc: Jiewen Yao Cc: Ray Ni Cc: Star Zeng Cc: Jiaxin Wu Cc: Sami Mujawar Cc: Ard Biesheuvel Cc: Supreeth Venkatesh -

[edk2-devel] edksetup.sh: fix for non POSIX whereis(1)

2022-11-21 Thread tlaronde
diff --git a/edksetup.sh b/edksetup.sh index 06d2f041e6..46b295c430 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -105,6 +105,19 @@ function SetupEnv() fi } +# whereis(1) is not a POSIX utility and, for example, its implementation +# in NetBSD is different form the Linux one. +# +function whe

[edk2-devel] [AddResetEnd v1] ShellPkg/DpDynamicCommand: Add ResetEnd support in DP command

2022-11-21 Thread Zhenhua Yang
From: zhenhuay DP command should be able to parse the FPDT ACPI table and dump the ResetEnd which was logged at the beginning of the firmware image execution. So that DP can calculate SEC phase time duration start from the beginning of firmware image execution. Cc: Ray Ni Cc: Zhichao Gao Cc: S

[edk2-devel] [edk2-libc Patch 0/1] edk2-libc : migration of edk2 module from chipsec repo

2022-11-21 Thread Jayaprakash, N
This PR contains the changes required to merge the edk2 module enhancements from chipsec repo to edk2-libc. More details are updated in the BZ https://bugzilla.tianocore.org/show_bug.cgi?id=4161 Jayaprakash Nevara (1): edk2-libc: migration of edk2module from chipsec repo .../Python-3.6.8/PyMo

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc: migration of edk2module from chipsec repo

2022-11-21 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access platform registers. These enhancements providing a set of APIs to

Re: [edk2-devel] [PATCH] CryptoPkg: Add b_print.c which removed floating-point to OpensslLib

2022-11-21 Thread Yao, Jiewen
Right. Size is the biggest concern, because some platforms already have limited space based on our internal survey. If we migrate to openssl3 directly, then we have no way to build these platforms. One idea of size optimization is to use MACRO to disable some features in openssl, if they are no

Re: [edk2-devel] [PATCH] CryptoPkg: Add b_print.c which removed floating-point to OpensslLib

2022-11-21 Thread Gerd Hoffmann
On Mon, Nov 21, 2022 at 08:31:19AM +, Li, Yi wrote: > Hi Gerd, > > Cool! I noticed your patch in openssl3.0 branch. > Because the Tls cert time check needs to be solved as soon as possible, > I will cherry-pick your patch to 1.1.1 branch instead of updating edk2 > openssl to 3.0. The latter s

Re: [edk2-devel] [edk2-platforms][PATCH V6 00/16] Platform: Add Loongson support.

2022-11-21 Thread Chao Li
Hi Mike and Liming, After the LoongArch EDK2 base code was merged, I become one of the maintainers of LoongArch, but I don't have push permissions in the EDK2 Platformes repo. How do we get the push permissions in EDK2 LoongArch folder and EDK2 Platformes repo? LoongArch Maintainers: M: Chao Li

Re: [edk2-devel] [PATCH] CryptoPkg: Add b_print.c which removed floating-point to OpensslLib

2022-11-21 Thread Li, Yi
Hi Gerd, Cool! I noticed your patch in openssl3.0 branch. Because the Tls cert time check needs to be solved as soon as possible, I will cherry-pick your patch to 1.1.1 branch instead of updating edk2 openssl to 3.0. The latter seems to take a long time. By the way, I remember you are already wo