Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch

2022-11-12 Thread Michael D Kinney
We do not want to do another global reformat for column width change. What does Uncristify do now? We need to make sure spec matches current behavior. I added Michael Kubacki to this thread earlier so he can provide the details. Mike > -Original Message- > From: Chang, Abner > Sent:

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

2022-11-12 Thread Michael D Kinney
Which change is that? Does it match Uncrustify behavior? Mike From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Saturday, November 12, 2022 5:25 PM To: Laszlo Ersek ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Fi

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

2022-11-12 Thread Michael D Kinney
Is this exactly what Uncrustify does now? Mike From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Saturday, November 12, 2022 5:36 PM To: Laszlo Ersek ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing /

Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch

2022-11-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Yes Mike, we can merge the patch 1/2 for the line in 80 columns topic. Not sure if Uncrustify is smart enough to correct the existing code that have the line with column > 80, especially for the postfix comment that makes the line has > 80 columns. Or we just

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

2022-11-12 Thread Chang, Abner via groups.io
Hi all, As we are going to release CCS 2.3, we would like to address some pending issues of CCS. For this, I think we can, - Still keep the one line per argument style in CCS although the multi-arguments in the one line style can cover this. This avoids confusion from readers and questions about

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

2022-11-12 Thread Chang, Abner via groups.io
This change (1/2) will be merged to the CCS v2.3 release. Abner -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96323): https://edk2.groups.io/g/devel/message/96323 Mute This Topic: https://groups.io/mt/30907265/21656 Group Owner: devel+o