Re: [edk2-devel] [PATCH 00/11] ArmVirtPkg: introduce VirtNorFlashDxe

On Mon, Oct 24, 2022 at 07:01:11PM +0200, Ard Biesheuvel wrote: > Create a new driver VirtNorFlashDxe that targets QEMU and KvmTool's NOR > flash emulation specifically, and retire the ArmPlatformPkg one. > > This permits new virt implementations to wire up QEMU's NOR flash > emulation without hav

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

On 26/10/2022 13:49, Alexey Kardashevskiy wrote: On 26/10/2022 12:35, Alexey Kardashevskiy wrote: On 26/10/2022 12:07, Dionna Amalie Glaze wrote: On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote: Hi Dionna, Thanks for updating the tree, builds nicely now! However the VM's

Re: [edk2-devel] [PATCH] UefiCpuPkg: Restore HpetTimer after CpuExceptionHandlerLib test

Hi Ray, Mike, The 2nd option works in qsp boot. Thanks, Dun -Original Message- From: Ni, Ray Sent: Thursday, October 27, 2022 11:03 AM To: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D ; Tan, Dun Cc: Dong, Eric ; Kumar, Rahul R Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Restor

Re: [edk2-devel] [PATCH] UefiCpuPkg: Restore HpetTimer after CpuExceptionHandlerLib test

TimerDriverSetTimerPeriod() { Tpl = gBS->RaiseTPL (TPL_HIGH_LEVEL); HpetEnable (FALSE); Mike, In above code, it's possible that timer interrupt happens after TPL is HIGH but before HPET hardware is stopped. When that happens, EOI sending logic in the timer interrupt handler function doesn't

Re: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk

Thanks a lot. Just one minor comment, in RemoveTrailingSpaces(), could you help to refine: String[Length] = 0; to: String[Length] = '\0'; Also, could you help to send a V2 patch (the change made in the below pull request) to the mailing list? (Mainly step 12 in https://github.com/tianocore/

Re: [edk2-devel] [PATCH] UefiCpuPkg: Restore HpetTimer after CpuExceptionHandlerLib test

Mike, I agree there might be a bug in HPET timer driver where the EOI should be issued within that driver. Original idea was to avoid changing a driver used heavily in production firmware due to a new unit test failure and that test scenario is not common in production firmware. We would like to

Re: [edk2-devel] [PATCH] UefiCpuPkg: Restore HpetTimer after CpuExceptionHandlerLib test

Hi Ray, I do not think it makes sense for the CpuExceptionHandlerLib unit test to directly access the IO APIC. It assumes that an IO APIC based timer interrupt is in use. Is it possible that this is a bug/race condition in the HpetDxe driver. Calling the Timer AP to set timer period from 0 -> N

Re: [edk2-devel] [PATCH] UefiCpuPkg: Restore HpetTimer after CpuExceptionHandlerLib test

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, October 20, 2022 11:01 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R > Subject: [PATCH] UefiCpuPkg: Restore HpetTimer after > CpuExceptionHandlerLib test > > Disable/Restore HpetTi

回复: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

Pavamana: The change should be merged after new FIT spec is published, because FitGen tool follows the public FIT spec. Thanks Liming 发件人: Hv, Pavamana 发送时间: 2022年10月26日 23:13 收件人: Holland, Michael ; Gao, Liming ; devel@edk2.groups.io; Chaganty, Rangasai V ; Lohr, Paul A ; Feng, Bob

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Hi Sean, That is great feedback!!! We can discuss with Ray when he is back online on how best to support both policies. You have provides some good options to consider * Extend enum * Add PCD Mike From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, October 26, 2022

[edk2-devel] [PATCH V1] SecurityPkg: Fix return handling in RdRandGenerateEntropy

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4090 The function GetRandomNumber128 returns a BOOLEAN and not EFI_STATUS. Update the code to correctly handle the BOOLEAN return type. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Erik Bjorge --- .../PeiDxeTpmPlatformHierarchyLib.c

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

Hi Judah, Does CryptoPkg.dsc break if DISABLE_SHA1_DEPRECATED_INTERFACE is defined in that DSC file [BuildOptions] section? All packages in edk2 repo have a .ci.yaml file that provides the set of CI checks that are performed when a PR contains source changes to that package. Here is link to Cry

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Hi Mike This patch is being upstreamed from the coreboot fork; about 70% of the coreboot community wants the logo centred (as the target OS is not Windows), and the rest want to use the 38.2% rule! Thanks Sean On Wed, 26 Oct 2022 at 05:55, Kinney, Michael D wrote: > Sean provided a sample PR

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

Mike, Can you explain #3? I have no idea how to update/modify the EDK2 CI. I know for MTL, we have this define there by default, that is why when I enabled crypto for RPMC feature for MTL we ran into the issue. #4, I prefer a build error. Judah -Original Message- From: Kinney, Michae

[edk2-devel] [PATCH edk2-platforms] Platform/SbsaQemu: Switch to VirtNorFlashDxe

Switch to the OVMF version of the NOR flash DXE driver, which supports QEMU's NOR flash emulation specifically, and carries some optimizations that are therefore permitted. Cc: Leif Lindholm Cc: Graeme Gregory Signed-off-by: Ard Biesheuvel --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

Acked-by: Michael D Kinney > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, October 26, 2022 6:35 AM > To: Kinney, Michael D ; Pedro Falcato > ; devel@edk2.groups.io > Cc: Vitaly Cheptsov ; Marvin Häuser > ; Gao, Liming ; Liu, > Zhiguang > Subject: RE: [PATCH v2 1/1] MdePk

Re: [edk2-devel] [PATCH v8 06/19] MdePkg/TrngLib: Definition for TRNG library class interface

On 2022-10-26 15:06, Yao, Jiewen wrote: Oh, I did not realize we are planning to deprecate ArmPkg. Is there a Bugzilla I can refer to? There wasn't, and that's a very good point. I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=4121 If so, I don't think MdeModulePkg is better, bec

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Hi Nickle, I would like to discuss that DisableBootstrapControl flag and how it is used in our implementation. According to Redfish HI specification we can use this flag to disable credential bootstrapping control. It can be disabled permanently or till next reboot of the host or service. That d

Re: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

Thanks for the review, Liming. @Feng, Bob C, What is the next step to merge the change? Let me know if anything is needed from me. Thanks for your help again. Regards, Pavamana From: Holland, Michael Sent: Tuesday, October 25, 2022 8:36 PM To: Gao, Liming ; devel@edk

Re: [edk2-devel] [PATCH v8 06/19] MdePkg/TrngLib: Definition for TRNG library class interface

Oh, I did not realize we are planning to deprecate ArmPkg. Is there a Bugzilla I can refer to? If so, I don't think MdeModulePkg is better, because we usually say: industry standard can be in MdePkg. With this justification, I would suggest to name this library class to be ArmTrngLib. In the l

Re: [edk2-devel] [PATCH v8 06/19] MdePkg/TrngLib: Definition for TRNG library class interface

Hi Jiewen, There could be an argument for moving it to MdeModulePkg, but there is no argument for it moving to ArmPkg. ArmPkg does not have any reason to exist other than that it has not yet been properly integrated in the core packages. Which clearly is becoming more urgent, as I seem to be rais

Re: [edk2-devel] [PATCH v1 2/2] SecurityPkg: OpalPasswordDxe: uninitialized local variable.

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Paul via > groups.io > Sent: Sunday, October 23, 2022 12:00 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Kumar, Rahul R > > Subject: [edk2-devel] [PATCH v1 2/2] SecurityPkg: OpalPasswordDxe: > uni

Re: [edk2-devel] [PATCH v3 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR

MdePkg *can* provide implementation. But usually, it is for a generic interface, which may be implemented by multiple architecture. But here the TrngLib is very ARM specific, what it follows is "ARM TRNG firmware interface". For example, GetVersion, GetUUID. As such, I suggest to name it ArmTrn

Re: [edk2-devel] 回复: [PATCH V4 00/10] Introduce Lazy-accept for Tdx guest

On October 26, 2022 9:27 AM, Gao Liming wrote: > > Min: > Thanks for the update. I have no other comments for MdePkg changes in > this patch set. > Hi, Liming Below 5 patches are changes in MdePkg and MdeModulePkg. Can you give "reviewed-by" if you have no other concerns? [PATCH V4 01/10] Mde

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

That is good catch. Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, October 26, 2022 12:23 AM > To: Pedro Falcato ; devel@edk2.groups.io > Cc: Vitaly Cheptsov ; Marvin Häuser > ; Gao, Liming ; Liu, > Zhiguang ; Yao, Jiewen > Subject: RE: [PATC

Re: [edk2-devel] [PATCH v8 06/19] MdePkg/TrngLib: Definition for TRNG library class interface

Hi This API is very ARM platform specific. I don't see any interface like GetVersion or GetUUID is defined in 800-90A/90B/90C. What it is following is "Arm True Random Number Generator Firmware, Interface 1.0". As such, I feel uncomfortable to define TrngLib in MdePkg. I have raised my concer

Re: [edk2-devel] [PATCH 09/14] DynamicTablesPkg: Fix Ssdt PCI generation comments

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois The second model of the _PRT object is used. Indeed: - the interrupts described are not re-configurable - OSes are aware of the p

Re: [edk2-devel] [PATCH 08/14] DynamicTablesPkg: FdtHwInfoParserLib: Remove wrong comment

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois commit 13136cc3111f ("DynamicTablesPkg: FdtHwInfoParserLib: Parse Pmu info") adds support for pmu parsing. Thus, remove the wrong

Re: [edk2-devel] [PATCH 07/14] DynamicTablesPkg: Remove deprecated APIs

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois commit 691c5f776274 ("DynamicTablesPkg: Deprecate Crs specific methods in AmlLib") deprecates some APIs. Finally remove them. Si

Re: [edk2-devel] [PATCH 05/14] DynamicTablesPkg: Fix GTBlock and GTBlockTimerFrame CmObjParsers

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois The CmObjParsers of the following objects was inverted, probably due to a wrong ordering placement in the file defining the struc

Re: [edk2-devel] [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois commit 0d23c447d6f5 ("DynamicTablesPkg: Add support to specify FADT minor revision") adds new 'MinorRevision' field to CM_STD_OBJ

Re: [edk2-devel] [PATCH 02/14] DynamicTablesPkg: Add PrintString to CmObjParser

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois Add a PrintString to print strings in the CmObjParser. String must be NULL terminated and no buffer overrun check is done by this

Re: [edk2-devel] [PATCH 01/14] DynamicTablesPkg: Use correct print formatter

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois In C, the 'long long' types are 64-bits. The 'll' printf length specifier should be used to pring these values. Just '%x' allows

Re: [edk2-devel] [PATCH 11/14] DynamicTablesPkg: Add PCCT Generator

Hi Pierre, There is a change required for this patch marked inline as [SAMI]. If you agree, I will make the changes before merging. Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois The Platform Communication Channel Table (PCCT) generator col

Re: [edk2-devel] [PATCH 12/14] DynamicTablesPkg/AmlLib: Allow larger AccessSize for Pcc address space

Hi Pierre, There are some minor changes required marked inline as [SAMI]. If you agree, I will make the changes before merging. Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois For Pcc address space, the AccessSize field of a Register is used

Re: [edk2-devel] [PATCH 10/14] DynamicTablesPkg: Add PCCT related objects

Hi Pierre, There are some minor updates that are required for this patch marked inline as [SAMI]. If you agree, I will make these changes before merging. Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois Introduce the following CmObj in the A

Re: [edk2-devel] [PATCH 06/14] DynamicTablesPkg: Fix wrong/missing fields in CmObjParser

Hi Pierre, I have one comment marked inline as [SAMI]. I believe other than that change this patch should be good. Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois Add missing fields to the following CmObjParser objects: - EArmObjGicDInfo - E

Re: [edk2-devel] [PATCH 03/14] DynamicTablesPkg: Update CmObjParser for IORT Rev E.d

Hi Pierre, I have one comment marked inline as [SAMI]. Other than that change this patch should be good. Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois commit de200b7e2c3c ("DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.d") ad

Re: [edk2-devel] [PATCH 13/14] DynamicTablesPkg: Readme.md: Update available tables for generation

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois The following tables can now be generated by the DynamicTablesPkg: - PCCT - PPTT - SRAT Update the documentation according

Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, pierre.gond...@arm.com wrote: From: Pierre Gondois The ACPI specification updated some terms in accordance with: s1.1.1 Principle of Inclusive Terminology Update the PCCT parser ac

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and N1Sdp to use PrePeiCoreUniCore

Hi Rebecca, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 25/10/2022, 21:57, "Rebecca Cran" wrote: Modern platforms that use TF-A should use PrePeiCoreUniCore, since any secondary cores will be put in the TF-A holding pen and won't reach EDK2.