[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Refine VTd core driver

2022-10-17 Thread Sheng Wei
Refine the DRHD table print message. Remove unused variable. Hsd-es-id: 15012152545 Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski --- .../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c| 3 +-- .../Feature/VTd/IntelVTdDxe/DmarAcpiTab

Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections

2022-10-17 Thread Ni, Ray
All look good to me. Thanks for addressing my comments regarding simplifying the rules. Except for one minor comment: I still don't think we need to define rules for source file names (4.3.5.4 EDK II source files within a Library/Module instance). And the rule "[][].*" doesn't specify what co

Re: [edk2-devel] [tianocore-docs][PATCH V2 1/2] edk II C Coding Standard: Insert Directory Names section

2022-10-17 Thread Ni, Ray
Thanks for addressing my comments šŸ˜Š Reviewed-by: Ray Ni > -Original Message- > From: abner.ch...@amd.com > Sent: Saturday, October 15, 2022 7:47 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Kinney, Michael D > ; Sunil V L ; > Abdul Lateef Attar ; Leif Lindholm > > Subject: [tianocore-

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Add a parameter to indicate whether the memory allocation is for TRB Ring or not.

2022-10-17 Thread Wu, Hao A
Thanks. Will rename the commit title to ā€œMdeModulePkg/XhciDxe: Add boundary check for TRB ring allocationā€ to pass the CI test. Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other reviewers. Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf O

Re: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk

2022-10-17 Thread Wu, Hao A
Thanks for the patch. Could you help to do a favor and create a pull request for the proposed patch? You can follow the steps 10 & 11 in the below wiki link to do so: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-developer-process-for-the-edk-ii-project Best

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Add a parameter to indicate whether the memory allocation is for TRB Ring or not.

2022-10-17 Thread Jiading Zhang
Hi, I renamed the parameter from ā€˜AllocationForTrbRingā€™ to ā€˜AllocationForRingā€™ in UsbHcAllocMemFromBlock, which matchs the description comment. And the attachment is the updated patch file. According the Xhci Spec, TRB Rings may be larger than a Page, however they shall not cross a 64K byte bou

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3] remove GCC build warning

2022-10-17 Thread JessyX Wu
I had verified both GCC5 and GCC49, and the build processes are good. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95304): https://edk2.groups.io/g/devel/message/95304 Mute This Topic: https://groups.io/mt/94193549/21656 Group Owner: de

Re: [edk2-devel] 回复: [PATCH V4 00/10] Introduce Lazy-accept for Tdx guest

2022-10-17 Thread Min Xu
On October 10, 2022 10:28 AM, Gao Liming wrote: > > Min: > I have no comments for new unaccepted resource type and unaccepted gcd > type. In fact, they are mapping to UEFI EfiUnacceptedMemoryType. > > For new protocol EfiMemoryAcceptProtocol, I see another patch serial > https://edk2.groups.i

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros

2022-10-17 Thread Michael Kubacki
Following up on this series. I addressed Nate's v1 feedback. Thanks, Michael On 10/12/2022 10:16 AM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095 Fixes several debug macros in Silicon/Intel that have a mismatched number of print specifi

[edk2-devel] [PATCH v1 3/3] EmulatorPkg/PlatformCI: Dyn BaseTools Selection

2022-10-17 Thread Joey Vagedes
When using pytools to build EmulatorPkg, add the ability to dynamically determine which BaseTools to build with. The Pypi BaseTools will be used if present, otherwise defaulting to the in-tree Basetools. Reference: https://bugzilla.tianocore.org/show_bug.cgi?id=4085 Cc: Andrew Fish Cc: Ray Ni

[edk2-devel] [PATCH v1 2/3] OvmfPkg/PlatformCI: Dyn BaseTools Selection

2022-10-17 Thread Joey Vagedes
When using pytools to build OvmfPkg, add the ability to dynamically determine which BaseTools to build with. The Pypi BaseTools will be used if present, otherwise defaulting to the in-tree Basetools. Reference: https://bugzilla.tianocore.org/show_bug.cgi?id=4085 Cc: Ard Biesheuvel Cc: Jiewen Yao

[edk2-devel] [PATCH v1 0/3] Dynamic BaseTools Selection

2022-10-17 Thread Joey Vagedes
When using pytools to build, this patch adds the ability to dynamically determine which BaseTools to build with. The Pypi BaseTools will be used if present, otherwise defaulting to the in-tree Basetools. Reference: https://bugzilla.tianocore.org/show_bug.cgi?id=4085 CC: Ard Biesheuvel CC: Leif L

[edk2-devel] [PATCH v1 1/3] ArmVirtPkg/PlatformCI: Dyn BaseTools Selection

2022-10-17 Thread Joey Vagedes
When using pytools to build ArmVirtPkg, add the ability to dynamically determine which BaseTools to build with. The Pypi BaseTools will be used if present, otherwise defaulting to the in-tree Basetools. Reference: https://bugzilla.tianocore.org/show_bug.cgi?id=4085 CC: Ard Biesheuvel CC: Leif Li

[edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk

2022-10-17 Thread Cheripally Gopi via groups.io
ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk.due to this, when multiple SCSI disk devices connected, facing difficulty in identifying correct SCSI disk device. As per SCSI spec, standard Inquiry Data is having the fields to know Vendor and

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 10/17/2022 #cal-notice

2022-10-17 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* 10/17/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610035 ) *Description:* TianoCore community, Micros

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 10/17/2022 #cal-reminder

2022-10-17 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* 10/17/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610035 ) *Description:* TianoCore communit

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Add a parameter to indicate whether the memory allocation is for TRB Ring or not.

2022-10-17 Thread Jiading Zhang
According the Xhci Spec, TRB Rings may be larger than a Page, however they shall not cross a 64K byte boundary, so add a parameter to indicate whether the memory allocation is for TRB or not. It will ensure the allocation not crossing 64K boundary in UsbHcAllocMemFromBlock if the memory is alloc

Re: [edk2-devel] [edk2-platforms][PATCH V3 15/16] Platform/Loongson: Add QemuFlashFvbServicesRuntimeDxe driver.

2022-10-17 Thread xianglai
Hi Ard Biesheuvel : In the function FvbInitialize, It validate the firmware volume header.The firmware volume header address is PcdOvmfFdBaseAddress, in Ovmf PcdOvmfFdBaseAddress is equal to PcdOvmfFlashNvStorageVariableBase, so the checksum can pass. When loongson is implemented, PcdOvmfFdBa

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V4 10/34] OvmfPkg/Sec: Add RISC-V support

2022-10-17 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > via groups.io > Sent: Saturday, October 15, 2022 12:48 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao > ; Jordan Justen ; Gerd > Hoffmann ; Singh, Brijesh ; > Er

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V4 10/34] OvmfPkg/Sec: Add RISC-V support

2022-10-17 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Sunil V L > Sent: Monday, October 17, 2022 12:53 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > Jiewen Yao ; Jordan Justen > ; Gerd Hoffmann ; Singh, > Brijesh ; Erdem Aktas ; > James Bottomley ; Min X

Re: [edk2-devel] [edk2-platforms][PATCH V3 15/16] Platform/Loongson: Add QemuFlashFvbServicesRuntimeDxe driver.

2022-10-17 Thread Ard Biesheuvel
On Fri, 14 Oct 2022 at 06:01, xianglai li wrote: > > This library provides flash read and write functionality > and supports writing variables to flash. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 > > Signed-off-by: xianglai li Why do you need a new driver for this? We already h