Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdePkg:Improved Smbios Type9 table and Smbios 3.5.0 spec changes

2022-08-11 Thread Sainadh Nagolu via groups.io
ShellPkg is updated and reviewed( message:92383 ( https://edk2.groups.io/g/devel/message/92383 ) ). Please help to review this patch and include in edk2-stable202208 tag. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92388): https://ed

Re: [edk2-devel] [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported

2022-08-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Three comments inline to coding standard. > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, August 11, 2022 4:11 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.w...@hpe.com; Igor > Kulchytskyy ; Chang, Abner > Subject: [PATCH V2

Re: [edk2-devel] [PATCH V2] RedfishPkg: Redfish third party modules may need to use the functions tat are currently private

2022-08-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, August 11, 2022 4:46 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.w...@hpe.com; Igor > Kulchytskyy ; Chang, Abner > Subject: [PATCH V2] RedfishPkg: Re

回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-08-11 Thread gaoliming via groups.io
Sean: According to the description, I agree with Pedro that this is a recommendation and not mandatory. Do you think so? Thanks Liming 发件人: devel@edk2.groups.io 代表 Pedro Falcato 发送时间: 2022年8月5日 15:04 收件人: edk2-devel-groups-io ; sean@starlabs.systems 抄送: Liming Gao ; Zhichao Gao ; Ray Ni

[edk2-devel] 回复: [PATCH EDK2 v1 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

2022-08-11 Thread gaoliming via groups.io
Agree this fix to add the check for this case. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Wenyi Xie > 发送时间: 2022年8月11日 16:32 > 收件人: devel@edk2.groups.io; jian.j.w...@intel.com; > gaolim...@byosoft.com.cn; zhichao@intel.com; ray...@intel.com > 抄送: songdongku...@huawei.com;

回复: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 table changes in PrintInfo.c

2022-08-11 Thread gaoliming via groups.io
Reviewed-by: Liming Gao 发件人: devel@edk2.groups.io 代表 Sainadh Nagolu via groups.io 发送时间: 2022年8月11日 19:44 收件人: Sainadh Nagolu ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 table changes in PrintInfo.c Please help to review the patch and include in edk

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL

2022-08-11 Thread Guo, Gua
Reviewd-by: Gua Guo -Original Message- From: Sravanthi, K KavyaX Sent: Thursday, August 11, 2022 3:08 PM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL Return Pci

[edk2-devel] [PATCH] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

2022-08-11 Thread Boeuf, Sebastien
From: Sebastien Boeuf Both ACPI shutdown and ACPI PM timer devices has been moved to different port addresses in the latest version of Cloud Hypervisor. These changes need to be reflected on the OVMF firmware. Signed-off-by: Sebastien Boeuf --- OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++

Re: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 table changes in PrintInfo.c

2022-08-11 Thread Sainadh Nagolu via groups.io
Please help to review the patch and include in edk2-stable202208 tag. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92378): https://edk2.groups.io/g/devel/message/92378 Mute This Topic: https://groups.io/mt/92912129/21656 Group Owner: de

Re: [edk2-devel] [PATCH v4 4/4] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-08-11 Thread Oliver Steffen
Hi Daniel, The CI still runs through all jobs successfully. This includes builds for RiscV64. See the PR: https://github.com/tianocore/edk2/pull/2935 Thanks, Oliver On Thu, Aug 11, 2022 at 5:34 AM Daniel Schaefer wrote: > Hi Oliver, > > I assume you made sure that the build still works on at

[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

2022-08-11 Thread wenyi,xie via groups.io
When BitPerPixel is 1,4,8, there should be a color map in bmp file. But if the format of bmp file is error, it maybe has no color map when BitPerPixel is 1,4,8. The condition checking now can not catch this issue. Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Wenyi X

[edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

2022-08-11 Thread wenyi,xie via groups.io
Main Changes : 1.Add check to catch the issue when format of bmp file is error. Wenyi Xie (1): MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 5 + 1 file changed, 5 insertions(+) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- G

[edk2-devel] How to access I2C IO?

2022-08-11 Thread gordontcp
Hi all, I set following command to load i2cdxe.efi: load I2cDxe.efi. Then, I set ‘drivers’ in UEFI shell, and the number of devices connected to this driver is 0. After I loaded I2cDXe.efi, it showed the messages that I2cBusDriverSupported and I2cHostDriverSupported returned the values ​​EFI_U

[edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL

2022-08-11 Thread kavya
Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration to FALSE when root bridge count is zero. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++-- 1 file changed, 2 insertion