Hi Edward,
Thank you for this patch.
This fix looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/08/2022 10:20 am, Edward Pickup wrote:
Fix using RmrNodeCount uninitliased by initliasing it to zero. Also, add
an additional check for ACPI version. This fixes a crash run
Reviewed-by: Isaac Oram
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Friday, August 5, 2022 11:02 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric
Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/Test
Reviewed-by: Isaac Oram
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Friday, August 5, 2022 10:16 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric
Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/Test
From: Michael Kubacki
Adds a PCD called "PcdEnableCompressedFspNvsBuffer" that allows the
"FspNvsBuffer" UEFI variable data to be saved as compressed data.
Especially due to the nature of the data saved in this variable, it
compresses well. For example, it has been found to reduce ~63KB
of data
From: Michael Kubacki
The data buffer returned from the GetVariable2() call in
TestPointCheckMemoryTypeInformation() is not actually used or freed.
This change removes the unnecessary function call.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by
From: Michael Kubacki
DumpMemoryTypeInfoSummary() is used to dump information about the
MemoryTypeInformation HOB. The dump function currently modifies the
data which can corrupt the data for later HOB consumers in the DXE
phase.
This change makes DumpMemoryTypeInfoSummary() treat the data as
re
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, August 2, 2022 10:51 AM
> To: Jeff Brasen
> Cc: devel@edk2.groups.io; hao.a...@intel.com; ray...@intel.com;
> quic_llind...@quicinc.com; ardb+tianoc...@kernel.org
> Subject: Re: [PATCH v2] MdeModulePkg/NonDiscoverablePciDevice
[AMD Official Use Only - General]
Hi Igor,
Just found that you don't have the CC for maintainers and your Signed-off-by
tag in the commit message.
You can refer to below link for the correct commit message format for the patch.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkemp
Liming,
Adding a new INF that is type BASE was my original suggestion. Not the name
change.
In that thread, I suggested we get input from MM owners before changing the
name.
If there are many downstream platforms that are breaking from the name change,
then we should add the old INF back to
Reviewed-by: Yiqi Shu
> -原始邮件-发件人:"贾玲" 发送时间:2022-08-05 15:37:30
> (星期五)收件人:"Yiqi Shu" , "Peng Xie"
> 抄送:主题:[PATCH v7 0/4] Improved support for FT2004/4
> chip.
>
> Completed the flash driver and fvb driver.
> Solved the problems in boot process.
> Added virtual address conversion.
>
Add APIs needed to build _DSD with different UUIDs.
This is per ACPI specification 6.4 s6.2.5.
Adds support for building data packages with format
Package {"Name", Integer}
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 50
.../Common/AmlLib/CodeGe
Hi Sami,
I see you created a PR that is marked as draft with these changes:
https://github.com/tianocore/edk2/pull/3167
When you're ready for them to be submitted, if you could please create a
non-draft PR with the review tags added, I'd be happy to push it.
Thanks,
Michael
On 8/3/2022 10:35
Use Block->Next instead of Pool->Head->Next, otherwise the for loop
will be not able to come out.
It will also match with the UsbHcFreeMemPool() in EhciPei.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Zhikai Sun
Signed-off-by: Star Zeng
---
MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 2 +-
1 file changed, 1 in
From: KasimX Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4013
For the SMBIOS version can be update by UPL,we create
the gUniversalPayloadSmbios3TableGuid HOB to store
the value then updated version.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Cc: Gua Guo
Signed-off-by: KasimX Liu
---
I would like to create anissue in bugzilla.
The detail is:
The secureboot framework finally invokes PKCS7_verifyof openssl. It has been
verified that PKCS7_verify does not support verifying the contents with a
RSA-PSS signature. The CMS_verify interface supports RSA-PSS. I would like to
ask if
From: Yanbo Huang
reback the DevicePathUtilitiesStandaloneMm to unblock the downstream sync
Signed-off-by: Yanbo Huang
CC: Michael D Kinney
CC: Liming Gao
CC: Zhiguang Liu
---
.../DevicePathUtilitiesStandaloneMm.c | 39 ++
.../UefiDevicePathLibStandaloneMm.inf | 75
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
MdeModuleP
Hook up MICROSOFT_RECOMMENDED macro to PcdFollowMicrosoftRecommended.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 91cd
Add an option to position the logo 38.2% from the top of the screen,
which follows the recommendations from Microsoft. These can be found
here:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Sig
As the CommunicationBuffer plus BufferSize may overflow, check the
value first before using.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 22 +---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 5 ++
Main Changes :
1.Add check to avoid overflow.
Wenyi Xie (1):
MdeModulePkg/PiSmmCore:Avoid overflow risk
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 22 +---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 5 +
2 files changed, 19 insertions(+), 8 deletions(-)
--
2.20.1.windows.1
Hi Sean,
I think it's clear from the wording that the 38.2% thing is a
recommendation and not mandatory. I was curious and checked out the ACPI
spec and they appear to not mention that at all. Maybe reword things to
"Microsoft recommendation"?
Thanks,
Pedro
On Fri, 5 Aug 2022, 07:55 Sean Rhodes,
22 matches
Mail list logo
