REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3962
Two SMM variables (mSmrrSupported & mSmmFeatureControlSupported) are global
variables, they control whether the SMRR and SMM Feature Control MSR will
be restored respectively.
To avoid the TOCTOU, add PCD to control SMRR & SmmFeatureControl
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Zhang, Qi1
> Sent: Friday, July 29, 2022 10:26 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 ; Yao, Jiewen ;
> Wang, Jian J ; Patil, Swapnil
>
> Subject: [PATCH v4] SecurityPkg: Add retry mechanism for tpm command
>
> REF: https://b
Hi Pierre,
Thank you for the suggestions. I will update the patch per your feedback and
send for review in v3.
Regards,
Kun
On 7/28/2022 6:07 AM, Pierre Gondois wrote:
Hello Kun,
With the changes below:
Reviewed-by: Pierre Gondois
Thanks!
On 7/28/22 06:31, Kun Qin via groups.io wrote:
REF
Hi Pierre,
Thank you for your feedback. I will add more document/comments to the
newly define structure, as
well as the "break" as you suggested.
As per failure to locate "gEfiAcpiSdtProtocolGuid", my thought was that
this protocol could be enabled
per platform through
"gEfiMdeModulePkgToken
Due to the SMI latency impact for IA-32 processor, I will drop this change &
replace with the PCD check. I will resend the new patch for review.
Thanks,
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, July 18, 2022 3:32 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
>
Hi Konstantin, this is really an issue need to be solved.
When GenSec tool uses the guidtools to encode the section, it differentiates
how GenCrc32 is used from other tools..
GenSec defines a CRC32_SECTION_HEADER structure for GenCrc32, and calculate the
DataOffset of the Section with this head
Patch merged:
https://github.com/tianocore/edk2/commit/0d0bfcb4571caa65b7875003f38e67e2ac7e5560
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Thursday, July 28, 2022 7:57 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone,
In \FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c There are comments for
RegisterFmpInstaller:
/**
Used to pass the FMP install function to this lib. This allows the library to
have control of the handle that the FMP instance is installed on. This allows
the library to use DriverBindi
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Friday, July 29, 2022 10:57 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support.
REF: https://bugzilla.tianocore.org/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Fixed a logic bug in GenCfgOpt.py to skip FSPI_UPD when platforms
do not support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3980
As per TCG PC Client Device Driver Design Principle document,
if tpm commands fails due to timeout condition, then it should
have retry mechanism (3 retry attempts).
Existing implementation of PtpCrbTpmCommand does not have retry
mechanism i
Thank you so much for your help to review my patch files. Will address comments
and push them to edk2-staging repo.
Nickle
-Original Message-
From: Chang, Abner
Sent: Thursday, July 28, 2022 11:48 AM
To: Wang, Nickle (Server BIOS) ; devel@edk2.groups.io
Cc: Yang, Atom ; Nick Ramirez
S
Ensure that the PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is zeroed out in
EFI_GRAPHICS_OUTPUT_PROTOCOL.QueryMode() and
EFI_GRAPHICS_OUTPUT_PROTOCOL.SetMode() when PixelFormat is
PixelBlueGreenRedReserved8BitPerColor.
According to UEFI 2.9 Section 12.9, PixelInfo
Ensure that the PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is zeroed out in
EFI_GRAPHICS_OUTPUT_PROTOCOL.QueryMode() and
EFI_GRAPHICS_OUTPUT_PROTOCOL.SetMode() when PixelFormat is
PixelBlueGreenRedReserved8BitPerColor.
According to UEFI 2.9 Section 12.9, PixelInfo
Adding Leif/Ard to CC incase they have any comments on this patch.
Thanks
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Friday, June 17, 2022 9:39 AM
> To: devel@edk2.groups.io
> Cc: hao.a...@intel.com; ray...@intel.com
> Subject: RE: [PATCH v2] MdeModulePkg/NonDiscoverablePciDev
Looks very nice, tyvm. I did add a few more comments, but nothing critical at
all.
Reviewed-by: Marvin Häuser as-is or with my comments
addressed, either works.
> On 28. Jul 2022, at 17:26, Savva Mitrofanov wrote:
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
>
> Provided sup
Reviewed-by: Marvin Häuser
(Please just include this in future revisions, if any)
> On 28. Jul 2022, at 17:26, Savva Mitrofanov wrote:
>
> We shouldn't use direct casts, because in the future it could break
> the code, so using BASE_CR would be safe against possible structure
> changes and rea
ble Length : 05FC
[008h 0008 1] Revision : 05
[009h 0009 1] Checksum : 0B
[00Ah 0010 6] Oem ID : "ARMLTD"
[010h 0016 8] Oem Table ID : "ARMSGI "
[018h 0024 4] Oem Revision : 20220728
[01Ch 0028
Patch merged:
https://github.com/tianocore/edk2/commit/3eca64f157c340f9bbf552d89a69698a3090c080
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Wednesday, July 27, 2022 10:15 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimon
On Wed, 27 Jul 2022 at 18:31, Michael D Kinney
wrote:
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Cc: Marc-André Lureau
> Cc: Stefan Berger
> Signed-off-by: Michael D Kinney
Acked-by: Ard Biesheuvel
> ---
> Maintainers.txt | 4 ++--
> 1 file changed
-Original Message-
From: Thangaraj, KalaiyarasanX
Sent: Wednesday, July 27, 2022 8:44 PM
To: devel@edk2.groups.io
Cc: Thangaraj, KalaiyarasanX ; Bi, Dandan
; Gao, Liming ; Pethaiyan,
Madhan ; Esakkithevar, Kathappan
; Balaji, Madhusudhan
Subject: [PATCH] VirtualKeyboardFeaturePkg:
In Type9 structure since PeerGroups has a variable
number of entries, must not define new fields in the structure.So added an
extended structure and defined new fields added after PeerGroups. Also done
some improvements to Smbios 3.5.0 spec changes.
Signed-off-by:
sainadh nagolu
---
MdePkg/
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
Cc: Pedro Falcato
Cc: Vitaly Cheptsov
Signed-off-by: Savva Mitrofanov
---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h |
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a security
meausure implemented simple symlink loop check with nest level limit
equal 8. Also this patch moves Ext
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Hi all,
In the fourth version I corrected SymlinkSize selection logic in
Ext4ReadFastSymlink(), previously fast-symlink's EXT4_INODE_SIZE is not
necessarily
validated when we checked it in Ext4SymlinkIsFastSymlink(), so we should
truncat
Hello Kun,
With the changes below:
Reviewed-by: Pierre Gondois
Thanks!
On 7/28/22 06:31, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
Certain OSes will complain if the ECAM config space is not reserved in
the ACPI namespace.
This change adds a functi
Hello Kun,
With the changes below:
Reviewed-by: Pierre Gondois
Thanks!
On 7/28/22 06:31, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
This change added an extra step to allow check for installed ACPI tables.
For FADT, MADT, GTDT, DSDT, DBG2 and SPCR t
Hey
Please add the spec related info to the code as comments.
Thank you
Yao, Jiewen
> -Original Message-
> From: Zhang, Qi1
> Sent: Thursday, July 28, 2022 4:51 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 ; Yao, Jiewen ;
> Wang, Jian J ; Patil, Swapnil
>
> Subject: [PATCH v3] Securit
Hi everyone,
I checked Rebecca's patch with my Qemu use case.
All fine - we can use that patch instead of the series I posted here.
Even better, because it prints the version information.
Thanks!
Regards,
Oliver
On Tue, Jul 26, 2022 at 6:22 PM Sami Mujawar wrote:
> Hi Oliver,
>
>
>
> Both yo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3980
As per TCG PC Client Device Driver Design Principle document,
if tpm commands fails due to timeout condition, then it should
have retry mechanism (3 retry attempts).
Existing implementation of PtpCrbTpmCommand does not have retry
mechanism i
BIOS should not reordering cpu processor_uid
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: Palakshareddy, Lavanya C
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlat
31 matches
Mail list logo
