Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Thursday, July 28, 2022 1:15 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: FSPI_UPD is not mandatory.
REF: https://bugzilla.tianocore.org/show_bug.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
FSPI_UPD is required only When platforms implemented FSP_I component.
Updated the scripts to allow FSPI_UPD not present scenario.
Also fixed FSP_GLOBAL_DATA structure alignment issue and unnecessary
non-backward compatibility change in previo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
This change added a switch case handling for PCI_SS_CONFIG during SSDT
generation. This will allow PCI config case return EFI_SUCCESS instead of
EFI_INVALID_PARAMETER.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Co-authored-by: Joe Lopez
Signed
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
This change added more token fixers for other node types, including
NamedComponentNode, RootComplexNode, and SmmuV3Node.
The corresponding entries for tokenFixer functions table is also updated.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Co-au
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
Certain OSes will complain if the ECAM config space is not reserved in
the ACPI namespace.
This change adds a function to reserve PNP motherboard resources for a
given PCI node.
Co-authored-by: Joe Lopez
Signed-off-by: Kun Qin
---
Notes
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
This change added an extra step to allow check for installed ACPI tables.
For FADT, MADT, GTDT, DSDT, DBG2 and SPCR tables, either pre-installed or
supplied through AcpiTableInfo can be accepted.
An extra check for FADT ACPI table existenc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
The DynamicPlatRepoLib has multiple reference to MemoryAllocationLib,
such as DynamicPlatRepo.c and TokenMapper.c. Not including it in the
library inf file could lead to potential build break.
This change added the MemoryAllocationLib into
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
This patch series is a follow-up of previous submission:
https://edk2.groups.io/g/devel/message/91497
The main changes between
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
The content of token should be derived from the data section of the
`CmObject` instead of the object itself.
This change fixed the issue by dereferencing the token value from the
data buffer of input CmObject.
Cc: Sami Mujawar
Cc: Alexei
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 15/15] edk2-staging/RedfishClientP
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 14/15] edk2-staging/RedfishClientP
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 13/15] edk2-staging/RedfishClientP
[AMD Official Use Only - General]
This is the auto-gen file. I just give my review tag.
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [e
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 11/15] edk2-staging/RedfishClientP
As previously mentioned in https://edk2.groups.io/g/devel/message/90345, the
PPI interface looks good from the device controllers perspective:
Reviewed-by: Hao A Wu
Sorry Ray and Liming, do you have additional comments for this newly introduced
EDKII_PCI_DEVICE_PPI?
Best Regards,
Hao Wu
> ---
1. In the AHCI PEIM entrypoint, after registering the PPI callbacks for:
* gEdkiiPeiAtaAhciHostControllerPpiGuid and
* gEdkiiPeiPciDevicePpiGuid
My take is that there is no need to locate above PPI instances already
installed within system (codes in entry point that come after the callback
regist
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 09/15] edk2-staging/RedfishClientP
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 08/15] edk2-staging/RedfishClientP
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 07/15] edk2-staging/RedfishClientP
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 06/15] edk2-staging/RedfishClientP
The commit message and comments for the #defines
for the retry count and timeouts should state that
the values are required by spec and name the spec.
Thanks,
Mike
> -Original Message-
> From: Zhang, Qi1
> Sent: Wednesday, July 27, 2022 5:41 PM
> To: Kinney, Michael D ; devel@edk2.group
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Stefan Berger
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 071644c35612..a0d
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3980
Signed-off-by: Qi Zhang
Cc: Jiewen Yao
Cc: Jian J Wang
Reviewed-by: Jiewen Yao
Tested-by: Swapnil Patil
---
.../Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 107 +++---
1 file changed, 68 insertions(+), 39 deletions(-)
diff
Retry count is suggested in the spec.
PtpCrbWaitRegisterBits() already has delay.
Thanks!
Qi Zhang
-Original Message-
From: Kinney, Michael D
Sent: Thursday, July 28, 2022 12:38 AM
To: devel@edk2.groups.io; Yao, Jiewen ; Zhang, Qi1
; Kinney, Michael D
Cc: Wang, Jian J
Subject: RE: [
[AMD Official Use Only - General]
There is another SCHEMA_NAME_PREFIX_OFFSET in EdkIIRedfishResourceConfig.c.
Please also address that when you push the code, no need V4 for this.
Thanks
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
FSPI_UPD is required only When platforms implemented FSP_I component.
Updated the scripts to allow FSPI_UPD not present scenario.
Also fixed FSP_GLOBAL_DATA structure alignment issue and unnecessary
non-backward compatibility change in previo
Hi,
I also cannot see the patch properly. "=" disappearing magically sounds
like a quoted-printable email with a non-quoted-printable content.
Groups.io does not properly parse quoted-printable emails, so it's leaving
the "=" as is.
Thanks,
Pedro
On Wed, Jul 27, 2022 at 8:34 PM Dimitrije Pavlov
Looks like the patch is corrupted for you for some reason. Up the email chain
it shows fine. You can see the patch here:
https://edk2.groups.io/g/devel/message/90822
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91905): https://edk2.gr
Adding second, third and fourth thread mapping to MADT
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Eric Dong
Signed-off-by: Ankit Sinha
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 16
+++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/Platform/Inte
1. Add the PCD for GPE 1 block register width control in FADT
2. Re-arrange PCD category for some PCDs
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Eric Dong
Signed-off-by: Ankit Sinha
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 1 +
Platform/Intel/MinPlatformPkg/Acpi/AcpiTab
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Eric Dong
Signed-off-by: Ankit Sinha
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 16
+++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
b/Platf
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Eric Dong
Signed-off-by: Ankit Sinha
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 1 +
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 9 ++---
Why is 3 the correct retry count?
Do we need this to be configurable?
Is a delay required between retries?
What specific state is a DTPM getting into that
requires this retry mechanism? Can that state be
detected?
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Beh
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, July 27, 2022 9:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Yang, Atom
> ; Nick Ramirez
> Subject: [edk2-staging][PATCH v3 05/15] edk2-staging/RedfishClientP
On Wed, 27 Jul 2022 at 02:21, Sami Mujawar wrote:
>
> Hi All,
>
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3458
>
> The edk2 patch series for IORT Rev E.d updates has been submitted to the
> mailing list and has been reviewed at
> https://edk2.groups.io/g/devel/message/91361
>
> T
On Tue, 28 Jun 2022 at 11:48, Dimitrije Pavlov wrote:
>
> Ensure that the PixelInformation field of the
> EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is zeroed out in
> EFI_GRAPHICS_OUTPUT_PROTOCOL.QueryMode() and
> EFI_GRAPHICS_OUTPUT_PROTOCOL.SetMode() when PixelFormat is
> PixelBlueGreenRedR
On one Touch, multiple Reads happend and this reads varying based on Key Press
time.
Resulting in Multiple key press update on screen. This condition avoids
KeyPressed skips
resulting due to faster key press and update only on valid key press.
Cc: Dandan Bi
Cc: Liming Gao
Cc: Madhan Pethaiya
Thanks Dimitrije for the patch!
Reviewed-By: Samer El-Haj-Mahmoud
> -Original Message-
> From: Dimitrije Pavlov
> Sent: Wednesday, July 20, 2022 6:05 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Graeme Gregory ;
> Radoslaw Biernacki ; Jeff Booher-Kaeding kaed
Hi Sami,
Please find my reply inline
On Thu, Jul 21, 2022 at 12:47 PM, Sami Mujawar wrote:
>
>
>
> Hi Nishant,
>
>
>
> Please find my response inline marked [SAMI].
>
>
>
> Regards,
>
>
>
> Sami Mujawar
>
> On 17/06/2022 07:07 am, Nishant Sharma wrote:
>
>> Isolated CPUs are those t
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
The purpose of those changes is to introduce the way to enumerate and assign
resources in PEI for the systems with more than one PCI root.
Here is a need to have an interface that will support such a mechanizm.
For now, the part that perfo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This change modifies AhciPei library to allow usage both EDKII_PCI_DEVICE_PPI
and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI to manage ATA HDD working under
AHCI mode.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej Czajkowski
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
This commit introduces EDKII_PCI_DEVICE_PPI. The purpose of this PPI is
to provide a way of accessing PCI devices to drvice drivers such as
NvmExpressPei or AhciPei.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Maciej Czajkowski
Thanks. Please add Bugzilla ID and add tested-by tag by the people who
performed the test.
For the code, reviewed-by: Jiewen Yao
> -Original Message-
> From: Zhang, Qi1
> Sent: Wednesday, July 27, 2022 7:36 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 ; Yao, Jiewen ;
> Wang, Jian J
Signed-off-by: Qi Zhang
Cc: Jiewen Yao
Cc: Jian J Wang
---
.../Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 107 +++---
1 file changed, 68 insertions(+), 39 deletions(-)
diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
i
Hi All,
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3458
The edk2 patch series for IORT Rev E.d updates has been submitted to the
mailing list and has been reviewed at
https://edk2.groups.io/g/devel/message/91361
The corresponding edk2-platforms series is posted on the mailing lis
Some print statements use format specifiers like %N/%H/%E/%B that are
only supported in the shell print functions. In the ordinary 'Print'
function they are just displayed as letters N/H/E/B.
Remove these unsupported format specifiers from the 'Print' statements
to fix the issue.
Signed-off-by: Ko
46 matches
Mail list logo
