[edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way to reconnect driver

2022-06-23 Thread Li, Walon
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3952 In UEFI spec, it defines reconnect timing that will be activated upon exiting of the formset or the browser. However, we did't use this kind of way to check reconnect conditioncode. Code only blocks reconnect if page is updated dynamically. T

[edk2-devel] [PATCH v2] UefiPayloadPkg: Backward support with python 3.6

2022-06-23 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3960 Currently, UniversalPayloadBuild.py don't have support python3.6, we use python3.6 will encounter f"" failure use the change to fix it to support python3.6/3.7/3.8. Cc: Guo Dong Cc: Ray Ni Cc: James Lu Reviewed-by: Gua

[edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Coding style bug fix

2022-06-23 Thread Paweł Poławski
Local variable name overlaped with function name. Variable name has been updated to remove name duplication. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Paweł Poławski --- UefiCpuPkg/CpuMpPei/CpuBist.c | 40 ++-- 1 file changed, 20 insertions(+), 20 deletions(-)

[edk2-devel] [PATCH] UefiPayloadPkg: Backward support with python 3.6

2022-06-23 Thread kasimx . liu
From: KasimX Liu REF: ttps://bugzilla.tianocore.org/show_bug.cgi?id=3960 Currently, UniversalPayloadBuild.py don't have support python3.6, we use python3.6 will encounter f"" failure use the change to fix it to support python3.6/3.7/3.8. Cc: Guo Dong Cc: Ray Ni Cc: James Lu Reviewed-by: Gua

[edk2-devel] [PATCH v1 0/1] Coding style violation fix

2022-06-23 Thread Paweł Poławski
Hello edk2-devel list, This is my first contribution to the EDK2 project. I was following upstream howto creating this email / patch. Please let me know in case I did something the wrong way. Laszlo Ersek in his email to edk2-devel related to "CPU count limitation in CpuMpPei BIST processing" poi

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Backward support with python 3.6

2022-06-23 Thread Ni, Ray
Why use PY 3.6? Even PY 3.8 is about to be deprecated by Python community. > -Original Message- > From: Liu, KasimX > Sent: Friday, June 24, 2022 11:48 AM > To: devel@edk2.groups.io > Cc: Liu, KasimX ; Dong, Guo ; Ni, > Ray ; Lu, James > ; Guo, Gua > Subject: [PATCH v2] UefiPayloadPkg:

Re: [edk2-devel] BaseTools: Current status of BaseTools/Source/Python

2022-06-23 Thread Yuwei Chen
Hi Ayush, The migration is still working in progress. In order to ensure the normal use of users, the current bug fixes are still based on BaseTools in edk2. After all the migrations are completed, an official notification will be sent, and the developments and bug fixing works will be transfe

Re: [edk2-devel] [edk2-rfc] RFC v2: Static Analysis in edk2 CI

2022-06-23 Thread Michael D Kinney
I have Coverity scan builds running in a GitHub Action and then uploaded to Coverity. We should be able to configure a GitHub Action to run other analyzers. Mike > -Original Message- > From: r...@edk2.groups.io On Behalf Of Pedro Falcato > Sent: Tuesday, June 14, 2022 1:00 PM > To: r..

Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message

2022-06-23 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Monday, June 20, 2022 6:07 AM > To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming > ; Chen, Christine > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix

Re: [edk2-devel] [PATCH v6 0/5] Handling of multiple PCI

2022-06-23 Thread Ojeda Leon, Nicolas via groups.io
> On Wed, 22 Jun 2022 at 17:35, Ard Biesheuvel wrote: > > > > On Tue, 21 Jun 2022 at 23:28, Nicolas Ojeda Leon wrote: > > > > > > Increased control is provided in Ovmf platforms to define and > > > configure the specifications of multiple PCI host bridges in the > > > hypervisor. The host propa

Re: [edk2-devel] [PATCH v2 2/2] [edk2-platforms] Silicon/Intel/FitGen: Support to override the MBZ byte in Startup ACM entries for other usages

2022-06-23 Thread Oram, Isaac W
This code is gratuitous on typecasting and pointer use. As this change is making the use of these fields more confusing, I would like to see it simplified. e.g. *(UINT32 *)&FitEntry[FitIndex].Size[0] = This is introducing possible errors. More correct would be FitEntry[FitIndex].Size[0] = (UI

Re: [edk2-devel] [PATCH v2 1/2] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-06-23 Thread Oram, Isaac W
Reviewed-by: Isaac Oram -Original Message- From: Lin, Jason1 Sent: Thursday, June 23, 2022 7:45 AM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v2 1/2] [edk2-platforms]

[edk2-devel] [PATCH v4] UefiPayloadPkg: Add support for logging to CBMEM console

2022-06-23 Thread Benjamin Doron
Writes TianoCore debug logs into the CBMEM console ringbuffer, from where the user can retrieve them with the `cbmem` userspace utility. The intention is to aid in debugging non-fatal issues even in release builds, or simply make TianoCore's logs available to those interested. Consequently, MDEPKG

[edk2-devel] [PATCH] Ovmf: Include HardwareInfoLib library classes for IntelTdx

2022-06-23 Thread Ojeda Leon, Nicolas via groups.io
Include HardwareInfoLib classes in the IntelTdxX64.dsc for this platform to use it during build given that PciHostBridgeUtilityLib depends on it. Cc: Alexander Graf Cc: Gerd Hoffmann Cc: Ard Biesheuvel Signed-off-by: Nicolas Ojeda Leon --- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 ++ 1 file chang

[edk2-devel] [PATCH 1/2] ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc

2022-06-23 Thread Ojeda Leon, Nicolas via groups.io
Include DxeHardwareInfoLib class in the common ArmVirt.dsc.inc so that ArmVirt* platforms use it during build given that PciHostBridgeUtilityLib depends on it. Cc: Alexander Graf Cc: Gerd Hoffmann Cc: Ard Biesheuvel Signed-off-by: Nicolas Ojeda Leon --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + ArmVi

[edk2-devel] [PATCH 0/2] Include HardwareInfoLib in all platforms using

2022-06-23 Thread Ojeda Leon, Nicolas via groups.io
In past days, a patch series to support multiple PCI host bridges in Ovmf was merged which caused an error in ArmVirtQemuKernel.dsc build, part of the CI pipeline. These 2 commits aim at fixing this issue by adding the HardwareInfoLib to all ArmVirt* platofrms as well as for IntelTdx which were mi

[edk2-devel] [PATCH v2 2/2] [edk2-platforms] Silicon/Intel/FitGen: Support to override the MBZ byte in Startup ACM entries for other usages

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3959 As per FIT BIOS Specification 1.2 Rules, the size bytes (3 bytes)/ reserved byte (1 byte) / CheckSum byte (1 byte) in type 2 are must-be-zero (MBZ). These bytes could be override for the other usages. In the future, if th

[edk2-devel] [PATCH v2 1/2] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 Within current FitGen tool there had limitation only allow one S-ACM to generate the Type 2 entry. This code change is used to support multiple type 2 entries up to 0x20. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Limin

[edk2-devel] [PATCH v1 1/2] [edk2-platforms] Silicon/Intel/FitGen: Support multiple Startup ACM Type 2 entries in FitGen tool

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3958 Within current FitGen tool there had limitation only allow one S-ACM to generate the Type 2 entry. This code change is used to support multiple type 2 entries up to 0x20. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Limin

[edk2-devel] [PATCH v1 2/2] [edk2-platforms] Silicon/Intel/FitGen: Support to override the MBZ byte in Startup ACM entries for other usages

2022-06-23 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3959 As per FIT BIOS Specification 1.2 Rules, the size bytes (3 bytes)/ reserved byte (1 byte) / CheckSum byte (1 byte) in type 2 are must-be-zero (MBZ). These bytes could be override for the other usages. In the future, if th

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - 06/23/2022 #cal-notice

2022-06-23 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* 06/23/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?subject=Re:%20Eve

[edk2-devel] [edk2-platforms][PATCH v1 0/1] BoardModulePkg: Fix Boot0000 got overwritten

2022-06-23 Thread JamesWang [王家明] via groups . io
A simple fix to avoid overwrtiing Boot when mBootMenuFile is not found. James Wang (1): BoardModulePkg: Fix Boot got overwritten Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) -- 2.13.2

[edk2-devel] [PATCH v1 1/1] BoardModulePkg: Fix Boot0000 got overwritten

2022-06-23 Thread JamesWang [王家明] via groups . io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3522 Boot will be overwritten when F7 is pressed and Boot Menu is not found. Check if mBootMenuOptionNumber is valid or not before calling RegisterBootOptionHotkey Cc: Eric Dong Cc: Isaac Oram Cc: Liming Gao Signed-off-by: James Wang ---

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-23 Thread Marvin Häuser
On 22. Jun 2022, at 20:18, Andrew Fish wrote: > > > >> On Jun 22, 2022, at 10:43 AM, Marvin Häuser wrote: >> >> Hey Andrew, >> >> thanks for verifying! If my last mail was not clear, this is already done >> for IA32 builds, by the way. I suspect more trouble appeared there due to >> the la

Re: [edk2-devel] [PATCH v1 0/1] Set RW and P Attributes on Split Page

2022-06-23 Thread Taylor Beebe
Reminder to review On 6/15/2022 2:23 PM, Taylor Beebe wrote: From: Taylor Beebe REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3869 A split page should always have the RW and P attributes set so the lowest level page frame determines the access rights as detailed in 4.10.2.2 of the Intel

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-23 Thread vincent zimmer
sounds like a good idea. As a next step, perhaps a candidate activity for https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process in anticipation of future inclusion in PI? Vincent On Wed, Jun 22, 2022 at 2:41 PM Brian J. Johnson wrote: > > Andrew, > > Yes, adding a new

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-23 Thread Marvin Häuser
Hey Andrew, thanks for verifying! If my last mail was not clear, this is already done for IA32 builds, by the way. I suspect more trouble appeared there due to the lack of IP-relative addressing. Theo wanted to prepare a V2 with an enhanced commit message and a 2nd patch to remove the related

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - 06/23/2022 #cal-reminder

2022-06-23 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* 06/23/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?subject

Re: [edk2-devel] [PATCH v6 0/5] Handling of multiple PCI

2022-06-23 Thread Ard Biesheuvel
On Wed, 22 Jun 2022 at 17:35, Ard Biesheuvel wrote: > > On Tue, 21 Jun 2022 at 23:28, Nicolas Ojeda Leon wrote: > > > > Increased control is provided in Ovmf platforms to define and configure > > the specifications of multiple PCI host bridges in the hypervisor. The > > host propagates this infor

Re: [edk2-devel] [edk2-platforms][PATCH V3 1/9] Platform/Sgi: Update ACPI version to v6.4

2022-06-23 Thread PierreGondois
Hello Pranav, On 6/9/22 18:56, Pranav Madhu via groups.io wrote: Update the common ACPI tables used by all the Neoverse Reference Design platforms to ACPI version v6.4. Significant changes introduced are update API/macro definitions to incorporate with the extra fields introduced in ACPI 6.4, su

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms

2022-06-23 Thread PierreGondois
On 6/22/22 07:39, Pranav Madhu wrote: Hi Pierre, Thanks for reviewing this patch series. Please find my reply inline. Regards, Pranav -Original Message- From: Pierre Gondois Sent: Tuesday, June 21, 2022 2:15 PM To: devel@edk2.groups.io; Pranav Madhu ; Thomas Abraham Cc: Sami Muja

Re: [edk2-devel] [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest

2022-06-23 Thread Gerd Hoffmann
> > The flag is already there ;) > SECURE_BOOT_ENABLE is not a build-flag. It can only works in .dsc files. > The build-flag(SECURE_BOOT_FEATURE_ENABLED) would be defined in .dsc: > [BuildOptions] > !if $(SECURE_BOOT_ENABLE) == TRUE > MSFT:*_*_*_CC_FLAGS = /D SECURE_BOOT_FEATURE_ENABLED > INTE