*Reminder:* TianoCore Design Meeting - APAC/NAMO
*When:*
05/13/2022
9:30am to 10:30am
(UTC+08:00) Asia/Shanghai
*Where:*
Microsoft Teams
*Organizer:* Ray Ni ray...@intel.com (
ray...@intel.com?subject=Re:%20Event:%20TianoCore%20Design%20Meeting%20-%20APAC%2FNAMO
)
View Event ( https://edk2.gr
Reviewed-by: Ray Ni
> -Original Message-
> From: Chao, Zhuoran
> Sent: Saturday, May 7, 2022 5:40 PM
> To: devel@edk2.groups.io
> Cc: Chao, Zhuoran ; Ni, Ray
> Subject: [PATCH v3] PcAtChipsetPkg: Change the flow of PcRtcInit()
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3913
Today's implementation allocates below 1MB memory for the 16bit, 32bit
and 64bit code.
But it's not necessary since now the 32bit and 64bit code run at high
memory no matter in PEI and DXE phase.
The patch simplifies the logic to remove the code that handles the
case when WakeupBufferHigh is 0.
I
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Michael Roth
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Erdem Aktas
Cc: Gerd Hoffmann
---
.../Library/MpInitLib/Ia32/MpFuncs.nasm | 3 +-
UefiCpuPkg/
Ray Ni (4):
MpInitLib: Allocate code buffer for PEI phase
MpInitLib: remove unneeded global ASM_PFX
MpInitLib: Put SEV logic in separate file
MpInitLib: Only allocate below 1MB memory for 16bit code
UefiCpuPkg/Library/MpInitLib/AmdSev.c | 6 +-
UefiCpuPkg/Library/MpInitLib/Dxe
Today's implementation assumes PEI phase runs at 32bit so
the execution-disable feature is not applicable.
It's not always TRUE.
The patch allocates 32bit&64bit code buffer for PEI phase as well.
Signed-off-by: Ray Ni
Cc: Eric Dong
---
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg
global in NASM file is used for symbols that are
referenced in C files.
Remove unneeded global keyword in NASM file.
Signed-off-by: Ray Ni
---
UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 8 +---
UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 10 ++
2 files changed, 3 insertio
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3913
The original flow of PcRtcInit() is like:
1. Guarantee atomic accesses to the RTC time registers and
read out the value.
2. Program RTC register B. (adopt 12h mode or 24h mode. Current
bios code sets RTC to 24h mode by default).
3. Then