Re: [edk2-devel] [rfc] Remove support for unsupported tool_chain_tags

2022-05-04 Thread Rebecca Cran
Yes, I've been occasionally running builds on XCODE5. OvmfPkg currently fails with an unresolved symbol. -- Rebecca Cran On 5/4/22 19:58, Andrew Fish via groups.io wrote: I can sign up to maintain XCODE. I think Rebecca has been running test builds with XCODE. The XCODE5 names comes from th

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg: Add README for TDVF

2022-05-04 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Wednesday, May 4, 2022 8:14 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Brijesh Singh ; > Aktas, Erdem ; Gerd Hoffmann > ; James Bottomley ; Yao, Jiewen > ; Tom Lendacky > Subject: [PATCH V2 1/1] OvmfPkg: Add REA

Re: [edk2-devel] [rfc] Remove support for unsupported tool_chain_tags

2022-05-04 Thread Andrew Fish via groups.io
I can sign up to maintain XCODE. I think Rebecca has been running test builds with XCODE. The XCODE5 names comes from the compiler flags needing to change for Xcode 5. Yes 2013 called and wants it compiler back. Thanks, Andrew Fish > On May 2, 2022, at 4:24 PM, Sean wrote: > > As discuss

[edk2-devel] 回复: [edk2-rfc] [rfc] Remove support for unsupported tool_chain_tags

2022-05-04 Thread gaoliming
Sean: After remove, the supported tool chain will have its maintainer. This is a good idea. For CLANG tool chain, CLANGPDB and CLANGDWARF supports IA32 and X64 arch only, they can run Windows/Linux/MacOs. CLANGPDB is to directly generate EFI image with PDB debug symbol, CLANGDWARF is to gen

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg: Save PcdConfidentialComputingGuestAttr in mCcGuestAttr

2022-05-04 Thread Ni, Ray
On Mon, May 2, 2022 at 03:03 PM, Min Xu wrote: > > The reason why C global variable cannot be used in PEIM is that in some > scenario PEIM is executed in FLASH so that the value of C global variable > cannot be kept in different calls. But I don't think it is a problem in this > situation. > 1. T

回复: [edk2-devel] Does BaseTools support VS2022?

2022-05-04 Thread gaoliming
Ray: There is one BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3879 for VS2022. Now, there is no work plan for it. Thanks Liming 发件人: devel@edk2.groups.io 代表 Ni, Ray 发送时间: 2022年4月29日 17:13 收件人: devel@edk2.groups.io 抄送: Feng, Bob C ; Sean Brogan 主题: [edk2-devel] Does BaseTools suppor

回复: [edk2-devel] [PATCH 10/10] BaseTools: Remove RVCT support

2022-05-04 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2022年5月4日 2:48 > 收件人: devel@edk2.groups.io; Leif Lindholm ; > Ard Biesheuvel ; Sami Mujawar > ; Gerd Hoffmann ; Bob Feng > ; Liming Gao ; Yuwei > Chen ; Jiewen Yao ; Jian J > Wang ; Xiaoyu Lu ; Guomin > Jia

回复: [edk2-devel] [PATCH v5 0/8] Add Variable Flash Info HOB

2022-05-04 Thread gaoliming
Michael: I would suggest to reuse MdePkg/MdeLibs.dsc.inc to list the library and PCD from the edk2 core packages, such as MdePkg, MdeModulePkg, CryptoPkg, SecurirtyPkg and so on. Those packages are required by every platforms. They can't be separated. So, I think MdePkg/MdeLibs.dsc.inc is for

[edk2-devel] [PATCH v1 11/11] EmulatorPkg: Pipeline: Resolve SecureBootVariableLib dependency

2022-05-04 Thread Kun Qin
The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve pipeline builds. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Kun Qin --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1

[edk2-devel] [PATCH v1 10/11] OvmfPkg: Pipeline: Resolve SecureBootVariableLib dependency

2022-05-04 Thread Kun Qin
The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve pipeline builds. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan Cc

[edk2-devel] [PATCH v1 09/11] SecurityPkg: SecureBootVariableLib: Added unit tests

2022-05-04 Thread Kun Qin
From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This change added unit test and enabled it from pipeline for the updated SecureBootVariableLib. The unit test covers all implemented interfaces and certain corner cases. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Signed-of

[edk2-devel] [PATCH v1 08/11] SecurityPkg: SecureBootConfigDxe: Updated invocation pattern

2022-05-04 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 This change is in pair with the previous SecureBootVariableLib change, which updated the interface of `CreateTimeBasedPayload`. This change added a helper function to query the current time through Real Time Clock protocol.

[edk2-devel] [PATCH v1 06/11] SecurityPkg: SecureBootVariableProvisionLib: Updated implementation

2022-05-04 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change is in pair with the previous SecureBootVariableLib, which removes the explicit invocation of `CreateTimeBasedPayload` and used new interface `EnrollFromInput` instead. The original `SecureBootFetchData` is also m

[edk2-devel] [PATCH v1 07/11] SecurityPkg: Secure Boot Drivers: Added common header files

2022-05-04 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change added common header files to consumer drivers to unblock pipeline builds. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Signed-off-by: Kun Qin --- SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c

[edk2-devel] [PATCH v1 05/11] SecurityPkg: SecureBootVariableLib: Added newly supported interfaces

2022-05-04 Thread Kun Qin
From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This change updated the interfaces provided by SecureBootVariableLib. The new additions provided interfaces to enroll single authenticated variable from input, a helper function to query secure boot status, enroll all secure b

[edk2-devel] [PATCH v1 03/11] SecurityPkg: SecureBootVariableLib: Updated time based payload creator

2022-05-04 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 This change updated the interface of 'CreateTimeBasedPayload' by requiring the caller to provide a timestamp, instead of relying on time protocol to be ready during runtime. It intends to extend the library availability durin

[edk2-devel] [PATCH v1 04/11] SecurityPkg: SecureBootVariableLib: Updated signature list creator

2022-05-04 Thread Kun Qin
From: kuqin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change removes the interface of SecureBootFetchData, and replaced it with `SecureBootCreateDataFromInput`, which will require caller to prepare available certificates in defined structures. This improvement will eliminate

[edk2-devel] [PATCH v1 02/11] SecurityPkg: PlatformPKProtectionLib: Added PK protection interface

2022-05-04 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 This patch provides an abstracted interface for platform to implement PK variable related protection interface, which is designed to be used when PK variable is about to be changed by UEFI firmware. This change also provided

[edk2-devel] [PATCH v1 00/11] Enhance Secure Boot Variable Libraries

2022-05-04 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 Current SecureBootVariableLib provide great support for deleting secure boot related variables, creating time-based payloads.

[edk2-devel] [PATCH v1 01/11] SecurityPkg: UefiSecureBoot: Definitions of cert and payload structures

2022-05-04 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 This change added certificate and payload structures that can be consumed by SecureBootVariableLib and other Secure Boot related operations. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Signed-off-by: Kun Qin --- Security

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add WPA3 related TLS configure macro

2022-05-04 Thread yi1 li
Hi Jiewen, Thanks for feedback, I will check it. For 7), I will submit relevant TLS function code together next patch. -Original Message- From: Yao, Jiewen Sent: Wednesday, May 4, 2022 6:13 PM To: devel@edk2.groups.io; Li, Yi1 Cc: Kinney, Michael D ; Gao, Liming Subject: RE: [edk2-de

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add WPA3 related TLS configure macro

2022-05-04 Thread Yao, Jiewen
Thanks Yi. Some feedback: 1) {0x13, *} is defined in TLS1.3 - https://datatracker.ietf.org/doc/html/rfc8446#appendix-B.4 The comment "> /// TLS Cipher Suite, refers to A.5 of rfc-2246, rfc-4346 and rfc-5246." should be updated to include 8446 as well. 2) Although it is not absolutely required

[edk2-devel] [PATCH 1/1] MdePkg: Add WPA3 related TLS configure macro

2022-05-04 Thread yi1 li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3892 Which are needed for SUITE-B and SUITE-B-192. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: yi1 li --- MdePkg/Include/IndustryStandard/Tls1.h | 133 ++--- 1 file changed, 97 insertions(+), 36 deletions(-) diff -

Re: [edk2-devel] [PATCH 00/10] Multiple packages: Remove RVCT support

2022-05-04 Thread Leif Lindholm
On Tue, May 03, 2022 at 21:13:18 +0200, Ard Biesheuvel wrote: > On Tue, 3 May 2022 at 20:48, Rebecca Cran wrote: > > > > RVCT is obsolete, no longer supported and only supports 32-bit systems. > > Since it's no longer used, remove it. > > > > Personal PR: https://github.com/tianocore/edk2/pull/283