Change the DebugPrintErrorLevelLib instance in UefiPayloadPkg.dsc to
allow bootloader to config DebugPrintErrorLevel.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yuanhao Xie
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +-
1 file changed, 1 insertion
It consumes the HOB defined in
UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h, and allow bootloader
to config DebugPrintErrorLevel.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yuanhao Xie
---
UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h
Hi,
Just wanted to note that this patch set is not mergeable/testable right
now. I'll submit a correct v2 as soon as possible.
Thanks for the understanding,
Pedro
On Sun, Mar 27, 2022 at 12:59 AM Pedro Falcato
wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871
>
> Delete BaseCrcL
Hi,
Hao, you are 100% correct. It seems that not only is SourceLevelDebugPkg
using a different CRC-16 algorithm, my CalculateCrc16()'s lookup table is
incorrect.
I'll re-submit a v2 that fixes these issues.
Sorry for the trouble.
Thanks,
Pedro
On Mon, Mar 28, 2022 at 1:14 AM Wu, Hao A wrote:
Reviewed-by: Ray Ni
-Original Message-
From: Vang, Judah
Sent: Saturday, March 26, 2022 7:28 AM
To: devel@edk2.groups.io
Cc: Vang, Judah ; Wang, Jian J ;
Dong, Guo ; Ni, Ray ; Maurice Ma
; You, Benjamin ; Rhodes, Sean
; Mistry, Nishant C
Subject: [PATCH v1 21/28] UefiPayloadPkg: Add
Reviewed-by: Ray Ni
-Original Message-
From: Vang, Judah
Sent: Saturday, March 26, 2022 7:28 AM
To: devel@edk2.groups.io
Cc: Vang, Judah ; Wang, Jian J ;
Andrew Fish ; Ni, Ray ; Mistry, Nishant C
Subject: [PATCH v1 22/28] EmulatorPkg: Add ProtectedVariable reference
REF: https://bug
All look good! 3 minor comments:
1. DxeMpLib.c may not need to include MpIntelTdx.h
2. You may use "ASSERT (!ExcludeBsp)" in below code. Otherwise, it may confuse
reader that when ExcludeBsp is TRUE, SUCCESS is returned when ProcessorCount is
1 which is not right.
if (CC_GUEST_IS_TDX (PcdGet64
Will slightly modify the subject to:
MdeModulePkg/Ufs: bRefClkFreq attribute be programmed after fDeviceInit
Reviewed-by: Hao A Wu
Will wait a day before merging to see if comment from other reviewers.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
Hello,
My local test shows that the results between the old (SourceLevelDebugPkg) &
new (MdePkg) CRC16 implementation are different:
UINT8 Array[16] = {1,2,3,4,5,6,7,8,8,7,6,5,4,3,2,1};
UINT16 a, b;
a = CalculateCrc16New(Array, sizeof(Array), 0x);
b = CalculateCrc16Old(Array, sizeof(Arr
