Reviewed-by: Ray Ni
-Original Message-
From: Kuo, Ted
Sent: Thursday, March 17, 2022 4:39 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; De, Debkumar ; Han,
Harry ; West, Catharine ; Xu,
Min M
Subject: [edk2-devel][PATCH] UefiCpuPkg: Update BFV searching algorithm in VTF0
REF:https://bug
This patch looks good to me.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Li, Yi1
Sent: Tuesday, March 22, 2022 3:26 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Feng, Bob C ; Gao, Liming
; Luo, Heng
Subject: [PATCH V3 1/1] BaseTools: Add the FeatureFlagExpression usage to
1. Use PeiDxeDebugLibReportStatusCode library for DebugLib, and add
ReportStatusCodeLib.
2. Remove gEfiMdeModulePkgTokenSpaceGuid.PcdSerialExtendedTxFifoSize
overrided in UefiPayloadPkg.dsc.
3. Change PcdHardwareErrorRecordLevel to 1
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc:
Reviewed-by: Dun Tan
-Original Message-
From: Ni, Ray
Sent: Thursday, March 24, 2022 8:38 AM
To: Dong, Guo ; Rhodes, Sean ;
devel@edk2.groups.io; Tan, Dun
Cc: Patrick Rudolph ; Ma, Maurice
; You, Benjamin ; Rhodes, Sean
Subject: RE: [PATCH 1/5] UefiPayloadPkg/UefiPayloadPkg.ci.yaml
Acked-by: Ray Ni
Dun, can you help review?
-Original Message-
From: Dong, Guo
Sent: Thursday, March 24, 2022 1:58 AM
To: Rhodes, Sean ; devel@edk2.groups.io
Cc: Patrick Rudolph ; Ni, Ray
; Ma, Maurice ; You, Benjamin
; Rhodes, Sean
Subject: RE: [PATCH 1/5] UefiPayloadPkg/UefiPayload
Reviewed-by: Ray Ni
-Original Message-
From: Dong, Guo
Sent: Thursday, March 24, 2022 1:56 AM
To: Akihiko Odaki
Cc: devel@edk2.groups.io; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: RE: [PATCH] UefiPayloadPkg: Fix architecture in the build instruction
Reviewed-by: Guo Dong
---
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDX the guest firmware is designed to publish a multiprocessor-wakeup
structure to let the guest-bootstrap processor wake up guest-application
processors with a mailbox. The mailbox is memory that the guest firmware
can reserve so each gu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
OvmfPkg/PlatformPei is updated to support Tdx guest. There are below
major changes.
- Set Tdx related PCDs
- Publish Tdx RamRegions
In this patch there is another new function BuildPlatformInfoHob ().
This function builds EFI_HOB_PLATFORM
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
There are below changes in PlatformInitLib for Tdx guest:
1. Publish ram regions
In Tdx guest, the system memory is passed in TdHob by host VMM. So
the major task of PlatformTdxPublishRamRegions is to walk thru the
TdHob list and transfer t
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
MMIO region in Tdx guest is set with PcdTdxSharedBitMask in TdxDxe's
entry point. In SEV guest the page table entries is set with
PcdPteMemoryEncryptionAddressOrMask when creating 1:1 identity table.
So the AddressEncMask in GetPageTableEnt
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Guest Physical Address (GPA) space in Td guest is divided into private
and shared sub-spaces, determined by the SHARED bit of GPA. This PCD
holds the shared bit mask. Its default value is 0 and it will be set
in PlatformPei driver if it is o
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
If IA32_ERER.NXE has already been set, skip setting it again.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Gerd Hoffmann
Acked-by: Gerd Hoffmann
Reviewed-by:
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
There are below major changes in this commit.
1. SecEntry.nasm
In TDX BSP and APs goes to the same entry point in SecEntry.nasm.
BSP initialize the temporary stack and then jumps to SecMain, just as
legacy Ovmf does.
APs spin in a modifie
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
Move functions in PlatformPei/Platform.c to PlatformInitLib/Platform.c.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Gerd Hoffmann
Cc: Sebastien Boeuf
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Declare the local variables in SecCoreStartupWithStack that actually
move the data elements as volatile to prevent the optimizer from
replacing this function with the intrinsic memcpy().
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Si
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
When host VMM create the Td guest, the system memory informations are
stored in TdHob, which is a memory region described in Tdx metadata.
The system memory region in TdHob should be accepted before it can be
accessed. So the newly added fun
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
Move functions in PlatformPei\MemDetect.c to PlatformInitLib\MemDetect.c.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Gerd Hoffmann
Cc: Sebastien Boeu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
NoexecDxeInitialization is split into 2 functions:
- PlatformNoexecDxeInitialization is for PlatformInitLib
- NoexecDxeInitialization calls PlatformNoexecDxeInitialization and
then sets PCD.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Br
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
MiscInitialization is split into 2 functions:
- PlatformMiscInitialization is for PlatformInitLib.
- MiscInitialization calls PlatformMiscInitialization and then sets
PCD. It is for PlatformPei.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
MemMapInitialization is split into 2 functions:
- PlatformMemMapInitialization is for PlatformInfoLib
- MemMapInitialization calls PlatformMemMapInitialization and then
sets PCDs. It is for PlatformPei.
Cc: Ard Biesheuvel
Cc: Jordan Ju
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
InitializeRamRegions is refactored into 3 calls:
- PlatformQemuInitializeRam
- SevInitializeRam
- PlatformQemuInitializeRamForS3
SevInitializeRam is not in PlatformInitLib. Because in the first stage
PlatformInitLib only support the basic
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
Rename QemuUc32BaseInitialization to PlatformQemuUc32BaseInitialization.
This function is for PlatformInitLib.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
MaxCpuCountInitialization is splitted into two:
- PlatformMaxCpuCountInitialization is for PlatformInitLib
- MaxCpuCountInitialization is for PlatformPei. It calls
PlatformMaxCpuCountInitialization then sets PCDs.
Cc: Ard Biesheuvel
Cc
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
>From this patch we start to restruct the functions which set PCDs into
two, one for PlatformInitLib, one for PlatformPei.
AddressWidthInitialization is the first one. It is splitted into two:
- PlatformAddressWidthInitialization is for Pla
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
Refactor MiscInitialization for CloudHV to set PCD as other platforms
do. Because in the following patch we will split the functions which
set PCDs into two, one for PlatformInitLib, one for PlatformPei.
Cc: Ard Biesheuvel
Cc: Jordan Justen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
In MiscInitialization Microvm looks a little weird. Other platforms
call PcdSet16S to set the PcdOvmfHostBridgePciDevId with the value same
as PlatformInfoHob->HostBridgeDevId. But Microvm doesn't follow this
way. In switch-case 0x is Mic
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
The intention of PlatformInitLib is to extract the common function used
in OvmfPkg/PlatformPei. This lib will be used not only in PEI phase but
also in SEC phase. SEC phase cannot use global variables between
different functions. So PlatformI
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
In this patch of PlatformInitLib, below hob functions are introduced:
- PlatformAddIoMemoryBaseSizeHob
- PlatformAddIoMemoryRangeHob
- PlatformAddMemoryBaseSizeHob
- PlatformAddMemoryRangeHob
- PlatformAddReservedMemoryBaseSizeHob
They
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TDVF access MMIO with TDG.VP.VMCALL to invoke VMM provided emulation
functions. If the access to MMIO fails, it fall backs to the direct
access.
BaseIoLibIntrinsic.inf is the IoLib used by other packages. It will
not support I/O in Td guest
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
There are 3 variants of PlatformPei in OvmfPkg:
- OvmfPkg/PlatformPei
- OvmfPkg/XenPlatformPei
- OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf
These PlatformPeis can share many common codes, such as
Cmos / Hob / Memory / Platform related funct
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel TDX architecture does not prescribe a specific software convention
to perform I/O from the guest TD. Guest TD providers have many choices to
provide I/O to the guest. The common I/O models are emulated devices,
para-virtualized devices
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Add base support to handle #VE exceptions. Update the common exception
handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib
library when a #VE is encountered. A non-zero return code will propagate
to the targeted exception h
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In Tdx BSP may issues commands to APs for some task, for example, to
accept pages paralelly. BSP also need to wait until all the APs have
done the task. TdxMailboxLib wraps these common funtions for BSP.
Cc: Ard Biesheuvel
Cc: Jordan Juste
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
IntelTdx.h defines the defition used by TDX in OvmfPkg:
- Mailbox related defitions,such as the data structure, command code,
AP relocation defitions.
See Table 5.44 Multiprocessor Wakeup Mailbox Structure in below link.
https://uefi.or
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others
are treated as APs.
So MP intialization is rather simple. The processor info is retrieved by
TDCALL, ApWorker is not supported, BSP is always the working processor,
whi
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Add macros CC_GUEST_IS_SEV / CC_GUEST_IS_TDX to check SEV / TDX guest.
Cc: Michael Roth
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Eric Dong
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
C
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed
directly from/to CPU. Some should be accessed via explicit requests
from the host VMM using TDCALL(TDG.VP.VMCALL). This is done by the
help of TdxLib.
Please refer to [TDX
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
This commit supports IoRead/IoWrite for SEV/TDX/Legacy guest in one
binary. It checks the guest type in runtime and then call corresponding
functions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Brijesh Singh
Cc: Erdem Akta
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Previously IoFifo functions are in X64/IoFifoSev.nasm which supports
both SEV guest and Legacy guest. IoLibFifo.c is introduced to support
SEV/TDX/Legacy guest in one binary. It checks the guest type in runtime
and call corresponding functio
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
VmgExitLib performs the necessary processing to handle a #VC exception.
VmgExitLibNull is a NULL instance of VmgExitLib which provides a
default limited interface. In this commit VmgExitLibNull is extended to
handle a #VE exception with a de
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
The base VmgExitLib library provides a default limited interface to
handle #VE exception. To provide full support, the OVMF version of
VmgExitLib is extended to provide full support of #VE handler.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jo
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TdxLib is created with functions to perform the related Tdx operation.
This includes functions for:
- TdAcceptPages : Accept pending private pages and initialize the pages
to all-0 using the TD ephemeral private key.
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Introduce basic Tdx functions in BaseLib:
- TdCall ()
- TdVmCall ()
- TdIsEnabled ()
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: G
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Guest software can be designed to run either as a TD, as a legacy virtual
machine, or directly on the CPU, based on enumeration of its run-time
environment. [TDX-Module] Chap 10.2 defines the flow and the new CPUID
leaf 0x21.
[TDX-Module] A
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Tdx.h includes the Intel Trust Domain Extension definitions.
Detailed information can be found in below document:
https://software.intel.com/content/dam/develop/external/us/en/
documents/tdx-module-1eas-v0.85.039.pdf
Cc: Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology
that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory
Encryption (MKTME) with a new kind of virutal machines guest called a
Trust Domain (TD). A T
Thanks for the patches. For the series:
Reviewed-by: Hao A Wu
Will wait a day before merging them to see if comments from others.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mara
> Sophie Grosch via groups.io
> Sent: Wednesday, March 23, 2022 6:2
I think it would be simpler to add the CpuLib mapping to MdePkg/MdeLibs.dsc.inc
All packages should already be including this file, so one change here removes
the need to modify all the individual DSC files.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yu Pu
> Sen
Step 4 to merge UefiCpuLib to CpuLib.
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLibNull.c | 17 --
UefiCpuPkg/Include/Library/UefiCpuLib.h| 5 ---
UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCp
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Ray Ni
Signed-off-by: Yu Pu
---
PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc
b/PcAtChipsetPkg/PcAtChipsetPkg.dsc
index 6db2bbc0b89d..b5441d0f2f23 100644
--- a/PcAtChipsetPkg/PcAt
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Hao A Wu
Signed-off-by: Yu Pu
---
SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
index 2f565d923bd4..71c5e93b99f5
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Yu Pu
---
OvmfPkg/Sec/SecMain.c | 1 -
OvmfPkg/AmdSev/AmdSevX64.dsc | 1 -
OvmfPkg/Bhyve/BhyveX64.dsc | 1 -
OvmfPkg/CloudHv/CloudHvX64.dsc | 1 -
OvmfPkg
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Guo Dong [gdong1]
Cc: Ray Ni [niruiyu]
Cc: Maurice Ma [mauricema]
Cc: Benjamin You [BenjaminYou]
Cc: Sean Rhodes
Signed-off-by: Yu Pu
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h| 1 -
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEnt
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Eric Dong [ydong10]
Cc: Ray Ni [niruiyu]
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 -
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 -
UefiCpuPkg/CpuDxe/CpuDxe.h
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 -
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 -
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
Step 3 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 -
IntelFsp2Pkg/FspSecCore/SecMain.h | 1 -
IntelFsp2Pkg/IntelFsp2Pkg.dsc | 1 -
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc |
Step 2 to merge UefiCpuLib to CpuLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c =>
MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c | 8 +--
MdePkg/Include/Library/CpuLib.h
Step 2 to merge UefiCpuLib to CpuLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLibNull.c | 17 ++
UefiCpuPkg/Include/Library/UefiCpuLib.h| 60
UefiCpuPkg/Library/BaseUefiCpuLib/Base
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Hao A Wu
Signed-off-by: Yu Pu
---
SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
index eba64a7b7877..2f565d923bd4
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Ray Ni
Signed-off-by: Yu Pu
---
PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc
b/PcAtChipsetPkg/PcAtChipsetPkg.dsc
index 451e60ddc857..6db2bbc0b89d 100644
--- a/PcAtChipsetPkg/PcA
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yu Pu
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h| 1 +
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 +
UefiPayloadPkg/UefiPayload
Step 1 to merge UefiCpuLib to CpuLib
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
IntelFsp2Pkg/FspSecCore/SecMain.h | 1 +
IntelFsp2Pkg/IntelFsp2Pkg.dsc | 1 +
3 files changed, 3 insertions(+)
diff --g
*** BLURB HERE ***
Yu Pu (17):
IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib.
IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on
UefiCpuLib.
OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
PcAtChipsetPkg: Add CpuLib to module INFs that depen
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Yu Pu
---
OvmfPkg/Sec/SecMain.c | 1 +
OvmfPkg/Sec/SecMain.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c
inde
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 +
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 +
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
I think these questions could be answered in the attached email which I replied
to Rudolph for similar questions.
Thanks,
Guo
From: devel@edk2.groups.io On Behalf Of King Sumo
Sent: Wednesday, March 23, 2022 2:06 PM
To: devel@edk2.groups.io; Rhodes, Sean
Cc: Dong, Guo
Subject: Re: [edk2-deve
Looks like for Guo's patch SMMSTORE driver is not needed since it
implements a SpiFlashLib for accessing the SPI Flash controller (via
hardware sequencer) of Intel CPU targets...
But this is for Universal Payload only right? I guess coreboot supports
only the non-universal mode.
This stuff was test
Hey Guo
To have the parselib and not SMMSTORE support is a bit of a paradox; coreboot
isn't fully functional without one. I think moving this and any subsequent
patches into edk2-platforms will inevitably lead to forks, which isn't
beneficial to anyone.
Is there any method (or ideally exceptio
Reviewed-by Sean Rhodes
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87912): https://edk2.groups.io/g/devel/message/87912
Mute This Topic: https://groups.io/mt/89710183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https:/
Hi Rudolph,
By my understanding, edk2 repo is mainly for the modules defined by industry
standards (e.g. UEFI and PI specifications).
For the modules that is specific to a vendor (e.g. Intel PCH), or a bootloader,
edk2-platform would be a better places.
Currently in the EDK2 UefiPayloadpkg, be
Hi Guo,
I don't see where it's written that UefiPayloadPkg is bootloader
independent. Can you point me to that documentation?
Reading the BuildAndIntegrationInstructions.txt I understand that it
is very bootloader specific, as it's basically designed as a
bootloader payload.
Where do you draw the
Hi Sean,
SMMSTORE and this FVB module are specific for coreboot while UefiPayloadPkg in
Edk2 is targeting platform/bootloader independent.
I just submitted an "add UEFI payload platform FV" patch to edk2-platforms
repo, in this patch it moves PCH specific modules from
Edk2 UefiPayloadPkg to edk
Reviewed-by: Guo Dong
-Original Message-
From: Sean Rhodes
Sent: Monday, March 21, 2022 2:10 AM
To: devel@edk2.groups.io
Cc: Patrick Rudolph ; Dong, Guo
; Ni, Ray ; Ma, Maurice
; You, Benjamin ; Rhodes, Sean
Subject: [PATCH 1/5] UefiPayloadPkg/UefiPayloadPkg.ci.yaml: Remove duplic
As a package reviewer, you just need review it and reply it with “Reviewed-by”
then the maintainer would merge it.
Thanks,
Guo
From: Sean Rhodes
Sent: Monday, March 21, 2022 1:52 AM
To: Dong, Guo ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
The
Reviewed-by: Guo Dong
-Original Message-
From: Akihiko Odaki
Sent: Saturday, March 19, 2022 2:07 AM
Cc: devel@edk2.groups.io; Dong, Guo ; Ni, Ray
; Ma, Maurice ; You, Benjamin
; Akihiko Odaki
Subject: [PATCH] UefiPayloadPkg: Fix architecture in the build instruction
Signed-off-by:
Reviewed-by: Guo Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sean Rhodes
Sent: Friday, March 18, 2022 7:17 AM
To: devel@edk2.groups.io
Cc: Rhodes, Sean
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Timeout configurable
Signed-off-by: Sean Rhodes
---
Uefi
Why adding "Cmos" in the module name?
In the DebugPrintErrorLevel.h, ErrorLevel is defined as UINT32, but its usage
is not clear for bootloaders ( so need add more info in the header file)
And it used "UNIVERSAL_PAYLOAD" in the interface, do you think this interface
would be added into universa
On March 23, 2022 3:20 PM, Ni Ray wrote:
> Min,
> MpInitLib contains following APIs. Let's discuss one by one.
>
> MpInitLibInitialize: Directly return. Looks good to me.
> MpInitLibGetNumberOfProcessors : Call TdxMpInitLibGetNumberOfProcessors().
> Why call a subfunction here but directly return
arghs, somehow broke those emails for group.io thread overview - not linked as
single thread. I hope they are fine in email clients :/
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87901): https://edk2.groups.io/g/devel/message/87901
Mu
Previous commit fixed that check in DXE, this one now for PEI.
Signed-off-by: Mara Sophie Grosch
---
MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiHci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiHci.c
b/MdeModulePkg/Bus
Hi,
new patch series, including the fix for the same problem in PEI
Mara Sophie Grosch (2):
MdeModulePkg/NvmExpressDxe: fix check for Cap.Css
MdeModulePkg/NvmExpressPei: fix check for NVM command set
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c| 2 +-
MdeModulePkg/Bus/Pci/NvmExpre
Fix the check for NVMe command set being supported by the controller.
Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1
in that register, making the OVMF think the NVMe controller does not
support NVMe.
Uncovered by commit 9dd14fc91c174eae87fd122c7ac70073a363527f, which
chan
Change the DebugPrintErrorLevelLib instance in UefiPayloadPkg.dsc to
allow bootloader to config DebugPrintErrorLevel.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yuanhao Xie
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +-
1 file changed, 1 insertion
It consumes the HOB defined in
UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h, and allow bootloader
to config DebugPrintErrorLevel
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yuanhao Xie
---
UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h
Reviewed-by: Ray Ni
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87895): https://edk2.groups.io/g/devel/message/87895
Mute This Topic: https://groups.io/mt/89858996/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk
Signed-off-by: Yuanhao Xie
---
UefiPayloadPkg/UefiPayloadPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec
b/UefiPayloadPkg/UefiPayloadPkg.dec
index 4051172caf..5c1aeb8235 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dec
+++ b/UefiPayload
Min,
MpInitLib contains following APIs. Let's discuss one by one.
MpInitLibInitialize: Directly return. Looks good to me.
MpInitLibGetNumberOfProcessors : Call TdxMpInitLibGetNumberOfProcessors(). Why
call a subfunction here but directly return in above API? Not quite consistent
to me. By the wa
88 matches
Mail list logo
