Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css

2022-03-19 Thread Mara Sophie Grosch via groups.io
Hi, sending again, because I forgot to CC reviewers. Best regards, Mara Sophie Grosch Am Wed, Mar 16, 2022 at 12:56:25PM -0700 schrieb littlefox via groups.io: Fix the check for NVMe command set being supported by the controller. Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which s

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Ayush Singh
Ok, I would like to ask why edkii-rust was abandoned. Was it simply because of a lack of time or were there some technical limitations/walls that lead to it? Ayush Singh -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87772): https://ed

[edk2-devel] [PATCH edk2-platforms 3/3] Platform/Qemu: Update SbsaQemu Readme.md with current TF-A build PLAT

2022-03-19 Thread Rebecca Cran
To build TF-A for QEMU Sbsa PLAT=qemu_sbsa should now be specified. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/Readme.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md index 692f9702de56..b

[edk2-devel] [PATCH edk2-platforms 2/3] Platform/Qemu: Update SbsaQemu Readme.md with current QEMU git URL

2022-03-19 Thread Rebecca Cran
The canonical QEMU Git URL isn't GitHub, but GitLab. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md index c514c33b7c2f..692f9702de56 100644 --

[edk2-devel] [PATCH edk2-platforms 0/3] Platform/Qemu/SbsaQemu: Update Readme.md

2022-03-19 Thread Rebecca Cran
Fix some issues with the SbsaQemu Readme.md file. Rebecca Cran (3): Platform/Qemu: Update SbsaQemu Readme.md to change 'ATF' to 'TF-A' Platform/Qemu: Update SbsaQemu Readme.md with current QEMU git URL Platform/Qemu: Update SbsaQemu Readme.md with current TF-A build PLAT Platform/Qemu/Sbsa

[edk2-devel] [PATCH edk2-platforms 1/3] Platform/Qemu: Update SbsaQemu Readme.md to change 'ATF' to 'TF-A'

2022-03-19 Thread Rebecca Cran
Trusted Firmware is no longer called ATF (ARM Trusted Firmware) but is now TF-A (Trusted Firmware for A-profile architecture). Update Readme.md to match. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/Readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platf

[edk2-devel] [PATCH edk2-platforms v2 3/3] Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device

2022-03-19 Thread Rebecca Cran
Add a RES0 device to the SSDT to reserve the PCI ECAM area. This fixes the warning that Linux prints: acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x4000-0x4fff] not reserved in ACPI namespace With this change, the "Firmware Bug" message is no longer printed, but a different warning i

[edk2-devel] [PATCH edk2-platforms v2 2/3] Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM addr

2022-03-19 Thread Rebecca Cran
Instead of using a custom Pcd for the ECAM address (gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress), use the Pcd from MdePkg. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar --- Platform/ARM/JunoPkg/ArmJuno.dec | 4

[edk2-devel] [PATCH edk2-platforms v2 1/3] Platform/ARM/JunoPkg: Convert AcpiSsdtRootPci.asl from tabs to spaces

2022-03-19 Thread Rebecca Cran
Other .asl files in Platform/ARM/JunoPkg/AcpiTables use spaces, while AcpiSsdtRootPci.asl uses tabs. To be consistent, convert it to spaces. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar --- Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl | 288 ++-- 1 file changed,

[edk2-devel] [PATCH edk2-platforms v2 0/3] JunoPkg: Fix AcpiSsdtRootPci.asl to use spaces and reserve ECAM area

2022-03-19 Thread Rebecca Cran
I noticed Linux reports a firmware bug with the current Juno ACPI tables. These patches fix it by reserving the ECAM area with a RES0 device, while also converting AcpiSsdtRootPci.asl from tabs to spaces and using the standard Pcd from MdePkg for the ECAM base address. Changes between v1 and v2:

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device

2022-03-19 Thread Rebecca Cran
On 3/17/22 03:55, Sami Mujawar wrote: On 05/03/2022 04:19 AM, Rebecca Cran wrote: Add a RES0 device to the SSDT to reserve the PCI ECAM area. This fixes the warning that Linux prints: acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x4000-0x4fff] not reserved in ACPI namespace [SAMI]

Re: [edk2-devel] [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM addr

2022-03-19 Thread Rebecca Cran
On 3/17/22 03:54, Sami Mujawar wrote:   // The physical base address for the PCI segment -    FixedPcdGet64 (PcdPciConfigurationSpaceBaseAddress), +    FixedPcdGet64 (gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress), [SAMI] I think this should just be FixedPcdGet64 (PcdPciExpressBaseAddres

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Yao, Jiewen
I see. Please let me know if you have some idea to continue. Thank you Yao, Jiewen From: Ayush Singh Sent: Saturday, March 19, 2022 10:14 PM To: Yao; Yao, Jiewen ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging Hello Jiewen,

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Ayush Singh
Hello Jiewen, I am a 2nd year University student and am interested in applying for GSoC 2022. I found the project Tasks-Add-Rust-Support-to-EDK-II ( https://github.com/tianocore/tianocore.github.io/wiki/Tasks-Add-Rust-Support-to-EDK-II ) and it contained links to the edkii-rust repository as be

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Yao, Jiewen
Thank you very much Marvin and Ayush. Glad you have interest on Rust. May I know what is your goal for this patch? Do you just want to make it pass build? Or want to work on something more? Currently, we did not work actively on https://github.com/tianocore/edk2-staging/tree/edkii-rust. Instea

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Ayush Singh
I see. While the other mails got the CC from the commits, the cover letter also needs to do a CC separately. Will keep this in mind from the next commit. Ayush Singh -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87758): https://edk2.gr

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Marvin Häuser
> On 19. Mar 2022, at 08:06, Ayush Singh wrote: > > CC Jiewen Yao You didn’t actually CC, done. Best regards, Marvin > > This is my 2nd email about this patch to fix edkii-rust branch in > edk2-staging repo, this time hopefully following contributing procedure > better. > > I have tried

[edk2-devel] [PATCH v1 3/3] RustPkg/Test/TestRustLangApp: Fix building

2022-03-19 Thread Ayush Singh
Removed defination of _fltused from RustPkg/Library/UefiRustIntrinsicLib since compiler_builtins now provides one Cc: Jiewen Yao Signed-off-by: Ayush Singh --- RustPkg/Library/UefiRustIntrinsicLib/src/lib.rs | 8 -- RustPkg/Test/TestRustLangApp/.cargo/config.toml | 3 + RustPkg/Test/TestRust

[edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Ayush Singh
CC Jiewen Yao This is my 2nd email about this patch to fix edkii-rust branch in edk2-staging repo, this time hopefully following contributing procedure better. I have tried to to fix RustPkg/Test/HelloWorld, RustPkg/Test/HelloWorld2, RustPkg/Test/TestRustLangApp, and RustPkg/Test/TestRustLangLib.

[edk2-devel] [PATCH v1 2/3] RustPkg/Test/TestRustLangLib: Fix Building

2022-03-19 Thread Ayush Singh
From: Ayush Singh Removed the Alloc trait usage which seems to have been removed from Rust now. Cc: Jiewen Yao Signed-off-by: Ayush Singh --- RustPkg/Library/UefiRustAllocationLib/src/lib.rs | 53 ++-- RustPkg/Test/TestRustLangLib/.cargo/config.toml | 3 + RustPkg/Test/TestRustLangLib/sr

[edk2-devel] [PATCH v1 1/3] RustPkg/Test: Replace cargo-xbuild with build-std

2022-03-19 Thread Ayush Singh
From: Ayush Singh Tests Migrated: - Test/HelloWorld - Test/HelloWorld2 Cc: Jiewen Yao Signed-off-by: Ayush Singh --- RustPkg/Test/HelloWorld/.cargo/config.toml | 3 +++ RustPkg/Test/HelloWorld2/.cargo/config.toml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/RustPkg/Test/HelloWorl