Re: [edk2-devel] [PATCH v4 1/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-01-20 Thread Gao, Zhichao
Hi Sami, Thanks for the clarification. You’re right. #1 it is better to add error message before skip this item. #2 I miss the variable check. Local variable would be release when exit the function. And there is no way to make the ItemPtr to point to the specific bit field. Abdul, can you addre

回复: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add Support for authenticated variable

2022-01-20 Thread gaoliming
Di: > -邮件原件- > 发件人: Zhang, Di > 发送时间: 2022年1月20日 14:05 > 收件人: Gao, Liming ; Chen, Lin Z > ; devel@edk2.groups.io; Huang, Long1 > > 抄送: Bi, Dandan ; Feng, Bob C > ; Li, Zhuangzhi > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add > Support for authenticated variable > > >

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] UserAuthFeaturePkg/PlatformPasswordLibNull: Add UEFI app support

2022-01-20 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Oram, Isaac W > Sent: Friday, January 21, 2022 3:55 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Palomino Sosa, Guillermo A > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > UserAuthFeatureP

Re: [edk2-devel] [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library

2022-01-20 Thread Min Xu
Hi > > +++ > b/OvmfPkg/Library/BaseMemEncryptTdxLib/BaseMemoryEncryptionNull.c > > @@ -0,0 +1,90 @@ > > +/** @file > > + > > + Virtual Memory Management Services to set or clear the memory > > + encryption > > + > > + Copyright (c) 2006 - 2018, Intel Corporation. All rights > > + reserved. Copyr

[edk2-devel] Now: TianoCore Design Meeting - APAC/NAMO - 01/21/2022 #cal-notice

2022-01-20 Thread devel@edk2.groups.io Calendar
*TianoCore Design Meeting - APAC/NAMO* *When:* 01/21/2022 9:30am to 10:30am (UTC+08:00) Asia/Shanghai *Where:* Microsoft Teams *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?subject=Re:%20Event:%20TianoCore%20Design%20Meeting%20-%20APAC%2FNAMO ) View Event ( https://edk2.groups.io/g/

[edk2-devel] Event: TianoCore Design Meeting - APAC/NAMO - 01/21/2022 #cal-reminder

2022-01-20 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCAT

[edk2-devel] [ed2-platforms][PATCH 2/2] Platform/Intel: Remove All UGA Support

2022-01-20 Thread Guomin Jiang
From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA Support in INTEL platform. Cc: Nate DeSimone Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Guomin Jiang --- .../Library/DxePlatformBootManagerLib/BdsPlatform.h | 1 - 1 file changed, 1 deletion

[edk2-devel] [ed2-platforms][PATCH 1/2] Platform/Intel/SimicsOpenBoardPkg: Remove all UGA support

2022-01-20 Thread Guomin Jiang
From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Cc: Nate DeSimone Signed-off-by: Guomin Jiang --- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 +- .../Library/DxeLogoLib/DxeLogoLib.inf | 6 +-- .../Library/DxeLogoLib/Logo.c | 45 +-

[edk2-devel] [ed2-platforms][PATCH 0/2] Remove all UGA support

2022-01-20 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368 Remove all UGA support GuoMinJ (2): Platform/Intel/SimicsOpenBoardPkg: Remove all UGA support Platform/Intel: Remove All UGA Support .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 +- .../Library/DxeLogoLib/DxeLogoLib.inf

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Enabling OS boot from SD card through UEFI payload

2022-01-20 Thread Wu, Hao A
(Add missing maintainers/reviewers) Reviewed-by: Hao A Wu Will wait until early next week for the merging to see if any comment from other reviewers. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Aiman > Rosli > Sent: Friday, January 21, 2022 2:53

[edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py

2022-01-20 Thread Jake Garver via groups.io
Fix a Edk2Logger.warn() message format to match the arguments. We ran into this after a failure in PcdValueInit. The failure was masked by a new exception, "TypeError: not all arguments converted during string formatting". Signed-off-by: Jake Garver --- BaseTools/Source/Python/Workspace/DscBui

[edk2-devel][edk2-platforms][PATCH V1 1/1] UserAuthFeaturePkg/PlatformPasswordLibNull: Add UEFI app support

2022-01-20 Thread Oram, Isaac W
Enable library use with UEFI_APPLICATION components similarly to the other libraries in the package. Cc: Dandan Bi Cc: Liming Gao Cc: Guillermo Antonio Palomino Sosa Signed-off-by: Isaac Oram --- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/PlatformPasswordLibNull/PlatformPasswor

[edk2-devel] [PATCH v3] MdeModulePkg: Enabling OS boot from SD card through UEFI payload

2022-01-20 Thread Aiman Rosli
This changes is by adding 50ms delay during voltage switching from 3.3V to 1.8V, plus adding a goto Voltage33Retry for 3.3V checking and retrying. Signed-off-by: Aiman Rosli --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 39 +-- 1 file changed, 36 insertions(+), 3 deletions(

[edk2-devel] [PATCH v2 7/8] MdeModulePkg/Pci MdePkg: Create service to retrieve PCI base addresses

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Extend the PCI host bridge resource allocation protocol to include one more service that retrieves the base addresses of all resources of a given root bridge. The service is defined to provide, on runtime, the possibility to fetch the base addresses of a root bridge, replicating the address alignme

[edk2-devel] [PATCH v2 6/8] MdeModulePkg, OvmfPkg: Add Pcd token for PCI pre-populated BARs

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Create a new PCD boolean token in MdeModulePkg for global use. We use this token to indicate if the configuration, parsed from fw-cfg, requires pre-populated BARs to be preserved. During creation of root bridges configurations, the flag is set according to the "pre-populated-bars" item in fw-cfg.

[edk2-devel] [PATCH v2 5/8] OvmfPkg/PciHostBridgeUtilityLib: Initialize RootBridges apertures with spec

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Consume the host-provided specification of PCI host bridges if available. Using the Hardware Info library, populate a list of hardware descriptors based on the content of the "hardware-info" fw-cfg file, if provided. In the affirmative case, use the resources and attributes specified by the hypervi

[edk2-devel] [PATCH v2 8/8] MdeModulePkg/PciBusDxe: Handling of pre-populated PCI BARs

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Extend the PCI BAR placement logic in order to consider pre-populated resources first, if indicated by the Pcd token for such purpose. The PCI_BAR type is augmented by one field for mapping the absolute address of prepopulated BARs into a root bridge relative offset. As part of the CreateResourceM

[edk2-devel] [PATCH v2 4/8] Ovmf/PlatformPei: Extend 64-bit MMIO range to fit resources

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Read the "hardware-info" item from fw-cfg to extract specifications of PCI host bridges and analyze the 64-bit apertures of them to find out if 64-bit PCI size needs to be increased in order to allocate enough address space to fit all the host bridges in a valid region. Using the static Hardware I

[edk2-devel] [PATCH v2 0/8] Handling of multiple PCI host bridges specified

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Increased control is provided in Ovmf platforms to define and configure the specifications of multiple PCI host bridges in the hypervisor. The host propagates this information to the guest, initially through fw-cfg interface. In some AWS EC2 platforms, we expose a PCI topology including several ro

[edk2-devel] [PATCH v2 2/8] Ovmf/HardwareInfoLib: Parse data directly from fw-cfg

2022-01-20 Thread Ojeda Leon, Nicolas via groups.io
Create QemuFwCfgHardwareInfoLib which extends the base HardwareInfoLib and provide fw-cfg wrappers to read hardware info elements out of a fw-cfg file. The Hardware Info library is intended to describe non-discoverable hardware information and share that from the host to the guest in Ovmf platform

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add Support for authenticated variable

2022-01-20 Thread Zhang, Di
Liming: > -Original Message- > From: gaoliming > Sent: Wednesday, January 19, 2022 10:57 AM > To: Chen, Lin Z ; devel@edk2.groups.io; Huang, Long1 > > Cc: Bi, Dandan ; Feng, Bob C ; > Zhang, Di ; Li, Zhuangzhi > Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add > Suppo

Re: [edk2-devel] [PATCH v4 1/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-01-20 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[Public] Hi Sami, Why Bugzilla ticket required? Also please see inline for my response [Abdul]. Thanks AbduL From: devel@edk2.groups.io On Behalf Of Sami Mujawar via groups.io Sent: 19 January 2022 22:17 To: Attar, AbdulLateef (Abdul Lateef) ; devel@edk2.groups.io Cc: Ray Ni ;

[edk2-devel] [Patch] BaseTools/Conf: Add new macro for customizing dll file reduction.

2022-01-20 Thread Xu, Wei6
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3810 New macro OBJCOPY_STRIPFLAG is added in build_rule.template to replace '--strip-unneeded -R .eh_frame', so that module can have some unique objcopy flags for its own purpose. In tools_def.template, set '--strip-unneeded -R .eh_frame' as defa

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, January 7, 2022 #cal-cancelled

2022-01-20 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check

2022-01-20 Thread Abner Chang
Merged. Thanks to helping on this. Abner -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85866): https://edk2.groups.io/g/devel/message/85866 Mute This Topic: https://groups.io/mt/88529321/21656 Group Owner: devel+ow...@edk2.groups.io Unsu

Re: [edk2-devel] [PATCH v4 1/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-01-20 Thread Sami Mujawar
Hi Zhichao, Abdul, Please find my response inline marked [SAMI]. Regards, Sami Mujawar From: "Gao, Zhichao" Date: Thursday, 20 January 2022 at 08:37 To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" , Sami Mujawar Cc: "Ni, Ray" , nd Subject: RE: [edk2-devel] [PATCH v4 1/2] S

Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check

2022-01-20 Thread wenyi,xie via groups.io
On 2022/1/20 10:30, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Wenyi, > Could you please create PR for this change? So we can have core CI on this > patch and I can also merge this patch later when the core CI is finished > successfully. > Just send me the link to PR once you create it.

Re: [edk2-devel] [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX

2022-01-20 Thread Min Xu
Hi > > +/** > > + Check if it is Tdx guest > > + > > + @retvalTRUE It is Tdx guest > > + @retvalFALSE It is not Tdx guest > > +**/ > > +BOOLEAN > > +PlatformPeiIsTdxGuest ( > > + VOID > > + ) > > +{ > > + CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER > *CcWorkAreaHeader; > > + > > + CcW

Re: [edk2-devel] [PATCH v4 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

2022-01-20 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Thursday, January 20, 2022 12:45 AM > To: Abdul Lateef Attar ; devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; nd > > Subject: Re: [edk2-devel] [PATCH v4 2

Re: [edk2-devel] [PATCH v4 1/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-01-20 Thread Gao, Zhichao
Hi, Sorry for the late response. Many works interrupt my review plan. The BZ creation and update is part of edk2 develop process EDK II Development Process * tianocore/tianocore.github.io Wiki * GitHub. It give a g