Re: [edk2-devel] [PATCH V3 29/29] OvmfPkg: Update IoMmuDxe to support TDX

2021-12-12 Thread Min Xu
Hi, > > > > + if (CC_GUEST_IS_SEV (PcdGet64 (PcdConfidentialComputingGuestAttr))) > { > > > > +// > > > > +// Clear the memory encryption mask on the plaintext buffer. > > > > +// > > > > +Status = MemEncryptSevClearPageEncMask ( > > > > + 0, > > > > +

[edk2-devel] [PATCH 2/2] OvmfPkg/Bhyve: add MemEncryptSevLib

2021-12-12 Thread Gerd Hoffmann
Fixes build failure: build.py... /home/kraxel/projects/edk2/OvmfPkg/Bhyve/BhyveX64.dsc(...): error 1001: Module type [SEC] is not supported by library instance [/home/kraxel/projects/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf] consumed by [/home/kraxel/projects/edk

[edk2-devel] [PATCH 0/2] two sev build fixes

2021-12-12 Thread Gerd Hoffmann
Gerd Hoffmann (2): OvmfPkg/Microvm: add PcdConfidentialComputingGuestAttr OvmfPkg/Bhyve: add MemEncryptSevLib OvmfPkg/Bhyve/BhyveX64.dsc | 1 + OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ 2 files changed, 4 insertions(+) -- 2.33.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive a

[edk2-devel] [PATCH 1/2] OvmfPkg/Microvm: add PcdConfidentialComputingGuestAttr

2021-12-12 Thread Gerd Hoffmann
Fixes build failure: /home/kraxel/projects/edk2/OvmfPkg/PlatformPei/AmdSev.c: In function ‘AmdSevInitialize’: /home/kraxel/projects/edk2/MdePkg/Include/Library/PcdLib.h:511:38: error: implicit declaration of function ‘_PCD_SET_MODE_64_S_PcdConfidentialComputingGuestAttr’ [-Werror=implicit-func

Re: [edk2-devel] [PATCH V3 29/29] OvmfPkg: Update IoMmuDxe to support TDX

2021-12-12 Thread Gerd Hoffmann
On Mon, Dec 13, 2021 at 02:39:53AM +, Xu, Min M wrote: > Hi > > > > > + if (CC_GUEST_IS_SEV (PcdGet64 (PcdConfidentialComputingGuestAttr))) { > > > +// > > > +// Clear the memory encryption mask on the plaintext buffer. > > > +// > > > +Status = MemEncryptSevClearPageEncMask (

Re: [edk2-devel] [PATCH V3 29/29] OvmfPkg: Update IoMmuDxe to support TDX

2021-12-12 Thread Min Xu
Hi > > > + if (CC_GUEST_IS_SEV (PcdGet64 (PcdConfidentialComputingGuestAttr))) { > > +// > > +// Clear the memory encryption mask on the plaintext buffer. > > +// > > +Status = MemEncryptSevClearPageEncMask ( > > + 0, > > + MapInfo->PlainTextAddress, >

Re: [edk2-devel] [PATCH V3 28/29] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe

2021-12-12 Thread Min Xu
Hi, > > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > > b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > > index 0182c9235cac..7a60b3e82863 100644 > > --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > > @@ -19,6 +19,7 @@ > > #inc

[edk2-devel] Adding *.uncrustify_plugin to .gitignore?

2021-12-12 Thread Rebecca Cran
I noticed that running Uncrustify results in lots of .c.uncrustify_plugin files. Should they be added to .gitignore? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84668): https://edk2.groups.io/g/devel/message/8466

Re: [edk2-devel] [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix readme files in edk2-libc

2021-12-12 Thread Rebecca Cran
It looks like it did get pushed to master - see https://github.com/tianocore/edk2-libc/commits/master . Hi Mike, Has this change been merged to master? Regards, JP -Original Message- From: Kinney, Michael D Sent: 02 November 2021 00:30 To: Jayaprakash, N ; devel@edk2.groups.io; Kin

Re: [edk2-devel] [PATCH] StdLib/LibC: add strnlen function wrapper

2021-12-12 Thread Rebecca Cran
Sorry for the delay. You should probably use the same doxygen header in both the .h and .c files, with the @param lines. -- Rebecca Cran On 11/3/21 2:44 AM, mateusz.mo...@intel.com wrote: From: mateusz-mowka This patch adds strnlen function wrapper that internally calls AsciiStrnLenS, w

[edk2-devel] Bug 3714 - Changing UFS descriptor configuration and retry for support device can't response in time

2021-12-12 Thread vincentx . ke
true -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84664): https://edk2.groups.io/g/devel/message/84664 Mute This Topic: https://groups.io/mt/87681736/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/de

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-12-12 Thread Rebecca Cran
I've fixed issues Uncrustify noted, and have submitted a v4 patch. -- Rebecca Cran On 12/9/21 3:53 PM, Rebecca Cran via groups.io wrote: Now that the edk2 tree is unfrozen, I'd like to get this committed. Could anyone else review it please, or if it's ready commit it? Thanks. Rebecca Cra

[edk2-devel] [PATCH v4 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-12-12 Thread Rebecca Cran
Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar --- MdeModulePkg/Application/MpServicesTest/MpServicesTest.c | 422 MdeModulePkg/Application/MpServicesT

[edk2-devel] [PATCH v4 0/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-12-12 Thread Rebecca Cran
Changes from v3 to v4: Fixed formatting with Uncrustify. - Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL. Rebecca Cran (1): MdeModulePkg: Add MpServicesTest application to exercise MP Services MdeModulePkg/Application/Mp