[edk2-devel] [PATCH v3 6/6] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes

2021-12-09 Thread Masami Hiramatsu
Add "EXPAND_NVSTORAGE" build option to expand NvStorage Variable size and FTW spare/working size for the DeveloperBox platform. Since the size of the NvStorage VariableSize is not enough large, FWTS uefirttime test, which updates the NV variables in runtime, failes. This expands the size to fix th

[edk2-devel] [PATCH v3 5/6] [edk2-platforms] Silicon/SynQuacer: add DBG2 ACPI table

2021-12-09 Thread Masami Hiramatsu
Add DBG2 table to ACPI tables. The COM1 uart port will be used for OS debug, and it is 16550 compatible. Signed-off-by: Masami Hiramatsu --- Changes in v2: - Move Dbg2.aslc before Dsdt.asl to keep the list alphabetically sorted. - Use EFI_ACPI_6_3_SYSTEM_MEMORY and EFI_ACPI_6_3_BYTE for i

[edk2-devel] [PATCH v3 4/6] [edk2-platforms] Silicon/SynQuacerPlatformFlashAccessLib: Fix the number of erase blocks

2021-12-09 Thread Masami Hiramatsu
Fix the number of erase blocks by rounding up the result. The erase blocks must include the last block covered by the length bytes. Signed-off-by: Masami Hiramatsu Reported-by: Kazuhiko Sakamoto Reviewed-by: Leif Lindholm --- .../SynQuacerPlatformFlashAccessLib.c |2 +- 1 file

[edk2-devel] [PATCH v3 3/6] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix to read watchdog parameters with correct width

2021-12-09 Thread Masami Hiramatsu
Since the RefreshFramePhysicalAddress and WatchdogControlFramePhysicalAddress fields are defined as UINT64 in EFI_ACPI_6_0_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE data structure, and both of gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase and gArmTokenSpaceGuid.PcdGenericWatchdogControlBase are defin

[edk2-devel] [PATCH v3 2/6] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix GenericWatchdog interrupt number

2021-12-09 Thread Masami Hiramatsu
This fixes Socionext DeveloperBox GenericWatchdog interrupt number to 93 instead of 94. Since the 93 is the default interrupt number defined in ArmPkg/ArmPkg.dec, this doesn't redefine gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum. Signed-off-by: Masami Hiramatsu Reported-by: Kazuhiko Sakamoto

[edk2-devel] [PATCH v3 1/6] [edk2-platforms] Silicon/SynQuacerI2cDxe: Wait for bus ready

2021-12-09 Thread Masami Hiramatsu
If an EFI application frequently repeats SetTime and GetTime, the I2C bus can be busy and failed to start. To fix this issue, add waiting loop for the bus busy status. (Usually, it is enough to read 3 times for checking, but for safety this sets 10 for timeout.) This also clean up the code path a

[edk2-devel] [PATCH v3 0/6] Series short description

2021-12-09 Thread Masami Hiramatsu
Hi Leif and Ard, Here are the 3rd version of the series to fix some issues on the DeveloperBox. In this version, I fixed the [1/6] for the line ending issue (sorry about this, I forgot to update the basement tree), and add NvStorage expanding patch [6/6/] again with the lowest supported firmware v

Re: [edk2-devel] [edk2-wiki][PATCH v1 1/1] Add more details to EDK II Code Formatting (Uncrustify)

2021-12-09 Thread Michael D Kinney
Michael, thanks for the update. When a branch of wiki is posted with commits like you have, you can get this view which shows the changes in a easier to review rendered format. https://github.com/makubacki/tianocore.github.io/commit/897b827c7790859bca8410a00ca29bdfd67eac4b?short_path=61e2124#di

[edk2-devel] [edk2-wiki][PATCH v1 1/1] Add more details to EDK II Code Formatting (Uncrustify)

2021-12-09 Thread Michael Kubacki
From: Michael Kubacki Updates the wiki page to include: 1. Minor formatting updates 2. Additional links to critical files 3. Increased details in a few important sections 4. More detailed manual usage instructions 5. More Linux examples Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #5 - Completed - Hard Freeze Lifted

2021-12-09 Thread Michael D Kinney
Bret answered this question for Linux https://edk2.groups.io/g/devel/message/77279 https://github.com/tianocore/edk2-pytool-extensions/blob/master/docs/usability/using_extdep.md#a-note-on-nuget-on-linux Mike > -Original Message- > From: Andrew Fish > Sent: Thursday, December 9, 2021 5:

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #5 - Completed - Hard Freeze Lifted

2021-12-09 Thread Andrew Fish via groups.io
Michael, I’m still researching how to install the dependent tools so I can follow the instructions. Do the stuart_* commands come from the EDKII Tools PIP? I think I can get NuGet from brew, but the 1st Google hits suggested installing Visual Studio for Mac. If I pip the EDKII tools and inst

Re: [edk2-devel] [edk2-wiki][PATCH v2 1/1] Add Uncrustify formatting overview

2021-12-09 Thread Michael D Kinney
Pushed: 424a0865bacd7ca57c9f07f7e02abe1ec8cf850f I also added a link to this new page from: https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 9, 2021 5:07 PM > To: devel@edk2.groups

Re: [edk2-devel] [edk2-wiki][PATCH v2 1/1] Add Uncrustify formatting overview

2021-12-09 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Wednesday, December 8, 2021 4:08 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; Kinney, > Michael D ; > Liming Gao > Subject: [edk2-devel] [edk2

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: Add SMC helper functions

2021-12-09 Thread Rebecca Cran
Now that the edk2 tree is unfrozen, I'd like to get this committed. Could anyone else review it please, or if it's ready commit it? Thanks. Rebecca Cran On 11/9/21 5:15 AM, Ard Biesheuvel wrote: On Tue, 9 Nov 2021 at 12:57, Leif Lindholm wrote: On Mon, Nov 08, 2021 at 18:56:09 -0700, Rebe

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-12-09 Thread Rebecca Cran
Now that the edk2 tree is unfrozen, I'd like to get this committed. Could anyone else review it please, or if it's ready commit it? Thanks. Rebecca Cran On 11/10/21 11:06 AM, Sami Mujawar wrote: Hi Rebecca, Thank you for the updated patch. These changes look good to me. The INF file menti

Re: [edk2-devel] [PATCH v3 0/7] Support ACPI 6.4 PPTT changes

2021-12-09 Thread Sami Mujawar
Hi Chris, Thank you for this patch series. Other than my feedback for optimisation in patch 7/7 (which I will address before merging), this patch series looks good to me. For this series, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 08/12/2021 04:06 PM, Chris Jones wrote: Bugzill

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, December 10, 2021 #cal-cancelled

2021-12-09 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

Re: [edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-09 Thread Chris Jones
Hi Sami, The optimisation looks good to me and I would be glad if you added it to the patch. Thanks, Chris From: Sami Mujawar Sent: Thursday, December 9, 2021 1:19 PM To: Christopher Jones ; devel@edk2.groups.io Cc: michael.d.kin...@intel.com ; gaolim...@byos

Re: [edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-09 Thread Sami Mujawar
Hi Chris, Thank you for this patch. Please see my feedback below inline marked [SAMI]. Regards, Sami Mujawar On 08/12/2021 04:06 PM, Chris Jones wrote: Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/11] Platform/ARM/Morello: Port PCI Express library

2021-12-09 Thread chandni cherukuri
Hi Ard, Leif, Sami, Pierre, For Morello platform, we created two custom libraries based on the below two native libraries: - https://github.com/tianocore/edk2/tree/master/MdePkg/Library/BasePciSegmentLibPci - https://github.com/tianocore/edk2/tree/master/MdePkg/Library/BasePciE

[edk2-devel] [PATCH v3 5/5] DynamicTablesPkg: Add DynamicPlatRepo library

2021-12-09 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v3 4/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper

2021-12-09 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v3 2/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator

2021-12-09 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v3 3/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer

2021-12-09 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to qu

[edk2-devel] [PATCH v3 1/5] DynamicTablesPkg: Definition for DynamicPlatRepoLib interface

2021-12-09 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepoLib library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to

[edk2-devel] [PATCH v3 0/5] Add DynamicPlatRepoLib

2021-12-09 Thread PierreGondois
From: Pierre Gondois v3: - Run uncrustify and apply the required formatting. [Pierre] - No other change with v2. [Pierre] v2: - Various small fixes (change status returned, reset values when freeing memory, ...). [Sami] Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3743 The DynamicPlatRe

[edk2-devel] [PATCH v4 15/15] DynamicTablesPkg: Handle 16550_WITH_GAS id

2021-12-09 Thread PierreGondois
From: Pierre Gondois Handle the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS id when generating an AML description of a serial port. The same _HID/_CID as the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550 are generated. Signed-off-by: Pierre Gondois --- .../Common/SsdtSerialPortFixupLib/Ssd

[edk2-devel] [PATCH v4 13/15] DynamicTablesPkg: FdtHwInfoParser: Add PCI config parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois On platforms that implement PCIe, the PCIe configuration space information must be described to a standards-based operating system in the Memory mapped configuration space base address Description (MCFG) table. The PCIe information is described in the platform Device Tree, t

[edk2-devel] [PATCH v4 14/15] DynamicTablesPkg: Add FdtHwInfoParser library

2021-12-09 Thread PierreGondois
From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. FdtHwInfoParser library is an ins

[edk2-devel] [PATCH v4 12/15] DynamicTablesPkg: FdtHwInfoParser: Add GIC dispatcher

2021-12-09 Thread PierreGondois
From: Pierre Gondois The GIC Dispatcher is the top-level component that is responsible for invoking the respective parsers for GICC, GICD, GIC MSI Frame, GIC ITS and the GICR. Signed-off-by: Pierre Gondois --- .../FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 218 ++ .../FdtHwInf

[edk2-devel] [PATCH v4 10/15] DynamicTablesPkg: FdtHwInfoParser: Add ITS parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois Arm GIC v3/v4 optionally includes support for GIC Interrupt Translation Service (ITS). The GIC ITS Structure is part of the Multiple APIC Description Table (MADT) that describes the GIC Interrupt Translation service to the OS. The GIC Interrupt Translation Service informatio

[edk2-devel] [PATCH v4 11/15] DynamicTablesPkg: FdtHwInfoParser: Add GICR parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois The GIC Redistributor (GICR) structure is part of the Multiple APIC Description Table (MADT) that enables the discovery of GIC Redistributor base addresses by providing the Physical Base Address of a page range containing the GIC Redistributors. More than one GICR Structure m

[edk2-devel] [PATCH v4 09/15] DynamicTablesPkg: FdtHwInfoParser: Add MSI Frame parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois Arm GIC version 2 systems that support Message Signalled Interrupts implement GICv2m MSI frame(s). Each GICv2m MSI frame consists of a 4k page which includes registers to generate message signalled interrupts to an associated GIC distributor. The frame also includes registers

[edk2-devel] [PATCH v4 08/15] DynamicTablesPkg: FdtHwInfoParser: Add GICD parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois On ARM-based systems the Generic Interrupt Controller (GIC) manages interrupts on the system. Each interrupt is identified in the GIC by an interrupt identifier (INTID). ACPI GSIVs map one to one to GIC INTIDs for peripheral interrupts, whether shared (SPI) or private (PPI).

[edk2-devel] [PATCH v4 07/15] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois The GIC CPU Interface (GICC) structure is part of the Multiple APIC Description Table (MADT) that describes the interrupt model for the platform. The MADT table is a mandatory table required for booting a standards-based operating system. Arm requires the GIC interrupt model

[edk2-devel] [PATCH v4 06/15] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois The Microsoft Debug Port Table 2 (DBG2), the Serial Port Console Redirector (SPCR) table are mandatory tables required for booting a standards-based operating system. The DBG2 table is used by the OS debugger while the SPCR table is used to configure the serial terminal. Addi

[edk2-devel] [PATCH v4 04/15] DynamicTablesPkg: FdtHwInfoParser: Add Boot Arch parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois The Fixed ACPI Description Table (FADT) is a mandatory table required for booting a standards-based operating system. The FADT table has an 'ARM Boot Architecture Flags' field that is used by an OS at boot time to determine the code path during boot. This field is used to spe

[edk2-devel] [PATCH v4 05/15] DynamicTablesPkg: FdtHwInfoParser: Generic Timer Parser

2021-12-09 Thread PierreGondois
From: Pierre Gondois The Generic Timer Description Table (GTDT) is a mandatory table required for booting a standards-based operating system. It provides an OSPM with information about a system's Generic Timer configuration. The Generic Timer (GT) is a standard timer interface implemented on ARM

[edk2-devel] [PATCH v4 03/15] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions

2021-12-09 Thread PierreGondois
From: Pierre Gondois The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects. Therefore, add a set of helper functions to simplify parsing of the platform Device Tree. Signed-off-by: Pierre Gondois --- .../Library/

[edk2-devel] [PATCH v4 02/15] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper

2021-12-09 Thread PierreGondois
From: Pierre Gondois FdtHwInfoParserLib is an instance of the HwInfoParser. The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects that describe the platform hardware. These Configuration Manager objects are encapsula

[edk2-devel] [PATCH v4 00/15] Implement a FdtHwInfoParserLib

2021-12-09 Thread PierreGondois
From: Pierre Gondois v4: - Run uncrustify and apply the required formatting. [Pierre] - No other change with v3. [Pierre] v3: - Populate the 64 bits of the MPIDR field of the GicC CmObj. [Sami] - Fix typos. [Sami] v2: - Handle absence of Pci legacy interrupts in Pci parser. [Pierre] - Han

[edk2-devel] [PATCH v4 01/15] DynamicTablesPkg: Definition for HwInfoParser interface

2021-12-09 Thread PierreGondois
From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. The Configuration Manager can the

[edk2-devel] [PATCH v4 8/8] DynamicTablesPkg: Fix multiple objects parsing

2021-12-09 Thread PierreGondois
From: Pierre Gondois When a CmObjDesc contains multiple objects, only the first one is parsed as the buffer doesn't progress. Fix this. Also check that the whole buffer has been parsed with an asset. Signed-off-by: Pierre Gondois --- Notes: v3: - New patch. [Pierre] .../Configuratio

[edk2-devel] [PATCH v4 5/8] DynamicTablesPkg: Add AmlAttachNode()

2021-12-09 Thread PierreGondois
From: Pierre Gondois This function allows to add a node as the last node of a parent node in an AML tree. For instance, ASL code corresponding to NewNode: Name (_UID, 0) ASL code corresponding to ParentNode: Device (PCI0) { Name(_HID, EISAID("PNP0A08")) } "AmlAttachNode (ParentNode, N

[edk2-devel] [PATCH v4 7/8] DynamicTablesPkg: SSDT Pci express generator

2021-12-09 Thread PierreGondois
From: Pierre Gondois This generator allows to generate a SSDT table describing a Pci express Bus. It uses the following CmObj: - EArmObjCmRef - EArmObjPciConfigSpaceInfo - EArmObjPciAddressMapInfo - EArmObjPciInterruptMapInfo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682 To: Sami Muj

[edk2-devel] [PATCH v4 6/8] DynamicTablesPkg: Add Pci related objects

2021-12-09 Thread PierreGondois
From: Pierre Gondois Introduce the following CmObj in the ArmNameSpaceObjects: - CM_ARM_PCI_ADDRESS_MAP_INFO - CM_ARM_PCI_INTERRUPT_MAP_INFO These objects allow to describe address range mapping of Pci busses and interrupt mapping of Pci devices. To: Sami Mujawar To: Alexei Fedorov Reviewed

[edk2-devel] [PATCH v4 1/8] DynamicTablesPkg: AML Code generation for memory ranges

2021-12-09 Thread PierreGondois
From: Pierre Gondois Add helper functions to generate AML Resource Data describing memory ranges. Memory ranges can be one, double or four words long. They can be of 'normal', IO or bus number memory type. The following APIs are exposed: - AmlCodeGenRdDWordIo () - AmlCodeGenRdDWordMemory () -

[edk2-devel] [PATCH v4 0/8] Create a SSDT PCIe generator

2021-12-09 Thread PierreGondois
From: Pierre Gondois REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682 As part of the DynamicTablesPkg, add a generator creating a SSDT table describing a PCIe bus. This patch-set also adds new functions to generate AML bytecode in the AmlLib. The changes can be seen at: https://github.

[edk2-devel] [PATCH v4 2/8] DynamicTablesPkg: AML Code generation to create a named Package()

2021-12-09 Thread PierreGondois
From: Pierre Gondois Add AmlCodeGenNamePackage() to generate code for a Package(). AmlCodeGenNamePackage ("PACK", ParentNode, NewObjectNode) is equivalent of the following ASL code: Name(PACK, Package () {}) To: Sami Mujawar To: Alexei Fedorov Reviewed-by: Sami Mujawar Signed-off-by: Pier

[edk2-devel] [PATCH v4 4/8] DynamicTablesPkg: AML Code generation to add _PRT entries

2021-12-09 Thread PierreGondois
From: Pierre Gondois _PRT entries can describe interrupt mapping for Pci devices. The object is described in ACPI 6.4 s6.2.13 "_PRT (PCI Routing Table)". Add AmlCodeGenPrtEntry() helper function to add _PRT entries to an existing _PRT object. To: Sami Mujawar To: Alexei Fedorov Reviewed-by: S

[edk2-devel] [PATCH v4 3/8] DynamicTablesPkg: AML Code generation to create a named ResourceTemplate()

2021-12-09 Thread PierreGondois
From: Pierre Gondois Add AmlCodeGenNameResourceTemplate() to generate code for a ResourceTemplate(). AmlCodeGenNameResourceTemplate ("REST", ParentNode, NewObjectNode) is equivalent of the following ASL code: Name(REST, ResourceTemplate () {}) To: Sami Mujawar To: Alexei Fedorov Reviewed-by

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/UhciDxe: Fix the UsbHc memory allocate and free issue

2021-12-09 Thread Jordan Zhang
Thanks! 发件人:"Wu, Hao A" 发送日期:2021-12-09 10:39:58 收件人:"devel@edk2.groups.io" ,"Wu, Hao A" ,"jdzh...@zd-tech.com.cn" 主题:RE: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/UhciDxe: Fix the UsbHc memory allocate and free issue Pushed via: