On Fri, Dec 03, 2021 at 06:38:52PM +, Kinney, Michael D wrote:
> Hi Pedro,
>
> If there are specific issues with specific submodules, I would prefer
> that we disable only the specific subset of warnings that are
> triggered by that one project. Disabling all warnings as errors may
> hide way
On Fri, Dec 03, 2021 at 04:27:02PM +, Michael D Kinney wrote:
> You should be able to undefine MIN at the right place instead of turning off
> all warnings as errors.
Not so easy unfortunately.
Tried that in CryptoPkg/Library/Include/CrtLibSupport.h (which is the
place where all the other #d
Check if Acpi table is already installed by locating the first ACPI table
in XSDT/RSDT based on Signature
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: kavya
Reviewed-by: Zhiguang Liu
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 18
Hi Kavya,
One minor comment.
Please change the DEBUG_ERROR to DEBUG_INFO.
With this modification, you can keep my Reviewed-by.
Reviewed-by: Zhiguang Liu
From: devel@edk2.groups.io on behalf of kavya
Sent: Monday, December 6, 2021 13:35
To: devel@edk2.groups.io
Check if Acpi table is already installed by locating the first ACPI table
in XSDT/RSDT based on Signature
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: kavya
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 18
++
1 file chan
The previous release also provide an “As Built” INF file to allow the shell to
be easily integrated into platform DSC files.
Do you think this is required? How was that generated?
The ShellPkg also contains a number of command extensions. Should those be
build and included in a binary release
In FvbInitialize Function,
PcdFlashNvStorageVariableBase64 PcdFlashNvStorageFtwWorkingBase
PcdFlashNvStorageFtwSpareBase will not exceed 0x1,
Due to truncation and variable type limitations.
That leads to the NV variable cannot be saved to the memory above 4G.
Modify as follows:
1.Remove t
To generate Full Shell, execute:
"build -a IA32 -a X64 -p ShellPkg\ShellPkg.dsc -b RELEASE"
To generate Minimal Shell, execute:
"build -a IA32 -a X64 -p ShellPkg\ShellPkg.dsc -b RELEASE -D
NO_SHELL_PROFILES"
The binary with name “Shell_7C04A583-9E3E-4f1c-AD65-E05268D0B4D1.efi" Is the
one for
Hi Michael,
I think you missed this feedback from my previous review.
---
I did notice that the JUNIT XML file does have the details of any failures,
but when running the UncrustifyCheck locally, the standard part of the log does
n
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3748
Adds a new CI plugin for Uncrustify. This is used to check
coding standard compliance of source code to the EDK II C Coding
Standards Specification.
An external dependency is added in the plugin directory to retrieve
Reviewed-by: Ray Ni
-Original Message-
From: Cheng, Gao
Sent: Monday, November 15, 2021 2:15 PM
To: devel@edk2.groups.io
Cc: Cheng, Gao ; Dong, Guo ; Ni, Ray
; Ma, Maurice ; You, Benjamin
Subject: [PATCH v3] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE Apriori list
REF: https://bug
Mike,
Thank you! I know it's a bit hard to get every code to meet human expectations
using auto-tools.
But it's the first time that edk2 code is more consistent than before.
Reviewed-by: Ray Ni
for:
UefiCpuPkg
PcAtChipsetPkg
SourceLevelDebugPkg
ShellPkg
EmulatorPkg
FatPkg
UefiPayl
Reviewed-by: Ray Ni
-Original Message-
From: Jiang, Guomin
Sent: Friday, December 3, 2021 1:17 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [PATCH v2 1/1] UefiPayloadPkg: Skip ModuleInfo HOB in Payload
REF: https://bugzilla.tianocore.org/
Better to remove the signature.
-Original Message-
From: Czajkowski, Maciej
Sent: Saturday, December 4, 2021 12:15 AM
To: Ni, Ray ; devel@edk2.groups.io
Cc: Chaganty, Rangasai V
Subject: RE: [edk2platforms][PATCH v3 1/1] IntelSiliconPkg: Add
IntelDieInfoProtocol
Hi Ray,
Thanks for th
For SourceLevelDebugPkg:
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Monday, December 6, 2021 9:18 AM
> To: Michael Kubacki ;
> devel@edk2.groups.io; maciej.rab...@linux.intel.com; Michael Kubacki
>
Hi Sami,
Any comments about this series?
Thanks,
Ming
On 11/5/21 6:51 PM, Sami Mujawar wrote:
> Hi Ming,
>
> Apologies for the delay. I will look at this patch series next week.
>
> Regards,
>
> Sami Mujawar
>
> On 01/11/2021, 14:19, "Ming Huang" wrote:
>
> Hi,
>
> Any comments about t
Hello EDK II Maintainers,
A detailed evaluation of the DEBUG_CODE() formatting issue has been completed.
The reason DEBUG_CODE() is a challenge is that this looks like a macro from a
C parsing perspective, but the EDK II usage places C statements or blocks of
C code as the parameter to this macro
17 matches
Mail list logo
