Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

Hi Mike, I am aware of this possibility, but it feels unnecessary ugly in my opinion. Marvin has already sent a patch alignment-related patches not so long ago[1], updating this with V3 and using as a ground feels like a much better choice. Best wishes, Vitaly [1] https://edk2.groups.io/g/dev

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

Hi Vitaly, So IA32 CLANGPDB is likely putting the UINTT8 array global mNewGdt on a 4-byte boundary, when it would have to be on an 8-byte boundary to meet the GDT alignment requirements. I would expect the X64 CLANGPDB build to use an 8-byte boundary. Another option to align to 8-byte boundary i

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

Hi Mike, The command is: build -a IA32 -p OvmfPkg/OvmfPkgIa32.dsc -t CLANGPDB -b NOOPT -D DEBUG_ON_SERIAL_PORT But I obviously needed to add gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|TRUE to OvmfPkgIa32.dsc. The compiler is clang 12.0.1, because clang 13 is badly broken[1]. It would then

[edk2-devel] [edk2-platforms][PATCH v1 1/2] Platform/RaspberryPi: Add support for PWM1 in ACPI

Also fix PWM0 on the Raspberry Pi 4, but we can't expose both yet. Signed-off-by: Mario Bălănică --- Platform/RaspberryPi/AcpiTables/AcpiTables.h | 10 ++- Platform/RaspberryPi/AcpiTables/Dsdt.asl | 34 ++--- Platform/RaspberryPi/AcpiTables/GpuDevs.asl

[edk2-devel] [edk2-platforms][PATCH v1 2/2] Platform/RaspberryPi: Add analog audio device in ACPI

The Windows audio driver now binds to this device. Signed-off-by: Mario Bălănică --- Platform/RaspberryPi/AcpiTables/GpuDevs.asl | 28 1 file changed, 28 insertions(+) diff --git a/Platform/RaspberryPi/AcpiTables/GpuDevs.asl b/Platform/RaspberryPi/AcpiTables/GpuDevs.asl in

[edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL. Signed-off-by: Rebecca Cran --- MdeModulePkg/Application/MpServicesTest/MpServicesTest.c | 428 MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf | 3

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

Hi Vitaly, Can you please provide some details on the compiler/build command that did not align the array correctly. I agree that the GDT must have the correct alignment. I do not like the idea of unused bytes at the beginning of the array. I would prefer to see an array that is aligned corre

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

Hi Leif, I assume you mean the commit description, because the commit message is in the topic. I believe something like that would do: CpuExceptionHandlerLib supplies misaligned GDT to the outer world (e.g. ArchSetupExceptionStack) when PcdCpuStackGuard is enabled. This happens because it uses a

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

UefiCpuPkg maintainers - please respond. Meanwhile, Vitaly, could you please provide a commit message? The BZ link is needed, but it's not a substitute. / Leif On Mon, Sep 20, 2021 at 17:13:47 +0300, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3639 > > > >

[edk2-devel] [PATCH] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks

In BaseConfigBlockLib add function to get next config block from config blocks table in order to iterate over blocks of the same type. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3700 Signed-off-by: Jakub Fedorowicz jakub.fedorow...@intel.com Cc: Ra

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg: Extend measurement of microcode patches to TPM

Thank you Ray for your kind and patient feedbacks and advices. I checked all 10 comments one by one and you could see my responses inline in below code change. I am testing new patch, will send to community soon if all tests pass. BRs Longlong -Original Message- From: Ni, Ray Sent: Tue

Re: [edk2-devel] [PATCH v1 07/14] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser

Hi Pierre, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 01:38 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The GIC CPU Interface (GICC) structure is part of the Multiple APIC Description Table (MADT) that describes the interrupt model for the p

Re: [edk2-devel] [PATCH v1 06/14] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

Hi Pierre, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 01:38 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The Microsoft Debug Port Table 2 (DBG2), the Serial Port Console Redirector (SPCR) table are mandatory tables required for booting a sta

Re: [edk2-devel] [PATCH v1 03/14] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions

Hi Pierre, I have a minor comment, otherwise this patch looks good to me. Regards, Sami Mujawar On 23/06/2021 01:38 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration M

Re: [edk2-devel] [PATCH v1 02/14] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper

Hi Pierre, Thank you for this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 01:38 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois FdtHwInfoParserLib is an instance of the HwInfoParser. The FdtHwInfoParser parses a platform Device Tree and p

Re: [edk2-devel] [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Sami, On Fri, Nov 5, 2021 at 06:54 AM, Khasim Mohammed wrote: > > Hi Sami, > > On Fri, Nov 5, 2021 at 06:05 AM, Sami Mujawar wrote: > >> Hi Khasim, >> >> Please find my response inline marked [SAMI]. >> >> Regards, >> >> Sami Mujawar >> >> On 26/10/2021 06:39 PM, Khasim Mohammed via gro

[edk2-devel] [PATCH v5 6/7] Platform/ARM/N1Sdp: Configuration Manager for N1Sdp

The dynamic tables framework utilizes the configuration manager protocol to get the platform specific information required for building the firmware tables. The configuration manager is a platform specific component that collates the platform hardware information and builds an abstract platform co

[edk2-devel] [PATCH v5 7/7] Platform/ARM/N1Sdp: Enable ACPI tables and configuration manager

This patch enables ACPI tables and configuration manager for N1SDP Signed-off-by: Sami Mujawar Signed-off-by: Khasim Syed Mohammed --- Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h | 35 Platform/ARM/N1Sdp/N1SdpPlatform.dec | 1 + Platform/ARM/N1Sdp/N1SdpPlatform.ds

[edk2-devel] [PATCH v5 5/7] Platform/ARM/N1Sdp: Introduce platform specific asl tables

This patch creates Dsdt.asl, SsdtPci.asl and SsdtRemotePci.asl files to provide the platform specific APCI table entries. Three PCI root ports are available on N1Sdp, PCI0 is the default root port PCI1 is the CCIX root port and PCI2 is the Remote host root port. The Remote host specific entries a

[edk2-devel] [PATCH v5 2/7] Silicon/ARM/NeoverseN1Soc: Define new PCDs and configure memory map

This patch introduces new PCDs required to enable chip to chip interface and corresponding memory map is updated. Signed-off-by: Chandni Cherukuri Signed-off-by: Khasim Syed Mohammed --- .../Library/PlatformLib/PlatformLib.inf | 28 +-- .../Library/PlatformLib/PlatformLibMem.c |

[edk2-devel] [PATCH v5 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

This patch adds PCDs and updates the fdf file for N1Sdp platform specific configurations. Signed-off-by: Deepak Pandey Signed-off-by: Khasim Syed Mohammed --- Platform/ARM/N1Sdp/N1SdpPlatform.dec | 98 Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 33 +- Platform/A

[edk2-devel] [PATCH v5 1/7] Silicon/ARM/NeoverseN1Soc: Fix missing function documentation

This patch adds missing documentation for few of the functions and fixes few formatting changes. Signed-off-by: Khasim Syed Mohammed --- .../Library/PlatformLib/PlatformLib.c | 46 +-- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/Silicon/ARM/NeoverseN1So

[edk2-devel] [PATCH v5 3/7] Platform/ARM/N1Sdp: Introduce platform DXE driver

Add an initial platform DXE driver and support for ramdisk devices. Signed-off-by: Deepak Pandey Signed-off-by: Khasim Syed Mohammed --- .../N1Sdp/Drivers/PlatformDxe/PlatformDxe.c | 59 +++ .../N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf | 47 +++ 2 files changed, 1

Re: [edk2-devel] [PATCH v1 5/5] DynamicTablesPkg: Add DynamicPlatRepo library

Hi Pierre, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 02:36 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1

Re: [edk2-devel] [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Sami, On Fri, Nov 5, 2021 at 06:05 AM, Sami Mujawar wrote: > > Hi Khasim, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 26/10/2021 06:39 PM, Khasim Mohammed via groups.io wrote: > >> This patch adds PCDs and updates the fdf file for N1Sdp >> platf

Re: [edk2-devel] [PATCH v1 4/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper

Hi Pierre, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 02:36 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states:

Re: [edk2-devel] [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Khasim, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 26/10/2021 06:39 PM, Khasim Mohammed via groups.io wrote: This patch adds PCDs and updates the fdf file for N1Sdp platform specific configurations. Signed-off-by: Deepak Pandey Signed-off-by: Khasim Syed Moham

[edk2-devel] [PATCH v1 1/1] MdePkg/Include: Smbios Specification 3.5.0 changes

Adds following changes 1) Added support for manufacturing mode in BIOS Characteristics Extension Byte 2. 2) Added support for slot height in System Slot Table (type 9). 3) Updated Built-in pointing device interface with USB, I2C and SPI. 4) Updates Onboard Devices Extended Information with

[edk2-devel] [PATCH v1 0/1] MdePkg/Include SMBIOS 3.5.0 changes

Resubmitting the correct patch. Changes to include Smbios 3.5.0 specfication delta. Reference: https://github.com/abdattar/edk2/tree/smbios_3_5_0 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Abdul Lateef Attar (1): MdePkg/Include: Smbios Specification 3.5.0 changes MdePkg/Include/

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

On Tue, Nov 02, 2021 at 11:49:09AM -0400, Stefan Berger wrote: > Enable the physical presence interface for TPM 1.2. It is required for the > TPM 1.2 menu to work. > > The changes to DxeTcgPhysicalPresenceLib.c are due to the device we are using > in QEMU for presenting the supported PPI commands

[edk2-devel] [PATCH v1] MdePkg/Include: Smbios Specification 3.5.0 changes

-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83383): https://edk2.groups.io/g/devel/message/83383 Mute This Topic: https://groups.io/mt/86838708/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/

Re: [edk2-devel] [PATCH edk2 v1 0/3] Fix several issues in StanaloneMmPkg

Hi Ming, Apologies for the delay. I will look at this patch series next week. Regards, Sami Mujawar On 01/11/2021, 14:19, "Ming Huang" wrote: Hi, Any comments about this series? On 10/15/21 5:06 PM, Ming Huang wrote: > Fix issues in StandaloneMmPkg for supporting communicat

[edk2-devel] [PATCH v2] MdeModulePkg\UfsBlockIoPei: UFS MMIO address size support both 32/64 bits

From: Ian Chiu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3703 MMIO base address size will overflow while finding two or more Host controller in the system. Correct it and support 32 and 64 bits address space. Signed-off-by: Ian Chiu Cc: Maggie Chu Cc: Ray Ni Cc: Hao A Wu --- MdeM

[edk2-devel] [PATCH 5/5] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes

Expand NvStorage Variable size and FTW spare/working size for the DeveloperBox platform. Since the size of the NvStorage VariableSize is not enough large, FWTS uefirttime test, which updates the NV variables in runtime, failes. This expands the size to fix this issue. Signed-off-by: Masami Hirama

[edk2-devel] [PATCH 4/5] [edk2-platforms] Silicon/SynQuacer: add DBG2 ACPI table

Add DBG2 table to ACPI tables. The COM1 uart port will be used for OS debug, and it is 16550 compatible. Signed-off-by: Masami Hiramatsu --- .../Socionext/SynQuacer/AcpiTables/AcpiTables.inf |1 Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc | 70 2 files changed

[edk2-devel] [PATCH 3/5] [edk2-platforms] Silicon/SynQuacerPlatformFlashAccessLib: Fix the number of erase blocks

Fix the number of erase blocks by rounding up the result. The erase blocks must include the last block covered by the length bytes. Signed-off-by: Masami Hiramatsu Reported-by: Kazuhiko Sakamoto --- .../SynQuacerPlatformFlashAccessLib.c |2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH 2/5] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix GenericWatchdog interrupt number

This fixes Socionext DeveloperBox GenericWatchdog interrupt number to 93 instead of 94. Since the 93 is the default interrupt number defined in ArmPkg/ArmPkg.dec, this doesn't redefine gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum. Signed-off-by: Masami Hiramatsu Reported-by: Kazuhiko Sakamoto

[edk2-devel] [PATCH 1/5] [RESEND][edk2-platforms] Silicon/SynQuacerI2cDxe: Wait for bus busy

If an EFI application frequently repeats SetTime and GetTime, the I2C bus can be busy and failed to start. To fix this issue, add waiting loop for the bus busy status. (Usually, it is enough to read 3 times for checking, but for safety this sets 10 for timeout.) This also clean up the code path a

[edk2-devel] [PATCH 0/5] Series short description

Hello Leif and Ard, Here are a series of patches to fix some issues on the DeveloperBox. Our team found those issues when we ran the SystemReady ES ACS tests[1]. [1] https://github.com/ARM-software/arm-systemready/tree/main/ES The seires has 5 patches, [1/5] is a resend patch which I sent befor

[edk2-devel][PATCH v5] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699 The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated interface VariableLockRequestToLock.c. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. Signed-off-by: Yang

[edk2-devel][PATCH v4] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699 The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated interface VariableLockRequestToLock.c. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. v4 changes: Fix the