Reviewed-by: Ray Ni
-Original Message-
From: Dong, Guo
Sent: Saturday, September 25, 2021 12:00 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [`edk2-devel][PATCH] UefiPayloadPkg: Use dummy constructor for
PlatformHookLib
From: Guo Dong
- Status = ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo);
+ Status = ParseMemoryInfo (MemInfoCallbackMmio, NULL);
Guo,
I am curious why you changed this part.
Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from the
parameter.
With the change, it has to locate th
Hi Ray,
I have no comments.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Sunday, September 26, 2021 10:10 AM
To: Dong, Guo ; devel@edk2.groups.io
Cc: Ma, Maurice ; You, Benjamin ;
Tan, Dun
Subject: RE: [`edk2-devel][PATCH v2] UefiPayloadPkg: Add ".upld_info" in
universal payload
Reviewed-by: Ray Ni
-Original Message-
From: xueshengfeng
Sent: Friday, September 24, 2021 2:31 PM
To: devel@edk2.groups.io; Ni, Ray ; Wu, Hao A
Cc: Liang, PanlingX ; Xue, ShengfengX
Subject: [PATCH V5] MdeModulePkg/PciBusDxe: Improve the flow of testing support
attributes
https:
Liming,
The purpose of the optional BufferOneElement is to ease consumer’s life
assuming most of the time the element size should be smaller than 256.
Are you saying that it’s a bit hard to calculate the actual value of sizeof
(Element) when writing code?
I recommend consumer always allocates me
Reviewed-by: Ray Ni
Dun, any comments?
-Original Message-
From: Dong, Guo
Sent: Sunday, September 26, 2021 7:12 AM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [`edk2-devel][PATCH v2] UefiPayloadPkg: Add ".upld_info" in universal
payload
F
Ray:
I may suggest to always require BufferOneElement. The consumer code may not
know ElementSize. To avoid the error, the consumer must allocate buffer for
BufferOneElement. If so, BufferOneElement is the required parameter.
Thanks
Liming
发件人: Ni, Ray
发送时间: 2021年9月24日 11:53
收件人: devel
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCAT
Yes. Agree. Good suggestion.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> Sent: Sunday, September 26, 2021 8:54 AM
> To: Yao, Jiewen ; devel@edk2.groups.io; Xu, Min M
>
> Cc: Kinney, Michael D ; Liu, Zhiguang
> ; Wang, Jian J ; Lu, Ken
>
> Subject: 回复: [edk
Zhichao:
I am OK to use "..." as the end of string. I suggest to add the comments to
explain the different behavior for BootManagerMenuApp and BootManagerUiLib in
BZ.
Thanks
Liming
> -邮件原件-
> 发件人: Gao, Zhichao
> 发送时间: 2021年9月24日 14:16
> 收件人: devel@edk2.groups.io; Gao, Zhichao ;
> gao
Jiewen:
Thanks for this information. I suggest to add this URL into the file header
comment, like
Edk2\MdePkg\Include\IndustryStandard\DmaRemappingReportingTable.h.
Thanks
Liming
> -邮件原件-
> 发件人: Yao, Jiewen
> 发送时间: 2021年9月25日 7:01
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
I recommend we start with 2 metadata and check in.
It is working today for both SEV and TDX, with KVM and Cloud Hypervisor support.
Thank you
Yao Jiewen
> -Original Message-
> From: Xu, Min M
> Sent: Sunday, September 26, 2021 7:17 AM
> To: devel@edk2.groups.io; brijesh.si...@amd.com
> C
On September 25, 2021 11:21 AM, Brijesh Singh wrote:
> Hi Min,
>
>
> On 9/24/21 7:03 PM, Xu, Min M wrote:
> > On September 24, 2021 6:58 PM, Brijesh Singh wrote:
> >> Hi Min,
> >>
> >> On 9/21/21 4:05 AM, Min Xu wrote:
> >>> ;
> >>> ; Modified: EAX, EBX, ECX, EDX
> >>> ;
> >>> SetCr3ForPageT
From: Guo Dong
V2: Use LittleEndianStructure by review comment.
>From the universal scalable firmware payload requirement V0.75,
Payload must have Universal Payload Information Section ".upld_info"
So update the build tool to add this section.
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signe
Thanks for the comments. I will update the patch to add LittleEndianStructure.
Thanks,
Guo
From: Andrew Fish
Sent: Saturday, September 25, 2021 9:30 AM
To: edk2-devel-groups-io ; Dong, Guo
Cc: Ni, Ray ; Ma, Maurice ; You,
Benjamin
Subject: Re: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg
From: Guo Dong
PCH SMM module would install SMM SW dispatch2 protocol.
And it supports to register SMI handlers based on SMI APM
interrupt from the bootloader information gSmmRegisterInfoGuid.
It is possible to extend bootloader HOB to pass other information
to support more SMI sources.
If this m
From: Guo Dong
Add SMM variable support for universal UEFI payload.
By default they are disabled.
Signed-off-by: Guo Dong
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 101 +++---
UefiPayloadPkg/UefiPayloadPkg.fdf | 38 ++-
2 files changed, 128 insertions(+), 11 dele
From: Guo Dong
This FVB module is used to initialize NV variable region
and provide SMM FVB protocol to read/write SPI variable region.
This module consume HOB gNvVariableInfoGuid and depends on
FlashDeviceLib for the actual SPI device operate.
During FVB initialization, it will initialize the
From: Guo Dong
This library provides FlashDeviceLib APIs based on
SpiFlashLib and consumed by FVB driver.
Signed-off-by: Guo Dong
---
.../Include/Library/FlashDeviceLib.h | 108
.../Library/FlashDeviceLib/FlashDeviceLib.c | 165 ++
.../Library/FlashDevic
From: Guo Dong
This module is only used for SMM S3 support for the bootloader that
doesn't support SMM.
The payload would save SMM rebase info to SMM communication area in
normal boot and expect the bootloader in S3 path to rebase the SMM
and trigger SMI by writing 0xB2 port with the given value
From: Guo Dong
This is a common SPI Flash library used for the Intel platform that
supports SPI hardware sequence. This library provides actual SPI flash
operation via Intel PCH SPI controller.
Signed-off-by: Guo Dong
---
.../Include/Guid/SpiFlashInfoGuid.h | 38 +
UefiPayloadPkg/In
From: Guo Dong
This module consumes SMM Registers HOB (SMI_GBL_EN and SMI_APM_EN) to
install SMM control 2 protocol gEfiSmmControl2ProtocolGuid.
The protocol activate() would set SMI_GBL_EN and SMI_APM_EN and trigger
SMI by writing to IO port 0xB3 and 0xB2.
Signed-off-by: Guo Dong
---
.../Incl
From: Guo Dong
https://bugzilla.tianocore.org/show_bug.cgi?id=3084
Currently UEFI payload uses emulated variable driver. So it could
not support secureboot and measured boot since both need NV variable
support.
EDKII already has SMM modules and variable modules. And modern Intel
platform suppor
From: Guo Dong
SmmAccessDxe module would consume EFI_SMRAM_HOB_DESCRIPTOR_BLOCK HOB to
produce SMM access protocol gEfiSmmAccess2ProtocolGuid (open, close, lock,
and GetCapabilities.)
Signed-off-by: Guo Dong
---
UefiPayloadPkg/SmmAccessDxe/SmmAccessDxe.c | 254 +++
UefiPayloa
> On Sep 24, 2021, at 8:57 PM, Guo Dong wrote:
>
> From: Guo Dong
>
> From the universal scalable firmware payload requirement V0.75,
> Payload must have Universal Payload Information Section ".upld_info"
> So update the build tool to add this section.
>
> Cc: Ray Ni
> Cc: Maurice Ma
> Cc:
Hi, forwarding this also to the mailing list:
https://bugzilla.tianocore.org/show_bug.cgi?id=3640
>
Hello,
it's been about a year I'm experiencing a strange issue, not a
stopper, so I started only recently to investigate.
I found that it's OVMF.
System: x86_64 manjaro 21.1.3 (only cli), qem
26 matches
Mail list logo
