Re: [edk2-devel] [PATCH] SecurityPkg/Tcg: remove TcgMorLockSmm driver

2021-08-27 Thread Qi Zhang
I created a new PR and pass CI. https://github.com/tianocore/edk2/pull/1924 Thanks! Qi Zhang > -Original Message- > From: Yao, Jiewen > Sent: Friday, August 27, 2021 9:44 PM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Kumar, Rahul1 > ; Ni, Ray > Subject: RE: [PATCH] Se

Re: [edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Yao, Jiewen
Hi Gerd Have you run CI and ensure this patch series can pass CI ? > -Original Message- > From: Gerd Hoffmann > Sent: Friday, August 27, 2021 9:45 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Gerd Hoffmann > ; Ard Biesheuvel ; Justen, > Jordan L > Subject: [PATCH v5 0/7] add support

Re: [edk2-devel] [PATCH 0/2] BaseTools: Switch ARM/AARCH64 CI gcc from Linaro to Arm

2021-08-27 Thread Rebecca Cran
On 8/27/2021 1:31 PM, Ard Biesheuvel wrote: On Thu, 26 Aug 2021 at 23:03, Rebecca Cran wrote: I've created a ticket in Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3594. -- Rebecca Cran On 8/22/21 11:35 PM, Rebecca Cran wrote: Linaro no longer do gcc releases - Arm creates them

[edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Eliminate extra buffer copy in Pkcs7Verify()

2021-08-27 Thread Bob Morgan via groups.io
Create a read-only openSSL BIO wrapper for the existing input buffer passed to Pkcs7Verify() instead of copying the buffer into an empty writable BIO which causes memory allocations within openSSL. Signed-off-by: Bob Morgan --- CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 6 +

Re: [edk2-devel] OVMF: NV Variable Store Layout of Larger Build Targets

2021-08-27 Thread Ard Biesheuvel
(+ Gerd) On Sat, 21 Aug 2021 at 03:10, Devon Bautista wrote: > > Hello All, > > I am currently working with the Linuxboot developers to improve testing > kernel + initramfs pairs in firmware using OVMF. > > The current maximum image size of an OVMF image is 4MB, which is insufficient > for stor

Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Ard Biesheuvel
On Fri, 27 Aug 2021 at 15:42, Gerd Hoffmann wrote: > > On Fri, Aug 27, 2021 at 11:35:42AM +, Yao, Jiewen wrote: > > I am sorry, I mess up https://github.com/tianocore/edk2/pull/1917, please > > ignore that. > > > > This pull request is re-created at > > https://github.com/tianocore/edk2/pull

Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Yao, Jiewen
Yes, please. Feel free to submit your own PR. As long as you did not label - PUSH, this CI just shows the test result. It will NOT merge automatically. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Friday, August 27, 2021 9:

[edk2-devel] [PATCH v5 7/7] OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0

2021-08-27 Thread Gerd Hoffmann
Now with everything in place for virtio 1.0 devices we can let VirtioMmioInit() return SUCCESS. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg

[edk2-devel] [PATCH v5 5/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum

2021-08-27 Thread Gerd Hoffmann
Use QueueNumMax as QueueNum default for drivers which do not explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- .../Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + .../VirtioMmioDeviceLib/VirtioMmioDeviceFunction

[edk2-devel] [PATCH v5 6/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling

2021-08-27 Thread Gerd Hoffmann
virtio 1.0 has 64 feature bits instead of 32. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- .../VirtioMmioDeviceFunctions.c | 28 +++ 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmi

[edk2-devel] [PATCH v5 3/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.

2021-08-27 Thread Gerd Hoffmann
Nothing to do here for virtio 1.0 devices. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- .../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevi

[edk2-devel] [PATCH v5 4/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress

2021-08-27 Thread Gerd Hoffmann
Virtio 1.0 allows a more flexible virtio ring layout, so we have to set addresses for descriptors avail flags and use flags separately. We continue to use a ring layout compatible with virtio 0.9.5 though, so no other changes are needed to setup the virtio queues. Signed-off-by: Gerd Hoffmann Re

[edk2-devel] [PATCH v5 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Gerd Hoffmann
This little series adds virtio 1.0 support for the virtio-mmio transport. For the mmio transport the difference between 0.9.5 and 1.0 is rather small (when compared to the pci transport), it is just a bunch of new registers for the changed virtio queue initialization. So the patch series is small

[edk2-devel] [PATCH v5 2/7] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.

2021-08-27 Thread Gerd Hoffmann
Add #defines for the Version field. Read and store the version, log the version found as info message. Continue to return UNSUPPORTED for now, we need some more patches to complete virtio 1.0 support first. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- .../VirtioMmioDev

[edk2-devel] [PATCH v5 1/7] OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines

2021-08-27 Thread Gerd Hoffmann
Add defines for the config space offsets for virtio 1.0 mmio transport. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/Include/IndustryStandard/Virtio10.h | 12 1 file changed, 12 insertions(+) diff --git a/OvmfPkg/Include/IndustryStandard/Virtio10.h

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg: remove TcgMorLockSmm driver

2021-08-27 Thread Yao, Jiewen
Hi This patch failed in CI - https://github.com/tianocore/edk2/pull/1922 Please take a look and submit patch again. > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 24, 2021 10:28 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Kumar, Rahul1

Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Gerd Hoffmann
On Fri, Aug 27, 2021 at 11:35:42AM +, Yao, Jiewen wrote: > I am sorry, I mess up https://github.com/tianocore/edk2/pull/1917, please > ignore that. > > This pull request is re-created at > https://github.com/tianocore/edk2/pull/1918. > > Please take a look at 1918. Is there some way to run

Re: [edk2-devel] [PATCH 0/2] BaseTools: Switch ARM/AARCH64 CI gcc from Linaro to Arm

2021-08-27 Thread Ard Biesheuvel
On Thu, 26 Aug 2021 at 23:03, Rebecca Cran wrote: > > I've created a ticket in Bugzilla: > https://bugzilla.tianocore.org/show_bug.cgi?id=3594. > > > -- > Rebecca Cran > > > On 8/22/21 11:35 PM, Rebecca Cran wrote: > > Linaro no longer do gcc releases - Arm creates them now. > > > > Update the gcc

Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

2021-08-27 Thread Ard Biesheuvel
On Tue, 24 Aug 2021 at 19:21, Jim Fehlig wrote: > > On 8/23/21 1:09 AM, Gary Lin wrote: > > When using HVM Direct kernel boot with OvmfXen, it could fail at the > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > > and PcdAcpiS3Enable. > > > > This patch series initializes Pcd

Re: [edk2-devel] [PATCH v3 0/3] reuse the SevEsWork area

2021-08-27 Thread Yao, Jiewen
Patch is pushed - 80e67af9afcac3b860384cdb1f4613f7240e1630.. b9af5037b270c4767b275fd5d23b942c422e742f > -Original Message- > From: Brijesh Singh > Sent: Tuesday, August 17, 2021 9:47 PM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Yao, Jiewen ; Tom Lendacky > ; Justen

Re: [edk2-devel] [PATCH] ArmPkg/GicV3Dxe: Don't signal EOI on arbitrary interrupts

2021-08-27 Thread Ard Biesheuvel
Merged as #1920 Thanks all, On Thu, 26 Aug 2021 at 04:47, gaoliming wrote: > > I agree with Leif. > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > > 发送时间: 2021年8月25日 20:51 > > 收件人: Ard Biesheuvel > > 抄送: devel@edk2.groups.io; sami.muja...@arm.com; > > ga

Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Yao, Jiewen
I am sorry, I mess up https://github.com/tianocore/edk2/pull/1917, please ignore that. This pull request is re-created at https://github.com/tianocore/edk2/pull/1918. Please take a look at 1918. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Friday,

Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0

2021-08-27 Thread Yao, Jiewen
Hi Gerd I create a PR but it fails. I am not able to merge. https://github.com/tianocore/edk2/pull/1917 Would you please take a look, fix it and resubmit V5? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, August 19, 2021 3:25 PM > To: d

Re: [edk2-devel] [PATCH 1/1] Maintainers: Add kraxel as Reviewer to ArmVirtPkg and OvmfPkg

2021-08-27 Thread Yao, Jiewen
This is merged - 8b15024dc74f2f1352d48c4345e31d7e4777b6f9 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, August 16, 2021 3:18 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann > Subject: [edk2-devel] [PATCH 1/1] Maintainers: Add kraxel as R

[edk2-devel] [PATCH EDK2 v1 1/1] BaseTools: Remove GCC option -x

2021-08-27 Thread wenyi,xie via groups.io
It seems no need to add option -x c in GCC and it will cause compiling warning "-x c after last input file has no effect" Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[edk2-devel] [PATCH EDK2 v1 0/1] BaseTools: Remove GCC option -x

2021-08-27 Thread wenyi,xie via groups.io
Main Changes : 1.remove GCC option -x c. Wenyi Xie (1): BaseTools: Remove GCC option -x BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/R

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/PeiCore: Remove MigrateSecModulesInFv()

2021-08-27 Thread Wu, Hao A
Pushed via: PR - https://github.com/tianocore/edk2/pull/1913 Commit - https://github.com/tianocore/edk2/commit/82f7e315d612399f65a3bedd3b2c0364b43b6929 Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Friday, August 20, 2021 1:08 PM

[edk2-devel] [PATCH] Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg

2021-08-27 Thread Wu, Hao A
Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhi

Re: [edk2-devel] [RFC PATCH v5 00/28] Add AMD Secure Nested Paging (SEV-SNP) support

2021-08-27 Thread Gerd Hoffmann
Hi, [ /me reading through a bunch of old threads ] > Many of the integrity guarantees of SEV-SNP are enforced through a new > structure called the Reverse Map Table (RMP). Adding a new page to SEV-SNP > VM requires a 2-step process. First, the hypervisor assigns a page to the > guest using