Re: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G

2021-08-25 Thread Benjamin Doron
Hi Nate, Thanks for addressing the comment for me with https://edk2.groups.io/g/devel/message/79830. Regarding copyrighting: I am not a lawyer and was unaware that a copyright was necessary. But if it's necessary for legal reasons, very well. However, I suppose I will need to put my legal name on

Re: [edk2-devel] [edk2-non-osi][PATCH v1] KabylakeOpenBoardBinPkg/AspireVn7Dash572G: Add VBT

2021-08-25 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-non-osi/commit/77f3ace -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 2:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-non-osi][PATCH v1] Kabyl

Re: [edk2-devel] [edk2-non-osi][PATCH v1] KabylakeOpenBoardBinPkg/AspireVn7Dash572G: Add VBT

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 2:08 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-non-osi][PATCH v1] KabylakeOpenBoardBinPkg/AspireVn7Dash572G:

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G

2021-08-25 Thread Nate DeSimone
Hi Benjamin, I have sent a separate patch to correct the comment that Michael pointed out: https://edk2.groups.io/g/devel/message/79830 For legal reasons I actually have to put "Copyright (c) 2021, Benjamin Doran" on the files that are brand new and are not a derivative of an existing file. T

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value

2021-08-25 Thread Nate DeSimone
Added EFI_INVALID_PARAMETER to the EcRead() function's list of return values. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Signed-off-by: Nate DeSimone --- .../Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h | 9 + .../KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G

2021-08-25 Thread Nate DeSimone
The series has been pushed as 4659ef0~..03a7a94 -Original Message- From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Wednesday, August 18, 2021 11:49 AM To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G T

Re: [edk2-devel] [edk2-platforms][PATCH v3 7/7] Platform/Intel/Readme.md: Add AspireVn7Dash572G to supported boards

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 11:49 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-platforms][PATCH v3 7/7] Platform/Intel/Readme.md: Add AspireVn7Dash572G to

Re: [edk2-devel] [edk2-platforms][PATCH v3 6/7] Maintainers.txt: Add myself as reviewer for AspireVn7Dash572G board

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 11:49 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-platforms][PATCH v3 6/7] Maintainers.txt: Add myself as reviewer for Aspire

Re: [edk2-devel] [edk2-platforms][PATCH v3 4/7] Platform/Intel: Early hook-up Acer Aspire VN7-572G

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 11:49 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-platforms][PATCH v3 4/7] Platform/Intel: Early hook-up Acer

Re: [edk2-devel] [edk2-platforms][PATCH v3 3/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 11:49 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-platforms][PATCH v3 3/7] KabylakeOpenBoardPkg/AspireVn7Dash5

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/7] KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Wednesday, August 18, 2021 11:49 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Michael Kubacki Subject: [edk2-platforms][PATCH v3 1/7] KabylakeOpenBoardPkg/BaseEcLib: Add

[edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition

2021-08-25 Thread Wenxing Hou
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should frist check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile

2021-08-25 Thread Nate DeSimone
Hi Benjamin, This is a compilation error in this patch. You have added the usage of gEfiMdeModulePkgTokenSpaceGuid to MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf but that GUID technically does not exist when this .inf is being compiled since the .inf only references the following DEC files: MdeP

回复: [edk2-devel] [PATCH] ArmPkg/GicV3Dxe: Don't signal EOI on arbitrary interrupts

2021-08-25 Thread gaoliming
I agree with Leif. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2021年8月25日 20:51 > 收件人: Ard Biesheuvel > 抄送: devel@edk2.groups.io; sami.muja...@arm.com; > gaolim...@byosoft.com.cn; Marc Zyngier > 主题: Re: [edk2-devel] [PATCH] ArmPkg/GicV3Dxe: Don't signal E

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters

2021-08-25 Thread Nate DeSimone
Hi Zhichao, Caden is correct that ‘\’ and ‘/’ were not removed and still work fine. I have updated the table on the wiki to reflect this. Thanks, Nate From: devel@edk2.groups.io On Behalf Of Caden Kline Sent: Sunday, August 22, 2021 7:49 PM To: Gao, Zhichao Cc: devel@edk2.groups.io; Wang, Jia

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg: remove TcgMorLockSmm driver

2021-08-25 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August 24, 2021 10:28 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Kumar, Rahul1 > ; Ni, Ray > Subject: [PATCH] SecurityPkg/Tcg: remove TcgMorLockSmm driver > > REF: http

[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block

2021-08-25 Thread wenyi,xie via groups.io
As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- 1 file changed, 3 deletions

[edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/HiiDatabaseDxe:remove dead code

2021-08-25 Thread wenyi,xie via groups.io
Main Changes : 1.remove dead code block. Wenyi Xie (1): MdeModulePkg/HiiDatabaseDxe:remove dead code block MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- 1 file changed, 3 deletions(-) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages se

Re: [edk2-devel] UefiPayloadPkg build error

2021-08-25 Thread Guo Dong
Reviewed-by: Guo Dong mailto:guo.d...@intel.com>> From: devel@edk2.groups.io On Behalf Of King Sumo Sent: Monday, August 23, 2021 8:54 AM To: devel@edk2.groups.io Subject: [edk2-devel] UefiPayloadPkg build error Hi, The following commit broke the UefiPayloadPkg build: commit d63595c3c91624f2

Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Update EHL microcode

2021-08-25 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Ong, Kok Tong Sent: Tuesday, August 24, 2021 8:33 PM To: devel@edk2.groups.io Cc: Ong, Kok Tong ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Lim, Jin Jhu Subject: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Upda

Re: [edk2-devel] [edk2-non-osi] [PATCH] Maintainers.txt: Modify maintainer role for EHL

2021-08-25 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty < rangasai.v.chaga...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79812): https://edk2.groups.io/g/devel/message/79812 Mute This Topic: https://groups.io/mt/85108528/21656 Group Owner: devel+ow...@

[edk2-devel] [edk2-platforms PATCH v2 1/1] Maintainers.txt: Add maintainer of Ext4Pkg

2021-08-25 Thread Pedro Falcato
Add myself as a maintainter for Features/Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Pedro Falcato --- Maintainers.txt | 4 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 9b8d6aead923..56b167447eb7 100644 --- a/Maintainers.txt +++

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Maintainers.txt: Add maintainer of Ext4Pkg

2021-08-25 Thread Pedro Falcato
Hi, It would be great if you could replace "heatd" with "Pedro Falcato" when applying the patch, as I somehow accidentally used the wrong git user.name when committing/sending the patch. Thanks, Pedro On Wed, 25 Aug 2021 at 23:39, Pedro Falcato via groups.io wrote: > > From: heatd > > Add myse

[edk2-devel] [edk2-platforms PATCH 1/1] Maintainers.txt: Add maintainer of Ext4Pkg

2021-08-25 Thread Pedro Falcato
From: heatd Add myself as a maintainter for Features/Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: heatd --- Maintainers.txt | 4 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 9b8d6aead923..56b167447eb7 100644 --- a/Maintainers.tx

Re: [edk2-devel] [RFC] Expose HII package list via C variables

2021-08-25 Thread Michael D Kinney
Hi Marvin, I think this feature is already there and supported. HII can either be in a global variable or in a PE/COFF resource section. The default is a global variable because HII was implemented before the PE/COFF resource section feature was added to the UEFI Specification. There is an INF [

[edk2-devel] [RFC] Expose HII package list via C variables

2021-08-25 Thread Marvin Häuser
Good day everyone, Currently, the HII package list is stored in a PE/COFF resource section [1]. I propose to store it in a C variable (byte array with a pointer to it and its size exposed) instead. DxeCore would have a guard to toggle the deprecated support for the automatic protocol installat

Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

2021-08-25 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/5f3e0bf -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, August 16, 2021 2:54 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Benjamin Doron ; Michael Kubacki Subject:

Re: [edk2-devel] [edk2-non-osi] [PATCH] Maintainers.txt: Modify maintainer role for EHL

2021-08-25 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Lim, Jin Jhu Sent: Tuesday, August 24, 2021 4:47 AM To: devel@edk2.groups.io Cc: Lim, Jin Jhu ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [edk2-devel] [edk2-non-osi] [PATCH] Maintainers.txt: Modify maintainer role for E

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Include Network modules in UefiPayloadPkg.

2021-08-25 Thread Guo Dong
It would be better if the FD size could change based on features as below, but it looks the FDF doesn't support expression ☹ !if $(NETWORK_DRIVER_ENABLE) == TRUE $(NUM_BLOCKS) += 0x170 !endif DEFINE FD_SIZE = $(NUM_BLOCKS) * $(FD_BLOCK_SIZE) Reviewed-by: Guo Dong Thanks, Guo -Or

Re: [edk2-devel] [PATCH 18/23] OvmfPkg: Enable Tdx in SecMain.c

2021-08-25 Thread Yao, Jiewen
Comment below: > -Original Message- > From: kra...@redhat.com > Sent: Wednesday, August 25, 2021 10:52 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Xu, Min M > ; Ard Biesheuvel ; Justen, > Jordan L ; Brijesh Singh ; > Erdem Aktas ; James Bottomley > ; Tom Lendacky >

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection

2021-08-25 Thread Yao, Jiewen
Thanks for the detail info. We do have process for handle compatibility. My recommendation is: 1) Please send out RFC email about removing CMOS support in QEMU. To see if someone still need support old version before qemu version 1.7 (released Nov 2013). 2) Let's wait for 1 WW. 3) If no people ne

Re: [edk2-devel] [PATCH 18/23] OvmfPkg: Enable Tdx in SecMain.c

2021-08-25 Thread Gerd Hoffmann
Hi, > > > In TDVF design, we choose the use TDX defined initial pointer to pass > > > the initial memory information - TD_HOB, instead of CMOS region. > > > Please help me understand what is the real concern here. > > > > Well, qemu settled to the fw_cfg design or a number of reasons. It is >

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection

2021-08-25 Thread Gerd Hoffmann
On Wed, Aug 25, 2021 at 09:24:43AM +, Yao, Jiewen wrote: > Hi > Would you please follow EDKII process? > 1) File an EDKII Bugzilla. Ok, will do. > 2) CC all reviewers in OVMF package. Is there some way to automate this? I see there is BaseTools/Scripts/GetMaintainer.py, but the script wants

Re: [edk2-devel] [PATCH] ArmPkg/GicV3Dxe: Don't signal EOI on arbitrary interrupts

2021-08-25 Thread Leif Lindholm
On Tue, Aug 24, 2021 at 17:31:32 +0200, Ard Biesheuvel wrote: > Currently, at ExitBootServices() time, the GICv3 driver signals > End-Of-Interrupt (EOI) on all interrupt lines that are supported by the > interrupt controller. This appears to have been carried over from the > GICv2 version, but has

Re: [edk2-devel] Question regarding subscription and mailing list

2021-08-25 Thread Marvin Häuser
Hey, https://edk2.groups.io/g/devel -> "Join This Group" Best regards, Marvin On 25/08/2021 04:52, jinjhuli wrote: Hi, Good Day! May I know how can I subscribe and receive mailing list for this group? Thanks. Regards, Jin Jhu -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

[edk2-devel] edk2-test-stable202108 is Released

2021-08-25 Thread G Edhaya Chandran
Hello All, edk2-test-stable202108 is now released. Please refer to the link for more details : https://github.com/tianocore/edk2-test/releases/tag/edk2-test-stable202108 Thanking you all for your contributions. Please feel free to contact me or Barton for any clarifications. With Warm Regar

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection

2021-08-25 Thread Yao, Jiewen
Hi Would you please follow EDKII process? 1) File an EDKII Bugzilla. 2) CC all reviewers in OVMF package. Please also describe what the reason of change, what is the benefit we can get from the change? I just feel it is confusing. Previously, the data is consistent from CMOS. Now, we have two

Re: [edk2-devel] [PATCH 18/23] OvmfPkg: Enable Tdx in SecMain.c

2021-08-25 Thread Yao, Jiewen
Comment below: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Wednesday, August 25, 2021 3:52 PM > To: Yao, Jiewen > Cc: Ard Biesheuvel ; Xu, Min M ; > devel@edk2.groups.io; Ard Biesheuvel ; Justen, > Jordan L ; Brijesh Singh ; > Erdem Aktas ; Jame

Re: [edk2-devel] [PATCH 18/23] OvmfPkg: Enable Tdx in SecMain.c

2021-08-25 Thread Gerd Hoffmann
Hi, > fw_cfg is just a KVM/QEMU specific way to pass some parameter, but not > all parameter. For example, OVMF today still get the memory size from > CMOS. > https://github.com/tianocore/edk2/blob/master/OvmfPkg/PlatformPei/MemDetect.c#L278 Patches to fix that are on the list. > In TDVF desi