Re: [EXTERNAL] [edk2-devel] [edk2][PATCH v1 1/1] StandaloneMmPkg: add support to populate StMM boot data from device tree

2021-07-30 Thread Yao, Jiewen
I agree with Bret. Adding EmbeddedPkg dependency is not a good idea. Another option: Is there any possibility to move the function to EmbeddedPkg and just add a simple function call in StanaloneMmPkg ? Thank you Yao Jiewen From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-07-30 Thread Yao, Jiewen
Hi Sean That is excellent topic. I agree with you that, one of most frequent asked question in the design meeting is: Should I use protocol or library? Sigh... I added my personal thought below. I would like other people to comment, Mike Kinney, Andrew Fish, Liming Gao, who knows the history an

Re: [EXTERNAL] [edk2-devel] [edk2][PATCH v1 1/1] StandaloneMmPkg: add support to populate StMM boot data from device tree

2021-07-30 Thread Andrew Fish via groups.io
> On Jul 30, 2021, at 12:34 PM, Bret Barkelew via groups.io > > wrote: > > I don’t think this is a good dependency. StandaloneMmCore shouldn’t require > anything from EmbeddedPkg, and if it does there’s probably some more > ge

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-07-30 Thread Taylor Beebe
I am going to extend the opportunity for feedback to the end of Tuesday. I would very much like more community input on this proposal. On 7/30/2021 11:42 AM, Sean Brogan wrote: Jiewen, **Slight rant** I agree with libraries as an effective abstraction method.  But I think there needs to be a

Re: [edk2-devel] edk2 memory map on QEMU

2021-07-30 Thread Stuart Yoder
On 7/30/21 3:36 PM, Andrew Fish wrote: On Jul 30, 2021, at 12:32 PM, Stuart Yoder mailto:stuart.yo...@arm.com>> wrote: I am playing around with EDK2 on QEMU with a UEFI shell application and in the app I allocate some memory using gBS->AllocatePool(EfiBootServicesData, ...) Programmatica

Re: [edk2-devel] EmulatorPkg and the state of DlLoadImage()

2021-07-30 Thread Andrew Fish via groups.io
> On Jul 30, 2021, at 1:34 PM, Marvin Häuser wrote: > > 30.07.2021 17:58:05 Andrew Fish via groups.io > mailto:afish=apple@groups.io>>: > >> >> >>> On Jul 30, 2021, at 3:37 AM, Marvin Häuser wrote: >>> >>> Good day everyone, >>> >>> I'm currently refining the port

Re: [edk2-devel] edk2 memory map on QEMU

2021-07-30 Thread Andrew Fish via groups.io
> On Jul 30, 2021, at 12:32 PM, Stuart Yoder wrote: > > I am playing around with EDK2 on QEMU with a UEFI shell application and in > the app I allocate some memory using gBS->AllocatePool(EfiBootServicesData, > ...) > > Programmatically accessing the pointer returned works fine, but when I p

Re: [edk2-devel] EmulatorPkg and the state of DlLoadImage()

2021-07-30 Thread Marvin Häuser
30.07.2021 17:58:05 Andrew Fish via groups.io : On Jul 30, 2021, at 3:37 AM, Marvin Häuser wrote: Good day everyone, I'm currently refining the port of EmulatorPkg to my new PE/COFF loader library instance. In the process, I found the function DlOpenImage() [1], which loads UEFI Images v

[edk2-devel] edk2 memory map on QEMU

2021-07-30 Thread Stuart Yoder
I am playing around with EDK2 on QEMU with a UEFI shell application and in the app I allocate some memory using gBS->AllocatePool(EfiBootServicesData, ...) Programmatically accessing the pointer returned works fine, but when I print it, it does not seem to be what I would expect is a valid addr

Re: [EXTERNAL] [edk2-devel] [edk2][PATCH v1 1/1] StandaloneMmPkg: add support to populate StMM boot data from device tree

2021-07-30 Thread Bret Barkelew via groups.io
I don’t think this is a good dependency. StandaloneMmCore shouldn’t require anything from EmbeddedPkg, and if it does there’s probably some more generalization necessary. Further, we can’t require the MmCore (which should be considered generic at the level of PEI Core or DXE Core) include some

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-07-30 Thread Sean
Jiewen, **Slight rant** I agree with libraries as an effective abstraction method. But I think there needs to be a broad discussion about the order of preference for methods of abstraction. Today the edk2 code base is a mix and often there are numerous methods abstracting the same thing whi

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

2021-07-30 Thread Bret Barkelew via groups.io
Note, even though this keeps with the style of the rest of the file, it breaks ECC: SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib by corthon · Pull Request #1848 · tianocore/edk2 (github.com) PROGRESS - --Running SecurityPkg:

[edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

2021-07-30 Thread Bret Barkelew
Used to provision and maintain certain HW-defined NV spaces. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2994 Signed-off-by: Bret Barkelew Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar --- SecurityPkg/Library/Tpm2CommandLib/Tpm2NVStorage.c | 122 S

[edk2-devel] [edk2][PATCH v1 1/1] StandaloneMmPkg: add support to populate StMM boot data from device tree

2021-07-30 Thread Sayanta Pattanayak
Introduce support to populate StMM boot data via DTS parsing. The DTB is passed as a boot argument by a binary of higer exception level. Previously it was achieved by placing the boot data structure in a shared buffer and the address of this shared buffer was passed by the binary of higher exceptio

Re: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion.

2021-07-30 Thread Rodrigo Gonzalez del Cueto
Missed adding the Bugzilla reference to the patch. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3463 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78448): https://edk2.groups.io/g/devel/message/78448 Mute This Topic: https://grou

[edk2-devel] [Patch 3/3] Ext4Pkg: Add .DSC file.

2021-07-30 Thread Pedro Falcato
This file is required to build Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dsc | 68 1 file changed, 68 insertions(+) create mode 100644 Features/Ext4Pkg/Ext4Pkg.dsc diff --

[edk2-devel] [Patch 0/3] Ext4Pkg: Add Ext4Pkg

2021-07-30 Thread Pedro Falcato
This patch-set adds Ext4Pkg, a package designed to hold various drivers and utilities related to the EXT4 filesystem. Right now, it holds a single read-only UEFI EXT4 driver (Ext4Dxe), which consumes the DISK_IO, BLOCK_IO and DISK_IO2 protocols and produce EFI_FILE_PROTOCOL and EFI_SIMPLE_FILE_SY

[edk2-devel] [Patch 1/3] Ext4Pkg: Add Ext4Pkg.dec and Ext4Pkg.uni.

2021-07-30 Thread Pedro Falcato
These files are needed to build Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dec | 17 + Features/Ext4Pkg/Ext4Pkg.uni | 14 ++ 2 files changed, 31 insertions(+) create mode 100644 Feat

Re: [edk2-devel] EmulatorPkg and the state of DlLoadImage()

2021-07-30 Thread Andrew Fish via groups.io
> On Jul 30, 2021, at 3:37 AM, Marvin Häuser wrote: > > Good day everyone, > > I'm currently refining the port of EmulatorPkg to my new PE/COFF loader > library instance. > In the process, I found the function DlOpenImage() [1], which loads UEFI > Images via the OS loader to utilise its symb

[edk2-devel] [PATCH edk2-platforms v3 6/6] Platform/ARM: Juno: Add JunoPkg.ci.yaml for CI support

2021-07-30 Thread PierreGondois
From: Pierre Gondois Add a JunoPkg.ci.yaml file to enable the CI for the JunoPkg. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Sami Mujawar Signed-off-by: Pierre Gondois --- Platform/ARM/JunoPkg/JunoPkg.ci.yaml | 104 +++ 1 file changed

[edk2-devel] [PATCH edk2-platforms v3 5/6] .mergify: Add Mergify YML pull request rules configuration file

2021-07-30 Thread PierreGondois
From: Pierre Gondois These files are copies of the files from the tianocore/edk2 repository. Any modification to the tianocore/edk2 files must be reflected on the tianocore/edk2-platforms copies. Initial commid-id in the edk2 repository: ab060128768b Initial message: Add directory for the Mergi

[edk2-devel] [PATCH edk2-platforms v3 4/6] .azurepipelines: Add Azure Pipelines YML configuration files

2021-07-30 Thread PierreGondois
From: Pierre Gondois To enable CI support of the tianocore/edk2-platforms repository, add YML configuration files used to run Continuous Integration (CI) checks on Azure Pipelines agents. These files are copies of the files from the tianocore/edk2 repository. Any modification to the tianocore/ed

[edk2-devel] [PATCH edk2-platforms v3 3/6] .pytool/Plugin: Add CI plugins

2021-07-30 Thread PierreGondois
From: Pierre Gondois To enable CI support of the tianocore/edk2-platforms repository, add a .pytool directory containing the following files: - .pytool/CISettings.py - .pytool/Readme.md These files are largely inspired from the same files available in the edk2 repository. The .pytool/Plugin/*

[edk2-devel] [PATCH edk2-platforms v3 2/6] pip-requirements.txt: Add python pip requirements file

2021-07-30 Thread PierreGondois
From: Pierre Gondois To enable CI support of the tianocore/edk2-platforms repository, add pip requirements file to install the python modules required to perform EDK II Continuous Integration (CI) builds. This file is a copy of the file from the tianocore/edk2 repository. Any modification to the

[edk2-devel] [PATCH edk2-platforms v3 1/6] edk2-platforms: add edk2 repository as a submodule

2021-07-30 Thread PierreGondois
From: Pierre Gondois Add the edk2 repository as a submodule: https://github.com/tianocore/edk2 Platforms in edk2-platforms often relies on modules available in the edk2 repository. In order to enable an upstream CI for edk2-platforms, adding edk2 as a submodule is a convenient way to advertise t

[edk2-devel] [PATCH edk2-platforms v3 0/6] Enable edk2-platforms CI for JunoPkg

2021-07-30 Thread PierreGondois
From: Pierre Gondois v3: - Replace Readme(s)'s by a reference to the initial Readmed(s) in tianocore repository. [Sean] - Align CI files with the latest version in the edk2 repository. [Sean/Michael] - Add additional step to checkout edk2's latest master in the CI. [Pierre] v2: - Use

[edk2-devel] EmulatorPkg and the state of DlLoadImage()

2021-07-30 Thread Marvin Häuser
Good day everyone, I'm currently refining the port of EmulatorPkg to my new PE/COFF loader library instance. In the process, I found the function DlOpenImage() [1], which loads UEFI Images via the OS loader to utilise its symbol loading capability. Theoretically, this should e.g. allow arbitra

[edk2-devel] [PATCH v7 11/11] SecurityPkg: Add option to reset secure boot keys.

2021-07-30 Thread Grzegorz Bernacki
This commit add option which allows reset content of Secure Boot keys and databases to default variables. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 --- SecurityPkg/VariableAuthenticated/S

[edk2-devel] [PATCH v7 10/11] SecurityPkg: Add new modules to Security package.

2021-07-30 Thread Grzegorz Bernacki
This commits adds modules and dependencies related to initialization and usage of default Secure Boot key variables to SecurityPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 --- Securit

[edk2-devel] [PATCH v7 09/11] SecurityPkg: Add EnrollFromDefaultKeys application.

2021-07-30 Thread Grzegorz Bernacki
This application allows user to force key enrollment from Secure Boot default variables. Signed-off-by: Grzegorz Bernacki Reviewed-by: Jiewen Yao Reviewed-by: Sunny Wang --- SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.inf | 48 SecurityPkg/EnrollFromDefaultKeysApp/

[edk2-devel] [PATCH v7 08/11] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-07-30 Thread Grzegorz Bernacki
This driver initializes default Secure Boot keys and databases based on keys embedded in flash. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi Reviewed-by: Jiewen Yao --- SecurityPkg/VariableAuthenticated/SecureBootDe

[edk2-devel] [PATCH v7 07/11] ArmPlatformPkg: Create include file for default key content.

2021-07-30 Thread Grzegorz Bernacki
This commits add file which can be included by platform Flash Description File. It allows to specify certificate files, which will be embedded into binary file. The content of these files can be used to initialize Secure Boot default keys and databases. Signed-off-by: Grzegorz Bernacki Reviewed-b

[edk2-devel] [PATCH v7 06/11] SecurityPkg: Remove duplicated functions from SecureBootConfigDxe.

2021-07-30 Thread Grzegorz Bernacki
This commit removes functions which were added to SecureBootVariableLib. It also adds dependecy on that library. Signed-off-by: Grzegorz Bernacki Reviewed-by: Jiewen Yao eviewed-by: Sunny Wang --- SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf | 2 + SecurityP

[edk2-devel] [PATCH v7 05/11] EmulatorPkg: add SecureBootVariableLib class resolution

2021-07-30 Thread Grzegorz Bernacki
The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for EmulatorPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --

[edk2-devel] [PATCH v7 04/11] OvmfPkg: add SecureBootVariableLib class resolution

2021-07-30 Thread Grzegorz Bernacki
The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for OvmfPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Laszlo Ersek Revi

[edk2-devel] [PATCH v7 03/11] ArmVirtPkg: add SecureBootVariableLib class resolution

2021-07-30 Thread Grzegorz Bernacki
The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for ArmVirtPkg platform. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny

[edk2-devel] [PATCH v7 02/11] SecurityPkg: Create library for enrolling Secure Boot variables.

2021-07-30 Thread Grzegorz Bernacki
This commits add library, which consist functions to enrolll Secure Boot keys and initialize Secure Boot default variables. Some of the functions was moved from SecureBootConfigImpl.c file. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao --- SecurityPkg/Securi

[edk2-devel] [PATCH v7 01/11] SecurityPkg: Create SecureBootVariableLib.

2021-07-30 Thread Grzegorz Bernacki
This commits add library, which consist helper functions related to creation/removal Secure Boot variables. Some of the functions was moved from SecureBootConfigImpl.c file. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec

[edk2-devel] [PATCH v7 00/11] Secure Boot default keys

2021-07-30 Thread Grzegorz Bernacki
This patchset adds support for initialization of default Secure Boot variables based on keys content embedded in

[edk2-devel] [PATCH RESEND v1 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT)

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5, Section 5.2.30 - Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094) Signed-off-by: Chris Jones --- MdePkg

[edk2-devel] [PATCH RESEND v1 12/13] MdePkg: Add Cache ID to PPTT

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141 - Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138) Signed-off-by: Chris Jones

[edk2-devel] [PATCH RESEND v1 11/13] MdePkg: Add Secure Access Components in the SDEV table

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.26.1.1 - Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111) Signed-off-by: Chris Jones --- MdePkg/Includ

[edk2-devel] [PATCH RESEND v1 13/13] MdePkg: Fix broken coding style in Acpi64.h

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Fix several coding style issues raised by EccCheck. These issues are also present in previous versions of Acpi.h however seem to have been introduced prior to the CI check. - Error code: 7008 - complex types should be typedef-ed

[edk2-devel] [PATCH RESEND v1 06/13] MdePkg: Remove DPPT table

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5 - Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133) Signed-off-by: Chris Jones --- MdePkg/Include/Industr

[edk2-devel] [PATCH RESEND v1 09/13] MdePkg: Add Multiprocessor Wakeup structure

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19 - Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087) Signed-off-by: Chris Jones --- Md

[edk2-devel] [PATCH RESEND v1 08/13] MdePkg: Add 'Type 5' PCC structure

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 14.1.7, Section 14.4 - Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010) Signed-off-by: Chris Jones --- Mde

[edk2-devel] [PATCH RESEND v1 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.25.2 System Physical Address (SPA) Range Structure, Table 5.109 - Mantis ID 1988 (https://mantis.uefi.org/mantis/view.p

[edk2-devel] [PATCH RESEND v1 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.24, Table 5.100 & Section 5.2.24.2 - Mantis ID 2126 (https://mantis.uefi.org/mantis/view.php?id=2126) Signed-off-by: Chr

[edk2-devel] [PATCH RESEND v1 01/13] MdePkg: Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) This patch introduces a header file for the ACPI specification version 6.4. Currently it is based on the Acpi63.h header file however makes six changes: 1. Replace all occurences of "6_3"/"6.3" with "6_4/6.4". 2. Remove the trai

[edk2-devel] [PATCH RESEND v1 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.59, Section 5.2.27.1 & Section 5.2.27.4 - Mantis ID 1991 (https://mantis.uefi.org/mantis/view.php?id=1991) Signed-off-by: Ch

[edk2-devel] [PATCH RESEND v1 02/13] MdePkg: Increment FADT version

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5-9 - Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105) Signed-off-by: Chris Jones --- MdePkg/Include/Industr

[edk2-devel] [PATCH RESEND v1 04/13] MdePkg: Update PMTT to ACPI 6.4

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.21.12 - Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975) Signed-off-by: Chris Jones --- MdePkg/Include

[edk2-devel] [PATCH RESEND v1 00/13] Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) This patch series introduces a header file for the latest version of the ACPI 6.4 specification, January 2021. This header contains all updates to the ACPI specification in addition to addressing a few small errors from the previ

Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables

2021-07-30 Thread Marcin Wojtas
Hi Ard, czw., 29 lip 2021 o 11:58 Ard Biesheuvel napisał(a): > > On Thu, 29 Jul 2021 at 11:46, Marcin Wojtas wrote: > > > > Hi Ard, > > > > pon., 19 lip 2021 o 17:06 Marcin Wojtas napisał(a): > > > > > > Hi Ard, > > > > > > pon., 19 lip 2021 o 11:54 Ard Biesheuvel napisał(a): > > > > > > > > O

Re: [edk2-devel] [PATCH v1 2/2] Platform/NXP: Modify duplicated GUID in ConfigurationManagerDxe

2021-07-30 Thread Sami Mujawar
Hi Leif, Is it possible to provide your feedback for this patch, please? I can then look at merging this series. Regards, Sami Mujawar From: on behalf of "Sami Mujawar via groups.io" Reply to: "devel@edk2.groups.io" , Sami Mujawar Date: Wednesday, 14 July 2021 at 15:42 To: Pierre Gondois ,

[edk2-devel] Status of autogen skipping

2021-07-30 Thread Daniel Schaefer
Hi, we, as probably most users of EDK2, have a huge codebase with lots of modules. Autogen takes multiple minutes, which is unnecessary when doing a rebuild. Luckily there is `--skip-autogen` but it only works if no INF, DSC, ... file has been changed. The developer needs to know when they

Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message

2021-07-30 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of > Seonghyun Park > Sent: Thursday, July 29, 2021 9:01 AM > To: devel@edk2.groups.io > Cc: Chen, Chen A ; Seonghyun Park > > Subject: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error > message > > Fix typo in error me

[edk2-devel] [PATCH v1 13/13] MdePkg: Fix broken coding style in Acpi64.h

2021-07-30 Thread Chris Jones
Fix several coding style issues raised by EccCheck. These issues are also present in previous versions of Acpi.h however seem to have been introduced prior to the CI check. - Error code: 7008 - complex types should be typedef-ed, Nested union in [EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE

[edk2-devel] [PATCH v1 11/13] MdePkg: Add Secure Access Components in the SDEV table

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.26.1.1 - Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 84 ++-- 1 file changed,

[edk2-devel] [PATCH v1 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT)

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5, Section 5.2.30 - Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 79 1 file c

[edk2-devel] [PATCH v1 12/13] MdePkg: Add Cache ID to PPTT

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141 - Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 6 -- 1 file chan

[edk2-devel] [PATCH v1 01/13] MdePkg: Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
This patch introduces a header file for the ACPI specification version 6.4. Currently it is based on the Acpi63.h header file however makes six changes: 1. Replace all occurences of "6_3"/"6.3" with "6_4/6.4". 2. Remove the trailing underscore from the header guard in accordance with the EDK2 c

[edk2-devel] [PATCH v1 08/13] MdePkg: Add 'Type 5' PCC structure

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 14.1.7, Section 14.4 - Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 29 1 fil

[edk2-devel] [PATCH v1 09/13] MdePkg: Add Multiprocessor Wakeup structure

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19 - Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 29 +++- 1 fi

[edk2-devel] [PATCH v1 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.59, Section 5.2.27.1 & Section 5.2.27.4 - Mantis ID 1991 (https://mantis.uefi.org/mantis/view.php?id=1991) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 9 ++---

[edk2-devel] [PATCH v1 02/13] MdePkg: Increment FADT version

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5-9 - Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[edk2-devel] [PATCH v1 06/13] MdePkg: Remove DPPT table

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Table 5.5 - Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 - 1 file changed, 5 deletions(-) diff --g

[edk2-devel] [PATCH v1 04/13] MdePkg: Update PMTT to ACPI 6.4

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.21.12 - Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 89 +++- 1 file changed,

[edk2-devel] [PATCH v1 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.24, Table 5.100 & Section 5.2.24.2 - Mantis ID 2126 (https://mantis.uefi.org/mantis/view.php?id=2126) Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 14 +++--

[edk2-devel] [PATCH v1 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure

2021-07-30 Thread Chris Jones
Make changes to ACPI 6.4 header according to the latest specification: - ACPI 6.4 January 2021, Section 5.2.25.2 System Physical Address (SPA) Range Structure, Table 5.109 - Mantis ID 1988 (https://mantis.uefi.org/mantis/view.php?id=1988) Also added a blank line between #defines and structure de

[edk2-devel] [PATCH v1 00/13] Add ACPI 6.4 header file

2021-07-30 Thread Chris Jones
This patch series introduces a header file for the latest version of the ACPI 6.4 specification, January 2021. This header contains all updates to the ACPI specification in addition to addressing a few small errors from the previous ACPI header files. The changes can be seen at: https://github.co

[edk2-devel] [PATCH 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters

2021-07-30 Thread Caden Kline
Improved encoding of box drawing characters for different terminal types. This includes Dec special graphics mode and more utf8. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Caden Kline --- .../Universal/Console/TerminalDxe/Terminal.h | 24 +- .../Universal/Consol