Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print which PCD was unable to be found

2021-07-18 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Daniel > Schaefer > Sent: Wednesday, July 14, 2021 12:43 PM > To: devel@edk2.groups.io > Cc: Daniel Schaefer ; Wang, Jian J > ; Wu, Hao A ; Bi, Dandan > ; Liming Gao > Subject: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print w

Re: [edk2-devel] [PATCH] Fix variables may be used uninitialize

2021-07-18 Thread Ni, Ray
Wesley, When applying the patch in my local tree, I found your patch is using unix style of EOL. Can you please send a V2 patch that uses the windows style of EOL? Thanks, Ray -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Monday, July 19, 2021 11:15 AM To: Hs

Re: [edk2-devel] [PATCH] Fix variables may be used uninitialize

2021-07-18 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Hsu, WesleyX Sent: Friday, July 16, 2021 2:38 PM To: devel@edk2.groups.io Cc: Hsu, WesleyX ; Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH] Fix variables may be used uninitialize REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3491 In

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

2021-07-18 Thread Ni, Ray
This change generates the reset vector binary which only contains 1G page table. If a platform doesn't support 1G page table, this will cause system hang. To Ard and Jordan, Can you evaluate whether this change impacts OVMF? To Prince, Can you evaluate whether this change impacts SimicsOpenBoard

Re: [edk2-devel] [PATCH] UefiCpuPkg: SecCoreNative without ResetVector

2021-07-18 Thread Ni, Ray
Ashraf, What unit tests have you performed with this native SecCore? Thanks, Ray -Original Message- From: S, Ashraf Ali Sent: Wednesday, July 14, 2021 5:48 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Ni, Ray ; Kumar, Rahul1 ; De, Debkumar ; Han, Harry ; West, Catharine ; Solanki,

Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value

2021-07-18 Thread Ni, Ray
Wenyi, Can you explain a bit more about "if 52 bit physical address need to be supported, page size should also be set to 64KB alignment"? Can the platform DSC override this value instead of changing the default value in MdeModulePkg.dec which impacts all platforms? Thanks, Ray -Original M

Re: [edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-18 Thread Brijesh Singh via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content > of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a > call to VerifyBlob after fetching to allow BlobVerifierLib > implementations to add a verification step for thes

Re: [edk2-devel] [PATCH v2 06/11] ArmVirtPkg: add NullBlobVerifierLib to DSC

2021-07-18 Thread Brijesh Singh via groups.io
On 7/6/21 3:54 AM, Dov Murik wrote: > This prepares the ground for calling VerifyBlob() in > QemuKernelLoaderFsDxe. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Jordan Justen > Cc: Ashish Kalra > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bot