Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

2021-07-13 Thread Zhiguang Liu
Add Maintainers. Thanks Zhiguang From: devel@edk2.groups.io on behalf of Zhiguang Liu Sent: Wednesday, July 14, 2021 14:24 To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu ---

[edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

2021-07-13 Thread Zhiguang Liu
Signed-off-by: Zhiguang Liu --- UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf index 2d51fdbacb..041fed842c 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPaylo

Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files

2021-07-13 Thread Daniel Schaefer
Thanks! Reviewed-By: Daniel Schaefer On 7/13/21 11:24 PM, Takuto Naito wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489 Fix build error of U540 and U500 caused by BdsDxe. The edk2 patch MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy requires VariablePolicyHelperLi

回复: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files

2021-07-13 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Takuto Naito > 发送时间: 2021年7月13日 23:25 > 收件人: devel@edk2.groups.io > 抄送: Takuto Naito ; Abner Chang > ; Gilbert Chen ; Daniel > Schaefer > 主题: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add > VariablePolicyH

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Print which PCD was unable to be found

2021-07-13 Thread Daniel Schaefer
Second version because I forgot to update HPE copyright. Signed-off-by: Daniel Schaefer Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Daniel Schaefer (1): MdeModulePkg: Print which PCD was unable to be found MdeModulePkg/Universal/PCD/Dxe/Service.c | 3 ++- 1 file changed, 2

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Print which PCD was unable to be found

2021-07-13 Thread Daniel Schaefer
When reaching the assert, it can't be debugged because the PCD is unknown. Therefore the PCD's GUID and token number should be printed. Signed-off-by: Daniel Schaefer Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 3 ++- 1 file change

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Add search function for Config Editor

2021-07-13 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Loo, Tung Lun > Sent: Tuesday, July 13, 2021 8:12 AM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH v2] IntelFsp2Pkg: Add search function for

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32

2021-07-13 Thread Chiu, Chasel
Patch pushed: 91f5d3b41043b8a0c8a5ed00e1c88bca4a777067 Thanks, Chasel > -Original Message- > From: S, Ashraf Ali > Sent: Friday, July 9, 2021 3:33 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Solanki, > Digant H

Re: [edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before registering RAM disk protocol

2021-07-13 Thread Wu, Hao A
Patch merged via: PR - https://github.com/tianocore/edk2/pull/1814 Commit - https://github.com/tianocore/edk2/commit/d0b6596b8e7ad72c86de0b9faa342a7a866bc87e Best Regards, Hao Wu > -Original Message- > From: Daniel Schaefer > Sent: Tuesday, July 13, 2021 5:31 PM > To: Wu, Hao A ; devel@

Re: [edk2-devel] [edk2-platforms] [PATCH V1 00/17] Add IceLake-SP and CooperLake Support to MinPlatform

2021-07-13 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, July 12, 2021 5:41 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Abbas, Mohamed > ; Chiu, Chasel > ; Kinney, Michael D ; > Liming Gao ; Dong, Eric > ; Michael Kubacki > Subject: [edk2-

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/13/2021 #cal-reminder

2021-07-13 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/13/2021 #cal-reminder

2021-07-13 Thread gaoliming
The following issues will be reviewed today. 3490 EDK2 Cod Specific unassig...@tianocore.org UNCO ACPI spec clarification - Time and Alarm Device methods requirements 17:31:34

Re: [edk2-devel] [Patch V3] UefiPayloadPkg: Dump hob information from boot loader

2021-07-13 Thread Guo Dong
Signed-off-by: Guo Dong > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, July 13, 2021 12:11 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; Ni, Ray ; You, Benjamin > ; Kesavan Balakrishnan, ThiyaguX > > Subject: [Patch V3] UefiPayloadPkg: Dump hob informati

Re: [edk2-devel] [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData

2021-07-13 Thread Guo Dong
Signed-off-by: Guo Dong > -Original Message- > From: Tan, Dun > Sent: Tuesday, July 13, 2021 12:19 AM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > ; Tan, Dun > Subject: [Patch V3 2/2] UefiPayloadPkg: Assign the length of > UniversalPayload Ext

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: Print which PCD was unable to be found

2021-07-13 Thread Daniel Schaefer
When reaching the assert, it can't be debugged because the PCD is unknown. Therefore the PCD's GUID and token number should be printed. Signed-off-by: Daniel Schaefer Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 1 + 1 file changed

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()

2021-07-13 Thread Sami Mujawar
Hi Joey, Thank you for this patch. This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/07/2021 01:24 PM, Joey Gouly wrote: Building with Clang showed that `RootComplexCount` and `DeviceIdMappingArrayCount` were unused. Use the variables where they were intend

[edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files

2021-07-13 Thread Takuto Naito
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489 Fix build error of U540 and U500 caused by BdsDxe. The edk2 patch MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy requires VariablePolicyHelperLib, but U500.dsc and U540.dsc didn't have it in the LibraryClasses section. Cc: Abne

[edk2-devel] [edk2-platforms PATCH v1 0/1] Platform/SiFive: Fix build error of U540 and U500 caused by BdsDxe

2021-07-13 Thread Takuto Naito
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489 v1 https://github.com/naitaku/edk2-platforms/tree/variablepolicyhelperlib_for_riscv_v1 Cc: Abner Chang Cc: Gilbert Chen Cc: Daniel Schaefer Takuto Naito (1): Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Platform/S

Re: [edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before registering RAM disk protocol

2021-07-13 Thread Daniel Schaefer
On 7/13/21 11:44 AM, Wu, Hao A wrote: -Original Message- From: devel@edk2.groups.io On Behalf Of Daniel Schaefer Sent: Tuesday, July 13, 2021 9:10 AM To: devel@edk2.groups.io Cc: Trammell Hudson ; Daniel Schaefer ; Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Gao, Zhichao Subject: [edk2-devel]

Re: [edk2-devel] [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_LO12_S relocation

2021-07-13 Thread Daniel Schaefer
Looks good. I compared it with existing R_RISCV_PCREL_LO12_I and looked at the differences. This one doesn't do use mRiscVPass1GotFixup. I assume this is an optimization that's not possible here? Haven't tested that it works but since it works for Pete: Reviewed-by: Daniel Schaefer Thanks!

[edk2-devel] [edk2-platforms][PATCH V1] KabylakeOpenBoardPkg: Implement the PEI Reset Services

2021-07-13 Thread Nate DeSimone
This change implements the ResetSystem and ResetSystem2 PEI services for KabylakeRvp3 and GalagoPro3. The invocation of PchInitializeReset() was missing from BoardInitLib. Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Jeremy Soller Cc: Michael Kubacki Cc: Benjamin Doron --- .../Library/Bo

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-13 Thread Yao, Jiewen
Appreciate your help on that. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Grzegorz > Bernacki > Sent: Tuesday, July 13, 2021 3:48 PM > To: Yao, Jiewen > Cc: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io; spbro...@outlook.com; l...@nuviainc.com; >

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-13 Thread Grzegorz Bernacki
Hi Jiewen, I think it is a good idea to split it this way. Please let me prepare next version of the patch. thanks, greg pon., 12 lip 2021 o 14:02 Yao, Jiewen napisał(a): > > I think Sean's feedback is a great idea to split the platform part from core > part. > > Even a simple split would be he

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PCD_DYNAMIC_AS_DYNAMICEX and set to True

2021-07-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Liu, Zhiguang Sent: Monday, July 12, 2021 4:10 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPkg: Add PCD_DYNAMIC_AS_DYNAMICEX and set to True PCD_DYNAMIC_AS_DYNAMICEX is rece

Re: [edk2-devel] [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData

2021-07-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Tan, Dun Sent: Tuesday, July 13, 2021 3:19 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Tan, Dun Subject: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData V1: Assign th

Re: [edk2-devel] [Patch V3 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h

2021-07-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Tan, Dun Sent: Tuesday, July 13, 2021 3:19 PM To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Ni, Ray ; Wang, Jian J ; Wu, Hao A ; Tan, Dun Subject: [Patch V3 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h Change the PldHe

Re: [edk2-devel] [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData

2021-07-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Tan, Dun Sent: Tuesday, July 13, 2021 3:19 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Tan, Dun Subject: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData V1: Assign th

Re: [edk2-devel] Possible [BUG] PeiCore: HOBs after cache-as-RAM teardown

2021-07-13 Thread Benjamin Doron
Hi Michael, I had missed the fact that the HobList pointer is updated in the entry to PEI core when ShadowedPeiCore is NULL. It had seemed odd to me that nobody else experienced issues, so in hindsight, that wouldn't have been the problem. I'm still not sure why CurrentWriteOffset is zeroed, whi

[edk2-devel] [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData

2021-07-13 Thread duntan
V1: Assign the length and revision of UniversalPayload ExtraData V2: Force int to UINT16 V3: Create a local variable to hold the size of ExtraData Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan --- UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 6 +

[edk2-devel] [Patch V3 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h

2021-07-13 Thread duntan
Change the PldHeader to Header in UNIVERSAL_PAYLOAD_EXTRA_DATA The meaning of Pld is too general Cc: Zhiguang Liu Cc: Ray Ni Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Zhiguang Liu Acked-by: Hao A Wu Signed-off-by: DunTan --- MdeModulePkg/Include/UniversalPayload/ExtraData.h | 4 +++- 1 fi

[edk2-devel] [Patch V3 0/2] Fix the length and PldHeader for UniversalPayload ExtraData

2021-07-13 Thread duntan
Change PldHeader to Header in ExtraData.h Assign the length and revision of UniversalPayload ExtraData duntan (2): MdeModulePkg: Change the PldHeader to Header in ExtraData.h UefiPayloadPkg: Assign the length of UniversalPayload ExtraData MdeModulePkg/Include/UniversalPayload/ExtraData.h

[edk2-devel] [Patch V3] UefiPayloadPkg: Dump hob information from boot loader

2021-07-13 Thread Zhiguang Liu
V1: Universal Payload will consume Hobs from boot loader. Dump all hobs in the Universal Payload entry. V2: Add function comments V3: minor change, for example Hobsize -> HobLength, SMBiosTable -> SmBiosTable Cc: Maurice Ma Cc: Guo Dong Cc: Ray Ni Cc: Benjamin You Signed-off-by: Thiyagu Kesa