Re: [edk2-devel] [Patch V2] Dump hob information from boot loader.

2021-07-12 Thread Ni, Ray
Minor comments: 1. Hobsize -> HobLength 2. SMBiosTable -> SmBiosTable 3. The comments "//0x000x" in below is not needed. Can you remove them? {EFI_HOB_TYPE_HANDOFF, "EFI_HOB_TYPE_HANDOFF", PrintHandOffHob}, //0x0001 {EFI_HOB_TYPE_MEMORY_ALLOCATION,

Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData

2021-07-12 Thread Ni, Ray
It will be better if you can create a local variable Length to hold "sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY)". So that Length can be used in BuildGuidHob() call as well. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all message

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

2021-07-12 Thread Ni, Ray
Thanks for your education on me about the open-source development process. Will miss you! Reviewed-by: Ray Ni -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77729): https://edk2.groups.io/g/devel/message/77729 Mute This Topic: https://

[edk2-devel] [edk2-platforms: PATCH] Platform/Intel: Correct CPU APIC IDs.

2021-07-12 Thread TinaX Y Chen
From: JackX REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chase

Re: [edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before registering RAM disk protocol

2021-07-12 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Daniel > Schaefer > Sent: Tuesday, July 13, 2021 9:10 AM > To: devel@edk2.groups.io > Cc: Trammell Hudson ; Daniel Schaefer > ; Wang, Jian J ; Wu, > Hao A ; Ni, Ray ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH v1 1/1] RamDi

Re: [edk2-devel] [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_LO12_S relocation

2021-07-12 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: Sunil V L [mailto:suni...@ventanamicro.com] > Sent: Saturday, July 10, 2021 2:31 PM > To: devel@edk2.groups.io > Cc: sunil...@gmail.com; Sunil V L ; Liming Gao > ; Bob Feng ; Yuwei > Chen ; Pete Batard ; Chang, Abner > (HPS SW/FW Technolo

Re: [edk2-devel] [edk2-platforms] [PATCH V1 00/17] Add IceLake-SP and CooperLake Support to MinPlatform

2021-07-12 Thread Oram, Isaac W
Series Reviewed-by: isaac.w.o...@intel.com -Original Message- From: Desimone, Nathaniel L Sent: Monday, July 12, 2021 5:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Abbas, Mohamed ; Chiu, Chasel ; Kinney, Michael D ; Liming Gao ; Dong, Eric ; Michael Kubacki Subject: [edk2-pla

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/13/2021 #cal-reminder

2021-07-12 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

[edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before registering RAM disk protocol

2021-07-12 Thread Daniel Schaefer
From: Trammell Hudson This patch initializes the linked list RegisteredRamDisks in RamDiskDxeEntryPoint before the registration of gEfiRamDiskProtocolGuid with InstallMultipleProtocolInterfaces, allowing ramdisks to be created via a callback installed with RegisterProtocolNotify as soon as the pr

[edk2-devel] [PATCH v1 0/1] RamDiskDxe: Initialize list head before registering RAM disk protocol

2021-07-12 Thread Daniel Schaefer
Sending this patch on behalf of Trammell, who asked me to do so, so that he doesn't have to set up git-send-email config. See his PR: https://github.com/tianocore/edk2/pull/1810 Trammell Hudson (1): RamDiskDxe: initialize list head before registering ram disk protocol MdeModulePkg/Universal/D

[edk2-devel] [edk2-platforms] [PATCH V1 17/17] Maintainers.txt: Add WhitleyOpenBoardPkg and WhitleySiliconPkg

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- Maintainers.txt | 12 1 file changed, 12 insertions(+) diff --git

[edk2-devel] [edk2-platforms] [PATCH V1 16/17] Readme.md: Add WhitleyOpenBoardPkg

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- Platform/Intel/Readme.md | 14 ++ Readme.md| 2 ++

[edk2-devel] [edk2-platforms] [PATCH V1 15/17] Platform/Intel: Add WhitleyOpenBoardPkg to build_bios.py

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- Platform/Intel/build.cfg | 2 ++ Platform/Intel/build_bios.py | 28 +++

[edk2-devel] [edk2-platforms] [PATCH V1 08/17] WhitleySiliconPkg: Add Security Includes

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- .../SecurityIp/SecurityIpMkTme1v0_Inputs.h| 25 .../SecurityIp

[edk2-devel] [edk2-platforms] [PATCH V1 09/17] WhitleySiliconPkg: Add SiliconPolicyInit

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- .../SiliconPolicyInit/SiliconPolicyInitLate.c | 52 +++ .../Silicon

[edk2-devel] [edk2-platforms] [PATCH V1 07/17] WhitleySiliconPkg: Add PCH Libraries

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- .../Library/PeiDxeSmmGpioLib/GpioLibrary.h| 224 ++ 1 file

[edk2-devel] [edk2-platforms] [PATCH V1 04/17] WhitleySiliconPkg: Add Me Includes

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- .../Me/MeSps.4/Include/Library/SpsPeiLib.h| 22 +++ 1 file

[edk2-devel] [edk2-platforms] [PATCH V1 03/17] WhitleySiliconPkg: Add Cpu Includes

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- .../Intel/WhitleySiliconPkg/Cpu/CpuRcPkg.dec | 101 ++ .../Cpu/Include/Cpu

[edk2-devel] [edk2-platforms] [PATCH V1 01/17] WhitleySiliconPkg: Add DEC and DSC files

2021-07-12 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Co-authored-by: Isaac Oram Co-authored-by: Mohamed Abbas Cc: Chasel Chiu Cc: Michael D Kinney Cc: Isaac Oram Cc: Mohamed Abbas Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki --- Silicon/Intel/WhitleySiliconPkg/CpRcPkg.dec | 541 + .../WhitleySili

[edk2-devel] [edk2-platforms] [PATCH V1 00/17] Add IceLake-SP and CooperLake Support to MinPlatform

2021-07-12 Thread Nate DeSimone
This patch series adds WhitleyOpenBoardPkg and WhitleySiliconPkg to edk2-platforms. These platforms along with the corresponding FSP and microcode binaries support the 3rd Generation Xeon Scalable processors formerly known as IceLake-SP and CooperLake. There are still some issues to be worked out.

[edk2-devel] [PATCH v2] IntelFsp2Pkg: Add search function for Config Editor

2021-07-12 Thread Tung Lun
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3482 This patch adds a search function in the Config Editor GUI at the top right corner. Once users key in the words to search, it will look for the option containing the string in the same page and display it. It also includes a README for this f

[edk2-devel] Update/current status on EFI AOP

2021-07-12 Thread Ethin Probst
Hello all, Since first evaluations are upon us in GSoC 2021, I thought I'd provide an update on the EFI audio output protocol (AOP) and its current status to ensure that we're all on the same page. Currently, I've forked the EDK II project and that fork is available at https://github.com/ethindp/

Re: [edk2-devel] Using the TCP->Accept interface.

2021-07-12 Thread Maciej Rabeda
Hi Ken, When calling Tcp4->Configure(), what is your EFI_TCP4_CONFIG_DATA.AccessPoint.ActiveFlag value? ActiveFlag should be set to FALSE and RemoteAddress set to zero in order to accept connection requests from any address. You should be able to double check the fields above by calling Tcp4

Re: [edk2-devel] [PATCH v5 05/10] SecurityPkg: Remove duplicated functions from SecureBootConfigDxe.

2021-07-12 Thread Yao, Jiewen
Sorry. My mistake. It should be Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Monday, July 12, 2021 7:46 PM > To: Grzegorz Bernacki ; devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud

[edk2-devel] 回复: [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_LO12_S relocation

2021-07-12 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: Sunil V L > 发送时间: 2021年7月10日 14:31 > 收件人: devel@edk2.groups.io > 抄送: sunil...@gmail.com; Sunil V L ; Liming Gao > ; Bob Feng ; Yuwei Chen > ; Pete Batard ; Abner Chang > ; Daniel Schaefer > 主题: [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_L

回复: [edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-07-12 Thread gaoliming
Include Ard who made this change to discard COMMON section (edk2 214a3b79417f64bf2faae74af42c1b9d23f50dc8). Ard: can you help confirm this change to add back COMMON section? Christopher adds back COMMON section for GCC support from the assembly-accelerated OpenSSL patch. Because -fno-common opt

回复: [edk2-devel] [edk2-platforms PATCH v5 1/4] Intel Platforms: add SecureBootVariableLib class resolution

2021-07-12 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sunny Wang > 发送时间: 2021年7月9日 17:09 > 收件人: Grzegorz Bernacki ; devel@edk2.groups.io > 抄送: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer > El-Haj-Mahmoud ; m...@semihalf.com; > upstr...@semihalf.com; jiewen@intel.com

Re: [edk2-devel] [PATCH v4] BaseTools GenFw: Add support for RISCV GOT/PLT relocations

2021-07-12 Thread Pete Batard
Since I was also impacted by this in the RISC-V NTFS driver, and I can vouch that this patch does produce a functional executable when tested with QEMU, I'll add my T-b as well. On 2021.06.24 14:25, Sunil V L wrote: Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3096 This patch adds supp

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-12 Thread Yao, Jiewen
I think Sean's feedback is a great idea to split the platform part from core part. Even a simple split would be helpful. How about below: 1) SecureBootVariableLib: SetSecureBootMode(), GetSetupMode(), CreateTimeBasedPayload(), DeleteDb(), DeleteDbx(), DeleteDbt(), DeleteKEK(), DeletePlatformKey

Re: [edk2-devel] [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_LO12_S relocation

2021-07-12 Thread Pete Batard
Hi Sunil, Thanks a lot for this patch. I confirm that it fixes the issue I raised in BZ3459. If anyone is interested, you can find builds of the RISC-V NTFS driver, where this patch has been applied, in the artefacts of https://github.com/pbatard/ntfs-3g/actions/runs/1022633741. With this:

Re: [edk2-devel] [PATCH v5 05/10] SecurityPkg: Remove duplicated functions from SecureBootConfigDxe.

2021-07-12 Thread Yao, Jiewen
Signed-off-by: Jiewen Yao > -Original Message- > From: Grzegorz Bernacki > Sent: Thursday, July 1, 2021 5:18 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang ; > m...@semihalf.com; upstr...@semihalf.com; Yao, Jiewen > ;

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

2021-07-12 Thread Jon Nettleton
On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > Hi, > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisał(a): > > > > Hi Leif, > > > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisał(a): > > > > > > Hi Marcin, > > > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > >

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

2021-07-12 Thread Marcin Wojtas
Hi, wt., 29 cze 2021 o 16:17 Marcin Wojtas napisał(a): > > Hi Leif, > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisał(a): > > > > Hi Marcin, > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > > Hi, > > > > > > The MDIO ACPI binding has been established and merged to the >

Re: [edk2-devel] [PATCH V2 3/4] NXP/LS1046aFrwyPkg: Enable ConfigurationManager on LS1046AFRWY

2021-07-12 Thread Sunny Wang
Hi Vikas, Just have two comments below. Others look good to me. 1. In LS1046aFrwyPkg.dsc, since you already include DynamicTablesPkg/DynamicTables.dsc.inc, I think we need to remove DynamicTableFactoryDxe.inf code block. Could you check this? 2. Remove " DEFINE DYNAMIC_ACPI_ENABLE = TRUE ". In o

Re: [edk2-devel] [PATCH V2 2/4] Silicon/NXP: Add support of SVR handling for LS1046A SoC

2021-07-12 Thread Sunny Wang
Looks good. Just have some comments mentioned Patch 0/4 about moving/renaming file/folder for synchronizing with NXP LSDK opensource https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms. Best Regards, Sunny Wang -Original Message- From: Vikas Singh Sent: Friday,

Re: [edk2-devel] [PATCH V2 1/4] Platform/NXP: Make SoC version log in ConfigurationManager generic

2021-07-12 Thread Sunny Wang
Looks good. Just have some comments mentioned Patch 0/4 about moving/renaming file/folder for synchronizing with NXP LSDK opensource https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms. Best Regards, Sunny Wang -Original Message- From: Vikas Singh Sent: Friday,

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-07-12 Thread Sunny Wang
Hi Vikas, Thanks for working on this. As our offline discussion with NXP, our goal is to make the Tiano edk2-platform and NXP LSDK opensource https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms in sync. Now the main problem is that some folders' names and locations hav

[edk2-devel] [Patch] Document: Add PCD_DYNAMIC_AS_DYNAMICEX to DSC defines section

2021-07-12 Thread Bob Feng
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 DynamicEx Pcd supports binary module build well. It's helpful to add a new build option for build tool to convert all Dynamic Pcd to DynamicEx Pcd. Add a new key word in defines section for this function. Signed-off-by: Bob Feng Cc: Limin

Re: [edk2-devel] [edk2-platforms PATCH v5 0/4] Secure Boot default keys

2021-07-12 Thread Sunny Wang
Reviewed whole series. Reviewed-by: Sunny Wang We still need Intel platforms' maintainers to review the patch below. All other patches (for ARM, RISC-V, and QEMU platforms) were already reviewed by maintainers. - [edk2-platforms PATCH v5 1/4] Intel Platforms: add SecureBootVariableLib clas

[edk2-devel] [PATCH] UefiPayloadPkg: Add PCD_DYNAMIC_AS_DYNAMICEX and set to True

2021-07-12 Thread Zhiguang Liu
PCD_DYNAMIC_AS_DYNAMICEX is recently added to Edk2, and it can treat Dynamic PCD to Dynamic Ex PCD, which is Uefi Payload needs. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Zhiguang Liu --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) di

[edk2-devel] Using the TCP->Accept interface.

2021-07-12 Thread Ken Taylor
Hi all, I hate to ask this, but has anyone used or tested the standard NetworkPkg TCP driver's socket Accept functionality? I've been trying to listen for a connection, but I can't seem to figure out how to configure the TCP interface correctly for this. I know the local IP address and listen