[edk2-devel] [PATCH] BaseTools GenFw: Add support for R_RISCV_PCREL_LO12_S relocation

2021-07-09 Thread Sunil V L
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3459 This patch adds support for R_RISCV_PCREL_LO12_S relocation type. The logic is same as existing R_RISCV_PCREL_LO12_I relocation except the difference between load vs store instruction formats. Signed-off-by: Sunil V L Cc: Liming Gao Cc:

Re: [edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-07-09 Thread Christopher Zurcher
The -fno-common addition to compiler flags should prevent variables being emitted into the COMMON section. Discarding the COMMON section prevents usage of the section even if a driver specifies -fcommon or otherwise utilizes the COMMON section. I do not think that this change should introduce an

[edk2-devel] TianoCore Community Meeting Minutes - July

2021-07-09 Thread Soumya Guptha
TianoCore Community Meeting July 8, 2021 EVENTS: Google Summer of Code: * TianoCore projects are listed here: https://summerofcode.withgoogle.com/organizations/6376892141142016/ * Going well. Midterm reviews are due in a few days. * Students have started submitting patches. Stu

Re: [edk2-devel] Proposing a new area of the edk2-test repository

2021-07-09 Thread Samer El-Haj-Mahmoud
Interesting, thanks for sharing Bret. Some of those tests seem to be x64 specific (SMM tests), and some can be more generic like MorLockTestApp Like I said earlier, I am not against adding test tools to edk2-test. That in fact is welcomed, especially if their usefulness in validating the solutio

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-09 Thread Samer El-Haj-Mahmoud
Sean, Thanks for the feedback. As you say, this is a design concern in SecurityPkg today, and the improvement you are suggesting is welcomed, especially for systems that rely on EDK2 (and lack a commercial FW solution). Considering that this patch series is at v5, and has accumulated enough rev

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-09 Thread Sean
Grzegorz, It is a little late to the party to provide broad feedback (given you are on v5) but i'll do it anyway and if anything resonates maybe you can make a few changes. This patchset (for modules/libraries in SecurityPkg) does not resolve a major issue within the SecurityPkg design toda

Re: [edk2-devel] [Patch V2 3/3] Maintainers.txt: Add GitHub IDs

2021-07-09 Thread Michael D Kinney
Hi Laszlo, Understood. I will merge your patch first. Then rebase mine. Thanks, Mike > -Original Message- > From: Laszlo Ersek > Sent: Friday, July 9, 2021 5:23 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; Ard > Biesheuvel (TianoCore) > > Su

[edk2-devel] [edk2-platforms][PATCH v1 1/1] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Remove PPI from HOB

2021-07-09 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3486 The PPI pointer should not be cached in a HOB as it could get out of sync with the current pointers in the PPI list. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Benjamin Doron Signed-off-by: Michael Kubacki --- Platfo

Re: [edk2-devel] [Patch V2 3/3] Maintainers.txt: Add GitHub IDs

2021-07-09 Thread Laszlo Ersek
Hi Mike, On 07/08/21 21:50, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 282 > 1 file changed, 139 insertions(+), 143 deletions(-) > > diff --git

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

2021-07-09 Thread Laszlo Ersek
On 07/09/21 09:42, Ard Biesheuvel wrote: > On Thu, 8 Jul 2021 at 09:09, Laszlo Ersek wrote: >> >> I'm relinquishing all my roles listed in "Maintainers.txt", for personal >> reasons. >> >> My email address remains functional. >> >> To my understanding, my employer is working to assign others engi

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE

2021-07-09 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77653): https://edk2.groups.io/g/devel/message/77653 Mute This Topic: https://groups.io/mt/82490304/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-09 Thread Sunny Wang
Reviewed whole series. Reviewed-by: Sunny Wang We still need matintainers to review the patches below: [PATCH v5 03/10] OvmfPkg: add SecureBootVariableLib class resolution [PATCH v5 04/10] EmulatorPkg: add SecureBootVariableLib class resolution [PATCH v5 05/10] SecurityPkg: Remove duplicated func

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-07-09 Thread Grzegorz Bernacki
Hi Zhichao, Setting HII-type PCD causes variable initialization, so if GetVariable() fails due to variable not being found, it will be initialized by PcdSet32S() function. thanks, greg czw., 8 lip 2021 o 10:08 Gao, Zhichao napisał(a): > > See below comments. > > > -Original Message- > >

Re: [edk2-devel] [edk2-platforms PATCH v2 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

2021-07-09 Thread Grzegorz Bernacki
Hi, Yes, you're right, I will send a corrected version of the patch. Thanks a lot, greg czw., 8 lip 2021 o 10:15 Gao, Zhichao napisał(a): > > See below comments. > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of > > Grzegorz Bernacki > > Sent: Tuesday, July 6, 2021 6:

Re: [edk2-devel] [PATCH v5 08/10] SecurityPkg: Add EnrollFromDefaultKeys application.

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v5 03/10] OvmfPkg: add SecureBootVariableLib class resolution

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v5 02/10] ArmVirtPkg: add SecureBootVariableLib class resolution

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v5 01/10] SecurityPkg: Create library for setting Secure Boot variables.

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v5 06/10] ArmPlatformPkg: Create include file for default key content.

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v5 05/10] SecurityPkg: Remove duplicated functions from SecureBootConfigDxe.

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v5 04/10] EmulatorPkg: add SecureBootVariableLib class resolution

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [edk2-platforms PATCH v5 1/4] Intel Platforms: add SecureBootVariableLib class resolution

2021-07-09 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:21 PM To: devel@edk2.groups.io Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; m...@semihalf.com; upstr...@semihalf.com; jiewen@

Re: [edk2-devel] [PATCH v1 1/1] ArmPlatformPkg/Scripts: Create add-symbol-file commands from UEFI console

2021-07-09 Thread PierreGondois
More formally: Tested-by: Pierre Gondois -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77641): https://edk2.groups.io/g/devel/message/77641 Mute This Topic: https://groups.io/mt/83561852/21656 Group Owner: devel+ow...@edk2.groups.io Un

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32

2021-07-09 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: S, Ashraf Ali > Sent: Friday, July 9, 2021 3:33 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; > Solanki, Digant H ; V, Sangeetha > > Subject: [PATCH] IntelFsp2P

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

2021-07-09 Thread Ard Biesheuvel
On Thu, 8 Jul 2021 at 09:09, Laszlo Ersek wrote: > > I'm relinquishing all my roles listed in "Maintainers.txt", for personal > reasons. > > My email address remains functional. > > To my understanding, my employer is working to assign others engineers to > the edk2 project (at their discretion).

[edk2-devel] [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32

2021-07-09 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3485 CacheLib EfiProgramMtrr Function takes MTRR number as a input parameter, in the function the parameter is defined as UINTN were as the caller calling MTTR number in UINT32. Signed-off-by: Ashraf Ali S Cc: Ray Ni Cc: Chasel Chiu Cc: Nate D