Re: [edk2-devel] QemuVideo: BochsID mismatch (got 0x0)

2021-07-06 Thread Lange Tang
Hi all: After testing, I found that once the QXL device shared a PciRoot slot with other devices, the following log would appear: QemuVideo: BochsID mismatch (got 0x0) Connect: PciRoot(0x0)... : Not Found Is this a feature of QXL devices? Best regards, Lange At 2021-07-07 00:0

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-07-06 Thread Michael D Kinney
Hi Laszlo, I did many experiments and could not get the exact behavior I proposed. Here is the best I can do with the behavior of GitHub and Mergify: 1) I further simplified Mergify configuration so personal builds ('push' label not set) are no longer auto closed. Any developer doing a pe

[edk2-devel] Possible [BUG] PeiCore: HOBs after cache-as-RAM teardown

2021-07-06 Thread Benjamin Doron
Hi all, I'm working on root-causing an issue where I'm unable to retrieve any debug logs after cache-as-RAM teardown on my MinPlatform board port for GSoC 2021. I'm using KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash. My best guess at the moment is that it's related to HOBs, which this SerialPo

回复: [edk2-devel] [PATCH] MdeModulePkg PiSmmCore: Change MemoryAttributes message to DEBUG_VERBOSE level

2021-07-06 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yang Gang > 发送时间: 2021年7月5日 9:20 > 收件人: devel@edk2.groups.io > 抄送: Eric Dong ; Ray Ni ; Liming > Gao > 主题: [edk2-devel] [PATCH] MdeModulePkg PiSmmCore: Change > MemoryAttributes message to DEBUG_VERBOSE level > > 1. Reduce

[edk2-devel] 回复: [PATCH v2 0/4] Allow EccCheck to run on other repositories

2021-07-06 Thread gaoliming
This version is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: pierre.gond...@arm.com > 发送时间: 2021年7月7日 4:56 > 收件人: devel@edk2.groups.io; Sean Brogan ; > Bret Barkelew ; Michael D Kinney > ; Liming Gao ; > Sami Mujawar > 主题: [PATCH v2 0/4] Allow EccCheck to run on oth

Re: [edk2-devel] [PATCH v4 2/3] Acpi: Install Acpi tables for Cloud hypervisor

2021-07-06 Thread Jianyong Wu
Hi Sami, Thanks for your rework on my patch. I tried the change and it works well. You can do what you like on the patch set. Thanks Jianyong > -Original Message- > From: Sami Mujawar > Sent: Tuesday, July 6, 2021 4:52 PM > To: Jianyong Wu ; devel@edk2.groups.io > Cc: ler...@redhat.com

回复: [edk2-devel] [PATCH v6 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2021-07-06 Thread gaoliming
Christopher: Discard COMMON section is added by edk2 commit 214a3b79417f64bf2faae74af42c1b9d23f50dc8. Please help evaluate its impact. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yao, Jiewen > 发送时间: 2021年6月23日 20:42 > 收件人: Christopher Zurcher ; > devel@edk2.groups.io; gaolim

回复: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

2021-07-06 Thread gaoliming
Grzegorz Bernacki: This is a new feature. Can you submit one BZ (https://bugzilla.tianocore.org/) for it? Then, I can add it into edk2 stable tag feature planning. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Grzegorz > Bernacki > 发送时间: 2021年7月1日 17:18 > 收件人: devel@edk2.groups

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-06 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: S, Ashraf Ali > Sent: Wednesday, July 7, 2021 2:42 AM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; Chiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3] IntelFsp2Pkg: PatchFv parseInfFile functi

[edk2-devel] Reminder: Community meeting this week

2021-07-06 Thread Soumya Guptha
Hi Team, I would like to remind you on the community meeting this Thursday, July 8. Typically, we have the call during the first week of each month. Due to the long weekend last week, I have moved the call to this Thursday. Please attend the call. Thanks, Soumya Soumya Guptha Firmware Ecosystem

[edk2-devel] [PATCH v2 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc

2021-07-06 Thread PierreGondois
From: Pierre Gondois When running Ecc on other repositories (e.g.: edk2-platforms with edk2 as a submodule), edk2 modules are referenced. E.g.: MdePkg/.. The PACKAGES_PATH env var can be used to reference other directories containing packages. Set it so that Ecc can find these packages. Cc: Sean

[edk2-devel] [PATCH v2 1/4] .pytool/EccCheck: Locate BaseTools dir with EDK_TOOLS_PATH

2021-07-06 Thread PierreGondois
From: Pierre Gondois The BaseTools directory is currently being located as a sub-directory of the WORKSPACE env var. This might not be true in other environments. Cf EDKII Build Specification, s4.1.3 "Build Process Restrictions": There is no restriction on the location of the EDK_TOOLS_PATH,

[edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

2021-07-06 Thread PierreGondois
From: Pierre Gondois EccCheck currently makes some assumptions on its working environment that prevent it from running it in other repositories. For instance, the workspace is assumed to be pointing to the edk2 repository path, which can be wrong. This patch-set aims to allow the EccCheck tool to

[edk2-devel] [PATCH v2 3/4] .pytool/EccCheck: Check ecc_csv exists

2021-07-06 Thread PierreGondois
From: Pierre Gondois 'workspace_path' being an absolute path leads to 'ecc_csv' being an absolute path. Then it won't be found among 'file' as they are relative paths. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Sami Mujawar Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v2 2/4] .pytool/EccCheck: Rename edk2_path as workspace_path

2021-07-06 Thread PierreGondois
From: Pierre Gondois The edk2 path and the workspace path are identical when running Ecc on edk2. When running Ecc on another repository (e.g.: edk2-platforms with edk2 as a submodule of edk2-platforms), these directories are different. Indeed, in the latter configuration, Ecc must run git comman

[edk2-devel] [PATCH v3] IntelFsp2Pkg: PatchFv parseInfFile function modification

2021-07-06 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3476 parseInfFile currently reading the EFI_BASE_ADDRESS from INF, once the address found still it's continues to read the complete inf file which is not required. once the EFI_BASE_ADDRESS read from the INF no need to read the INF further. MSFT c

Re: [EXTERNAL] 回复: [edk2-devel] 回复: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors

2021-07-06 Thread manickavasakam karpagavinayagam
Yeah I can see the change. Thank you Liming for all your help. -Manic From: gaoliming Sent: Sunday, July 4, 2021 8:53 PM To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; latee...@gmail.com Cc: Manickavasakam Karpagavinayagam ; isaac.w.o...@intel.com; nathaniel.l.desim...@intel.com; Felix Pol

[edk2-devel] QemuVideo: BochsID mismatch (got 0x0)

2021-07-06 Thread Lange Tang
Greeting! branch: edk2 master ArmVirtPkg/ArmVirtQemu.dsc commit 17143c4837393d42c484b42d1789b85b2cff1aaf (origin/master, origin/HEAD) Author: Rebecca Cran Date: Sun Jun 13 11:43:01 2021 +0800 I clone edk2 code and build, run on arm64 platform for debug. Following is key log, :

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-06 Thread Laszlo Ersek
On 07/06/21 11:53, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > The Print service driver is not used by OVMF, remove it. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment

2021-07-06 Thread Laszlo Ersek
On 07/06/21 11:49, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > The "Shell Embedded Boot Loader" description (added in > commit 6f5872b1f401) does not add any value, remove it. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Julien G

Re: [edk2-devel] EFI_AUDIO_OUTPUT_PROTOCOL: assistance with VirtIO initialization

2021-07-06 Thread Michael Brown
On 02/07/2021 19:22, Ethin Probst wrote: Update: I just realized I'd made a typo -- the unknown request is actually a get_min request. On 7/2/21, Ethin Probst wrote: Setup Data bmRequestType: 0xa1 1... = Direction: Device-to-host .01. = Type: Class (0x1)

Re: [edk2-devel] [PATCH v5 09/10] SecurityPkg: Add new modules to Security package.

2021-07-06 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Grzegorz Bernacki > Sent: Thursday, July 1, 2021 5:18 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.com; > upstr...@semihalf.com; Ya

Re: [edk2-devel] [PATCH v5 01/10] SecurityPkg: Create library for setting Secure Boot variables.

2021-07-06 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Grzegorz Bernacki > Sent: Thursday, July 1, 2021 5:18 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.com; > upstr...@semihalf.com; Ya

Re: [edk2-devel] [PATCH v5 10/10] SecurityPkg: Add option to reset secure boot keys.

2021-07-06 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Grzegorz Bernacki > Sent: Thursday, July 1, 2021 5:18 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.com; > upstr...@semihalf.com; Ya

Re: [edk2-devel] [PATCH v5 07/10] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-07-06 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Grzegorz Bernacki > Sent: Thursday, July 1, 2021 5:18 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.com; > upstr...@semihalf.com; Ya

Re: [edk2-devel] [PATCH v5 08/10] SecurityPkg: Add EnrollFromDefaultKeys application.

2021-07-06 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Grzegorz Bernacki > Sent: Thursday, July 1, 2021 5:18 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.com; > upstr...@semihalf.com; Ya

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-07-06 Thread Grzegorz Bernacki
This library extends Boot Maintenance Menu and allows to select Boot Discovery Policy. When choice is made BootDiscoveryPolicy variable is set. Platform code can use this variable to decide which class of device shall be connected. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Md

[edk2-devel] [edk2-platforms PATCH v2 2/2] Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"

2021-07-06 Thread Grzegorz Bernacki
This reverts commit efdc159ef7c9f15581a0f63d755a1530ff475156. This commit is not longer required as Boot Discovery Policy has been implemented for RPi. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Platform/RaspberryPi/RaspberryPi.dec |

[edk2-devel] [edk2-platforms PATCH v2 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

2021-07-06 Thread Grzegorz Bernacki
This commit modify platform boot to check the value of BootDiscoveryPolicy variable and use BootPolicyManager Protocol to connect devices specified by the variable. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Platform/RaspberryPi/RPi4/RPi4.dsc

[edk2-devel] [PATCH v2 0/2] Add BootDiscoveryPolicyUiLib

2021-07-06 Thread Grzegorz Bernacki
This patchset extends Boot Maintenance Menu and allows to select Boot Discovery Policy. Raspberry Pi platforms uses the variable to connect specified class of devices on boot. This patchset also removes efdc159e which has similar functionality. Discussion on design can be found at: https://edk2.gr

[edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-07-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude The Print service driver is not used by OVMF, remove it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Suggested-by: Laszlo Ersek Signed-off-by: Philipp

[edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment

2021-07-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude The "Shell Embedded Boot Loader" description (added in commit 6f5872b1f401) does not add any value, remove it. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Julien Grall Suggested-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Dau

[edk2-devel] [PATCH v2 11/11] OvmfPkg/AmdSev: Enforce hash verification of kernel blobs

2021-07-06 Thread Dov Murik
In the AmdSevX86 build, use SevHashesBlobVerifierLib to enforce verification of hashes of the kernel/initrd/cmdline blobs fetched from firmware config. This allows for secure (measured) boot of SEV guests with QEMU's -kernel/-initrd/-append switches (with the corresponding QEMU support for injecti

[edk2-devel] [PATCH v2 05/11] OvmfPkg: add NullBlobVerifierLib to DSC

2021-07-06 Thread Dov Murik
This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Ref: https://bugzilla.tianocore.org/show_bug

[edk2-devel] [PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

2021-07-06 Thread Dov Murik
In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a call to VerifyBlob after fetching to allow BlobVerifierLib implementations to add a verification step for these blobs. This will allow confidential computi

[edk2-devel] [PATCH v2 10/11] OvmfPkg: add SevHashesBlobVerifierLib

2021-07-06 Thread Dov Murik
Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in the hashes table. If there's a missing hash or a hash mismatch then EFI_ACCESS_DENIED is returned

[edk2-devel] [PATCH v2 02/11] OvmfPkg/AmdSev: use GenericQemuLoadImageLib in AmdSev builds

2021-07-06 Thread Dov Murik
Newer kernels support efistub and therefore don't need all the legacy stuff in X86QemuLoadImageLib, which are harder to secure. Specifically the verification of kernel/initrd/cmdlien blobs will be added only to the GenericQemuLoadImageLib implementation, so use that for SEV builds. Cc: Laszlo Ers

[edk2-devel] [PATCH v2 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page

2021-07-06 Thread Dov Murik
Round up the size of the SEV launch secret area to a whole page, as required by BuildMemoryAllocationHob. This will allow the secret area defined in the MEMFD to take less than a whole 4KB page. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erde

[edk2-devel] [PATCH v2 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation

2021-07-06 Thread Dov Murik
BlobVerifierLib will be used to verify blobs fetching them from QEMU's firmware config (fw_cfg) in platforms that enable such verification. The null implementation NullBlobVerifierLib treats all blobs as valid. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh

[edk2-devel] [PATCH v2 09/11] OvmfPkg/AmdSev: reserve MEMFD space for for firmware config hashes

2021-07-06 Thread Dov Murik
From: James Bottomley Split the existing 4KB page reserved for SEV launch secrets into two parts: first 3KB for SEV launch secrets and last 1KB for firmware config hashes. The area of the firmware config hashes will be attested (measured) by the PSP and thus the untrusted VMM can't pass in diffe

[edk2-devel] [PATCH v2 06/11] ArmVirtPkg: add NullBlobVerifierLib to DSC

2021-07-06 Thread Dov Murik
This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Ref: ht

[edk2-devel] [PATCH v2 01/11] OvmfPkg/AmdSev/SecretDxe: fix header comment to generic naming

2021-07-06 Thread Dov Murik
From: James Bottomley Commit 96201ae7bf97 ("OvmfPkg/AmdSev/SecretDxe: make secret location naming generic", 2020-12-15) replaced references to SEV with the generic term Confidential Computing, but missed the file header comment. Fix the naming in that header. Cc: Laszlo Ersek Cc: Ard Biesheuve

[edk2-devel] [PATCH v2 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-06 Thread Dov Murik
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 Booting with SEV prevented the loading of kernel, initrd, and kernel command-line via QEMU fw_cfg interface because they arrive from the VMM which is untrusted in SEV. However, in some cases the kernel, initrd, and cmdline are not secret but

[edk2-devel] [PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

2021-07-06 Thread Dov Murik
From: James Bottomley Support QEMU's -kernel option. OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c is an exact copy of OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c . Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas C

Re: [edk2-devel] [PATCH v4 2/3] Acpi: Install Acpi tables for Cloud hypervisor

2021-07-06 Thread Sami Mujawar
Hi Jianyong, I should have caught this earlier in my review. However, if you agree, I will do the following changes before pushing the patch. 1. The subject line of the commit message does not confirm to the edk2 coding standard. It should have ‘ArmVirtPkg: ’ 2. The ACPI table signat

[edk2-devel] Loading EFI module from disk and handing over execution

2021-07-06 Thread Andy Pont via groups.io
Originally sent to the edk2-discuss list but with no response. Resending to the edk2-devel list as it appears to have more traffic and active users. I am currently working on a project using tianocore as a payload for coreboot and have having some problems booting Qubes. When trying to boot t

[edk2-devel] "edk2-redfish-client" branch on edk2-staging

2021-07-06 Thread Abner Chang
Hi all, FYI, "edk2-redfish-client" branch is created on edk2-staging repository for the future contribution of EDK2 Redfish client implementation. The EDK2 Redfish client is implemented based on EDK2 Redfish foundation (RedfishPkg)to provide the remote platform configuration using EDK2 HII and t

Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Ignore PMBR BootIndicator per UEFI spec

2021-07-06 Thread Laszlo Ersek
On 07/05/21 11:36, Neal Gompa wrote: > Per UEFI Spec 2.8 (UEFI_Spec_2_8_final.pdf, page 114) > 5.2.3 Protective MBR > Table 20. Protective MBR Partition Record protecting the entire disk > > The description for BootIndicator states the following: > >> Set to 0x00 to indicate a non-bootable partit

[edk2-devel] [edk2-platforms: PATCH 1/1] Platform/Intel: Correct CPU APIC IDs.

2021-07-06 Thread Li, Daoxiang
From: JackX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: C