Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: Saturday, June 5, 2021 9:19 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Leif Lindholm ; Feng, Bob C
Subject: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to
convert the ima
Ray:
When convert the image to ACPI data, only data section is required. So, we
can update GenFw tool not do this check when convert ACPI data.
I just send the patch to update GenFw tool.
This issue happens on GCC49 tool chain. So, it is not detected in open CI
with GCC5 tool chain.
Bel
Cool! Thank you so much!!
It answers my question that why CI cannot detect such failure because it's
using GCC5+.
Leif,
Can you verify that this can resolve your GCC49 issue?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming
> Sent: Saturday, June 5
Leif,
OVMF Bhyve GCC build succeeds without GenFW assertion issue.
I dumped the ELF image generated for OvmfPkg/Bhyve/AcpiTables/AcpiTables.
Below output shows that .text does have "AX" set:
---
$ readelf -S Hpet.dll
...
[ 1] .text PROGBITS 0140
With GCC49 tool chain, aslc file is compiled into elf image.
But, its text section has no CODE attribute. So, it can't be detected
by new GenFw tool.For this type file. its text section is not required.
Its data section will be converted to acpi table.
This fix is to remove assert check when the g
Leif,
Sorry to hear that. It seems a CI gap that doesn't capture such errors.
It looks like the logic update to detect .text section doesn't work in your
case.
I am trying to build the OVMF Bhyve because I saw it contains an AcpiTables
module that has .aslc file.
Thanks,
Ray
> -Original M
On Wed, May 26, 2021 at 17:07:06 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides essential functions to initialize the PCIe Root Complex of
> Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
On Wed, May 26, 2021 at 17:07:04 +0700, Nhi Pham wrote:
> The AcpiHelperLib provides functions to update the ACPI DSDT table after
> this table is installed.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSim
On Wed, May 26, 2021 at 17:07:03 +0700, Nhi Pham wrote:
> The AcpiPccLib provides functions to allocate and get the physical
> address of PCC shared memory.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimo
On Wed, May 26, 2021 at 17:07:02 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> The idea came from DeviceManagerUiLib that all related menu settings can be
> placed under a common entry. This change intends to provide a central point
> for all platform menus by creating a Platform Manager entry loc
On Wed, May 26, 2021 at 17:07:01 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Non-volatile variables now can be stored on flash. MM communication
> protocol is used to access storage on flash.
>
> Included in this change are:
> * FlashPei module is used to compare saved UUID with firmware's
>
On Wed, May 26, 2021 at 17:07:00 +0700, Nhi Pham wrote:
> From: Quan Nguyen
>
> BootProgress will send 32-bit UEFI Status Code via doorbell to report
> its progress status.
> Currently support reporting Progress Status Code and Error Status Code
> only. Other types of Status Code are ignored.
>
On Wed, May 26, 2021 at 17:06:59 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This library adds the support for retrieving and updating system
> datetime over real RTC PCF85063 device on Mt. Jade platform instead of
> using virtual RTC.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
>
On Wed, May 26, 2021 at 17:06:58 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> The DwGpioLib library provides basic functions to control the GPIO
> controller on Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard
On Wed, May 26, 2021 at 17:06:57 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> The DwI2cLib library provides basic functions to control the I2C
> controller on Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard B
On Wed, May 26, 2021 at 17:06:56 +0700, Nhi Pham wrote:
> The FailSafeDxe driver reverts the system's configuration to known good
> values if the system fails to boot up multiple times. It also implements
> the Watchdog Timer Architectural Protocol to reset the system if it
> hangs.
>
> By default
On Wed, May 26, 2021 at 17:06:55 +0700, Nhi Pham wrote:
> The Ampere Altra System Firmware provides a fail-safe feature to help
> recover the system if there are setting changes such as Core voltage,
> DRAM parameters that cause the UEFI failed to boot.
>
> The FailSafeLib supports API calls to Se
On Wed, May 26, 2021 at 17:06:54 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> The MmCommunicationDxe module is derived from
> ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf.
>
> The MmCommunication PEI and DXE modules implement the MM Communication
> protocol (EFI_MM_COMMUNICATION_PROTOCO
On Wed, May 26, 2021 at 17:06:52 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This commit adds the support for Ampere’s Altra processor-based Mt. Jade
> platform that provides up to 160 processor cores in a dual socket
> configuration. The essential modules are wired up enough to boot system
> to
On 06/04/21 16:02, Anthony PERARD via groups.io wrote:
> On Wed, Jun 02, 2021 at 10:36:49AM +0200, Laszlo Ersek wrote:
>> Anthony, Julien,
>>
>> (or anyone else subscribed to xen-devel -- CC'd now),
>>
>> On 05/26/21 22:14, Laszlo Ersek wrote:
>>> Bugzilla: https://bugzilla.tianocore.org/show_bug.c
On Fri, 2021-06-04 at 15:52 +0100, Michael Brown wrote:
> On 04/06/2021 11:43, Michael Brown wrote:
> > On 04/06/2021 11:11, Laszlo Ersek wrote:
> > > And, to reiterate, just because Confidential Computing is the
> > > new hot thing, the use cases for OvmfPkgIa32, OvmfPkgIa32X64,
> > > OvmfPkgX64 d
On 04/06/2021 11:43, Michael Brown wrote:
On 04/06/2021 11:11, Laszlo Ersek wrote:
And, to reiterate, just because Confidential Computing is the
new hot thing, the use cases for OvmfPkgIa32, OvmfPkgIa32X64, OvmfPkgX64
do not disappear. Regressing them, or making them unmaintainable due to
skyroc
On 06/04/21 16:02, Anthony PERARD wrote:
> On Wed, Jun 02, 2021 at 10:36:49AM +0200, Laszlo Ersek wrote:
>> Anthony, Julien,
>>
>> (or anyone else subscribed to xen-devel -- CC'd now),
>>
>> On 05/26/21 22:14, Laszlo Ersek wrote:
>>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
>>>
On 05/27/21 01:10, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
>
> Extend the workarea to include the SEV-SNP enabled fields. This will be set
> when SEV-SNP is active in the guest VM.
>
> Cc: James Bottomley
> Cc: Min Xu
> Cc: Jiewen Yao
> Cc: Tom Lendacky
On Wed, Jun 02, 2021 at 10:36:49AM +0200, Laszlo Ersek wrote:
> Anthony, Julien,
>
> (or anyone else subscribed to xen-devel -- CC'd now),
>
> On 05/26/21 22:14, Laszlo Ersek wrote:
> > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> > Repo: https://pagure.io/lersek/edk2.git
>
Hi Nhi,
Apologies, this dragged out a bit longer than I intended.
Some high-level comments before I get into the contents:
In order to build this against current upstream, I needed to go back
to edk2 commit
c1aa3bab1259 ("BaseTools: Add ClangBase.lds for CLANG8 tool chain with
max-page-size")
Tha
On 05/27/21 01:10, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
>
> Create a function that can be used to determine if VM is running as an
> SEV-SNP guest.
>
> Cc: James Bottomley
> Cc: Min Xu
> Cc: Jiewen Yao
> Cc: Tom Lendacky
> Cc: Jordan Justen
> Cc: Ard
Hi Vu,
For this set:
Reviewed-by: Leif Lindholm
Is there any value to you in me pushing this before the edk2-platforms
set goes in? If not, I'll hold back and push them both at the same
time.
Best Regards,
Leif
On Wed, May 26, 2021 at 17:18:28 +0700, Vu Nguyen wrote:
> Create edk2-non-osi com
Hi Ray,
On Wed, Jun 02, 2021 at 16:11:41 +0800, Ni, Ray wrote:
> From: Liming Gao
>
> CLANG8ELF tool chain generated ELF image with the different attributes
> in section. Update GenFw to handle them.
> 1. .text section with writable attribute (support)
> 2. .reloc section has the symbol for *ABS
On 06/04/21 13:50, Brijesh Singh wrote:
> Hi Laszlo,
>
> On 6/4/21 4:32 AM, Laszlo Ersek wrote:
>> Hi Brijesh,
>>
>> On 05/27/21 01:10, Brijesh Singh wrote:
>>> (I missed adding devel@edk2.groups.io, resending the series)
>>>
>>> BZ:
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3
Hi Laszlo,
On 6/4/21 4:32 AM, Laszlo Ersek wrote:
> Hi Brijesh,
>
> On 05/27/21 01:10, Brijesh Singh wrote:
>> (I missed adding devel@edk2.groups.io, resending the series)
>>
>> BZ:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3
On 06/04/21 12:30, Dov Murik wrote:
> So I argue to keep the existing approach with two separate areas:
> existing one for injected secrets, and new one for a table of approved
> hashes (filled by QEMU and updated as initial encrypted measured guest
> memory).
OK.
> If the issue is MEMFD space,
On 04/06/2021 11:11, Laszlo Ersek wrote:
And, to reiterate, just because Confidential Computing is the
new hot thing, the use cases for OvmfPkgIa32, OvmfPkgIa32X64, OvmfPkgX64
do not disappear. Regressing them, or making them unmaintainable due to
skyrocketing complexity, is not acceptable.
Tot
Thank you Laszlo for reviewing this.
On 01/06/2021 15:11, Laszlo Ersek wrote:
> Ard,
>
> I'll have a specific question for you below; please feel free to jump
> forward (search for your name). Thanks.
>
> Dov, my comments below:
>
> On 05/25/21 07:31, Dov Murik wrote:
>> Booting with SEV preve
thank you Laszlo. Your feedback is received.
I am waiting for comment from other people.
thank you!
Yao, Jiewen
> 在 2021年6月4日，下午6:11，Laszlo Ersek 写道：
>
> On 06/04/21 01:19, Yao, Jiewen wrote:
>> Hi Laszlo.
>>
>> To clarify your "one binary" feedback below, do you mean you suggest A)
>> cre
On 06/04/21 01:19, Yao, Jiewen wrote:
> Hi Laszlo.
>
> To clarify your "one binary" feedback below, do you mean you suggest A)
> create a separate DSC (for example OvmfPkg/ConfidentialComputing.dsc) for a
> full solution including AMD SEC + Intel TDX + NonConfidentialComputing?
> Or B) to create
>From SysTableInfo Hob, get ACPI table address, and creat gPldAcpiTableGuid Hob
to store it. Remove diretly adding ACPI table to ConfigurationTable.
Dxe ACPI driver will parse it and install ACPI table from Guid Hob.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
Cc: Ray Ni
Signed-off-by: Zhigua
>From SysTableInfo Hob, get Smbios table address, and creat gPldSmbiosTableGuid
>Hob
to store it. Remove diretly adding smbios table to ConfigurationTable.
Dxe module SmbiosDxe will parse it and install smbios table from it.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
Reviewed-by: Guo Dong
S
V1:
The default EfiSmbiosProtocol operates on an empty SMBIOS table.
The SMBIOS tables are provided by the bootloader on UefiPayloadPkg.
Scan for existing tables in SmbiosDxe and load them if they seem valid.
This fixes the settings menu not showing any hardware information, instead
only "0 MB RAM
V1:
If HOB contains APCI table information, entry point of AcpiTableDxe.inf
should parse the APCI table from HOB, and install these tables.
We assume the whole ACPI table (starting with
EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER)
is contained by a single gEfiAcpiTableGuid HOB.
V2:
If error happ
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Zhiguang Liu
---
MdeModulePkg/Include/UniversalPayload/SmbiosTable.h | 28
MdeModulePkg/MdeModulePkg.dec | 6 ++
2 files changed, 34 insertions(+)
diff --
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Zhiguang Liu
---
MdeModulePkg/Include/UniversalPayload/AcpiTable.h | 28
MdeModulePkg/MdeModulePkg.dec | 3 +++
2 files changed, 31 insertions(+)
diff --git a/M
UefiPayload parse gPldPciRootBridgeInfoGuid Guid Hob to retrieve PCI root
bridges
information. gPldPciRootBridgeInfoGuid Guid Hob should be created by Bootloader.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
Signed-off-by: Zhiguang Liu
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBrid
V1:
This patch set is based on Universal Payload on
https://universalpayload.github.io/documentation/payload-interfaces/index.html
This patch set introduce one general header, three different hob types and how
Universal Payload consume these hobs.
V2:
Move all the header files and Guid define to
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Zhiguang Liu
---
MdeModulePkg/Include/UniversalPayload/PciRootBridges.h | 89
+
MdeModulePkg/MdeModulePkg.dec
V1:
Add Universal Payload general defination header file according to
Universal Payload’s documentation
V2:
Add a macro funtion to check the Revision
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Zhiguang Liu
---
MdeModulePkg/Include/UniversalPayload/Univer
Hi Brijesh,
On 05/27/21 01:10, Brijesh Singh wrote:
> (I missed adding devel@edk2.groups.io, resending the series)
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
>
> SEV-SNP builds upon existing SEV and SEV-ES functionality while adding
> new hardware-based memory protections. SEV-SNP
Created a PR https://github.com/tianocore/edk2/pull/1688
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: Friday, June 4, 2021 1:42 PM
To: devel@edk2.groups.io; Ni, Ray
Subject: 回复: [edk2-devel] [PATCH v2 0/6] Add CLANGDWARF toolchain for universal
Internally reviewed this patch before sending the edk2 mailing list and it
looks good to me.
Reviewed-by: Sunny Wang
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
; Sunny Wang ;
m...@semihalf.com; upstr...@sem
Internally reviewed this patch before sending the edk2 mailing list and Greg
already addressed all my comments, so It looks good to me.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviainc.com;
Internally reviewed this patch before sending the edk2 mailing list and It
looks good to me. Please also address Pete's good catches/comments.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviain
Internally reviewed this patch before sending the edk2 mailing list and Greg
already addressed all my comments, so It looks good to me.
Reviewed-by: Sunny Wang
As for Bret's comment, the "#define FAIL(fmt...).. " was added for addressing
my internal review comment for better maintenance. If thi
Grzegorz
Have you built this feature with different tool chains, such as
VS2017/VS2019/GCC5? And test it in IA32/X64/AARCH64?
Would you post your test result in the mail?
Thanks much!
> -Original Message-
> From: Grzegorz Bernacki
> Sent: Tuesday, June 1, 2021 9:12 PM
> To: devel@edk2.gr
Internally reviewed this patch before sending the edk2 mailing list and It
looks good to me. Please also address Pete's good catches/comments.
Reviewed-by: Sunny Wang
-Original Message-
From: Grzegorz Bernacki
Sent: Tuesday, June 1, 2021 9:12 PM
To: devel@edk2.groups.io
Cc: l...@nuviain
Internally reviewed this patch before sending the edk2 mailing list and It
looks good to me. Please also address Min M's good catch/comment.
Reviewed-by: Sunny Wang
Hi Laszlo,
if you have time, I think you can still review this patch because this patch is
a simple one and is based on your valua
On June 1, 2021 9:12 PM, Grzegorz Bernacki Wrote:
> This commits adds modules related to initialization and usage of default
> Secure Boot key variables to SecurityPkg.
>
> Signed-off-by: Grzegorz Bernacki
> ---
> SecurityPkg/SecurityPkg.dec | 14 ++
> SecurityPkg/SecurityPkg.dsc | 4
On June 1, 2021 9:12 PM, Grzegorz Bernacki Wrote:
> This driver initializes default Secure Boot keys and databases based on keys
> embedded in flash.
>
> Signed-off-by: Grzegorz Bernacki
> ---
>
> SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootD
> efaultKeysDxe.inf | 46 +++
Internally reviewed this patch before sending the edk2 mailing list and Greg
already addressed all my comments, so It looks good to me. Please also address
Bret and Min M's good catches/comments.
Moreover, for Bret's comment about CreateTimeBasedPayload (), I think we only
missed one instance in
On 06/04/2021 12:12 AM, Laszlo wrote:
> On 06/03/21 15:51, Yao, Jiewen wrote:
> > Hi, All
> > We plan to do a design review for TDVF in OVMF package.
> >
> >
> > The TDVF Design slides for TinaoCore Design Review Meeting (Jun 11) is
> > now available in blow link:
> > https://edk2.groups.io/g/devel
59 matches
Mail list logo
