回复: [edk2-devel] [PATCH v2 0/6] Add CLANGDWARF toolchain for universal payload needs

2021-06-03 Thread gaoliming
Ray: Thanks for your update. Reviewed-by: Liming Gao for this patch set. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ni, Ray > 发送时间: 2021年6月2日 16:12 > 收件人: devel@edk2.groups.io > 主题: [edk2-devel] [PATCH v2 0/6] Add CLANGDWARF toolchain for universal > payload needs > > Univ

[edk2-devel] [Patch V2 1/9] MdeModulePkg: Add Universal Payload general defination header file

2021-06-03 Thread Zhiguang Liu
V1: Add Universal Payload general defination header file according to Universal Payload’s documentation V2: Add a macro funtion to check the Revision Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg/Include/UniversalPayload/Univer

[edk2-devel] [Patch V2 8/9] MdeModulePkg/ACPI: Install ACPI table from HOB.

2021-06-03 Thread Zhiguang Liu
V1: If HOB contains APCI table information, entry point of AcpiTableDxe.inf should parse the APCI table from HOB, and install these tables. We assume the whole ACPI table (starting with EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER) is contained by a single gEfiAcpiTableGuid HOB. V2: If error happ

[edk2-devel] [Patch V2 6/9] UefiPayloadPkg: Creat gPldSmbiosTableGuid Hob

2021-06-03 Thread Zhiguang Liu
>From SysTableInfo Hob, get Smbios table address, and creat gPldSmbiosTableGuid >Hob to store it. Remove diretly adding smbios table to ConfigurationTable. Dxe module SmbiosDxe will parse it and install smbios table from it. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Reviewed-by: Guo Dong S

[edk2-devel] [Patch V2 9/9] UefiPayloadPkg: Creat gPldAcpiTableGuid Hob

2021-06-03 Thread Zhiguang Liu
>From SysTableInfo Hob, get ACPI table address, and creat gPldAcpiTableGuid Hob to store it. Remove diretly adding ACPI table to ConfigurationTable. Dxe ACPI driver will parse it and install ACPI table from Guid Hob. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Ray Ni Signed-off-by: Zhigua

[edk2-devel] [Patch V2 4/9] MdeModulePkg: Add new structure for the Universal Payload SMBios Table Info Hob

2021-06-03 Thread Zhiguang Liu
Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg/Include/UniversalPayload/SmbiosTable.h | 28 MdeModulePkg/MdeModulePkg.dec | 6 ++ 2 files changed, 34 insertions(+) diff --

[edk2-devel] [Patch V2 7/9] MdeModulePkg: Add new structure for the Universal Payload ACPI Table Info Hob

2021-06-03 Thread Zhiguang Liu
Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg/Include/UniversalPayload/AcpiTable.h | 28 MdeModulePkg/MdeModulePkg.dec | 3 +++ 2 files changed, 31 insertions(+) diff --git a/M

[edk2-devel] [Patch V2 0/9] Create multiple Hobs for Universal Payload

2021-06-03 Thread Zhiguang Liu
V1: This patch set is based on Universal Payload on https://universalpayload.github.io/documentation/payload-interfaces/index.html This patch set introduce one general header, three different hob types and how Universal Payload consume these hobs. V2: Move all the header files and Guid define to

[edk2-devel] [Patch V2 5/9] MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables

2021-06-03 Thread Zhiguang Liu
V1: The default EfiSmbiosProtocol operates on an empty SMBIOS table. The SMBIOS tables are provided by the bootloader on UefiPayloadPkg. Scan for existing tables in SmbiosDxe and load them if they seem valid. This fixes the settings menu not showing any hardware information, instead only "0 MB RAM

[edk2-devel] [Patch V2 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob

2021-06-03 Thread Zhiguang Liu
Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg/Include/UniversalPayload/PciRootBridges.h | 89 + MdeModulePkg/MdeModulePkg.dec

[edk2-devel] [Patch V2 3/9] UefiPayloadPkg: UefiPayload retrieve PCI root bridge from Guid Hob

2021-06-03 Thread Zhiguang Liu
UefiPayload parse gPldPciRootBridgeInfoGuid Guid Hob to retrieve PCI root bridges information. gPldPciRootBridgeInfoGuid Guid Hob should be created by Bootloader. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Signed-off-by: Zhiguang Liu --- UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBrid

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

2021-06-03 Thread Satoshi Tanda
Thank you, Liming! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76030): https://edk2.groups.io/g/devel/message/76030 Mute This Topic: https://groups.io/mt/83300488/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.

回复: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

2021-06-03 Thread gaoliming
Reviewed-by: Liming Gao I have updated BZ link and title in the commit message. Create PR https://github.com/tianocore/edk2/pull/1687 Thanks Liming 发件人: devel@edk2.groups.io 代表 Satoshi Tanda 发送时间: 2021年6月4日 8:24 收件人: Laszlo Ersek ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH]

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-06-03 Thread Rebecca Cran
Is there any way I can help? For example I have a Mac Pro I could give you remote access to. -- Rebecca Cran On 5/23/21 3:00 PM, Andrew (EFI) Fish wrote: I’ll take a look . I need to grab a blank system and give it a try. Sent from my iPhone On May 23, 2021, at 9:12 AM, Rebecca Cran wro

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload

2021-06-03 Thread Wu, Hao A
Hello Ray, Yes, it looks to good me. Thanks a lot for the support. Best Regards, Hao Wu > -Original Message- > From: Ni, Ray > Sent: Friday, June 4, 2021 9:01 AM > To: Wu, Hao A ; devel@edk2.groups.io; Liu, Zhiguang > > Cc: Kinney, Michael D ; Liming Gao > ; Ma, Maurice ; Dong, > Guo

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload

2021-06-03 Thread Ni, Ray
Hao, Sure. I will send patch to change Maintainers.txt putting Zhiguang and me on the reviewer list for Include/UniversalPayload after this is merged. For the specific changes in AcpiTableDxe and SmbiosDxe, I will discuss with Zhiguang and send changes to append him on reviewer list of ACPI Modu

Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

2021-06-03 Thread Satoshi Tanda
Could we get this patch reviewed and approved by required folks, or advise me how can I move forward? Thanks! Satoshi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76025): https://edk2.groups.io/g/devel/message/76025 Mute This Topic: h

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

2021-06-03 Thread Yao, Jiewen
Hi Laszlo. To clarify your "one binary" feedback below, do you mean you suggest A) create a separate DSC (for example OvmfPkg/ConfidentialComputing.dsc) for a full solution including AMD SEC + Intel TDX + NonConfidentialComputing? Or B) to create a standalone DSC for Intel TDX (for example, crea

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

2021-06-03 Thread Laszlo Ersek
On 06/03/21 15:51, Yao, Jiewen wrote: > Hi, All > We plan to do a design review for TDVF in OVMF package. > > > The TDVF Design slides for TinaoCore Design Review Meeting (Jun 11) is > now available in blow link: > https://edk2.groups.io/g/devel/files/Designs/2021/0611. > > The Bugzilla is https://

[edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

2021-06-03 Thread Yao, Jiewen
Hi, All We plan to do a design review for TDVF in OVMF package. The TDVF Design slides for TinaoCore Design Review Meeting (Jun 11) is now available in blow link: https://edk2.groups.io/g/devel/files/Designs/2021/0611. The Bugzilla is https://bugzilla.tianocore.org/show_bug.cgi?id=3429 You c

Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs

2021-06-03 Thread Laszlo Ersek
On 05/27/21 01:10, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Define the PCDs used by the MpLib while creating the AP when SEV-SNP is > active in the guest VMs. (1) I think MpLib should be MpInitLib. (2) If it's not too annoying, I'd suggest using "APs" (p

Re: [edk2-devel] [PATCH RFC v3 22/22] MdePkg/GHCB: increase the GHCB protocol max version

2021-06-03 Thread Laszlo Ersek
Copying the MdePkg reviewers. Thanks Laszlo On 05/27/21 01:11, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Now that OvmfPkg supports version 2 of the GHCB specification, bump the > protocol version. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao

Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs

2021-06-03 Thread Laszlo Ersek
On 06/03/21 14:16, Brijesh Singh wrote: > > On 6/3/21 3:15 AM, Laszlo Ersek wrote: >> Hi Brijesh, >> >> On 05/27/21 01:10, Brijesh Singh wrote: >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.si

Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs

2021-06-03 Thread Brijesh Singh via groups.io
On 6/3/21 3:15 AM, Laszlo Ersek wrote: > Hi Brijesh, > > On 05/27/21 01:10, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cb4d27ba148e544f984ee08d92667d860

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Readme.md: Refer users to the Arm GNU-A Downloads page for toolchains

2021-06-03 Thread Leif Lindholm
Hi Sami, No issue from my end, please go ahead. Reviewed-by: Leif Lindholm On Wed, Jun 02, 2021 at 09:52:33 +0100, Sami Mujawar wrote: > Hi Leif, > > If there are no further comments on this patch, may I have your RB and > permission to merge this change, please? > > Regards, > > Sami Mujaw

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-03 Thread Laszlo Ersek
Hi James, thanks for the answer, one comment below: On 06/02/21 20:10, James Bottomley wrote: > On Tue, 2021-06-01 at 14:11 +0200, Laszlo Ersek wrote: >> Ard, >> >> I'll have a specific question for you below; please feel free to jump >> forward (search for your name). Thanks. >> >> Dov, my comme

Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs

2021-06-03 Thread Laszlo Ersek
Hi Brijesh, On 05/27/21 01:10, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Define the PCDs used by the MpLib while creating the AP when SEV-SNP is > active in the guest VMs. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc:

Re: [edk2-devel] [PATCH v2 2/6] SecurityPkg: Create include file for default key content.

2021-06-03 Thread Min Xu
On Tuesday, June 1, 2021 9:12 PM, Grzegorz Bernacki Wrote: > This commits add file which can be included by platform Flash Description > File. It allows to specify certificate files, which will be embedded into > binary > file. The content of these files can be used to initialize Secure Boot defau