[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Support queued invalidation interface

2021-04-29 Thread Sheng Wei
Add queued invalidation interface support for VTd core driver. For software to invalidate the various caching structures, the architecture supports the following two types of invalidation interfaces. 1. Register-based invalidation interface 2. Queued invalidation interface. BIOS shall check VER_RE

[edk2-devel] Updated Event: TianoCore Bug Triage - APAC / NAMO #cal-invite

2021-04-29 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, 4 May 2021 #cal-cancelled

2021-04-29 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAM

Re: [edk2-devel] [PATCH v1] Intel/TigerlakeOpenBoardPkg: Simplify microcode related PCD usage

2021-04-29 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty < rangasai.v.chaga...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74622): https://edk2.groups.io/g/devel/message/74622 Mute This Topic: https://groups.io/mt/82355106/21656 Group Owner: devel+ow...@

Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

2021-04-29 Thread Bret Barkelew via groups.io
This change should also be made in: UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLibDebugLib.c UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLib.c (for the prototype) - Bret From: Getnat Ejigu Sent: Thursday, Ap

[edk2-devel] [PATCH v1 0/1] Sample unit test hangs when running in OVMF/QEMU

2021-04-29 Thread Getnat Ejigu
*** BLURB HERE *** Getnat Ejigu (1): UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You r

[edk2-devel] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

2021-04-29 Thread Getnat Ejigu
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew --- UnitTestFrame

Re: [edk2-devel] [PATCH 1/2] Silicon/Broadcom/BcmGenetDxe: Delay for linkup in transmit

2021-04-29 Thread Andrei Warkentin
Looks fine to me Reviewed-by: Andrei Warkentin From: Jeremy Linton Sent: Thursday, April 15, 2021 2:22 PM To: devel@edk2.groups.io Cc: ard.biesheu...@arm.com ; l...@nuviainc.com ; p...@akeo.ie ; samer.el-haj-mahm...@arm.com ; Andrei Warkentin ; Jeremy Linton

Re: [edk2-devel] [PATCH 1/2] Silicon/Broadcom/BcmGenetDxe: Delay for linkup in transmit

2021-04-29 Thread Jeremy Linton
+Jared McNeill for review. Thanks, On 4/15/21 2:22 PM, Jeremy Linton wrote: Under normal circumstances GenetSimpleNetworkTransmit won't be called unless the rest of the network stack detects the link is up. So, during normal operation when the adapter is initialized the link naturally transitio

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 30 April 2021 #cal-cancelled

2021-04-29 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM

Re: [edk2-devel] [PATCH v3 3/5] OvmfPkg: Define a new PPI GUID to signal TPM MMIO accessability

2021-04-29 Thread Lendacky, Thomas
On 4/29/21 12:12 PM, Tom Lendacky wrote: > Define a new PPI GUID that is to be used as a signal of when it is safe > to access the TPM MMIO range. This is needed so that, when SEV is active, > the MMIO range can be mapped unencrypted before it is accessed. > > Cc: Laszlo Ersek > Cc: Ard Biesheuve

Re: [edk2-devel] [PATCH v3 2/5] OvmfPkg/VmgExitLib: Add support for new MMIO MOV opcodes

2021-04-29 Thread Lendacky, Thomas
On 4/29/21 12:12 PM, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 > > Enabling TPM support results in guest termination of an SEV-ES guest > because it uses MMIO opcodes that are not currently supported. > > Add support for the new MMIO opcodes (0xA0 - 0xA3), MOV

[edk2-devel] [PATCH v3 4/5] OvmfPkg/Tcg2ConfigPei: Mark TPM MMIO range as unencrypted for SEV-ES

2021-04-29 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 During PEI, the MMIO range for the TPM is marked as encrypted when running as an SEV guest. While this isn't an issue for an SEV guest because of the way the nested page fault is handled, it does result in an SEV-ES guest terminating because

[edk2-devel] [PATCH v3 5/5] OvmfPkg/Tcg2ConfigPei: Update Depex for IA32 and X64

2021-04-29 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 The OVMF Tcg2Config PEIM adds the gOvmfTpmMmioAccessiblePpiGuid as a Depex for IA32 and X64 builds so that the MMIO range is properly mapped as unencrypted for an SEV-ES guest before the Tcg2Config PEIM is loaded. Cc: Laszlo Ersek Cc: Ard B

[edk2-devel] [PATCH v3 3/5] OvmfPkg: Define a new PPI GUID to signal TPM MMIO accessability

2021-04-29 Thread Lendacky, Thomas
Define a new PPI GUID that is to be used as a signal of when it is safe to access the TPM MMIO range. This is needed so that, when SEV is active, the MMIO range can be mapped unencrypted before it is accessed. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Ak

[edk2-devel] [PATCH v3 2/5] OvmfPkg/VmgExitLib: Add support for new MMIO MOV opcodes

2021-04-29 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 Enabling TPM support results in guest termination of an SEV-ES guest because it uses MMIO opcodes that are not currently supported. Add support for the new MMIO opcodes (0xA0 - 0xA3), MOV instructions which use a memory offset directly encod

[edk2-devel] [PATCH v3 1/5] OvfmPkg/VmgExitLib: Properly decode MMIO MOVZX and MOVSX opcodes

2021-04-29 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 The MOVZX and MOVSX instructions use the ModRM byte in the instruction, but the instruction decoding support was not decoding it. This resulted in invalid decoding and failing of the MMIO operation. Also, when performing the zero-extend or si

[edk2-devel] [PATCH v3 0/5] SEV-ES TPM enablement fixes

2021-04-29 Thread Lendacky, Thomas
This patch series provides fixes for using TPM support with an SEV-ES guest. The fixes include: - Decode ModRM byte for MOVZX and MOVSX opcodes. - Add MMIO support for MOV opcodes 0xA0-0xA3. - Create a new TPM MMIO ready PPI guid, gOvmfTpmMmioAccessiblePpiGuid - Mark TPM MMIO range as un-encrypte

Re: [edk2-devel] Problem: TPM 2.0 event log by OVMF is shown empty in Linux kernel versions after 5.8

2021-04-29 Thread Thore Sommer
This is somewhat tricky to get right in grub, so you can rule this out by booting ovmf to a shell and then executing vmlinuz directly from the shell. I've now tried this and unfortunately it produces the same result. The ACPI "TPM2" table is there and the tpm eventlog is empty. Thore -=-=-=-=

Re: [edk2-devel] Problem: TPM 2.0 event log by OVMF is shown empty in Linux kernel versions after 5.8

2021-04-29 Thread Thore Sommer
I think I found my problem. The latest kernel from master probes if the table actually includes some values. This was introduced in 3dcd15665aca80197333500a4be3900948afccc1 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3dcd15665aca80197333500a4be3900948afccc1 Thi

Re: [edk2-devel] 回复: [PATCH 3/3] SecurityPkg: Add support for RngDxe on AARCH64

2021-04-29 Thread Rebecca Cran
On 4/28/21 7:13 PM, gaoliming wrote: Rebecca: -邮件原件- 发件人: Rebecca Cran 发送时间: 2021年4月29日 4:44 收件人: devel@edk2.groups.io 抄送: Rebecca Cran ; Jiewen Yao ; Jian J Wang ; Michael D Kinney ; Liming Gao ; Zhiguang Liu ; Ard Biesheuvel ; Sami Mujawar 主题: [PATCH 3/3] SecurityPkg: Add support fo

Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2021-04-29 Thread Samer El-Haj-Mahmoud
All, Please take a moment to add any comments to this UEFI ECR BZ. This is needed to UEFI Forum can make a decision and close the ECR. https://bugzilla.tianocore.org/show_bug.cgi?id=3336 Thanks, --Samer > -Original Message- > From: devel@edk2.groups.io On Behalf Of Samer > El-Haj-Ma

Re: [edk2-devel] [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer

2021-04-29 Thread Samer El-Haj-Mahmoud
Any further comments on the ACPI ECR documented in: https://bugzilla.tianocore.org/show_bug.cgi?id=3335 ? I already have comments from Jeremey and Andrew saying it looks good. If there are no objections, I will let ASWG know to approve the ECR for future ACPI spec publication. Thanks, --Samer

Re: [edk2-devel] [PATCH 3/3] SecurityPkg: Add support for RngDxe on AARCH64

2021-04-29 Thread Ard Biesheuvel
On Wed, 28 Apr 2021 at 22:44, Rebecca Cran wrote: > > AARCH64 support has been added to BaseRngLib via the optional > ARMv8.5 FEAT_RNG. > > Refactor RngDxe to support AARCH64, note support for it in the > VALID_ARCHITECTURES line of RngDxe.inf and enable it in SecurityPkg.dsc. > > Signed-off-by: R