[edk2-devel] [PATCH] Platform/ARM/VExpressPkg: Fix unused but set

2021-04-23 Thread Adrián Herrera
Remove unused but set variables in GetArmNameSpaceObject. These caused a build crash due to -Werror=unused-but-set-variable. Signed-off-by: Adrián Herrera --- .../ConfigurationManagerDxe/ConfigurationManager.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/Platform/ARM/VExpre

[edk2-devel] [PATCH] ArmPkg/ArmGicLib: fix maximum interrupts supported

2021-04-23 Thread Adrián Herrera
The maximum number of interrupts supported is determined as 32 * (GICD_TYPER.ITLinesNumber + 1). When GICD_TYPER.ITLinesNumber = 0b1, the maximum number of interrupts supported is 1024. However, both GICv2 and GICv3 reserve INTIDs 1020-1023 for special purposes. This results in runtime crashe

Re: [edk2-devel] [edk2-platforms PATCH v2 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions

2021-04-23 Thread Rebecca Cran
v2 has no changes other than adding a newline at the end of Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c and reverting the change to SbsaQemu.dec. -- Rebecca Cran On 4/23/21 3:57 PM, Rebecca Cran wrote: Add new SMBIOS Type 32 boot information and Type 3 chassis status functions that have be

[edk2-devel] [edk2-platforms PATCH v2 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions

2021-04-23 Thread Rebecca Cran
Add new SMBIOS Type 32 boot information and Type 3 chassis status functions that have been added to OemMiscLib in ArmPkg. Since this is a virtual platform, return fixed values for the chassis statuses. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 +

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-23 Thread Lendacky, Thomas
On 4/23/21 12:41 PM, Tom Lendacky wrote: > On 4/23/21 8:04 AM, Laszlo Ersek wrote: >> On 04/23/21 12:26, Laszlo Ersek wrote: >>> review#2 from scratch: >>> >>> On 04/21/21 00:54, Tom Lendacky wrote: From: Tom Lendacky BZ: https://nam11.safelinks.protection.outlook.com/?url=htt

Re: [edk2-devel] [edk2-platforms PATCH 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions

2021-04-23 Thread Leif Lindholm
On Fri, Apr 16, 2021 at 16:26:49 -0600, Rebecca Cran wrote: > Add new SMBIOS Type 32 boot information and Type 3 chassis status > functions that have been added to OemMiscLib in ArmPkg. > > Since this is a virtual platform, return fixed values for the chassis > statuses. > > Signed-off-by: Rebecc

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-23 Thread Lendacky, Thomas
On 4/23/21 8:04 AM, Laszlo Ersek wrote: > On 04/23/21 12:26, Laszlo Ersek wrote: >> review#2 from scratch: >> >> On 04/21/21 00:54, Tom Lendacky wrote: >>> From: Tom Lendacky >>> >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3F

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/VmgExitLib: Add support for new MMIO MOV opcodes

2021-04-23 Thread Lendacky, Thomas
On 4/23/21 4:10 AM, Laszlo Ersek wrote: > On 04/22/21 17:42, Tom Lendacky wrote: >> On 4/22/21 9:15 AM, Tom Lendacky wrote: >>> On 4/22/21 12:50 AM, Laszlo Ersek via groups.io wrote: On 04/21/21 00:54, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: > https://nam11.safel

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-23 Thread Laszlo Ersek
On 04/23/21 15:04, Laszlo Ersek wrote: > There are several advantages to such a separate PEIM: > > - For Bhyve, the update is minimal. Just include one line in each of the > FDF and the DSC files. No need to customize an existent > platform-specific PEIM, no code duplication between two PlatformP

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-23 Thread Laszlo Ersek
On 04/23/21 12:26, Laszlo Ersek wrote: > review#2 from scratch: > > On 04/21/21 00:54, Tom Lendacky wrote: >> From: Tom Lendacky >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 >> >> The TPM support in OVMF performs MMIO accesses during the PEI phase. At >> this point, MMIO ranges h

Re: [edk2-devel] [PATCH] Maintainers.txt: Add 'Erdem Aktas' to Confidential Computing reviewers

2021-04-23 Thread Laszlo Ersek
On 04/22/21 17:05, Erdem Aktas via groups.io wrote: > Add 'Erdem Aktas' as a reviewer for OvmfPkg/Confidential Computing. > > Signed-off-by: Erdem Aktas > --- > Maintainers.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index fda3df5de2..cafe6b1

Re: [edk2-devel] [PATCH v1 1/4] ArmVirtPkg: Library: Memory initialization for Cloud Hypervisor

2021-04-23 Thread Laszlo Ersek
Hi Jianyong, On 04/22/21 15:56, Laszlo Ersek wrote: > (2) "Clh" is a catastrophically bad abbreviation. The whole point of > your work is to add Cloud Hypervisor support, so why trash the most > relevant information in the file names with an inane abbreviation? > > (Not to mention that the name

[edk2-devel] [PATCH v2] BaseTools: Add support for version 3 of FMP Image Header structure

2021-04-23 Thread Sughosh Ganu
Add support for the ImageCapsuleSupport field, introduced in version 3 of the EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER structure. This structure member is used to indicate if the corresponding payload has support for authentication and dependency. Signed-off-by: Sughosh Ganu --- Changes sinc

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-23 Thread Laszlo Ersek
review#2 from scratch: On 04/21/21 00:54, Tom Lendacky wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 > > The TPM support in OVMF performs MMIO accesses during the PEI phase. At > this point, MMIO ranges have not been marked un-encyrpted, so an SEV-ES >

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-23 Thread Laszlo Ersek
On 04/22/21 21:10, Tom Lendacky wrote: > On 4/22/21 3:39 AM, Laszlo Ersek wrote: >> On 04/22/21 09:34, Laszlo Ersek wrote: >> >>> The new InternalTpmDecryptAddressRange() function should be called >>> from Tcg2ConfigPeimEntryPoint(), before the latter calls >>> InternalTpm12Detect(). Regarding erro

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/VmgExitLib: Add support for new MMIO MOV opcodes

2021-04-23 Thread Laszlo Ersek
On 04/22/21 17:42, Tom Lendacky wrote: > On 4/22/21 9:15 AM, Tom Lendacky wrote: >> On 4/22/21 12:50 AM, Laszlo Ersek via groups.io wrote: >>> On 04/21/21 00:54, Lendacky, Thomas wrote: From: Tom Lendacky BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbu

Re: [edk2-devel] [PATCH 1/3] OvfmPkg/VmgExitLib: Properly decode MMIO MOVZX and MOVSX opcodes

2021-04-23 Thread Laszlo Ersek
On 04/22/21 15:35, Tom Lendacky wrote: > On 4/22/21 12:28 AM, Laszlo Ersek wrote: >> On 04/21/21 00:54, Lendacky, Thomas wrote: >>> From: Tom Lendacky >>> >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3345&data=04%7C01%7

Re: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro an error (GCC)

2021-04-23 Thread Daniel Schaefer
Ok sure, let's make only undef an error, not all other warnings. Then the behaviour will also be the same as on MSVC. From: devel@edk2.groups.io on behalf of Daniel Schaefer Sent: Monday, March 8, 2021 11:44 To: Feng, Bob C ; devel@edk2.groups.io Cc: Liming Ga

Re: [edk2-devel] 回复: [PATCH v1 2/2] BaseTools: Make undefined VFR macro an error (MSVC)

2021-04-23 Thread Daniel Schaefer
Ok, I'll send a new series without EBC. Can't find anything about it and we don't use it. From: Schaefer, Daniel Sent: Thursday, March 4, 2021 10:46 To: gaoliming ; devel@edk2.groups.io Cc: 'Bob Feng' ; 'Yuwei Chen' ; Lin, Derek (HPS SW) Subject: Re: 回复: [PATC