Re: [edk2-devel] [PATCH] * MdePkg/SmBios.h: Updated newly added socket info from smbios 3.4.

2021-04-20 Thread Chaganty, Rangasai V
Please also update SmbiosView library in ShellPkg with the new socket types. With that: Reviewed-by: Sai Chaganty -Original Message- From: Bhargava, Avinash Sent: Tuesday, April 20, 2021 7:39 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty; Chaganty, Rangasai V ; Liming Gao ; Kumar;

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-20 Thread Eric van Tassell
On 4/20/21 5:54 PM, Tom Lendacky wrote: From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 The TPM support in OVMF performs MMIO accesses during the PEI phase. At where are the phases defined and how many other are there? this point, MMIO ranges have not been mar

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

2021-04-20 Thread Yao, Jiewen
HI Sachin Sorry, I forget to add link for the reference. 1) TPM2 Library Specification, part 2 structure (https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p64_Part2_Structures_15may2021.pdf) describes the PSS salt length. For the TPM_ALG_RSAPSS signing scheme, ... The salt s

Re: [edk2-devel] separate OVMF binary for TDX? [was: OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest]

2021-04-20 Thread Yao, Jiewen
Hello Do we have some conclusion on this topic? Do we agree the one-binary solution in OVMF or we need more discussion? Thank you Yao Jiewen > -Original Message- > From: Erdem Aktas > Sent: Friday, April 16, 2021 3:43 AM > To: Paolo Bonzini > Cc: devel@edk2.groups.io; j...@linux.ibm.

Re: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg: FmpDeviceLib interface change for Driver Unload support

2021-04-20 Thread John Rahn
Driver unload in the sample FmpDxe is currently configured to directly call UninstallFmpInstance (UNLOAD_IMAGE) with the ImageHandle and EFI_UNSUPPORTED is returned because the driver binding provided by FmpDeviceLib is managing the instance on the DeviceHandle, not the ImageHandle. The FmpDevi

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-20 Thread Lendacky, Thomas
On 4/20/21 5:54 PM, Lendacky, Thomas via groups.io wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 > > The TPM support in OVMF performs MMIO accesses during the PEI phase. At > this point, MMIO ranges have not been marked un-encyrpted, so an SEV-ES > guest

[edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV

2021-04-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 The TPM support in OVMF performs MMIO accesses during the PEI phase. At this point, MMIO ranges have not been marked un-encyrpted, so an SEV-ES guest will fail attempting to perform MMIO to an encrypted address. Read the

[edk2-devel] [PATCH 2/3] OvmfPkg/VmgExitLib: Add support for new MMIO MOV opcodes

2021-04-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 Enabling TPM support results in guest termination of an SEV-ES guest because it uses MMIO opcodes that are not currently supported. Add support for the new MMIO opcodes (0xA0 - 0xA3), MOV instructions which use a memory

[edk2-devel] [PATCH 1/3] OvfmPkg/VmgExitLib: Properly decode MMIO MOVZX and MOVSX opcodes

2021-04-20 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345 The MOVZX and MOVSX instructions use the ModRM byte in the instruction, but the instruction decoding support was not decoding it. This resulted in invalid decoding and failing of the MMIO operation. Also, when performing

[edk2-devel] [PATCH 0/3] SEV-ES TPM enablement fixes

2021-04-20 Thread Lendacky, Thomas
From: Tom Lendacky This patch series provides fixes for using TPM support with an SEV-ES guest. The fixes include: - Decode ModRM byte for MOVZX and MOVSX opcodes. - Add MMIO support for MOV opcodes 0xA0-0xA3. - Mark TPM MMIO range as un-encrypted during PEI phase. BZ: https://bugzilla.tianoco

Re: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg: FmpDeviceLib interface change for Driver Unload support

2021-04-20 Thread Michael D Kinney
Hi John, The FmpDeviceLib provides the RegisterFmpInstaller() and RegisterFmpUninstaller() APIs for UEFI Driver Model drivers to manage the FMP contexts. Why does the Unload need to be extended into the FmpDeviceLib when these APIs are used? I would think that a UEFI Driver Model Driver that su

[edk2-devel] [PATCH v1 0/1] FmpDevicePkg: FmpDeviceLib interface change for Driver Unload support

2021-04-20 Thread John Rahn
Implement interface to allow addition of Driver Unload support for a FmpDeviceLib which supports the UEFI Driver Binding model. Add FmpDeviceLibUnloadImage function declaration and NULL sample. Add FmpDxeUnloadImage function. Replace UNLOAD_IMAGE function in FmpDxe sample with FmpDxeUnloadI

[edk2-devel] [PATCH v1 1/1] FmpDevicePkg: FmpDeviceLib interface change for Driver Unload support

2021-04-20 Thread John Rahn
https://bugzilla.tianocore.org/show_bug.cgi?id=3342 FmpDeviceLib interface for Driver Unload is missing Add FmpDeviceLibUnloadImage function declaration and NULL sample. Add FmpDxeUnloadImage function. Replace UNLOAD_IMAGE function in FmpDxe sample with FmpDxeUnloadImage. Cc: Limi

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging

2021-04-20 Thread Kun Qin
Hi Ray, Thanks for reviewing and merging the change. Regards, Kun On 04/19/2021 15:28, Ni, Ray wrote: Reviewed-by: ray...@intel.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74304): https://edk2.groups.io/g/devel/message/74304

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

2021-04-20 Thread Rebecca Cran
Hi Sami, I was wondering if you're still collecting feedback on the design, or if you have a plan and schedule for the implementation? -- Rebecca Cran On 1/15/21 7:51 PM, Sami Mujawar wrote: Hi All, I have shared some initial thoughts on the RNG implementation updates at https://edk2.group

[edk2-devel] [Patch 1/1] BaseTools/Source/Python: Verify TAB_TOD_DEFINES_FAMILY key present

2021-04-20 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3344 Veify that TAB_TOD_DEFINES_FAMILY key is present in ToolDef dictionary before access. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Michael D Kinney --- .../Source/Python/AutoGen/ModuleAutoGenHelper.py | 11 ---

Re: [edk2-devel] [PATCH] BaseTools: GenerateCapsule.py: Add support for version 3 of FMP Image Header structure

2021-04-20 Thread Michael D Kinney
Hi, I think this patch is functional, but there are a few things that can be improved. 1) We should not use of the hard coded constants for the ImageCapsuleSupport values. The UEFI spec has #defines for these values, and we need to figure out how to add those define values in the scope o

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

2021-04-20 Thread Agrawal, Sachin
Hi Jiewen, I reviewed RFC 8017 and I could not find any specific 'recommendations' on salt length to be used during signing with PSS encoding scheme. However, in Section D.5.2.2.1(Notes 2) of IEEE 1363a-2004, it is recommended to use salt length atleast equal to the hash digest length. We can

Re: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string

2021-04-20 Thread Bob Feng
Created a PR https://github.com/tianocore/edk2/pull/1580 -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Monday, April 19, 2021 5:13 PM To: Shi, Steven ; devel@edk2.groups.io Cc: gaolim...@byosoft.com.cn Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Add double

Re: [edk2-devel] [PATCH] BaseTools: GenerateCapsule.py: Add support for version 3 of FMP Image Header structure

2021-04-20 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Sughosh Ganu Sent: Monday, April 19, 2021 7:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine ; Sughosh Ganu Subject: [PATCH] BaseTools: GenerateCapsule.py: Add support for version 3 of FMP Image Header struct

Re: [edk2-devel] [PATCH] [INTEL][TOOLS][FITGEN] Modify Fitgen tool to support new ACM header

2021-04-20 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Mohammad Miazi Sent: Thursday, April 15, 2021 2:31 PM To: devel@edk2.groups.io Cc: Miazi, Mohammad M Subject: [edk2-devel] [PATCH] [INTEL][TOOLS][FITGEN] Modify Fitgen tool to support new ACM header REF:

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

2021-04-20 Thread Yao, Jiewen
Right. That has PROs and CONs. On one hand, that allows maximum compatibility, salt could be HASH_SIZE or MAX, or even 0 ? On the other hand, what if the consumer only wants to accept a specific length? E.g. TPM in FIPS mode and TLS requires SaltLength==HashLength. Thank you Yao Jiewen > ---

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

2021-04-20 Thread Laszlo Ersek
On 04/19/21 23:42, Brijesh Singh wrote: > > On 4/13/21 4:49 AM, Laszlo Ersek wrote: >> On 04/12/21 16:52, Brijesh Singh wrote: >>> Hi James and Laszlo, >>> >>> I was planning to work to add the support to reserve the Secrets and >>> CPUID page in E820 map and then create the EFI configuration tabl

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

2021-04-20 Thread Agrawal, Sachin
Hi Jiewen, >From Section 9.1 in RFC 8017: " Note that the verification operation follows reverse steps to recover salt and then forward steps to recompute and compare H." Therefore, salt length can be inferred from the PSS block structure during verification operation. I opted for 'RSA_PSS_S