Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

Andrew, Thanks for that example -- that makes things a lot easier to understand now. I think, anyway. As for the simple text output protocol, I was just using that as an example; I understand that the HII infrastructure draws graphical characters, as does the simple text output protocol, and the sc

[edk2-devel] [edk2-platforms PATCH 1/1] SbsaQemu: Add OemMiscLib boot information and chassis status functions

Add new SMBIOS Type 32 boot information and Type 3 chassis status functions that have been added to OemMiscLib in ArmPkg. Since this is a virtual platform, return fixed values for the chassis statuses. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 91 +

[edk2-devel] [edk2-platforms PATCH 4/4] Marvell/Cn9132Db: Enable ACPI support

Because of the limitation in a number of available intterrupts that can be mapped in a current version of the IcuLib, the ACPI support for Cn9132 variant remained disabled. Such hard limitation is not needed though and enable ACPI boot, however with a the interfaces present only on the first two CP

[edk2-devel] [edk2-platforms PATCH 3/4] SolidRun/Armada80x0McBin: Add 2.5G NIC port description in ACPI

The ACPI tables of MacchiatoBin board were missing 2.5G NIC port description. Add it. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 22 +++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/Silicon/Marvell/Armada7k

[edk2-devel] [edk2-platforms PATCH 1/4] Marvell: PlatInitDxe: Use more adequate print during init

One of first logs visible during DXE initialization is a fixed string "Armada Platform Init", which is pretty generic and not true for CN913X platforms. Modify it to use already exesting vendor/product name PCDs. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/Pla

[edk2-devel] [edk2-platforms PATCH 2/4] Marvell: Armada7k8/OcteonTx: Enhance NIC ACPI description

The early firmware allows to use flow control mechanism via shared memory region. Include its description in the PP2 NIC nodes. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl| 1 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl|

[edk2-devel] [edk2-platforms PATCH 0/4] Marvell misc improvements

Hi, This short patchset applies minor modifications to the platforms based on the Marvell SoCs. It updates the initial print, allows to use a new Linux mvpp2 driver feature with ACPI, adds missing port in MacchiatoBin description and allows to use (however limited) ACPI for CN9132 variant. More d

[edk2-devel] [edk2-non-osi PATCH] Marvell: Update device trees

The recent device tree modifications for the platforms based on the Marvell SoCs were merged in their initial revision. Perform a desired update from the final version. Changes included: * Align DT sources to the upcoming Linux v5.12 * Revert ahci nodes changes for Armada7k8k and OcteonTx * Remove

Re: [edk2-devel] [edk2-non-osi/edk2-platforms PATCH v2 0/4] Marvell SoCs device tree update

Hi Ard, sob., 10 kwi 2021 o 10:34 Ard Biesheuvel napisał(a): > > On Sun, 28 Mar 2021 at 11:45, Marcin Wojtas wrote: > > > > Hi Ard, > > > > I've just realized I sent the patchset using your old address. Should I > > resend with a proper one? > > > > Best regards, > > Marcin > > > > Hi Marcin, >

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

> On Apr 16, 2021, at 10:55 AM, Ethin Probst wrote: > > Also, forgot to add this before sending: yes, speech synthesizers > usually generate the PCM audio on the fly. They can write it to an > output file, but if your just using it in a screen reader, then you > end up streaming it to the audi

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

> On Apr 16, 2021, at 10:45 AM, Ethin Probst wrote: > > Yes, three APIs (maybe like this) would work well: > - Start, Stop: begin playback of a stream > - SetVolume, GetVolume, Mute, Unmute: control volume of output and enable > muting > - CreateStream, ReleaseStream, SetStreamSampleRate: Cont

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

Also, forgot to add this before sending: yes, speech synthesizers usually generate the PCM audio on the fly. They can write it to an output file, but if your just using it in a screen reader, then you end up streaming it to the audio device. This raises another issue I was pondering, but I (don't t

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

Yes, three APIs (maybe like this) would work well: - Start, Stop: begin playback of a stream - SetVolume, GetVolume, Mute, Unmute: control volume of output and enable muting - CreateStream, ReleaseStream, SetStreamSampleRate: Control sample rate of stream (but not sample format since Signed 16-bit

Re: [EXTERNAL] [edk2-devel] [PATCH 1/1] MdeModulePkg/BmpSupportLib: Allow BMP with extra data

Sorry I was out for a bit so didn't get back to this thread for a bit. Who should be on any additional security review? In TranslateBmpToGopBlt the Size is only used in DEBUG prints and this verification check. Processing of the data uses the image structure data. In addition BMP that have extr

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

> On Apr 16, 2021, at 4:34 AM, Leif Lindholm wrote: > > Hi Ethin, > > I think we also want to have a SetMode function, even if we don't get > around to implement proper support for it as part of GSoC (although I > expect at least for virtio, that should be pretty straightforward). > Leif,

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

On 16.04.21 16:34, Andrew Fish via groups.io wrote: On Apr 16, 2021, at 6:22 AM, Marvin Häuser > wrote: Good day, Sorry for the nitpicking. - Protocols always need a "Revision" field as first member. This is used to be able to expand its capabilities in later rev

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

> On Apr 16, 2021, at 6:22 AM, Marvin Häuser wrote: > > Good day, > > Sorry for the nitpicking. > > - Protocols always need a "Revision" field as first member. This is used to > be able to expand its capabilities in later revisions without introducing a > new, distinct protocol. > - Conside

Re: [edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

Hi Samer, Thanks for checking and putting all related issues here. However, I missed your comment in v2. Sorry about that. Therefore, I directly added the references to the commit. https://github.com/tianocore/edk2-platforms/commit/efdc159ef7c9f15581a0f63d755a1530ff475156 This commit turned out

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

Good day, Sorry for the nitpicking. - Protocols always need a "Revision" field as first member. This is used to be able to expand its capabilities in later revisions without introducing a new, distinct protocol. - Consider the name EFI_SIMPLE_AUDIO_OUTPUT(!)_PROTOCOL, to not cause confusion i

Re: [edk2-devel] [PATCH v1 4/4] DynamicTablesPkg: Set the Access size for the DBG2 table

Hi Joey, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/04/2021, 13:17, "Joey Gouly" wrote: The DBG2 table generator set the access size for the UART to DWORD (4 bytes) by default. However, according to Section B Generic UART, Arm Base System

Re: [edk2-devel] [PATCH v1 3/4] DynamicTablesPkg: Set the Access size for the SPCR table

Hi Joey, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/04/2021, 13:19, "Joey Gouly" wrote: The SPCR table generator set the access size for the UART to DWORD (4 bytes) by default. However, according to Section B Generic UART, Arm Base System

Re: [edk2-devel] [PATCH v1 2/4] DynamicTablesPkg: Add access size to CM_ARM_SERIAL_PORT_INFO

Hi Joey, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/04/2021, 13:19, "Joey Gouly" wrote: Add access size to CM_ARM_SERIAL_PORT_INFO so that this can be passed down to the Generic Address Structure. Signed-off-by: Joey Gouly ---

Re: [edk2-devel] [Patch 1/1] BaseTools/Conf/tools_def.template: Remove redundante MAKE statements

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: Wednesday, April 14, 2021 11:47 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [edk2-devel] [Patch 1/1] BaseTools/Conf/tools_def.template: Remov

Re: [edk2-devel] [PATCH v1 1/4] ShellPkg: Rename Address Size to Access size

Hi Joey, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/04/2021, 13:29, "devel@edk2.groups.io on behalf of Sami Mujawar via groups.io" wrote: Adding Zhichao. Regards, Sami Mujawar On 15/04/2021, 13:19, "Joey Gouly" wrote: This

Re: [edk2-devel] [PATCH RESEND 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

Pushed as 4b53da6b12a8..c896c358ad59 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74202): https://edk2.groups.io/g/devel/message/74202 Mute This Topic: https://groups.io/mt/82138139/21656 Group Owner: de

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

Hi Ethin, I think we also want to have a SetMode function, even if we don't get around to implement proper support for it as part of GSoC (although I expect at least for virtio, that should be pretty straightforward). It's quite likely that speech for UI would be stored as 8kHz (or 20kHz) in some

Re: [edk2-devel] [edk2-platforms][PATCH v1 10/35] IntelSiliconPkg: Add MM SPI FVB services

Guo, I remember you mentioned to me there is a standard way to manipulate the flash storage because there is a HW between the SW and the real flash that does the command translation. Is this change related to the standard way what you mentioned to me? If yes, can you please help to review and pro

Re: [edk2-devel] [PATCH RESEND 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74199): https://edk2.groups.io/g/devel/message/74199 Mute This Topic: https://groups.io/mt/82138139/21656 Group Owner: devel+ow...@edk2.grou

[edk2-devel] [PATCH RESEND 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

From: Pierre Gondois Following the Ecc reported error in the edk2 repository, the SCMI_CLOCK_RATE structure has been modified in: an enum and its elements have been renamed in: ArmPkg/Include/Protocol/ArmScmiClockProtocol.h This patch is a follow-up and fixes the following Ecc reported error: Co

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

Good day everyone, Sorry for the late reply, but somehow my mail filter is malfunctioning. I have two folders for edk2-devel, one where all mails with me in To/CC go, and one for the rest. And somehow, multiple times in this conversation already, mails end up in the latter. While I try to figu