Re: [edk2-devel] [PATCH v2] RedfishPkg/RestJsonStructureDxe: Fix typo in function header

2021-04-14 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, April 15, 2021 1:37 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) Subject: [PATCH v2] RedfishPkg/RestJsonStructureDxe: Fix typo in function header In v2, BZ referenc

[edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs

2021-04-14 Thread Jason Lou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3334 IntelFsp2WrapperPkg defines following PCDs: PcdCpuMicrocodePatchAddress PcdCpuMicrocodePatchRegionSize PcdFlashMicrocodeOffset But the PCD name caused confusion because UefiCpuPkg defines: PcdCpuMicrocodePatchAddress PcdCpuMicroco

Re: [edk2-devel] [Patch v2 2/4] CryptoPkg/Library/Include: Allow CPU specific defines to be predefined

2021-04-14 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 14, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, Guomin ; > Andrew Fish ; Abner Chang > Subject: [Patch v2 2/4] CryptoP

[edk2-devel] [PATCH v2] RedfishPkg/RestJsonStructureDxe: Fix typo in function header

2021-04-14 Thread Abner Chang
In v2, BZ reference is added. BZ#:3030 Fix the typo [in]/[out] of parameter DestroyStructure in function header. Signed-off-by: Abner Chang Cc: Nickle Wang --- MdePkg/Include/Protocol/RestJsonStructure.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protoco

[edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Fix typo in function header

2021-04-14 Thread Abner Chang
Fix the typo [in]/[out] of parameter DestroyStructure in function header. Signed-off-by: Abner Chang Cc: Nickle Wang --- MdePkg/Include/Protocol/RestJsonStructure.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/RestJsonStructure.h b/MdePkg/Include/

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-14 Thread Ethin Probst
So here's the rationale for my extra stuff: - I hoped to add recording in case we in future want to add accessibility aids like speech recognition (that was one of the todo tasks on the EDK2 tasks list) - Muting and volume control could easily be added by just replacing the sample buffer with sile

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-14 Thread Ethin Probst
Hi Mike and Andrew, Thanks for your responses. I'm looking at the VirtIO block device now but will certainly have a look at the others as well. We'll also need to define a completely new protocol for audio, as well, as no existing protocol will fit the bill. The generic protocol proposed by Andrew

Re: [edk2-devel] [PATCH v2] RedfishPkg: Add EDK2 Redfish Foundation diagrams

2021-04-14 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, April 14, 2021 10:25 PM To: devel@edk2.groups.io Cc: Jiaxin Wu ; Ting Ye ; Siyuan Fu ; Fan Wang ; Jiewen Yao ; Wang, Nickle (HPS SW) ; Andrew Fish ; Laszlo Ersek ; Leif Lin

[edk2-devel] 回复: [Patch v2 1/4] MdePkg/Include: Allow CPU specific defines to be predefined

2021-04-14 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年4月14日 11:28 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Zhiguang Liu > ; Andrew Fish ; Abner Chang > > 主题: [Patch v2 1/4] MdePkg/Include: Allow CPU specific defines to be > predefined > > REF: https://bugzilla.tia

Re: [edk2-devel] separate OVMF binary for TDX? [was: OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest]

2021-04-14 Thread Erdem Aktas via groups.io
Hi all, >>Can we please pry a little bit at that "one binary" requirement? I think when we call it a "one binary" requirement, it sounds like we are asking something new but what we are asking is pretty much captured by James Bottomley. We do not want to generate different binaries for AMD, Intel

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-14 Thread Andrew Fish via groups.io
> On Apr 14, 2021, at 3:30 PM, Kinney, Michael D > wrote: > > Hi Ethin, > > Most UEFI Drivers do use polling. > > If it is a blocking I/O operation the UEFI Driver waits for completion. > Typically by polling a status register until the I/O is complete and then > return status. > > If it

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-14 Thread Michael D Kinney
Hi Ethin, Most UEFI Drivers do use polling. If it is a blocking I/O operation the UEFI Driver waits for completion. Typically by polling a status register until the I/O is complete and then return status. If it is a non-blocking I/O Operation, then the UEFI Driver can create a timer event to

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-14 Thread Ethin Probst
These are some pretty good suggestions; however, while reading through the VirtIO specification again yesterday, I (re)-discovered that VirtIO devices are usually interrupt based. In particular, a VirtIO PCI/PCIe device defines the common, notifications, ISR status, device-specific configuration, P

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging

2021-04-14 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3300 Current implementation of SetStaticPageTable routine in PiSmmCpuDxeSmm driver will check a global variable mPhysicalAddressBits, and eventually cap any value larger than 39 at 39. This global variable is used in ConvertMemoryPageAttributes,

[edk2-devel] [PATCH v2 0/1] Not to Update Bitwidth Variable in Static Paging

2021-04-14 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3300 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/74078 These module change is validated on two different physical platforms. v2 patch focus on feedback for reviewed commits in v1 patch, includ

Re: [edk2-devel] [EDK2 / UEFI]: Support for flashing ubi-volume using fastboot

2021-04-14 Thread Michael Brown
On 14/04/2021 20:34, Andrew Fish via groups.io wrote: EFI does not have a concept of Volume names, EFI has a concept of EFI_HANDLEs that contain device paths that indentify the volume. The UEFI Shell has volume names, but that is a construct produced by the UEFI Shell. The filesystem label (

Re: [edk2-devel] [EDK2 / UEFI]: Support for flashing ubi-volume using fastboot

2021-04-14 Thread Andrew Fish via groups.io
> On Apr 14, 2021, at 11:12 AM, Pintu Agarwal wrote: > > Hi, > > I am new to EDK2 and UEFI. > I am working on an ARM32 embedded Linux board that supports NAND and UBI > images. > I have several partitions in my system images, and some partitions > have sub-volumes. > I am looking for help on

[edk2-devel] [EDK2 / UEFI]: Support for flashing ubi-volume using fastboot

2021-04-14 Thread Pintu Agarwal
Hi, I am new to EDK2 and UEFI. I am working on an ARM32 embedded Linux board that supports NAND and UBI images. I have several partitions in my system images, and some partitions have sub-volumes. I am looking for help on how to support flashing ubi-volumes directly using the fastboot flash method

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging

2021-04-14 Thread Kun Qin
Hi Laszlo, Thanks for the feedback. I will update commit message for (2) and variable type for (3) in v2. As per suggestion by Ray in another thread, we are moving "PhysicalAddressBits" from local variable to input parameter. So I will update the term "stack based variable" for (1) according

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging

2021-04-14 Thread Kun Qin
Hi Ray, I do not have a preference in using local variable or input parameter. I can change the SetStaticPageTable interface to accept bitwidth in v2. Regards, Kun On 04/14/2021 02:49, Ni, Ray wrote: Is it possible to let SetStaticPageTable() accept another parameter "PhysicalAddressBits" s

[edk2-devel] [PATCH v2] RedfishPkg: Add EDK2 Redfish Foundation diagrams

2021-04-14 Thread Abner Chang
The Readme.md to delineate the EDK2 Redfish foundation driver stack diagrams. Signed-off-by: Abner Chang Cc: Jiaxin Wu Cc: Ting Ye Cc: Siyuan Fu Cc: Fan Wang Cc: Jiewen Yao Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- RedfishPkg/Readme.md

Re: [edk2-devel] [RFC PATCH 00/19] Add AMD Secure Nested Paging (SEV-SNP) support

2021-04-14 Thread Brijesh Singh
>> Since I had the data structures available in PEI >> phase for the tracking the page state hence made those available to >> DXE to verify that we are called to invalidate the SYSTEM_RAM and not >> MMIO. IMO, we should either extend the >> MemEncryptSev{Set,Clear}PageEncMask() to pass either a n

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging

2021-04-14 Thread Ni, Ray
Is it possible to let SetStaticPageTable() accept another parameter "PhysicalAddressBits" so it doesn't update the global one? Using this way, SetStaticPageTable() can avoid reference the global variable completely. > -Original Message- > From: Kun Qin > Sent: Wednesday, April 14, 2021

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Not to Change Bitwidth During Static Paging

2021-04-14 Thread Laszlo Ersek
On 04/14/21 04:59, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3300 > > Current implementation of SetStaticPageTable routine in PiSmmCpuDxeSmm > driver will check a global variable mPhysicalAddressBits, and eventually > cap any value larger than 39 at 39. > > This global

Re: [edk2-devel] [Patch v2 1/4] MdePkg/Include: Allow CPU specific defines to be predefined

2021-04-14 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Michael D Kinney [mailto:michael.d.kin...@intel.com] > Sent: Wednesday, April 14, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Zhiguang Liu > ; Andrew Fish ; Chang, Abner > (HPS SW/FW Technologist) > Subject: [Patch v2