I recommend to use SIZE_1GB to indicate size, instead of BIT30, for readability.
===
if (Length <= BIT30) {
Length = 0;
} else {
Length -= BIT30;
}
PhysicalAddress += BIT30;
===
Also
===
if (
Hi
Would you please clarify why the IA32 version implementation is empty?
Does it mean IA32 does not need validate?
Or IA32 should never call this function?
Anyway, I recommend to add some comment to describe it clearly.
If it should never be called, I recommend to add ASSERT(FALSE).
+++ b/Ovmf
Hi Zhiguang,
this is still on my todo-list, but I'm quite busy right now.
If you got time please take care of that patch.
Regards,
Patrick Rudolph
On Thu, Apr 1, 2021 at 6:42 AM Liu, Zhiguang wrote:
>
> Hi Patrick Rudolph,
>
> I also want this feature that enables Smbios driver to parse and inst
The generic timer and watchdog timer interrupt numbers on the RD-N2
platform is different than those on the other platforms supported by
SgiPkg. So in order to reuse the existing GTDT ACPI table for all the
supported platforms including RD-N2, introduce and use PCD to provide
the interrupt numbers
Add PCDs for base address and address space size for generic timer and
SMMU controllers. Use those PCDs to add platform memory map entries. The
ServerReady SBSA tests, when executed, accesses these controllers and so
the memory mapping for generic timer and SMMU controllers are required.
In additi
Ssdt ACPI table in SgiPkg describes the PCIe controller and the root
complex resources. Include this table for RD-V1 and RD-V1-MC platforms.
Signed-off-by: Pranav Madhu
Reviewed-by: Sami Mujawar
---
Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 1 +
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc
Fix the ACPI DSDT/SSDT table version numbers. As per ACPI 6.3
specification, the DSDT/SSDT table should use version 2 instead of 1. In
addition to this, update 'PcdAcpiExposedTableVersions' to avoid building
RSDT table into ACPI firmware volume because the platforms supported
under SgiPkg are 64-bi
Fix the incorrect ACPI _UID (Unique ID) object for CPU devices listed
for the RD-V1-MC platform.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc | 24 ++--
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTabl
RD-V1-MC platform has four CPUs in each of its four coherently connected
chips. So remove a incorrect CPU device entry in DSDT table that lists a
additional non-existent CPU.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 6 --
1 file changed, 6 deletions(-)
Changes since V1:
- Rebase the patches on top of latest master branch
- Add three more patches to the series
- Picked up Sami's R-b tags on applicable patches
This patch series contains assorted cleanups for the RD platforms. The
first patch in this series includes the SSDT table for both the RD-V
Hello there,
Some good advice, and thank you! I might add it to the other virtIO*
drivers if I can figure out a good template for that.
One thing I'm running into right now is that my build setup is
currently unable to build MdeModulePkg (which is required to build
OVMF, according to the readme).
Hi Patrick Rudolph,
I also want this feature that enables Smbios driver to parse and install
existing SMBIOS table.
I notice there are some comments about your patch. If you don't have time to
refine it, I can keep your signed-off-by, and continue your work based on Ray
and Guo's comments.
Tha
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Dandan Bi
Reviewed-by: Michael D Kinney
Reviewed-by: Liming Gao
Acked-by: Ard Biesheuvel
---
V5: NA
MdePkg/Library/BaseLib/BaseLib.inf | 5 ++-
MdePkg/Libr
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Cc: Sami Mujawar
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Dandan Bi
Reviewed-by: Michael D Kinney
Reviewed-by: Liming Gao
Acked-by: Ard Biesheuvel
---
V5: Add missing closing bracket for if (Flag) check in
Hi Benjamin,
Great to meet you and welcome to the TianoCore project! Glad you hear you are
interested! Doing a board port to the Acer Aspire VN7-572G laptop sounds like a
great GSoC project! I presume that since you already did a coreboot port that
boot guard is disabled on this laptop and you
Hi,
On 3/11/21 4:56 PM, René Treffer wrote:
There is only a single pcie port on the bcm2711 so limiting the number of
devices to 1 worked as long as there is no way to add a pcie switch.
I thought this got merged, but I just rebased and realized it didn't.
Which is just as well, because there
Hi Pedro,
Happy to hear our conversations here have helped 😊.
The ext4 project sounds good! I’d recommend putting write support on as a “if I
have time at the end” stretch goal. Just getting read working and stable would
be a great accomplishment. GSoC does end in August… but you can continue
Hi Bret,
I've shared the project's draft with Tianocore, take a look and give out some
feedback if you want to :)
Thanks, it's great to work with you folks too!
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73582): https://edk2.
Hi Nate,
Everything you said sounds great :))
I did end up going with ext4 as a target, as I find it's the more useful and
more interesting project, the only thing I'm not too sure of is whether or not
to add write support as one of the project's targets.
Anyway, I've just shared my draft with T
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3290
When BuildAtaDeviceNode() is called with L"Ata(0,0,0)" it creates a node
Ata(1,1,0). This leads to test to an assertion failed test result
../DevicePathToTextBBTestFunction.c:332:
Convert result: Ata(0,0,0) - Expected: Ata(Primary,M
Please ignore this one because I just found already have the XGETBV instruction
Support.
So, I create another patch to support XSETBV instruction for XCR write.
See email thread:
[edk2-devel] [PATCH v1] MdePkg/BaseLib: Add support for the XSETBV instruction
So, let's review above one.
Thank
https://bugzilla.tianocore.org/show_bug.cgi?id=3284
This patch is to support XSETBV instruction so as to support
Extended Control Register(XCR) write.
Extended Control Register(XCR) read has already been supported
by below commit to support XGETBV instruction:
9b3ca509abd4e45439bbdfe2c2fa8780c950
The following files have been uploaded to the Files area of the
devel@edk2.groups.io group.
* /Designs/2021/0319/New EFI Protocols for edk2 Redfish
Implementation_conclusion.pdf (
https://edk2.groups.io/g/devel/files/Designs/2021/0319/New EFI Protocols for
edk2 Redfish Implementation_conclus
23 matches
Mail list logo
