On Wed, Mar 10, 2021 at 3:52 PM Laszlo Ersek wrote:
>
> On 03/10/21 09:04, Jon Nettleton wrote:
> > I am debugging a failure that I am seeing while using the HoneyComb's
> > spi-nor flash for runtime variable storage. I am hoping someone on
> > the list can give me some insight as what may be the
Thanks for the review and good comments, Pete.
Since I'm busy with other things, I will work on your comments next week or
later.
Regards,
Sunny
On Tue, Mar 9, 2021 at 12:58 AM Pete Batard wrote:
> Hi Sunny,
>
> Thanks a lot for submitting this patch!
>
> This is something that has been on the
On 3/11/21 1:37 AM, Kun Qin via groups.io wrote:
> The merging of commit range c5740f360636..59a3ccb09e7a on edk2 master has
> separated Tcg2Smm driver into 2 functional componnents, Tcg2Acpi and Tcg2
> MM driver. They also introduced dependency of MmUnblockMemoryLib on
> VariableSmmRuntimeDxe as
Reviewed-by: Eric Dong
-Original Message-
From: Liu, Zhiguang
Sent: Thursday, March 11, 2021 9:22 AM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Liming Gao ;
Desimone, Nathaniel L ; Agyeman, Prince
; Ni, Ray ; Gao, Zhichao
Subject: [Patch edk2-platforms V3] Intel/BoardModulePkg: sort
Reviewed-by: Liming Gao
Besides, the subject should be edk2-platforms instead of edk2-staging.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Kun Qin
> 发送时间: 2021年3月11日 4:08
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu ; Nate DeSimone
> ; Liming Gao ;
> Eric Dong
> 主题: [edk2-d
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Kun Qin
> 发送时间: 2021年3月11日 4:08
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu ; Nate DeSimone
> ; Liming Gao ;
> Eric Dong
> 主题: [edk2-devel] [edk2-staging][PATCH V1 1/5] MinPlatformPkg:
> CoreCommonLib: Added new library f
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> Sent: Thursday, March 11, 2021 9:10 AM
> To: Wu, Hao A ; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: [edk2-devel] 回复: [PATCH] MdeModulePkg: Initialize local variable
> value before they are used
>
> Hao:
>
Is this checker for .h file only?
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> PierreGondois
> 发送时间: 2021年3月10日 0:17
> 收件人: devel@edk2.groups.io; bob.c.f...@intel.com;
> gaolim...@byosoft.com.cn; yuwei.c...@intel.com
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
> Sent: Thursday, March 11, 2021 9:22 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Liming Gao ;
> Desimone, Nathaniel L
> ; Agyeman, Prince ;
> Ni, Ray ; Gao, Zhichao
>
> Subject: [edk2
Currently, load option is only sorted when setup is the first priority in boot
option. However, Below change in UefiBootManagerLib puts setup in the end, which
causes the sort function won't be called.
MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder
SHA-1: 7f34681c488aee25
Hao:
Yes. I agree. I will add this information when I merge it.
Thanks
Liming
> -邮件原件-
> 发件人: Wu, Hao A
> 发送时间: 2021年3月9日 10:10
> 收件人: Liming Gao ; devel@edk2.groups.io
> 抄送: Wang, Jian J
> 主题: RE: [PATCH] MdeModulePkg: Initialize local variable value before
they
> are used
>
> > ---
On 3/10/21 12:56 PM, Laszlo Ersek wrote:
> Ref:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=04%7C01%7Cbrijesh.singh%40amd.com%7C69a977a229bf49dda26008d8e3f64dd3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63750999431
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.
Cc: Ard Bieshe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
This change added NULL MmUnblockMemoryLib instance in Quark.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.
Cc: Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
This change added NULL MmUnblockMemoryLib instance in dsc files of
CoreCommonLib to resolve newly introduced dependency. The library
interface is consumed by VariableSmmRuntimeDxe to better support variable
runtime cache feature.
Cc: Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3251
This change follows the commit that separates the original Tcg2Smm driver
into Tcg2Acpi and Tcg2 MM based on functionality in DXE and MM. The new
Tcg2Acpi driver now will be responsible for patching and publishing ACPI
table from DXE, and Tc
The merging of commit range c5740f360636..59a3ccb09e7a on edk2 master has
separated Tcg2Smm driver into 2 functional componnents, Tcg2Acpi and Tcg2
MM driver. They also introduced dependency of MmUnblockMemoryLib on
VariableSmmRuntimeDxe as well as the new Tcg2Acpi driver.
This patch series is sen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
file to resolve new dependency by VariableSmmRuntimeDxe. The library
interface is consumed by variable module to better support variable
runtime cache feature.
Cc: Zailia
Both Acked-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: Thursday, March 11, 2021 2:57 AM
> To: edk2-devel-groups-io
> Cc: Andrew Fish ; Ard Biesheuvel
> ; Brijesh Singh ; James
> Bottomley ; Yao, Jiewen ; Justen,
> Jordan L ; Leif Li
On 3/10/21 12:56 PM, Laszlo Ersek wrote:
Ref:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=04%7C01%7Cthomas.lendacky%40amd.com%7C273e70e0168942830a1108d8e3f64e49%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6375099943223
Reviewed-by: Kelly Steele
> -Original Message-
> From: Kun Qin
> Sent: Wednesday, March 10, 2021 12:08 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Steele, Kelly
>
> Subject: [edk2-staging][PATCH V1 3/5] QuarkPlatformPkg: Quark DSC File:
> Added new library for VariableSmmRun
On 3/10/21 7:56 PM, Laszlo Ersek wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
>
> Generalize the current OVMF SEV subsystem entry, so that we can use it
> for
On Wed, 10 Mar 2021 at 19:57, Laszlo Ersek wrote:
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
>
> Generalize the current OVMF SEV subsystem entry, so that we can u
The implementation of Intel TDX for OVMF has begun (TianoCore#3249).
Generalize the OVMF SEV section in "Maintainers.txt" to "Confidential
Computing". Add Jiewen Yao and Min Xu to the list of reviewers. Sort the
reviewer list alphabetically, for easier extension in the future.
After the rename, re
Tom added initial SEV-ES support (tracked under TianoCore#2198) in commit
range 7f7f511c5a74..7f0b28415cb4. The last commit in that range created
the "OvmfPkg: SEV-related modules" section in "Maintainers.txt".
However, we didn't list the "OvmfPkg/ResetVector" module, which had
received significan
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3077
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
Generalize the current OVMF SEV subsystem entry, so that we can use it
for Intel TDX in the future, ensuring proper patch circu
Hi Everyone,
I am pleased to announce that TianoCore has been accepted to participate in
GSoC 2021! If you are a student and are interested in participating this year,
feel free to introduce yourself on the mailing list and discuss potential
project proposals. You can find a list of suggested p
Agree. Just one "confidential computing" can make things simpler.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of James
> Bottomley
> Sent: Wednesday, March 10, 2021 11:34 PM
> To: Laszlo Ersek ; Xu, Min M ; Yao,
> Jiewen ; Brijesh Singh ; Tom
> Lendacky
> Cc: devel@edk2.
On 3/10/21 9:09 AM, Tom Lendacky wrote:
> On 3/10/21 8:20 AM, Laszlo Ersek wrote:
>> Adding James, Brijesh, Tom; comments below:
>>
>> On 03/10/21 03:55, Min Xu wrote:
>>> Register reviewers for the Confidential Computing related modules in
>>> OvmfPkg.
>>>
>>> Cc: Andrew Fish
>>> Cc: Laszlo Ers
Thanks Laszlo for copying me. From AMD, I will be soon start submitting
the SNP support in the OMVF. I look forward collaborating with Yao and
Min on software architecture.
On 3/9/21 6:25 PM, Yao, Jiewen wrote:
> Very good suggestion. Thanks Laszlo.
>
> For 3), Min Xu and I will be the reviewer f
On Wed, 2021-03-10 at 15:20 +0100, Laszlo Ersek wrote:
[...]
> (2) Reviewing this patch makes me realize we've missed some
> "Maintainers.txt" updates in the past, in relation to SEV and/or
> confidential computing.
>
> Namely, we did not designated any reviewers for the following
> pathnames:
>
> From: devel@edk2.groups.io on behalf of Ni, Ray via
> groups.io
> Is this for ARM only?
Yes, the GIC interrupt controller is for Arm only.
Thanks,
Joey
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended r
On 3/10/21 8:20 AM, Laszlo Ersek wrote:
Adding James, Brijesh, Tom; comments below:
On 03/10/21 03:55, Min Xu wrote:
Register reviewers for the Confidential Computing related modules in
OvmfPkg.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Jiewen Yao
Signed-
On 03/10/21 09:04, Jon Nettleton wrote:
> I am debugging a failure that I am seeing while using the HoneyComb's
> spi-nor flash for runtime variable storage. I am hoping someone on
> the list can give me some insight as what may be the problem.
>
> The problem showed up when we switched the MMIO
Adding James, Brijesh, Tom; comments below:
On 03/10/21 03:55, Min Xu wrote:
> Register reviewers for the Confidential Computing related modules in
> OvmfPkg.
>
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Signed-off-by: Min Xu
> ---
> M
On 03/10/21 14:12, Laszlo Ersek wrote:
> On 03/10/21 03:55, Min Xu wrote:
>> Register reviewers for the TDX-related files in OvmfPkg.
>>
>> Cc: Andrew Fish
>> Cc: Laszlo Ersek
>> Cc: Leif Lindholm
>> Cc: Michael D Kinney
>> Cc: Jiewen Yao
>> Signed-off-by: Min Xu
>> ---
>> Maintainers.txt |
On 03/10/21 03:55, Min Xu wrote:
> Register reviewers for the TDX-related files in OvmfPkg.
>
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Signed-off-by: Min Xu
> ---
> Maintainers.txt | 4
> 1 file changed, 4 insertions(+)
>
> dif
Hi Pierre,
On Wed, Mar 10, 2021 at 09:58:19AM +, Pierre wrote:
> Hi Ilias,
> Just minor coding style nit picking:
>
> * Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c:FixPcdMemory() I think the
>error codes are missing in the function header
Ah you mean the return values of locate protocol?
>
On 03/10/21 11:12, Ray Ni wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3199
>
> When Token points to mSmmStartupThisApToken, this routine is called
> from SmmStartupThisAp() in non-blocking mode due to
> PcdCpuSmmBlockStartupThisAp == FALSE.
>
> In this case, caller wants to start
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3199
When Token points to mSmmStartupThisApToken, this routine is called
from SmmStartupThisAp() in non-blocking mode due to
PcdCpuSmmBlockStartupThisAp == FALSE.
In this case, caller wants to startup AP procedure in non-blocking
mode and cannot
Hi Ilias,
Just minor coding style nit picking:
* Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c:FixPcdMemory() I think the
error codes are missing in the function header
* Thanks for adding the IN/OUT function parameter descriptors. Is it
possible to also add them in the function headers [1] ?
Ab
1. DataSIze should be set to sizeof (BOOLEAN) before calling GetVariable()
> + Status = gRT->GetVariable (
> + L"IsFirstBoot",
2. Can you please define a macro in this C file for IsFirstBoot string?
e.g.: #define IS_FIRST_BOOT_VAR_NAME L"IsFirstBoot"
> + if (IsFirs
Please ignore this meeting request sent from Outlook. I will create meetings in
groups.io.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72620): https://edk2.groups.io/g/devel/message/72620
Mute This Topic: https://groups.io/mt/81223142
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCATION:Asia/Shanghai
BEGIN:STANDARD
TZNAME:CST
TZOFFSETFROM:+
BEGIN:VCALENDAR
METHOD:CANCEL
PRODID:Microsoft Exchange Server 2010
VERSION:2.0
BEGIN:VTIMEZONE
TZID:China Standard Time
BEGIN:STANDARD
DTSTART:16010101T00
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T00
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
END:DAYLIGHT
EN
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCATION:Asia/Shanghai
BEGIN:STANDARD
TZNAME:CST
TZOFFSETFROM:+
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCATION:Asia/Shanghai
BEGIN:STANDARD
TZNAME:CST
TZOFFSETFROM:+
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCATION:Asia/Shanghai
BEGIN:STANDARD
TZNAME:CST
TZOFFSETFROM:+
BEGIN:VCALENDAR
METHOD:REQUEST
PRODID:Microsoft Exchange Server 2010
VERSION:2.0
BEGIN:VTIMEZONE
TZID:China Standard Time
BEGIN:STANDARD
DTSTART:16010101T00
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T00
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
END:DAYLIGHT
E
BEGIN:VCALENDAR
METHOD:REQUEST
PRODID:Microsoft Exchange Server 2010
VERSION:2.0
BEGIN:VTIMEZONE
TZID:China Standard Time
BEGIN:STANDARD
DTSTART:16010101T00
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T00
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
END:DAYLIGHT
E
Currently, load option is only sorted when setup is the first priority in boot
option. However, Below change in UefiBootManagerLib puts setup in the end, which
causes the sort function won't be called.
MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder
SHA-1: 7f34681c488aee25
Currently, load option is only sorted when setup is the first priority in boot
option. However, Below change in UefiBootManagerLib puts setup in the end, which
causes the sort function won't be called.
MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder
SHA-1: 7f34681c488aee25
I am debugging a failure that I am seeing while using the HoneyComb's
spi-nor flash for runtime variable storage. I am hoping someone on
the list can give me some insight as what may be the problem.
The problem showed up when we switched the MMIO region for the fspi
flash device to be marked as n
53 matches
Mail list logo
