回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

Hi, Stewards and All: So far, there are still three patch sets to be requested to catch this stable tag. They are bug fixes, and pass code review in soft feature freeze phase. Have you any comments for them? 1. Fix two issue in ArmGicLib (https://edk2.groups.io/g/devel/message/72175) 2.

[edk2-devel] [PATCH] BaseTools: Fix build failure of "modules" option

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3238 The "modules" option in build command is to build all modules only but not to generate the final FV image. The option doesn't work now and report makefile missing build failure. This patch fix this issue. Signed-off-by: Steven Shi Cc: Bob

回复: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

Merge @ 7f34681c488aee2563eaa2afcc6a2c8aa7c5b912 Thanks Liming > -邮件原件- > 发件人: bounce+27952+71937+4905953+8761...@groups.io > 代表 gaoliming > 发送时间: 2021年2月22日 18:00 > 收件人: devel@edk2.groups.io; sunnyw...@hpe.com; 'Li, Walon' > > 抄送: ler...@redhat.com; ray...@intel.com; hao.a...@intel.com

回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

Create PR https://github.com/tianocore/edk2/pull/1463 for it. Thanks Liming > -邮件原件- > 发件人: bounce+27952+71780+4905953+8761...@groups.io > 代表 gaoliming > 发送时间: 2021年2月18日 13:38 > 收件人: devel@edk2.groups.io; pierre.gond...@arm.com; > bob.c.f...@intel.com; rebe...@nuviainc.com; sami.muja...

Re: [edk2-devel] 回复: Can merge any code changes to edk2 now?

It’s a bug fix together with some code cleanup. But the code cleanup doesn’t cause any CPU instruction change. From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Friday, February 26, 2021 12:17 PM To: Ni, Ray Cc: devel@edk2.groups.io Subject: [edk2-devel] 回复: Can merge any code changes to e

[edk2-devel] 回复: Can merge any code changes to edk2 now?

Ray: Now, we are in soft feature freeze phase for stable tag 202102. In this phase, the bug fix is still allowed to be merged. So, is this change a bug fix or the code enhancement? edk2-stable202102 tag planning Proposed Schedule Date (00:00:00 UTC-8) Description 2020-11-27 Beginning of

Re: [edk2-devel] 回复: edk2-stable202102 Re: [PATCH edk2 v2 0/2] Fix two issue in ArmGicLib

Tested these patches in my Ampere Altra Mt.Jade server and they look good. I hope this fix could be included in stable tag too. Thanks, Quan On 25/02/2021 20:50, gaoliming via groups.io wrote: Leif: They are bug fixes. I am OK to merge them for this stable tag after they pass code review.

Re: [edk2-devel] [PATCH v5 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

Thank you. I have reviewed that. We still need UefiCpuPkg and MdePkg maintainer's review before merge. Thank you Yao Jiewen > -Original Message- > From: Sheng, W > Sent: Thursday, February 25, 2021 1:58 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Sheng, W > ; Ni, Ray > Cc: Dong, Eric

Re: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sheng Wei > Sent: Saturday, February 20, 2021 11:15 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Yao, > Jiewen > Subject: [edk2-devel] [PATCH v5 1/2] MdePkg/I

Re: [edk2-devel] [PATCH v5 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sheng Wei > Sent: Saturday, February 20, 2021 11:15 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek > ; Kumar, Rahul1 ; Yao, Jiewen > ; Feng, Roger > Subject: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc

Hi Liming, Got it. The patches are used to fix the bug when enable CET SMM shadow stack feature. It will cause #DF exception in in some cases. BR Sheng Wei > -Original Message- > From: gaoliming > Sent: 2021年2月25日 21:45 > To: devel@edk2.groups.io; Sheng, W ; Kinney, Michael > D ; Liu,

[edk2-devel] Can merge any code changes to edk2 now?

Liming, I have got all R-b for below changes and before I set the "push" label I want to confirm with you that is it proper for merging below code? When if not? Cpu/nasm struc3 by niruiyu * Pull Request #1462 * tianocore/edk2 (github.com) Thanks, Ray

Re: 回复: [edk2-devel] [PATCH v1 1/2] ArmVirtPkg/PlatformCI: Add EDKII CI support for Kvmtool

Liming, The patch as authored there doesn't correctly detect if a given set of changes (in a pr) impact the ArmVirtKvmTool platform. I sent a follow up with a link to a branch that will correctly return the DSC file based on the build configuration requested. Thanks Sean On 2/25/2021 6:3

Re: [edk2-devel] [PATCH v1 1/2] ArmVirtPkg/PlatformCI: Add EDKII CI support for Kvmtool

Sami, Looking over this. The root of the issue is that when I setup the PlatformBuild.py file i chose to split the objects. PlatformBuilder is the UefiBuilder and BuildSettingsManager SettingsManager is the Update, Setup, and PrEval object. This means that you need to add that

Re: [edk2-devel] [PATCH] ArmPkg/ArmGicLib: Fix setting GICv3 Interrupt Priority

Hi Ashish, This bug was already reported by Ming (who also submitted a patch). Tracked in https://bugzilla.tianocore.org/show_bug.cgi?id=3236, should make it into the tree tomorrow. Thank you for your contribution! / Leif On Thu, Feb 25, 2021 at 10:19:46 -0700, Ashish Singhal wrote: > Inco

Re: [edk2-devel] [PATCH v8 09/10] OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject

On 02/24/21 04:44, Ankur Arora wrote: > On 2021-02-23 1:39 p.m., Laszlo Ersek wrote: >> On 02/22/21 08:19, Ankur Arora wrote: >>> +    UINT32 Idx; >>> + >>> +    for (Idx = 0; Idx < mCpuHotEjectData->ArrayLength; Idx++) { >>> +  UINT64 QemuSelector; >>> + >>> +  QemuSelector = mCpuHotEject

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Remove StandaloneMmDriverEntryPoint.h

On 02/25/21 04:33, mikub...@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3235 > > The library for this header initially resided in StandaloneMmPkg > but moved to MdePkg and now this file is a duplicate of the header > file in MdePkg. >

Re: [edk2-devel] [PATCH v3 0/4] Use XADD to avoid lock acquire/release

On 02/09/21 15:16, Ni, Ray wrote: > Patch #1 follows Mike's suggestion to use XADD to avoid lock acquire/release. > Patch #2 follows Laszlo's suggestion to add global NASM macros for NASM struc > usage. > Patch #3 simply remves all hardcode offset in NASM without changing any logic. > Patch #4 rem

Re: [edk2-devel] [PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

On 02/25/21 05:04, Ni, Ray wrote: > Laszlo, > Do you think that Mike's R-b to the first patch can be an ack to the V3 patch > set? No, I don't think so. If an R-b is given in response to a specific patch (not the cover letter), and the reviewer doesn't explicitly say "series Reviewed-by" or "for

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Hi Liming, Thanks for confirmation. Here is a preview implementation we have: Introduce Standlone MM instance of MM unblock memory ・ kuqin12/mu_basecore@16dfdc3 (github.com) But please know that the real imp

Re: [edk2-devel] implement about virtio-keyboard

On 02/24/21 03:55, Zhu Yijun wrote: > Thanks for the update. > > Now the usb tablet and keyboard are the only two usb devices on > aarch64, so I want to eliminate the "qemu-xhci" controller. > > I even think the situation that something more lightweight VMM instead > of QEMU may not support any U

[edk2-devel] [PATCH] ArmPkg/ArmGicLib: Fix setting GICv3 Interrupt Priority

Incorrect register is being set for configuring interrupt priority. Correct register is located in SGI space and not in RD space. Signed-off-by: Ashish Singhal --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLi

[edk2-devel] [PATCH v2 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib

The following patches added support for StandaloneMM using FF-A: 9da5ee116a28 ArmPkg: Allow FF-A calls to set memory region's attributes 0e43e02b9bd8 ArmPkg: Allow FF-A calls to get memory region's attributes However, in the error handling logic for the Get/Set Memory attributes, the CLANG compile

[edk2-devel] [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm

From: Pierre Gondois The DependencyCheck available in .pytool detects an unnecessary dependency of the NorFlashStandaloneMm.inf module over the EmbeddedPkg package. This patch removes this dependency. Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/ed

[edk2-devel] [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001

From: Pierre Gondois This patch fixes the following Ecc reported error: INF/DEC/DSC/FDF file header comment should begin with "## @file" or "# @file" at the very top file Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmP

[edk2-devel] [PATCH v1 0/3] Prepare ArmPlatformPkg enablement

From: Pierre Gondois To prepare for the enablement of the ArmPlatformPkg CI, fix some errors reported by running the CI locally. The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmPlatformPkg_v1 Pierre Gondois (3): ArmPlatformPkg: Fix Ecc error 8001 Arm

[edk2-devel] [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001

From: Pierre Gondois This patch fixes the following Ecc reported error: File header doesn't exist File header comment missing the ""Copyright"" Even though a copyright is present in the header file, the leading '*' char prevents the Ecc tool from detecting it. According to the edk2 coding specif

回复: [edk2-devel] [PATCH v1 1/2] ArmVirtPkg/PlatformCI: Add EDKII CI support for Kvmtool

Sami: New patch will be sent after soft feature freeze (SFF). According to SFF, it will not catch this stable tag. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sami > Mujawar > 发送时间: 2021年2月25日 22:39 > 收件人: gaoliming ; devel@edk2.groups.io; > spbro...@outlook.com > 抄送: ardb+tia

Re: [edk2-devel] [PATCH v1 1/2] ArmVirtPkg/PlatformCI: Add EDKII CI support for Kvmtool

Hi All, It appears that the --dsc parameter would fail in the stuart_setup stage when running in the upstream EDKII Core CI environment. For some reason it worked for me in the local CI builds. I am testing a v2 version of my patch at https://github.com/samimujawar/edk2/tree/1596_kvmtool_ci_v2

回复: [edk2-devel] [PATCH v1 1/2] ArmVirtPkg/PlatformCI: Add EDKII CI support for Kvmtool

Sean: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sean > 发送时间: 2021年2月24日 6:32 > 收件人: devel@edk2.groups.io; sami.muja...@arm.com > 抄送: ardb+tianoc...@kernel.org; l...@nuviainc.com; > sean.bro...@microsoft.com; bret.barke...@microsoft.com; > michael.d.kin...@intel.com; gaolim...@byosoft.com.cn

回复: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Kun: I agree to add new library class MmUnblockMemoryLib and its NULL implementation into MdePkg. I want to confirm where is the real implementation for MmUnblockMemoryLib. Thanks Liming 发件人: devel@edk2.groups.io 代表 Kun Qin 发送时间: 2021年2月24日 9:49 收件人: devel@edk2.groups.io; jiewen@intel

[edk2-devel] 回复: edk2-stable202102 Re: [PATCH edk2 v2 0/2] Fix two issue in ArmGicLib

Leif: They are bug fixes. I am OK to merge them for this stable tag after they pass code review. Thanks Liming > -邮件原件- > 发件人: Leif Lindholm > 发送时间: 2021年2月25日 20:04 > 收件人: Ming Huang ; gaoliming > > 抄送: devel@edk2.groups.io; ardb+tianoc...@kernel.org; > guoh...@linux.alibaba.com; Qua

回复: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc

Wei: This is the patch set. They will be merged together, because one patch update may impact another one. We don't want to roll back previous commit. Besides, can you give the reason to merge this patch for this stable tag 202102? What impact will be caused if this patch is deferred to nex

回复: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Remove StandaloneMmDriverEntryPoint.h

Ard: I think it is a code bug fix, because the module should use the one in MdePkg instead of the one in StandaloneMmPkg. So, I am OK to merge it for this stable tag. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard > Biesheuvel > 发送时间: 2021年2月25日 16:08 > 收件人: Michael Kubacki

Re: [edk2-devel] [PATCH v3 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72191): https://edk2.groups.io/g/devel/message/72191 Mute This Topic: https://groups.io/mt/80850104/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v3 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72190): https://edk2.groups.io/g/devel/message/72190 Mute This Topic: https://groups.io/mt/80850103/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib

Hi Leif, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Leif Lindholm Sent: 25 February 2021 11:38 AM To: Sami Mujawar Cc: devel@edk2.groups.io; ardb+tianoc...@kernel.org; Matteo Carlini ; Ben Adderson ; nd Subject: Re: [PATCH v1 1/1] A

[edk2-devel] edk2-stable202102 Re: [PATCH edk2 v2 0/2] Fix two issue in ArmGicLib

On Thu, Feb 25, 2021 at 11:32:10 +0800, Ming Huang wrote: > The first patch is prepare for the second one. I have raised BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3236 to track this issue, and I would like to include this fix in the stable tag. > Ming Huang (2): > ArmPkg/ArmGicLib: Fix

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib

Hi Sami, On Wed, Feb 24, 2021 at 19:37:56 +, Sami Mujawar wrote: > The following patches added support for StandaloneMM using FF-A: > 9da5ee116a28 ArmPkg: Allow FF-A calls to set memory region's attributes > 0e43e02b9bd8 ArmPkg: Allow FF-A calls to get memory region's attributes > > However,

Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

Hi Sunny, I appreciate the input, but seeing that it is clear that no consensus has been reached with regards to how the specs should be interpreted, and that at least 4 separate people have now indicated that their interpretation is different from the one you are putting forward (i.e. you as

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Remove StandaloneMmDriverEntryPoint.h

(+ Liming) On Thu, 25 Feb 2021 at 04:33, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3235 > > The library for this header initially resided in StandaloneMmPkg > but moved to MdePkg and now this file is a duplicate of the header > file in MdePkg. > > Th