Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: Add more CRT functions

Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner (HPS SW/FW Technologist) > Sent: Thursday, January 28, 2021 10:58 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Leif Lindholm > ; Michael D Kinney > Subje

Re: [edk2-devel] [PATCH v5 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

Hi Jiewen, Ray, Could you help to review and give Review-by for this patch for fix CET shadow stack token busy bit issue ? As the common in v5 patch 1/2 by Limin, since it is a bug fix, it can still be merged in 202102 stable tag soft feature freeze phase. https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [PATCH v2] RedfishPkg/JsonLib: Add JsonLoadString function

Thanks for addressing my comment. The function header looks good to me now. Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, February 18, 2021 11:12 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Wang, Nic

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

On 22/02/21 15:53, Laszlo Ersek wrote: + + if (mCpuHotEjectData != NULL) { +CPU_HOT_EJECT_HANDLER Handler; + +Handler = mCpuHotEjectData->Handler; This patch looks otherwise OK to me, but: In patch v8 08/10, we have a ReleaseMemoryFence(). (For now, it is only expressed as a MemoryFenc

Re: [edk2-devel] [PATCH] RedfishPkg/Include: EDKII Redfish Config Handler Protocol header file

Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner (HPS SW/FW Technologist) > Sent: Monday, January 18, 2021 10:31 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) > Subject: [edk2-devel] [PATCH] RedfishPkg/Inc

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishContentCodingLib: EDKII Redfish En/Decode library

Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner (HPS SW/FW Technologist) > Sent: Monday, January 18, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Ray Ni > ; Michael D Kinney > Subject: [edk2

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

On 2021-02-22 6:53 a.m., Laszlo Ersek wrote: Adding Paolo, one comment below: On 02/22/21 08:19, Ankur Arora wrote: Call the CPU hot-eject handler if one is installed. The condition for installation is (PcdCpuMaxLogicalProcessorNumber > 1), and there's a hot-unplug request. The handler execute

Re: [edk2-devel] [PATCH v8 06/10] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state

On 2021-02-22 6:19 a.m., Laszlo Ersek wrote: On 02/22/21 08:19, Ankur Arora wrote: Init CPU_HOT_EJECT_DATA, which will be used to share CPU ejection state between SmmCpuFeaturesLib (via PiSmmCpuDxeSmm) and CpuHotPlugSmm. The init happens via SmmCpuFeaturesSmmRelocationComplete(), and so it will

Re: [edk2-devel] [PATCH] * ShellPkg: add the support to show Contained Element Count, Contained Element Record Length and Contained Elements

Hi Mars, I cannot extract the patch from your email. May be there are some problems with your git config. Do you have a fork repo in git? If yes, can you help to upload the change to your own branch and share me the link? Example: https://github.com/ZhichaoGao/edk2/tree/push The other way is at

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Could we decouple BSP and AP GDT in early waking up stage ? For example, AP uses temporary GDT (below 4GB) just for mode switching. Once AP is in the final stage, AP can reload GDT to match BSP. In this way, we don’t have assumption on the final GDT location. Thanks Maurice From: Ni, Ray Sen

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Ray, BSP's GDT table is setup in CpuDxe and then MpInitLib re-uses BSP's GDT table for APs. 1, UefiCpuPkg\CpuDxe: gdt = AllocateRuntimePool (sizeof (GdtTemplate) + 8); . gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt; 2, UefiCpuPkg\Library\MpInitLib\MpLib.c: // // Get the BSP's data of

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

“But we could allocate room under 4G for GDT table directly in CpuDxe.” The GDT pre-allocated is re-used by AP. Why do you suggest CpuDxe allocate GDT? Thanks, Ray From: devel@edk2.groups.io On Behalf Of Jeff Fan Sent: Tuesday, February 23, 2021 11:43 AM To: devel@edk2.groups.io; Ni, Ray ; Ma, M

[edk2-devel] [PATCH v3 0/3] ArmPkg: Fix several issues in OemMiscLib

Update OemMiscLib with the following changes: o Fixed ordering of return type and EFIAPI specifier. o Renamed 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'. o Renamed OemGetProcessorMaxSockets to OemGetMaxProcessors. o

[edk2-devel] [PATCH v3 2/3] ArmPkg: Rename some functions and parameters in OemMiscLib

o Rename 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. o Rename 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'. o Rename OemGetProcessorMaxSockets to OemGetMaxProcessors. o Rename OemIsSocketPresent to OemIsProcessorPresent. o Update Universal/Smbios to follow the changes to O

[edk2-devel] [PATCH v3 3/3] ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE

Update OemGetChassisType in OemMiscLib to return MISC_CHASSIS_TYPE instead of EFI_STATUS, which matches other OemMiscLib functions. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/OemMiscLib.h | 8 +++--- ArmPkg/Universal/Smbios/OemMiscLibNull/

[edk2-devel] [PATCH v3 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib

The return type should be on the line before any EFIAPI specifier. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/OemMiscLib.h | 14 +++--- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 12 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) d

Re: [edk2-devel] MP Services Protocol : Support Hyper threading or not

Dear All: Got it. Thank you very much. Thanks 发件人: devel@edk2.groups.io 代表 fanjianf...@byosoft.com.cn 发送时间: 2021年2月23日 9:18 收件人: devel@edk2.groups.io; lersek ; Tiger Liu(BJ-RD) 主题: Re: [edk2-devel] MP Services Protocol : Support Hyper threading or not " Will EFI_MP_SERVICES_PROTOCOL.StartupAl

[edk2-devel] [PATCH v2 1/1] BaseTools: Update the NASM CI dependency

Update the external dependency (consumed by Edk2Tools) version for NASM, as agreed in recent community meetings: https://edk2.groups.io/g/devel/message/71289 https://edk2.groups.io/g/devel/message/71070 This is primarily used by CI builds, but may also be used by platforms. --- BaseTools/Bin/nasm

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Ray, Yes. You are right. Acutally, x64 IDT table cannot work correctly on protected mode. :-) But for GDT location, I agree it should be located under 4G space to support AP mode changing. But we could allocate room under 4G for GDT table directly in CpuDxe. Thanks, Jeff From: Ni, Ray Dat

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Jeff, You are right that BSP’s GDT and IDT tables are under 4G memory. It’s because when AP wakes up, it needs the GDT for entering protected mode. AP cannot access above 4G memory without entering to long mode. I do agree that the 64bit IDT is not proper for AP when entering protected mode. As

回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 02/23/2021 6:30pm-7:30pm #cal-reminder

Hi, all The following BZs will be discussed in this week bug triage meeting. 3219 EDK2 Pla Placehol unassig...@tianocore.org UNCO TigerlakeOpenBoardPkg cannot boot the Tiger Lake UP3 RVP with DDR4 SODIMMs

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 02/23/2021 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 23 February 2021, 6:30pm to 7:30pm, (GMT-08:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=mb96c5bd411bd010e1e6d43a6f6c65f45 View Event ( https://edk2.groups.io/g/devel/viewevent?eventi

Re: [edk2-devel] [PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

Mike, This patch follows your suggestion to fix the performance issue first, clean up the code next. Can you check specifically this patch? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Tuesday, February 9, 2021 10:17 PM > To: devel@edk2.gro

Re: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc

Liming, I thought we decided against adding macros and instead want to use newer NASM version that supports these instructions. Mike > -Original Message- > From: gaoliming > Sent: Monday, February 22, 2021 5:01 PM > To: devel@edk2.groups.io; Liu, Zhiguang ; Sheng, W > > Cc: Kinney, M

Re: [edk2-devel] [PATCH edk2 v1 1/1] ArmPkg/ArmGicLib: Fix GICR_IPRIORITYR address wrong issue

On 2/22/21 8:52 PM, Leif Lindholm wrote: > Hi Ming, > > On Sat, Feb 20, 2021 at 15:08:39 +0800, Ming Huang wrote: >> The address of GICR_IPRIORITYR is in SGI_base frame. ARM_GICR_CTLR_FRAME_SIZE >> should add to GicCpuRedistributorBase for GICR_IPRIORITYR. Otherwise RAS >> error(Uncorrected sof

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Hello Kun, Sorry for the delayed response. Except for missing the UNI file for the newly added library, I do not have other comment for the implementation at this moment. But I am wondering if this library can be added into the MdePkg as the case for MdePkg\Library\SmmMemLib\ I have looped in J

Re: [edk2-devel] MP Services Protocol : Support Hyper threading or not

" Will EFI_MP_SERVICES_PROTOCOL.StartupAllAPs() make all 8 logical cores do some tasks simultaneously?" All APs logical processors excute AP task, not including BSP. Acutally the answer is 7. Jeff From: Laszlo Ersek Date: 2021-02-22 18:39 To: devel; tigerliu Subject: Re: [edk2-devel] MP Servi

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

> -Original Message- > From: Bandaru, Purna Chandra Rao > Sent: Tuesday, February 23, 2021 1:11 AM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Albecki, Mateusz ; Ni, Ray > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: > Improve Error handling of Ufs Pass Thru driver >

回复: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc

Wei: This is a patch set. If all patches pass the review by the package maintainer, I will help merge it. Seemly, this is a bug fix. So, it can still be merged in 202102 stable tag soft feature freeze phase. Thanks Liming > -邮件原件- > 发件人: bounce+27952+71908+4905953+8761...@groups.i

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

we will save the current BSP's GDT and IDT for APs at first time APs are waken by BSP as below. APs will start from real mode to protected mode and then to long mode. During protected mode, BSP's GDT/IDT table are working on APs. In UefiCpuPkg\Library\MpInitLib\MpLib.c, // // Get the BSP's

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

Thank you Hai Bu for the response. I have broken this into three separate patches. There were no specific recommendation in the speciation for seen multiple issues on all the UFS platforms like LKF, ADP-P and EHK. And these changes worked on all the three with various UFS cards. Can you please r

[edk2-devel] [PATCH 3/3] MdeModulePkg/UfsPassThruDxe: Improve UFS device Readiness check.

https://bugzilla.tianocore.org/show_bug.cgi?id=3217 Retry sending NOP OUT command upto 10 times. This to give extra time for UFS device to respond if was busy. Signed-off-by: Bandaru Cc: Mateusz Albecki Cc: Ray Ni Cc: Hao A Wu Change-Id: I46054ea9ee34ad295fce58dff1756241fd22e17c --- MdeModu

[edk2-devel] [PATCH 1/3] MdeModulePkg/UfsPassThruDxe: Improve Device initialization polling Loop

https://bugzilla.tianocore.org/show_bug.cgi?id=3217 Current Ufs Pass thru driver polls for 5us and return success even when the timeout occurs. There are cards that can take upto 600ms for Init and hence increased the time out for fDeviceInit polling loop. Signed-off-by: Bandaru Cc: Mateusz Albe

[edk2-devel] [PATCH 2/3] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

https://bugzilla.tianocore.org/show_bug.cgi?id=3217 Add UFS host conctroller reset in the last retry of the Link start up to allow scope for recovery of the Link. Signed-off-by: Bandaru Cc: Mateusz Albecki Cc: Ray Ni Cc: Hao A Wu Change-Id: Iecc87be51c557ec07890e2d700d6912ddf16adbd --- MdeM

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

Pierre: This patch was reviewed by BaseTools maintainer before soft feature freeze. So, it can be merged for this stable tag. I will merge it this week. Thanks Liming 发件人: tosubbounce+27952+0+...@groups.io 代表 PierreGondois 发送时间: 2021年2月23日 4:28 收件人: gaoliming ; devel@edk2.groups.io 主题:

Re: [edk2-devel] [PATCH v8 05/10] OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA

On 2021-02-22 5:06 a.m., Laszlo Ersek wrote: On 02/22/21 08:19, Ankur Arora wrote: Define CPU_HOT_EJECT_DATA and add PCD PcdCpuHotEjectDataAddress, which will be used to share CPU ejection state between OvmfPkg/CpuHotPlugSmm and PiSmmCpuDxeSmm. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Ard Biesh

Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5

The series has been pushed as 12ef75d~.. 9fb5174 Thanks, Nate > -Original Message- > From: Takuto Naito > Sent: Sunday, February 21, 2021 7:10 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > > Subject: [PATCH v2 0/2] TigerlakeOpenBoard: F

Re: [edk2-devel] [PATCH v8 04/10] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()

On 2021-02-22 4:39 a.m., Laszlo Ersek wrote: On 02/22/21 08:19, Ankur Arora wrote: Introduce UnplugCpus() which maps each APIC ID being unplugged onto the hardware ID of the processor and informs PiSmmCpuDxeSmm of removal by calling EFI_SMM_CPU_SERVICE_PROTOCOL.RemoveProcessor(). With this chan

Re: [edk2-devel] [PATCH v8 03/10] OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper

On 2021-02-22 4:31 a.m., Laszlo Ersek wrote: On 02/22/21 08:19, Ankur Arora wrote: Add QemuCpuhpWriteCpuStatus() which will be used to update the QEMU CPU status register. On error, it hangs in a similar fashion as other helper functions. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Ard Biesheuvel

Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5

Thank You Takuto! For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Takuto Naito > Sent: Sunday, February 21, 2021 7:10 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > > Subject: [PATCH v2 0/2] TigerlakeOpenBoard:

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Hi Hao, The patch series was resent with intended usage in VariableRuntime and Tcg2 drivers. Could you please provide feedback on them? Any input is appreciated. Regards, Kun From: Kun Qin Sent: Tuesday, February 9, 2021 17:25 To: devel@edk2.groups.io

[edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h

Is there a particular reason two copies of StandaloneMmDriverEntryPoint.h exist in the edk2 repo? 1. MdePkg https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h 2. StandaloneMmPkg https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Includ

Re: [edk2-devel] [PATCH v8 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events

On 2021-02-22 4:27 a.m., Laszlo Ersek wrote: On 02/22/21 08:19, Ankur Arora wrote: Process fw_remove events in QemuCpuhpCollectApicIds() and collect corresponding APIC IDs for CPUs that are being hot-unplugged. (1) We also collect selectors for those; please mention the fact here. In addit

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102

Hi Liming, Would it be possible to include the following patch "BaseTools: Align include guard policy" in this release ? https://edk2.groups.io/g/devel/message/71780 Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71997

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Great. Thanks Patrick for the quick test. Here is my thought on the UEFI Payload works on 4GB: UefiPayloadPkg tries to provides a generic UEFI payload impl with minimum hard-coded values. If UEFI payload could not work since a platform specific limitation, user could change their UEFI payload t

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Hi Guo, I tested it and it works fine with your patch. The crash is gone. BTW: Are there are other possible side effects with placing memory above 4GB? Like 32bit UEFI drivers or Option ROMs malfunctioning? Regards, Patrick On Mon, Feb 22, 2021 at 6:10 PM Dong, Guo wrote: > > > Hi Patrick, > Th

Re: [edk2-devel] [PATCH v2 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71994): https://edk2.groups.io/g/devel/message/71994 Mute This Topic: https://groups.io/mt/80474634/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] reg: RNG functions Usage in NetworkPkg

Siva, OEMs are very welcome to submit a patch for that. Thanks, Maciej On 17-Feb-21 10:31, Sivaraman Nainar wrote: Hello Maciej: We haven’t met any issue with the current implementation. RNG Library functions are using Process Based Random Number generation. Some OEM’s asking about the pla

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Hi Patrick, Thank you for the test and root-cause the issues. Could you try if this patch works with "gdtPtr.Base = (UINTN)(VOID*) gdt;"? I didn't see this issue when I tested SBL with UEFI payload on QEMU and a real platform. I guess there is something that could make AllocateRuntimePool to allo

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Hi, Ray and Eric, Is there any reason why the GDT base was typecast to UINT32 in CpuDxe driver ? In x64 long mode, the GDT base is actually 64bit. Typecasting will zero out the high 32bit address. To me the correct code seems to be something like: gdtPtr.Base = (UINTN)(VOID*) gdt; T

Re: [edk2-devel] [PATCH v2 26/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71990): https://edk2.groups.io/g/devel/message/71990 Mute This Topic: https://groups.io/mt/80474644/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 25/26] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71989): https://edk2.groups.io/g/devel/message/71989 Mute This Topic: https://groups.io/mt/80474643/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK

This patch also updates the ScmiMessageIdBasexxx for SCMI_MESSAGE_ID_BASE. The patch subject line and commit message probably needs updating accordingly. With that changed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Hi Guo, I tested on 078400ee15e7b250e4dfafd840c2e0c19835e16b and run it in QEMU. The problem seems to be here, as gdt is allocated > 4GiB: gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt; Regards, Patrick On Mon, Feb 22, 2021 at 3:59 PM Dong, Guo wrote: > > > Hi Patrick, > Please make sure you are usin

Re: [edk2-devel] [PATCH v2 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71986): https://edk2.groups.io/g/devel/message/71986 Mute This Topic: https://groups.io/mt/80474641/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71985): https://edk2.groups.io/g/devel/message/71985 Mute This Topic: https://groups.io/mt/80474639/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71984): https://edk2.groups.io/g/devel/message/71984 Mute This Topic: https://groups.io/mt/80474638/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71983): https://edk2.groups.io/g/devel/message/71983 Mute This Topic: https://groups.io/mt/80474637/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 19/26] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71982): https://edk2.groups.io/g/devel/message/71982 Mute This Topic: https://groups.io/mt/80474635/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v5 00/14] Add support for using FF-A calls

hi Sami, On Mon, 22 Feb 2021 at 19:40, Ard Biesheuvel wrote: > On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu > wrote: > > > > The following patch series adds support for using the Firmware > > Framework(FF-A) as a transport mechanism for requesting services from > > the Secure Partition Manager(SP

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Hi Patrick, Please make sure you are using latest master when testing this patch. That issue should be fix be this patch: UefiCpuPkg/CpuDxe: Fix boot error (commit: ebfe2d3eb5ac7fd92d74011edb31303a181920c7) And there is similar fix in another place as below: UefiCpuPkg/MpInitLib: Fix a hang in ab

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

Adding Paolo, one comment below: On 02/22/21 08:19, Ankur Arora wrote: > Call the CPU hot-eject handler if one is installed. The condition for > installation is (PcdCpuMaxLogicalProcessorNumber > 1), and there's > a hot-unplug request. > > The handler executes in context of SmmCpuFeaturesRendezvo

Re: [edk2-devel] [PATCH v2 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71978): https://edk2.groups.io/g/devel/message/71978 Mute This Topic: https://groups.io/mt/80474633/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71977): https://edk2.groups.io/g/devel/message/71977 Mute This Topic: https://groups.io/mt/80474632/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 15/26] ArmPkg: Rename include guard in ArmGicLib.h

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71976): https://edk2.groups.io/g/devel/message/71976 Mute This Topic: https://groups.io/mt/80474631/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71975): https://edk2.groups.io/g/devel/message/71975 Mute This Topic: https://groups.io/mt/80474630/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71974): https://edk2.groups.io/g/devel/message/71974 Mute This Topic: https://groups.io/mt/80474628/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 2/3] ArmPkg: Rename some functions and parameters in OemMiscLib

On 2/22/21 5:35 AM, Leif Lindholm wrote: On Sun, Feb 21, 2021 at 16:04:31 -0700, Rebecca Cran wrote: On 2/21/21 2:21 PM, Leif Lindholm wrote: On Sat, Feb 20, 2021 at 20:28:59 -0700, Rebecca Cran wrote: (Adding necessary patch context back in - please don't strip out until absolutely certain i

Re: [edk2-devel] [PATCH v2 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71972): https://edk2.groups.io/g/devel/message/71972 Mute This Topic: https://groups.io/mt/80474627/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71971): https://edk2.groups.io/g/devel/message/71971 Mute This Topic: https://groups.io/mt/80474626/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71970): https://edk2.groups.io/g/devel/message/71970 Mute This Topic: https://groups.io/mt/80474629/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71969): https://edk2.groups.io/g/devel/message/71969 Mute This Topic: https://groups.io/mt/80474624/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71968): https://edk2.groups.io/g/devel/message/71968 Mute This Topic: https://groups.io/mt/80474623/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71967): https://edk2.groups.io/g/devel/message/71967 Mute This Topic: https://groups.io/mt/80474621/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71966): https://edk2.groups.io/g/devel/message/71966 Mute This Topic: https://groups.io/mt/80474616/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc

On Mon, Feb 8, 2021 at 03:04 AM, PierreGondois wrote: > > + > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf > Should PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.inf be used here? Regards, Sami Mu

Re: [edk2-devel] [PATCH v8 06/10] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state

On 02/22/21 08:19, Ankur Arora wrote: > Init CPU_HOT_EJECT_DATA, which will be used to share CPU ejection > state between SmmCpuFeaturesLib (via PiSmmCpuDxeSmm) and CpuHotPlugSmm. > > The init happens via SmmCpuFeaturesSmmRelocationComplete(), and so it > will run as part of the PiSmmCpuDxeSmm entr

Re: [edk2-devel] [PATCH v2 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71963): https://edk2.groups.io/g/devel/message/71963 Mute This Topic: https://groups.io/mt/80474620/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71962): https://edk2.groups.io/g/devel/message/71962 Mute This Topic: https://groups.io/mt/80474618/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71961): https://edk2.groups.io/g/devel/message/71961 Mute This Topic: https://groups.io/mt/80474615/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v2 01/26] ArmPkg: Fix Ecc error 8001 in Chipset

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71960): https://edk2.groups.io/g/devel/message/71960 Mute This Topic: https://groups.io/mt/80474622/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v5 00/14] Add support for using FF-A calls

On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu wrote: > > The following patch series adds support for using the Firmware > Framework(FF-A) as a transport mechanism for requesting services from > the Secure Partition Manager(SPM). This is done through a Pcd which > can be used to enable the FF-A mechan

Re: [edk2-devel] [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

On Mon, 22 Feb 2021 at 12:47, Sughosh Ganu wrote: > > > hi Ard, > > On Mon, 22 Feb 2021 at 16:19, Ard Biesheuvel wrote: >> >> On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu wrote: >> > >> > The Secure Partition(SP) can request services from the Secure >> > Partition Manager Core(SPMC) either through

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

This patch breaks booting on master. In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is casted to 32bits. Regards, Patrick On Fri, Feb 19, 2021 at 3:12 AM Ma, Maurice wrote: > > Reviewed-by: Maurice Ma > > Regards > Maurice > > > -Original Message- > > From: Dong, Guo > >

Re: [edk2-devel] [edk2-platforms PATCH v3 3/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

On Thu, Feb 18, 2021 at 20:57:41 -0700, Rebecca Cran wrote: > o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. > o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support > for SMBIOS 3.4.0, as is required by SBBR. > o Add an implementation of OemMiscLib that provides the sy

Re: [edk2-devel] [edk2-platforms PATCH v3 2/3] SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib

On Thu, Feb 18, 2021 at 20:57:40 -0700, Rebecca Cran wrote: > Use the copy of the CountCpusFromFdt function from FdtHelperLib. This patch also needs to invoke CountCpusFromFdt ... Hmm, come to think of it. Could we change the name of the function (in 1/3) to FdtHelperCountCpus? Since it's now a gl

Re: [edk2-devel] [PATCH v8 05/10] OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA

On 02/22/21 08:19, Ankur Arora wrote: > Define CPU_HOT_EJECT_DATA and add PCD PcdCpuHotEjectDataAddress, which > will be used to share CPU ejection state between OvmfPkg/CpuHotPlugSmm > and PiSmmCpuDxeSmm. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: B

Re: [edk2-devel] [edk2-platforms PATCH v3 1/3] SbsaQemu: Add FdtHelperLib

On Thu, Feb 18, 2021 at 20:57:39 -0700, Rebecca Cran wrote: > The CountCpusFromFdt function is now used in two places. Create > FdtHelperLib for this and similar functions. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm One comment below, you can fold in or not and still keep the re

Re: [edk2-devel] [edk2-sct PATCH 3/3] edk2-test: Helper script to build SCT+Shell in a bootable format

Reviewed-by: G Edhaya Chandran Upstreamed by : https://github.com/tianocore/edk2-test/commit/92efde18495c2c77ceac1a0cd0d34c32b8e13431 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71952): https://edk2.groups.io/g/devel/message/71952 Mut

Re: [edk2-devel] [PATCH edk2 v1 1/1] ArmPkg/ArmGicLib: Fix GICR_IPRIORITYR address wrong issue

Hi Ming, On Sat, Feb 20, 2021 at 15:08:39 +0800, Ming Huang wrote: > The address of GICR_IPRIORITYR is in SGI_base frame. ARM_GICR_CTLR_FRAME_SIZE > should add to GicCpuRedistributorBase for GICR_IPRIORITYR. Otherwise RAS > error(Uncorrected software error) will reported in ArmGicDxe. > > Signed-

Re: [edk2-devel] [edk2-sct PATCH 2/3] edk2-test: use bash 'shift' in build.sh to manage arguments

Upstreamed by the commit-id :  https://github.com/tianocore/edk2-test/commit/cff3686e83d5a3e32c5ba57c296b7d4e3266508d -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71950): https://edk2.groups.io/g/devel/message/71950 Mute This Topic: htt

Re: [edk2-devel] [PATCH v8 04/10] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()

On 02/22/21 08:19, Ankur Arora wrote: > Introduce UnplugCpus() which maps each APIC ID being unplugged > onto the hardware ID of the processor and informs PiSmmCpuDxeSmm > of removal by calling EFI_SMM_CPU_SERVICE_PROTOCOL.RemoveProcessor(). > > With this change we handle the first phase of unplug

Re: [edk2-devel] [PATCH v2 2/3] ArmPkg: Rename some functions and parameters in OemMiscLib

On Sun, Feb 21, 2021 at 16:04:31 -0700, Rebecca Cran wrote: > On 2/21/21 2:21 PM, Leif Lindholm wrote: > > On Sat, Feb 20, 2021 at 20:28:59 -0700, Rebecca Cran wrote: (Adding necessary patch context back in - please don't strip out until absolutely certain it is irrelevant to conversation.) diff

Re: [edk2-devel] [PATCH v8 03/10] OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper

On 02/22/21 08:19, Ankur Arora wrote: > Add QemuCpuhpWriteCpuStatus() which will be used to update the QEMU > CPU status register. On error, it hangs in a similar fashion as > other helper functions. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Boris

Re: [edk2-devel] [PATCH v8 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events

On 02/22/21 08:19, Ankur Arora wrote: > Process fw_remove events in QemuCpuhpCollectApicIds() and collect > corresponding APIC IDs for CPUs that are being hot-unplugged. (1) We also collect selectors for those; please mention the fact here. > > In addition, we now ignore CPUs which only have re

Re: [edk2-devel] [edk2-sct PATCH 1/3] edk2-test: Add support for building extra packages

Upstreamed by commit-id :  https://github.com/tianocore/edk2-test/commit/1f4b6b22521232bca1e185681ac514eee38ad822 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71945): https://edk2.groups.io/g/devel/message/71945 Mute This Topic: https:/

Re: [edk2-devel] [PATCH v8 01/10] OvmfPkg/CpuHotplugSmm: refactor hotplug logic

On 02/22/21 08:19, Ankur Arora wrote: > Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into > ProcessHotAddedCpus(). This is in preparation for supporting CPU > hot-unplug. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Boris Ostrovsky > Cc

Re: [edk2-devel] [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

hi Ard, On Mon, 22 Feb 2021 at 16:19, Ard Biesheuvel wrote: > On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu > wrote: > > > > The Secure Partition(SP) can request services from the Secure > > Partition Manager Core(SPMC) either through FF-A calls or through the > > existing SVC calls. Add a feature

Re: [edk2-devel] [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu wrote: > > The Secure Partition(SP) can request services from the Secure > Partition Manager Core(SPMC) either through FF-A calls or through the > existing SVC calls. Add a feature flag Pcd for enabling the FF-A > method -- when this is set to FALSE, the

Re: [edk2-devel] MP Services Protocol : Support Hyper threading or not

On 02/22/21 08:08, Tiger Liu(BJ-RD) wrote: > Dear All: > I have a question about MP Services Protocol. > Does it support Hyper-threading technology? > > For example: > A Quad-cores CPU(with HT feature support), actually it is equal to 8 logical > cores. > Take assumption 8 logical cores are all h

  1   2   >