Re: [edk2-devel] [edk2-platforms][PATCH v1 2/3] MinPlatformPkg/MinPlatformPkg.dsc: Add basic MM_STANDALONE libraries

2021-02-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, February 5, 2021 4:15 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 2/3] > MinPlatformPkg/Mi

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/3] MinPlatformPkg/SpiFlashCommonLibNull: Make MODULE_TYPE BASE

2021-02-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, February 5, 2021 4:15 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 1/3] > MinPlatformPkg/Sp

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/3] MinPlatformPkg/SpiFvbService: Add Standalone MM support

2021-02-10 Thread Nate DeSimone
Hi Michael, Given that MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceMm.c is almost identical to MinPlatformPkg/Flash/SpiFvbService/Smm/SpiFvbServiceSmm.c, it seems a little inappropriate to remove Intel's copyright from that file. You are welcome to add a Microsoft copyright of course. Other

Re: [edk2-devel] [Patch V3 8/8] Update Maintainers.txt for TigerlakeOpenBoardPkg

2021-02-10 Thread Nate DeSimone
The series has been pushed as 51bfa26~..6f2b23c Thanks, Nate > -Original Message- > From: Luo, Heng > Sent: Tuesday, February 9, 2021 8:00 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [Patch V3 8/8] Update Maintainers.txt for TigerlakeOpe

Re: [edk2-devel] [Patch V3 8/8] Update Maintainers.txt for TigerlakeOpenBoardPkg

2021-02-10 Thread Nate DeSimone
Great Job Heng! For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Tuesday, February 9, 2021 8:00 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [Patch V3 8/8] Update Maintainers.txt for TigerlakeOp

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Add X64 build support

2021-02-10 Thread Michael Kubacki
I updated the patch with your new email in V2. Thanks, Michael On 2/10/2021 2:31 PM, Ard Biesheuvel wrote: On Wed, 3 Feb 2021 at 04:54, wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3202 Several libraries have been added to the package to support X64 but

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning

2021-02-10 Thread Michael Kubacki
Hi Ard, V2 is now on the list. Thanks, Michael On 2/10/2021 2:30 PM, Ard Biesheuvel wrote: On Wed, 3 Feb 2021 at 04:51, wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3204 Fixes the following compiler warning in VS2019 by changing defining the MmramRangeC

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning

2021-02-10 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3204 Fixes the following compiler warning in VS2019 by changing defining the MmramRangeCount variable to be UINTN and type casting prior to value assignment. \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): error C2220:

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Add X64 build support

2021-02-10 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3202 Several libraries have been added to the package to support X64 but the package itself does not support X64. This modifies the DSC to enable X64 build. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreet

Re: [edk2-devel] [edk2-announce] Reminder: Community meeting this week - please see updates

2021-02-10 Thread Soumya Guptha
Hi Folks, This is a Reminder for tomorrow's Community meeting in the morning for EMEA/NAMO from 9-10am (PST), that was rescheduled from last week. Talk to you all tomorrow. Thanks, Soumya -Original Message- From: annou...@edk2.groups.io On Behalf Of Soumya Guptha Sent: Thursday,

Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

2021-02-10 Thread Rebecca Cran
On 1/15/21 7:51 PM, Sami Mujawar wrote: I have shared some initial thoughts on the RNG implementation updates at https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf Kindly let me know your feedback or if you have any queries. The

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection()

2021-02-10 Thread Ard Biesheuvel
On Tue, 9 Feb 2021 at 23:25, Sami Mujawar wrote: > > Hi Michael, > > Thank you for this patch. > > There must be something missing with the GCC5 settings for AARCH64 as this > problem does not get flagged. > That is because EFIAPI is #define'd to an empty string on all architectures except X64

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Add X64 build support

2021-02-10 Thread Ard Biesheuvel
On Wed, 3 Feb 2021 at 04:54, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3202 > > Several libraries have been added to the package to support X64 but > the package itself does not support X64. This modifies the DSC to > enable X64 build. > > Cc: Ard Bie

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning

2021-02-10 Thread Ard Biesheuvel
On Wed, 3 Feb 2021 at 04:51, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3204 > > Fixes the following compiler warning in VS2019 by changing defining > the MmramRangeCount variable to be UINTN and type casting prior > to value assignment. > > \edk2\Stan

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

2021-02-10 Thread Leif Lindholm
On Wed, Feb 10, 2021 at 08:04:57 -0700, Rebecca Cran wrote: > The ARM ProcessorSubClassDxe build was broken due to changes in the > SmbiosProcessor API and an unused variable. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Pushed as c615265b366d. Thanks! > --- > ArmPkg/Universal/

Re: [edk2-devel] [PATCH v1 10/10] Maintainers.txt: Added maintainers and reviewers for the DurianPkg

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:30 +0800, Ling Jia wrote: > Signed-off-by: Ling Jia Reviewed-by: Leif Lindholm > --- > Maintainers.txt | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 56e16fc48cb4..2e8e1d3272fd 100644 > --- a/Maintainers

Re: [edk2-devel] [PATCH v1 09/10] Silicon/Phytium: Added Rtc driver to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:29 +0800, Ling Jia wrote: > The RealTimeClockLib implemented EFI RealTimeClock > runtime services via RTC Lib. > > Signed-off-by: Ling Jia > --- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | > 1 + > Platform/Phytium/DurianPkg/Duri

Re: [edk2-devel] [PATCH v1 08/10] Silicon/Phytium: Added fvb driver for norflash

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:28 +0800, Ling Jia wrote: > The FlashFvbDxe provided the fvb protocol, > which requested by the flash operators. > > Signed-off-by: Ling Jia > --- > Platform/Phytium/DurianPkg/DurianPkg.dsc |1 + > Platform/Phytium/DurianPkg/DurianPkg

Re: [edk2-devel] [PATCH v1 07/10] Silicon/Phytium: Added flash driver support to Phytium Silicon

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:27 +0800, Ling Jia wrote: > The SpiNorFlashDxe provided norflash initialization, > read-write, erase and other interfaces. > > Signed-off-by: Ling Jia > --- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | > 1 + > Platform/Phytium/Duri

Re: [edk2-devel] [PATCH v1 06/10] Silicon/Phytium: Added Spi driver support to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:26 +0800, Ling Jia wrote: > The SpiDxe is to provide Spi bus read-write interface. > > Signed-off-by: Ling Jia > --- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 9 + > Platform/Phytium/DurianPkg/DurianPkg.dsc| 5 +

Re: [edk2-devel] [PATCH v1 05/10] Silicon/Phytium: Added PciHostBridgeLib to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:25 +0800, Ling Jia wrote: > The Pci host bridge library is mainly > to get Pci bridge information. > > Signed-off-by: Ling Jia > --- > Platform/Phytium/DurianPkg/DurianPkg.dsc | > 9 + > Platform/Phytium/DurianPkg/DurianPkg.fdf

Re: [edk2-devel] [PATCH v1 04/10] Silicon/Phytium: Added PciSegmentLib to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:24 +0800, Ling Jia wrote: > The PCI Segment Library for Phytium platform. > with multiple RCs. > > Signed-off-by: Ling Jia > --- > Platform/Phytium/DurianPkg/DurianPkg.dsc|9 +- > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciS

Re: [edk2-devel] [PATCH v1 03/10] Silicon/Phytium: Added SMBIOS support to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:23 +0800, Ling Jia wrote: > This driver installs SMBIOS information for FT2000/4. > > Signed-off-by: Ling Jia Reviewed-by: Leif Lindholm / Leif > --- > Platform/Phytium/DurianPkg/DurianPkg.dsc > | 6 + > Platform/Phytium

Re: [edk2-devel] [PATCH v1 02/10] Silicon/Phytium: Added Acpi support to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:22 +0800, Ling Jia wrote: > Added Acpi driver and table to FT2000/4, > the ACPI Tables providing library AcpiTables.inf uses > a lot of information that is available in the form of PCDs > for differnt platforms. > > Signed-off-by: Ling Jia > --- > Platform/Phytium/D

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Add X64 build support

2021-02-10 Thread Sami Mujawar
Hi Michael, Thank you for this patch. Acked-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: devel@edk2.groups.io On Behalf Of mikuback via groups.io Sent: 03 February 2021 03:54 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Supreeth Ve

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platform/Qemu/SbsaQemu: Add SMBIOS tables

2021-02-10 Thread Graeme Gregory
On 10/02/2021 03:24, Rebecca Cran wrote: o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The

Re: [edk2-devel] [PATCH v1 01/10] Silicon/Phytium: Added PlatformLib to FT2000/4

2021-02-10 Thread Leif Lindholm
On Fri, Feb 05, 2021 at 18:06:21 +0800, Ling Jia wrote: > The PlatformLib supported the system > library for FT2000/4 chip. > Platform/Phytium: Added the dsc and fdf files of DurianPkg. > > Signed-off-by: Ling Jia > --- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec

[edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

2021-02-10 Thread Rebecca Cran
The ARM ProcessorSubClassDxe build was broken due to changes in the SmbiosProcessor API and an unused variable. Signed-off-by: Rebecca Cran --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Unive

Re: [edk2-devel] [Patch] BaseTools: Fix the ending character for Linux script BuildEnv

2021-02-10 Thread Bob Feng
Thank you Mike. Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Wednesday, February 10, 2021 9:53 AM To: Feng, Bob C ; Leif Lindholm ; Kinney, Michael D Cc: devel@edk2.groups.io; Liming Gao ; Chen, Christine ; Matthew Carlson Subject: RE: [Patch] BaseTools: Fix the end

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning

2021-02-10 Thread Sami Mujawar
Hi Michael, Please see my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki via groups.io Sent: 10 February 2021 02:59 AM To: devel@edk2.groups.io; Sami Mujawar Cc: Ard Biesheuvel ; Jiewen Yao ; Supreeth V