Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Add MpService dependency

2021-02-02 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Lou, Yun > Sent: Tuesday, February 2, 2021 8:41 AM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric > ; Laszlo Ersek ; Kumar, Rahul1 > > Subject: [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Add MpService > dependency > > R

[edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add microcode header verification.

2021-02-02 Thread Aaron Li
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3196 Microcode header should be checked before calling IsMicrocodePatchNeedLoad(). This is to make sure garbage value after remove microcode from FV would not cause stack overflow in IsMicrocodePatchNeedLoad(). Signed-off-by: Aaron Li Cc: Ray Ni

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-02 Thread Ankur Arora
On 2021-02-02 6:15 a.m., Laszlo Ersek wrote: On 02/02/21 15:00, Laszlo Ersek wrote: ... I guess that volatile-qualifying both CPU_HOT_EJECT_DATA, and the array pointed-to by CPU_HOT_EJECT_DATA.ApicIdMap, should suffice. In combination with the sync-up point that you quoted. This seems to match

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-02 Thread Ankur Arora
On 2021-02-02 6:00 a.m., Laszlo Ersek wrote: On 02/01/21 21:12, Ankur Arora wrote: On 2021-02-01 11:08 a.m., Laszlo Ersek wrote: apologies, I've got more comments here: On 01/29/21 01:59, Ankur Arora wrote: /** + CPU Hot-eject handler, called from SmmCpuFeaturesRendezvousExit(), + on ea

Re: [edk2-devel] [PATCH v6 9/9] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug

2021-02-02 Thread Ankur Arora
On 2021-02-01 9:37 a.m., Laszlo Ersek wrote: On 01/29/21 01:59, Ankur Arora wrote: As part of the negotiation treat ICH9_LPC_SMI_F_CPU_HOT_UNPLUG as a subfeature of feature flag ICH9_LPC_SMI_F_CPU_HOTPLUG, so enable it only if the other is also being negotiated. Cc: Laszlo Ersek Cc: Jordan Jus

Re: [edk2-devel] [PATCH v6 8/9] OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection

2021-02-02 Thread Ankur Arora
On 2021-02-02 5:23 a.m., Laszlo Ersek wrote: On 02/01/21 20:21, Ankur Arora wrote: On 2021-02-01 9:22 a.m., Laszlo Ersek wrote: On 01/29/21 01:59, Ankur Arora wrote: Designate a worker CPU (we use the one executing the root MMI handler), which will do the actual ejection via QEMU in CpuEject()

Re: [edk2-devel] [PATCH v6 6/9] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state

2021-02-02 Thread Ankur Arora
On 2021-02-01 5:36 a.m., Laszlo Ersek wrote: On 01/29/21 01:59, Ankur Arora wrote: Init CPU_HOT_EJECT_DATA, which will be used to share CPU ejection state between SmmCpuFeaturesLib (via PiSmmCpuDxeSmm) and CpuHotPlugSmm. CpuHotplugSmm also sets up the CPU ejection mechanism via CPU_HOT_EJECT_DAT

Re: [edk2-devel] [PATCH v6 4/9] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()

2021-02-02 Thread Ankur Arora
On 2021-01-31 7:13 p.m., Laszlo Ersek wrote: On 01/29/21 01:59, Ankur Arora wrote: Introduce UnplugCpus() which maps each APIC ID being unplugged onto the hardware ID of the processor and informs PiSmmCpuDxeSmm of removal by calling EFI_SMM_CPU_SERVICE_PROTOCOL.RemoveProcessor(). With this chan

[edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Add X64 build support

2021-02-02 Thread mikuback
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3202 Several libraries have been added to the package to support X64 but the package itself does not support X64. This modifies the DSC to enable X64 build. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreet

[edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection()

2021-02-02 Thread mikuback
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3203 The EFIAPI modifier is present in the function definition in FvLib.c but missing in FvLib.h. Causes a GCC build error. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Signed-off-by: Micha

[edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmCore: Fix compiler warning

2021-02-02 Thread mikuback
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3204 Fixes the following compiler warning in VS2019 by changing defining the MmramRangeCount variable to be UINTN and type casting prior to value assignment. \edk2\StandaloneMmPkg\Core\StandaloneMmCore.c(570): error C2220:

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

2021-02-02 Thread Sheng Wei
Hi Jiewen, Thank you for the comments. 1) I have tried CET is working if set gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmRestrictedMemoryAccess = TRUE 2) 3) I will add detail comments and add shadow stack layout in the source code file. 4) Sorry for miss the code in file https://github.com/tianocore/e

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 02/02/2021 6:30pm-7:30pm #cal-reminder

2021-02-02 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 2 February 2021, 6:30pm to 7:30pm, (GMT-08:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=mb96c5bd411bd010e1e6d43a6f6c65f45 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid

[edk2-devel] 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc

2021-02-02 Thread gaoliming
Wei: The normal process is to send RFC in edk2 mail list and collect the feedback. This RFC introduces the proposed change, the impact and the suggestion. Then, wait for one or two weeks to collect the feedback. If there are more feedback, more time will be required. Now, we are in the late

Re: [edk2-devel] [edk2-announce] Reminder: Community meeting this week - please resync your calendar

2021-02-02 Thread Nate DeSimone
Hi All, For those on macOS systems, the WebEx client can be downloaded here: https://intel.webex.com/client/WBXclient-41.1.4-13/mac/intel/Webex.pkg Thanks, Nate On 2/2/21, 4:34 PM, "annou...@edk2.groups.io on behalf of Soumya Guptha" wrote: Dear Community members, Tianocore communi

[edk2-devel] Reminder: Community meeting this week - please resync your calendar

2021-02-02 Thread Soumya Guptha
Dear Community members, Tianocore community meeting is coming up this week, on 2/4 from 9am-10am (PST) and 7.30pm-8.30pm (PST). Please resync and subscribe to the calendar (https://edk2.groups.io/g/devel/calendar) so you have the latest series. Thanks, Soumya Soumya Guptha Tianocore Commun

Re: [edk2-devel] [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc

2021-02-02 Thread Sheng Wei
Hi Mike, If we plan to update the NSAM version, it will affect everyone why is building the BIOS image, do you know the process ? How to request all the people update their NSAM tool ? How long will be the whole process ? Thanks BR Sheng Wei > -Original Message- > From: Kinney, Michael D

[edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

2021-02-02 Thread Kun Qin
The interface proposed in this patch series intends to provide an abstraction layer for DXE drivers to request certain memory regions to be accessible from inside MM environment that applies total memory blockage. This abstraction could pave way for models such as Standalone MM to manage memory re

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

2021-02-02 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3168 This interface definition provides an abstraction layer for DXE drivers to request certain memory blocks to be mapped/unblocked for accessibility inside MM environment. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Cc: Jiewen Ya

Re: [edk2-devel] [PATCH 1/2] Maintainers.txt: Remove Jordan Justen from EmulatorPkg

2021-02-02 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Feb 2, 2021, at 12:34 PM, Jordan Justen wrote: > > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Jordan Justen > --- > Maintainers.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 2cd356551e..96e792ab66 100644

[edk2-devel] [PATCH 2/2] Maintainers.txt: Remove Jordan Justen from OvmfPkg

2021-02-02 Thread Jordan Justen
Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Jordan Justen --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 96e792ab66..e986a3680c 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -423,7 +423,6 @@ R: Siyuan Fu OvmfPkg F

[edk2-devel] [PATCH 1/2] Maintainers.txt: Remove Jordan Justen from EmulatorPkg

2021-02-02 Thread Jordan Justen
Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Jordan Justen --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 2cd356551e..96e792ab66 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -197,7 +197,6 @@ M: Ard Biesheuvel EmulatorPkg F

Re: [edk2-devel] [PATCH edk2-platforms v3 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-02 Thread Ilias Apalodimas
Hi Sami, On Tue, 2 Feb 2021 at 17:13, Sami Mujawar wrote: > > Hi Ilias, > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > -Original Message- > From: Ilias Apalodimas > Sent: 02 February 2021 02:50 PM > To: Sami Mujawar > Cc: Sughosh Ganu ; devel@edk2.gro

Re: [edk2-devel] [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc

2021-02-02 Thread Laszlo Ersek
On 02/02/21 16:21, Kinney, Michael D wrote: > Hi Sheng, > > I recommend we update required NASM version. > > From your investigation, the new min version would be 2.15.01. I'd be happy with that -- the Linux distros I primarily care about seem to support a nasm version that's not earlier than th

回复: [edk2-devel] 回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 02/02/2021 6:30pm-7:30pm #cal-reminder

2021-02-02 Thread gaoliming
Niels: Yes. Now, the meeting doesn’t start. You can join the meeting on its time slot. Thanks Liming 发件人: bounce+27952+71058+4905953+8761...@groups.io 代表 Niels Holm Olsen 发送时间: 2021年2月2日 17:49 收件人: gaoliming ; devel@edk2.groups.io 主题: Re: [edk2-devel] 回复: [edk2-devel] TianoCore Bug Tria

Re: [edk2-devel] 回复: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc

2021-02-02 Thread Michael D Kinney
Liming, We can always install a newer version in CI agents, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Monday, February 1, 2021 7:51 PM > To: Sheng, W ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Liu, Zhiguang ; Yao, Jiewen > ; 'Andrew

Re: [edk2-devel] [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc

2021-02-02 Thread Michael D Kinney
Hi Sheng, I recommend we update required NASM version. From your investigation, the new min version would be 2.15.01. Mike > -Original Message- > From: Sheng, W > Sent: Monday, February 1, 2021 7:39 PM > To: gaoliming ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Liu, Zhiguang ;

Re: [edk2-devel] [PATCH edk2-platforms v3 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-02 Thread Sami Mujawar
Hi Ilias, Please see my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Ilias Apalodimas Sent: 02 February 2021 02:50 PM To: Sami Mujawar Cc: Sughosh Ganu ; devel@edk2.groups.io; Ard Biesheuvel ; Leif Lindholm ; Sahil Malhotra ; nd Subject: Re: [PATCH

Re: [edk2-devel] [PATCH edk2-platforms v3 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-02 Thread Ilias Apalodimas
Hi Sami, Inlining some additional info on my explanation. > > > [...] > > > I actually picked up the error handling from the previous non-FFA code. > > > I'll check what's on Sughosh latest patches and fix it if there are > > > any differences. > > > Looking at it again EFI_BAD_BUFFER_SIZE can c

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-02 Thread Laszlo Ersek
On 02/02/21 15:00, Laszlo Ersek wrote: > ... I guess that volatile-qualifying both CPU_HOT_EJECT_DATA, and the > array pointed-to by CPU_HOT_EJECT_DATA.ApicIdMap, should suffice. In > combination with the sync-up point that you quoted. This seems to match > existing practice in PiSmmCpuDxeSmm -- t

Re: [edk2-devel] [PATCH v6 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject()

2021-02-02 Thread Laszlo Ersek
On 02/01/21 21:12, Ankur Arora wrote: > On 2021-02-01 11:08 a.m., Laszlo Ersek wrote: >> apologies, I've got more comments here: >> >> On 01/29/21 01:59, Ankur Arora wrote: >> >>> /** >>> + CPU Hot-eject handler, called from SmmCpuFeaturesRendezvousExit(), >>> + on each CPU at exit from SMM. >>

Re: [edk2-devel] [PATCH v6 8/9] OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection

2021-02-02 Thread Laszlo Ersek
On 02/01/21 20:21, Ankur Arora wrote: > On 2021-02-01 9:22 a.m., Laszlo Ersek wrote: >> On 01/29/21 01:59, Ankur Arora wrote: >>> Designate a worker CPU (we use the one executing the root MMI >>> handler), which will do the actual ejection via QEMU in CpuEject(). >>> >>> CpuEject(), on the worker C

Re: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Add an override for 16550 HID in SSDT

2021-02-02 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71063): https://edk2.groups.io/g/devel/message/71063 Mute This Topic: https://groups.io/mt/80029091/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode

2021-02-02 Thread Albecki, Mateusz
Hello, Sorry for getting in so late on the conversation but I want to make sure we are not going to break some platforms with this change. Excuse me if I am simply repeating what was being said before. 1. We can’t have SataControllerDxe report supported for all raid interface devices on th

Re: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid

2021-02-02 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71061): https://edk2.groups.io/g/devel/message/71061 Mute This Topic: https://groups.io/mt/80029084/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v2 0/2] Add a Pcd to override the 16650 HID in SSDT

2021-02-02 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71060): https://edk2.groups.io/g/devel/message/71060 Mute This Topic: https://groups.io/mt/80029085/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH edk2-platforms v3 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-02 Thread Ilias Apalodimas
Hi Sami, On Tue, Feb 02, 2021 at 10:40:32AM +, Sami Mujawar wrote: > Hi Ilias, > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > -Original Message- > From: Ilias Apalodimas > Sent: 01 February 2021 02:01 PM > To: Sami Mujawar > Cc: Sughosh Ganu ;

Re: [edk2-devel] 回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 02/02/2021 6:30pm-7:30pm #cal-reminder

2021-02-02 Thread Niels Holm Olsen
Hi Out of curiosity and to follow up on my bugreport 3186, I would like to know if it makes sense and is ok if I try to join the TianoCore Bug Triage tonight/early tomorrow. I have taken the liberty of following the link to meetingsamer and it resulted in a download of a webex.exe. Running this

[edk2-devel] How can I receive EAP packets?

2021-02-02 Thread 梁宇飞
Hello, I am Jiangbo technology R&D, using edkii to write EAP certified loader, I use EFI_ SIMPLE_ NETWORK.Transmit () to contract, want to use EFI_ SIMPLE_ NETWORK.Receive () to receive packets. It is found that ordinary IP packets can be received, but EAP packets cannot be received. How can I rece

[edk2-devel] [PATCH] IntelFsp2Pkg: Add YAML file generation support

2021-02-02 Thread Loo Tung Lun
Add support for YAML format file generation in addition to current BSF structure. Configuration of YAML format output will be supported by an open source ConfigEditor. Reference to YAML code, test and ConfigEditor is at https://github.com/joshloo/fsp_yaml_cfg/tree/master/Tools A unit test is also

Re: [edk2-devel] [PATCH edk2-platforms v3 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-02 Thread Sami Mujawar
Hi Ilias, Please see my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Ilias Apalodimas Sent: 01 February 2021 02:01 PM To: Sami Mujawar Cc: Sughosh Ganu ; devel@edk2.groups.io; Ard Biesheuvel ; Leif Lindholm ; Sahil Malhotra Subject: Re: [PATCH edk2

[edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe

2021-02-02 Thread Patrick Rudolph
Currently the console is connected before EndOfDxe causing OptionsROMs to be loaded, but their drivers aren't used and thus no GOP is installed. To make use of 3rdparty OptionROMs connect the console after EndOfDxe. Tested on Intel CFL board using Nvidia Quadro GPU. Signed-off-by: Patrick Rudolp