On Tue, Jan 26, 2021 at 4:49 PM Leif Lindholm wrote:
>
> Hi Vikas,
>
> On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > > +/** A helper macro for returning configuration manager objects
> > > > > > +*/
> > > > > > +#define HANDLE_CM_OBJECT(ObjId, CmObjectId, Object, ObjectCount
These changes add platform specific DSDT generator
and Clk dsdt properties for LX2160ARDB.
Signed-off-by: Vikas Singh
---
.../ConfigurationManagerDxe/ConfigurationManager.c | 9 ++
.../ConfigurationManagerDxe/ConfigurationManager.h | 4 +-
.../ConfigurationManagerDxe.inf|
These changes intend to add Common Configuration Manager (CM)
for all fsl platforms and Platform headers consumed by CM for
LX2160ARDB.
Signed-off-by: Vikas Singh
---
.../ConfigurationManagerDxe/ConfigurationManager.c | 834 +
.../ConfigurationManagerDxe/ConfigurationManager.
This patch series sets the foundation of Dynamic ACPI framework for all
fsl layerscape platforms. In order to achieve:
- Configurable firmware builds.
- Unify firmware build for similar platforms.
- Minimize/eliminate human induced errors.
- Validate and generate firmware that complies with
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
EDK-II-Release-Planning.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md
index 336d8d2..bbb5f18 100644
--- a/EDK-II-Release-Planning.md
+++ b/EDK-II-Release-Planning.md
@@ -32,6 +32,7 @@
Hi Renan,
The UEFI driver model uses a stack of several modular DXE drivers to translate
from lower level to higher level interfaces. As a baseline reference, this is
what the driver stack would look like for a UFS device on an Intel SoC:
+--+
| EFI_BL
> -Original Message-
> From: Kun Qin
> Sent: Wednesday, January 27, 2021 3:47 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Dong, Eric ; Ni, Ray
> Subject: [PATCH v4 11/20] MdeModulePkg: SmmSmiHandlerProfileLib:
> Support StandaloneMm Instance
>
> REF: https://bugzilla
> On Jan 26, 2021, at 9:23 AM, renan.moraes2 via groups.io
> wrote:
>
> Good afternoon,
>
> We are studying how to communicate with Universal Flash Storage (UFS) device
> on UEFI environment. The first step is identify the UFS device, we are using
> the system Lenovo Flex 5G (It has Snapdrago
When we added the SpellCheck to CI, we intended to move through package by
package and turn on the PR gate checks (right now they're all in "audit only").
To do this, we must first fix all the existing spelling errors and/or update
the ignore lists and dictionaries with expected terms.
I would
On 2021-01-26 1:32 p.m., Laszlo Ersek wrote:
On 01/26/21 22:17, Ankur Arora wrote:
On 2021-01-26 1:07 p.m., Laszlo Ersek wrote:
On 01/26/21 20:15, Ankur Arora wrote:
On 2021-01-26 11:01 a.m., Laszlo Ersek wrote:
I'll continue the review later this week.
Acking the comments above.
Thank
On 01/26/21 22:17, Ankur Arora wrote:
> On 2021-01-26 1:07 p.m., Laszlo Ersek wrote:
>> On 01/26/21 20:15, Ankur Arora wrote:
>>> On 2021-01-26 11:01 a.m., Laszlo Ersek wrote:
>>
I'll continue the review later this week.
>>>
>>> Acking the comments above.
>>
>> Thank you!
>>
>>> Meanwhile let
On 2021-01-26 1:07 p.m., Laszlo Ersek wrote:
On 01/26/21 20:15, Ankur Arora wrote:
On 2021-01-26 11:01 a.m., Laszlo Ersek wrote:
I'll continue the review later this week.
Acking the comments above.
Thank you!
Meanwhile let me reprocess the series in light of the comments above.
I'm at
On 01/26/21 20:15, Ankur Arora wrote:
> On 2021-01-26 11:01 a.m., Laszlo Ersek wrote:
>> I'll continue the review later this week.
>
> Acking the comments above.
Thank you!
> Meanwhile let me reprocess the series in light of the comments above.
I'm at such a point now, during the v5 review, th
On 01/26/21 20:44, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3129
>
> This patch series is a follow up of previous submission:
> https://edk2.groups.io/g/devel/message/70329
>
> These module changes are validated on two different physical platforms.
> Standalone and tra
Good afternoon,
We are studying how to communicate with Universal Flash Storage (UFS) device on
UEFI environment. The first step is identify the UFS device, we are using the
system Lenovo Flex 5G (It has Snapdragon processor + UFS device).
We tried to identify the UFS device in three ways:
1 -
On 2021-01-26 10:03 a.m., Laszlo Ersek wrote:
Hi Ankur,
On 01/26/21 07:44, Ankur Arora wrote:
Hi,
This series adds support for CPU hot-unplug with OVMF.
Please see this in conjunction with the QEMU secureboot hot-unplug v2
series posted here (now upstreamed):
https://lore.kernel.org/qemu-
This change of SmmCpuExceptionHandlerLib adds support for StandaloneMm
components to allow x64 StandaloneMm environment setting up exception
handlers.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Kun Qin
Reviewed-by: Laszlo Ersek
Reviewed-by: Ray Ni
---
Notes:
This change adds a new CpuIo driver instance for MM_STANDALONE type. The
new driver entrypoint is implemented in a separate file to match the
interface definition of MM_STANDALONE modules.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Kun Qin
---
Notes:
v4:
This change added an instance of UefiDevicePathLib for StandaloneMm. It
abstracts DevicePathFromHandle function into different files for
Standalone MM and other instances to avoid linking gBS into MM_STANDALONE
drivers.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Kun Qi
This change added a new instance of Tpm2DeviceLibDTpm to support drivers
of type MM_STANDALONE. It abstracts dynamic Pcd access into separate file
for different instances to avoid dynamic usage for StandaloneMm modules.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by
This change added support of RSC router under StandaloneMm. It replaces
SMM version ReportStatusCode protocol definitions with MM version. This
patch also switched to use gMmst instead of gSmst. Lastly, it abstracts
standalone and traditional MM driver entrypoints into separate files to
allow maxim
This change abstracts CpuIo2Smm driver entrypoint into separate file and
moves functions/definitions that are not substantially specific to
Traditional MM (SMM) into CpuIo2Mm.* in order to set ways for Standalone
MM support in the future.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kuma
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3185
This change added support of SMI handler profile library router under
StandaloneMm. This change replaces gSmst with gMmst. It also abstracts
standalone and traditional MM driver entrypoints into separate files to
allow maximal common impleme
This change replaced gSmst with gMmst to support broader compatibility
under MM environment for CpuIo2Smm driver.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Kun Qin
Reviewed-by: Laszlo Ersek
Reviewed-by: Ray Ni
---
Notes:
v4:
- Added reviewed-by tag [
This change added support of StandaloneMm for StatusCodeHandler. It
adds a new instance of StatusCodeHandler of MM_STANDALONE type, and
abstracts the driver entrypoint into separate files, replaced gSmst with
gMmst, and switched to MM version of RscHandlerProtocol.
Cc: Jian J Wang
Cc: Hao A Wu
C
This change extends this null instance of Tcg2PpVendorLib to support
MM_STANDALONE drivers.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Kun Qin
Reviewed-by: Jiewen Yao
---
Notes:
v4:
- Previously reviewed. No change.
v3:
- Previously reviewed
This change added support of StandaloneMm for ReportStatusCodeLib. It
adds a new instance of ReportStatusCodeLib for MM_STANDALONE type, and
abstracts the references of gMmst and gSmst functionalities into separate
files in order to link in proper Service Table for SMM core/drivers.
Cc: Jian J Wan
This change added a new instance of Tcg2PhysicalPresenceLib to support
MM_STANDALONE type drivers. It centralizes the common routines into
shared files and abstract the library constructor into corresponding
files to implement each constructor function prototypes.
Cc: Jiewen Yao
Cc: Jian J Wang
This change added support of StandaloneMm for SmmLockBoxLib. It replaces
gSmst with gMmst to support both traditional MM and standalone MM. The
contructor and desctructor functions are abstracted to support different
function prototype definitions.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Eric Dong
Si
This change extends StandaloneMmMemLib library to support X64
architecture. The implementation is ported from MdePkg/Library/SmmMemLib.
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Signed-off-by: Kun Qin
Reviewed-by: Jiewen Yao
---
Notes:
v4:
- Added re
This change added a new instance of AcpiTimerLib for StandaloneMm core
and drivers. It centralizes the common routines into shared files and
abstract the library constructor into corresponding files to accommodate
each constructor function prototypes.
Cc: Ray Ni
Signed-off-by: Kun Qin
Reviewed-
Assigning MmramRangeCount from MmCorePrivate (UINT64) to local variable
MmramRangeCount (UINT32) will cause compilation failure due to "warning
C4244: '=': conversion from 'UINT64' to 'UINT32', possible loss of data".
This changes defines local MmramRangeCount as UINTN type and adds type
cast befor
This change added support of FPDT driver under StandaloneMm. It replaces
SMM version ReportStatusCode protocol with MM version. This patch also
abstracts standalone and traditional MM interfaces into separate files to
support each corresponding function prototypes and implementations.
Cc: Jian J W
This change adds support of x64 version of StandaloneMmCoreHobLib. It
brings in global variable "gHobList" through StandaloneMmCoreEntryPoint,
imports implementation from DxeCoreHobLib.inf to support x64 Mm Core and
moved shared functional plementations into a common file.
Cc: Ard Biesheuvel
Cc:
This change extends StandaloneMmCoreEntryPoint library to support X64
architecture.
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Signed-off-by: Kun Qin
Reviewed-by: Jiewen Yao
---
Notes:
v4:
- Reviewed previously. No change.
v3:
- Reviewed prev
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3129
This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/70329
These module changes are validated on two different physical platforms.
Standalone and traditional MM are both tested to be functional on
Function '_ModuleEntryPoint' is a pre-defined interface for various EFI
module types and should not be caught violating EFI coding style. This
change added '_ModuleEntryPoint' into exception list to fix EFI coding
style error 8006 during CI build.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Sig
On 2021-01-26 11:01 a.m., Laszlo Ersek wrote:
On 01/26/21 07:44, Ankur Arora wrote:
Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into
PlugCpus(). This is in preparation for supporting CPU hot-unplug.
Cc: Laszlo Ersek
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: B
On 01/26/21 20:01, Laszlo Ersek wrote:
> On 01/26/21 07:44, Ankur Arora wrote:
>> + if (EFI_ERROR(Status)) {
>> +goto Fatal;
>>}
>
> (13) Without having seen the rest of the patches, I think this error
> check should be nested under the same (PluggedCount > 0) condition; in
> other words
On 01/26/21 20:01, Laszlo Ersek wrote:
> (1b) Similarly, in the parameter comments, "to be plugged" is wrong. I
> suggest copying the parameter descriptions from
> QemuCpuhpCollectApicIds():
>
> @param[out] PluggedApicIds The APIC IDs of the CPUs that have been
>
On 01/26/21 07:44, Ankur Arora wrote:
> Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into
> PlugCpus(). This is in preparation for supporting CPU hot-unplug.
>
> Cc: Laszlo Ersek
> Cc: Jordan Justen
> Cc: Ard Biesheuvel
> Cc: Igor Mammedov
> Cc: Boris Ostrovsky
> Cc: Aaron Young
On 01/26/21 07:44, Ankur Arora wrote:
> Hi,
>
> This series adds support for CPU hot-unplug with OVMF.
>
> Please see this in conjunction with the QEMU secureboot hot-unplug v2
> series posted here (now upstreamed):
>
> https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-imamm...@redha
Hi Ankur,
On 01/26/21 07:44, Ankur Arora wrote:
> Hi,
>
> This series adds support for CPU hot-unplug with OVMF.
>
> Please see this in conjunction with the QEMU secureboot hot-unplug v2
> series posted here (now upstreamed):
>
> https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-ima
On Friday, January 15, 2021 11:57 PM, Pranav Madhu wrote:
> SMBIOS provides basic hardware and firmware configuration information
> through table-driven data structure. This patch series adds SMBIOS
> support for Arm's SGI/RD platforms.
>
> The first patch in this series defines platform-id valu
Many thanks.
Reviewed-by: Leif Lindholm
Pushed as 04744d2432ba.
On Tue, Jan 12, 2021 at 15:06:21 +0800, wenyi,xie via groups.io wrote:
> Hi Leif,
>
> I have pushed my patch to github, here's the link:
> https://github.com/leadsama/edk2-non-osi/tree/compile_issue_fix_v1
>
> Thanks
> Wenyi
>
>
Reviewed-by: Jiewen Yao
From: devel@edk2.groups.io On Behalf Of Kun Qin
Sent: Thursday, January 21, 2021 9:35 AM
To: devel@edk2.groups.io; Ard Biesheuvel ; Sami Mujawar
; Yao, Jiewen ; Supreeth Venkatesh
Subject: Re: [edk2-devel] [PATCH v3 03/18] StandaloneMmPkg:
StandaloneMmCoreHobLib: Exte
Thanks. Looks good to me.
Reviewed-by: Jiewen Yao
From: Kun Qin
Sent: Thursday, January 21, 2021 9:44 AM
To: devel@edk2.groups.io; Yao, Jiewen
Cc: Ard Biesheuvel ; Sami Mujawar
; Supreeth Venkatesh
Subject: RE: [edk2-devel] [PATCH v3 05/18] StandaloneMmPkg: StandaloneMmMemLib:
Extends suppo
On Mon, Jan 25, 2021 at 12:36:53 +0800, Abner Chang wrote:
> Add more functions which were missed in the first time commit,
> that causes the build error with EDK2 Redfish feature driver.
>
> strerror - We don't support this on edk2 environment.
> strpbrk - Cloned this function from edk2-LibC
> F
Hi Abner,
On Mon, Jan 25, 2021 at 12:31:54 +0800, Abner Chang wrote:
> This patch fixes the build errors when build JsonLib with EDK2
> Redfish feature driver.
>
> - Add JsonLoadString function to load a NULL terminated-string JSON
> - json_string_value() in JsonValueGetAsciiString () is removed
Hi Vikas,
On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > +/** A helper macro for returning configuration manager objects
> > > > > +*/
> > > > > +#define HANDLE_CM_OBJECT(ObjId, CmObjectId, Object, ObjectCount)
> > > > > \
> > > > > + case ObjId: {
Hi Liming,
If it was purely a question of style, I would agree that whatever is
70% used should be the norm. But this is not really an issue under our
control.
Macros starting with leading _ are reserved for toolchain use.
Some toolchains, i.e. clang, have dedicated warnings for this.
Whether we
On 01/26/21 06:50, Ni, Ray wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3179
>
> When BSP first time wakes all APs, each AP atomically increases
> CpuMpData->CpuCount and CpuMpData->FinishedCount.
> Each AP atomically increases CpuMpData->NumApsExecuting
> in early assembly code an
On 1/14/21 5:36 PM, Rebecca Cran wrote:
> Add helper function to read the MMFR2 register. We will need this to
> determine CCIDX support.
>
> Signed-off-by: Rebecca Cran
> Reviewed-by: Leif Lindholm
> Reviewed-by: Sami Mujawar
> ---
> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 +++
53 matches
Mail list logo
