回复: [edk2-devel] [Patch V4 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

Chinni: Can you change subject and commit message with the top flash address instead of higher flash address? Thanks Liming > -邮件原件- > 发件人: bounce+27952+65758+4905953+8761...@groups.io > 代表 cbduggap > 发送时间: 2020年9月30日 13:49 > 收件人: devel@edk2.groups.io > 抄送: cbduggap ; Bob Feng > ; Limi

[edk2-devel] [Patch V1 1/1] \Silicon\Intel\Tools\FitGen: Add extra parameter to the Fit Gen Tool to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap --- Silicon/Int

[edk2-devel] [Patch V4 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap Cc: Bob Feng Cc

[edk2-devel] [Patch V1 1/1] \Silicon\Intel\Tools\FitGen: Add extra parameter to the Fit Gen Tool to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap --- Silicon/Int

[edk2-devel] [Patch V3 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap Cc: Bob Feng Cc

Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Got it! v2 patches sent to mail list. From: gaoliming [mailto:gaolim...@byosoft.com.cn] Sent: Wednesday, September 30, 2020 8:59 AM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; 'Laszlo Ersek' Cc: Wang, Nickle (HPS SW) ; 'Andrew Fish' ; 'Leif Lindholm' ; 'Michael D Kinney'

[edk2-devel] [RedfishPkg PATCH v2 4/4] edk2: Add maintainers to RedfishPkg

Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 6a22a14796..cabadac177 100644 --- a/Maintainers.txt +++ b/Ma

[edk2-devel] [RedfishPkg PATCH v2 3/4] .azurepipelines/templates: Add RedfishPkg to target build

Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/temp

[edk2-devel] [RedfishPkg PATCH v2 2/4] .pytool: Add CI on RedfishPkg

Add RedfishPkg to CI test. Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang --- .pytool/CISettings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 0c

[edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.

Initial version of RedfishPkg. Signed-off-by: Wu Jiaxin Signed-off-by: Fu Siyuan Signed-off-by: Wang Fan Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- RedfishPkg/RedfishPkg.ci.yaml | 67 +

[edk2-devel] [RedfishPkg PATCH v2 0/4] Inital RedfishPkg

Initial version of RedfishPkg and the CI test on RedfishPkg. CI Test result: https://github.com/tianocore/edk2/pull/975 There is no components in RedfishPkg in this commit, the further edk2 Redfish components will be committed base on this version. changab (4): RedfishPkg: Initial commit of Re

Re: [EXTERNAL] RE: [edk2-announce] 回复: [edk2-devel] Tianocore community page on who we are - please review

Hi Leif and Liming I have double checked with Mike Kinney on the role and responsibility of reviewers. Mike and I reach the consensus below (a short version, detail will be added to the wiki page later): 1) Maintainers are the ONLY ones who can approve a patch. 2) Reviewers CANNOT approve the pa

Re: [edk2-devel] [PATCH 1/1] BaseTools: Update license of UserManuals files

I would object to remove these manual for now. The short description and the example of tool usage are still useful. Thanks, Bob -Original Message- From: gaoliming Sent: Wednesday, September 30, 2020 8:44 AM To: devel@edk2.groups.io; Feng, Bob C ; Chen, Christine Subject: 回复: [edk2-

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Merged at d8ab884fe9b4dd148980bf0d8673187f8fb25887. Thanks, Zhichao > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 30, 2020 12:50 AM > To: devel@edk2.groups.io; Gao, Zhichao ; Vladimir > Olovyannikov > Cc: Samer El-Haj-Mahmoud ; Maciej > Rabeda ; Wu, Jiaxin ; Fu,

Re: [edk2-devel] 回复: [PATCH 1/1] BaseTools: Move C tool flags before the common flags

I see. Thanks. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Wednesday, September 30, 2020 8:57 AM To: Feng, Bob C ; devel@edk2.groups.io Cc: Chen, Christine Subject: [edk2-devel] 回复: [PATCH 1/1] BaseTools: Move C tool flags before th

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 09/29/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 29 September 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=m623b1dceab0c6dc62d56b2508fa50f39 View Event ( https://edk2.groups.io/g/devel/viewevent?event

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Vladimir, It is a bug fix for http. It is part of NetworkPkg. I see you already add the maintainer and reviewer in the Cc list. Sometimes, the maintainers/reviewers may be busy at other work and miss the patch. You can remind and push them for review. If the maintainers/reviewers don't have

回复: [edk2-devel] 回复: [edk2-devel] [Patch V2 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

So, the specified top flash address should be less than 4G. Right? If yes, I suggest to update the patch tile with the top flash address instead of the higher flash address. The higher flash address may confuse me that it may be above 4G. Thanks Liming 发件人: bounce+27952+65713+4905953+8761

回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Yes. Maintainer has the both role of reviewer and patch merge. Thanks Liming 发件人: bounce+27952+65723+4905953+8761...@groups.io 代表 Abner Chang 发送时间: 2020年9月29日 19:23 收件人: Laszlo Ersek ; devel@edk2.groups.io 抄送: Wang, Nickle (HPS SW) ; Andrew Fish ; Leif Lindholm ; Michael D Kinney 主题: Re

[edk2-devel] 回复: [PATCH 1/1] BaseTools: Move C tool flags before the common flags

Bob: In edk2\BaseTools\Source\C\Makefiles\header.makefile, TOOL_INCLUDE is the first include directory. So, I update DscBuildData.py to generate Edk2 source package include directory to TOOL_INCLUDE macro. Then, PcdValueInit will search the definition from Edk2 source package first. Thanks

回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".

Reviewed-by: Liming Gao > -邮件原件- > 发件人: bounce+27952+65712+4905953+8761...@groups.io > 代表 Zhiguang Liu > 发送时间: 2020年9月29日 16:12 > 收件人: devel@edk2.groups.io; Liu, Zhiguang > 抄送: Wang, Sanyo ; Kinney, Michael D > ; Liming Gao > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "ad

回复: [edk2-devel] [PATCH 1/1] BaseTools: Update license of UserManuals files

Bob: I suggest to send RFC to propose to remove all BaseTools UserManuals files. If no objection, they can be removed. In fact, they are out of maintain for long time. For license update, I have no comment. Thanks Liming > -邮件原件- > 发件人: bounce+27952+65714+4905953+8761...@groups.io

[edk2-devel] [edk2-platforms] [PATCH V1 1/2] MinPlatformPkg: Add missing bounds checks to CompressLib

Current code only as bounds checks in ASSERT macros. They are also needed in release mode where ASSERT is not used. Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- .../MinPlatformPkg/Library/CompressLib/CompressLib.c | 10 -- 1 file c

[edk2-devel] [edk2-platforms] [PATCH V1 2/2] MinPlatformPkg: Coding style cleanups in CompressLib

Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- .../Library/CompressLib/CompressLib.c | 177 +- .../Library/CompressLib/CompressLib.inf | 4 +- 2 files changed, 95 insertions(+), 86 deletions(-) diff --git a/Plat

[edk2-devel] [edk2-platforms] [PATCH V1 0/2] MinPlatformPkg: Minor fixes in CompressLib

Current code only has bounds checks in ASSERT macros. They are also needed in release mode where ASSERT is not used. Also adds coding style cleanups in CompressLib Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Nate DeSimone (2): MinPlatformPkg:

[edk2-devel] Please resync your calendar - next community meeting on Oct 8th

Dear Community members, Our next community meeting is on the 8th of October from 9am-10am (PST) and 7.30pm-8.30pm (PST). Please resync and subscribe to the calendar so you have the meeting. https://edk2.groups.io/g/devel/calendar Thanks, Soumya Soumya Guptha Open Source Firmware PM, SFP/IAGS

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/OpensslLib: Add native instruction support for X64

The GCC build fails with this error: `OPENSSL_ia32cap_P' referenced in section `.text.OPENSSL_cpuid_setup' of /tmp/ccIIRAYs.ltrans20.ltrans.o: defined in discarded section `COMMON' of /mnt/c/mssql/tiano/Build/OvmfX64/DEBUG_GCC5/X64/CryptoPkg/Library/OpensslLib/OpensslLibX64/OUTPUT/OpensslLibX64.

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix incorrect display resolution

Fix https://github.com/pftf/RPi4/issues/100 by swapping RPi DisplayDxe resolution settings for 640x480 and 800x600, which were incorrectly mapped to the settings shown in the Setup configuration variable. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by:

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 09/29/20 04:29, Gao, Zhichao wrote: > Hi, > > I have checked in openCI and it is passed. > > Reviewed-by: Zhichao Gao > > Hi Laszlo, > > Do you have a plan to test this patch? Yep, I've been watching this thread as well. I'm happy that you are OK with v13, and so v13 is about to be merged.

Re: [edk2-devel] [PATCH v13 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Zhichao, Thank you for review. There is another commit waiting for review, which is related to Http, but it is not related to ShellPkg: https://edk2.groups.io/g/devel/message/64765 If one has a server which replies with Content-type: HTML, but does not send the Content-Length field, this con

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Correct issue with memory protection enabled.

Jeff, Thanks for the patch. I will send a patch to move the Maintainers.txt one level up for consistency with other TianoCore repos. Reviewed-By Samer El-Haj-Mahmoud From: devel@edk2.groups.io On Behalf Of Jeff Brasen via groups.io Sent: Wednesday, September 23, 2020 11:56 AM To: Laszlo Erse

Re: [edk2-devel] [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4

Thanks Pete and Andrei. Should we count these as RB or AB for the patch? Reviewed-by: Samer El-Haj-Mahmoud From: devel@edk2.groups.io On Behalf Of Andrei Warkentin via groups.io Sent: Monday, September 21, 2020 4:01 PM To: Pete Batard ; Jeff Booher-Kaeding ; devel@edk2.groups.io Cc: Ard Biesh

Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset

Reviewed-by: Maciej Rabeda On 28-Sep-20 08:29, Abner Chang wrote: BZ #2909, https://bugzilla.tianocore.org/show_bug.cgi?id=2909 When Http->Configure() is invoked with HttpConfigData set to NULL to reset the EFI HTTP instance, TLS child instance is destroyed but HttpInstance->TlsChildHandle is

[edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix invalid memory access in AArch64 SetJump/LongJump

Correct the memory offsets used in REG_ONE/REG_PAIR macros to synchronize them with definition of the BASE_LIBRARY_JUMP_BUFFER structure on AArch64. The REG_ONE macro declares only a single 64-bit register be read/written; however, the subsequent offset has previously been 16 bytes larger, creatin

[edk2-devel] [PATCH 0/1] MdePkg/BaseLib: AArch64 SetJump/LongJump bugfix

Hi all, I have recently discovered a bug in the BaseLib's implementation of SetJump and LongJump; the offsets listed in the assembly files are 8 bytes off, causing the functions to read/write 8 bytes past the end of the jump buffer. More details can be found in the commit message. I must admit I

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

On 09/29/20 06:13, Guo Dong wrote: > >> On 09/26/20 02:34, Dong, Guo wrote: >>> >>> Sorry to have a long email thread since my merge and thanks all for >>> the comments. >>> In general, I still feel current process is a little complicated for >>> the maintainers who don't daily work on EDK2 like m

Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Without R, I still can give reviewed-by to others contribute to RedfishPkg right? Get Outlook for Android From: Laszlo Ersek Sent: Tuesday, September 29, 2020, 6:42 PM To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io Cc: Wan

Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

On 09/29/20 11:47, changab wrote: > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Maintainers.txt | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 6

[edk2-devel] [RedfishPkg PATCH 1/4] RedfishPkg: Initial commit of RedfishPkg.

Initial version of RedfishPkg. Signed-off-by: Wu Jiaxin Signed-off-by: Fu Siyuan Signed-off-by: Wang Fan Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- RedfishPkg/RedfishPkg.ci.yaml | 67 +

[edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Signed-off-by: Chang Abner Cc: Nickle Wang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 6a22a14796..cc9d173285 100644 --- a/Maintainers.txt +++ b/M

[edk2-devel] [RedfishPkg PATCH 3/4] .azurepipelines/templates: Add RedfishPkg to target build

Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/temp

[edk2-devel] [RedfishPkg PATCH 0/4] Inital RedfishPkg

Initial version of RedfishPkg and the CI test on RedfishPkg. CI Test result: https://github.com/tianocore/edk2/pull/975 There is no components in RedfishPkg in this commit, the further edk2 Redfish components will be committed base on this version. changab (4): RedfishPkg: Initial commit of Re

[edk2-devel] [RedfishPkg PATCH 2/4] .pytool: Add CI on RedfishPkg

Add RedfishPkg to CI test. Signed-off-by: Abner Chang Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Nickle Wang --- .pytool/CISettings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 0c

[edk2-devel] Any plan to enforce the x509 EKU check?

Hi, My colleagues recently raised a question to me: does UEFI enforce the x509v3 extended key usage check, such as CodeSigning, for Secure Boot? (Some certification such as NIAP OS PP requires the OS to verify EKUs of x509 certs, and they wonder if UEFI requires similar checks.) I did a quick ch

Re: [edk2-devel] [PATCH] BaseTools Build_Rule: Add the missing ASM16_FLAGS for ASM16 source file

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Friday, September 25, 2020 3:38 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Chen, Christine Subject: [edk2-devel] [PATCH] BaseTools Build_Rule: Add the missing ASM16_FLAGS for ASM16 sourc

Re: [edk2-devel] [PATCH 1/1] BaseTools: Update license of UserManuals files

Liming, I think some information is still valid and useful but not in the tool's help message, so I think we can just update license this time. Thanks, Bob -Original Message- From: Chen, Christine Sent: Tuesday, September 29, 2020 10:52 AM To: devel@edk2.groups.io; gaolim...@byosoft.c

Re: [edk2-devel] 回复: [edk2-devel] [Patch V2 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

Use case : For Boot from Block device feature, As Block device is not Memory mapped, we need some agent to load the Initial firmware to Host memory. CSE takes care of it by mapping CSE internal SRAM to host memory of 4GB to 4 GB – 256 KB. *Boot from Block Configuration Host Memory Map :* Curre

Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".

Reviewed-by: Zhiguang Liu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiguang > Liu > Sent: Tuesday, September 29, 2020 4:09 PM > To: devel@edk2.groups.io > Cc: Wang, Sanyo ; Kinney, Michael D > ; Liming Gao > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Upda

[edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".

From: "Wang, Sanyo" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352 SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5) Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sanyo Wang --- MdePkg/Include/IndustryStandard/SmBios.h | 4 +++- 1 file changed, 3 i

Re: [edk2-devel] [PATCH 1/1] BaseTools: Move C tool flags before the common flags

Hi Liming, Would you explain the purpose of the change done in DscBuildData.py? Thanks, Bob -Original Message- From: Liming Gao Sent: Wednesday, September 16, 2020 9:03 AM To: devel@edk2.groups.io Cc: Chen, Christine ; Feng, Bob C Subject: [PATCH 1/1] BaseTools: Move C tool flags befo

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h

Reviewed-by: Bob Feng -Original Message- From: Liming Gao Sent: Friday, September 25, 2020 3:49 PM To: devel@edk2.groups.io Cc: gaoliming ; Feng, Bob C ; Chen, Christine ; Kinney, Michael D Subject: [edk2-devel] [PATCH v2 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h Fr