On 09/25/20 07:25, Ni, Ray wrote:
> Reviewed-by: Ray Ni
Acked-by: Laszlo Ersek
Thanks
Laszlo
>
>> -Original Message-
>> From: Lou, Yun
>> Sent: Friday, September 25, 2020 11:58 AM
>> To: devel@edk2.groups.io
>> Cc: Lou, Yun ; Ni, Ray ; Dong, Eric
>> ; Laszlo Ersek
>> ; Kumar, Rahul1
gInXcode is only used by GDB script and if optimization is turned on then
compiler
treats this variable as unused so it can't been linked in the final object.
Signed-off-by: LiuYu
---
EmulatorPkg/Unix/Host/Host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg/Un
Reviewed-by: Ray Ni
> -Original Message-
> From: Lou, Yun
> Sent: Friday, September 25, 2020 11:58 AM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Ni, Ray ; Dong, Eric
> ; Laszlo Ersek
> ; Kumar, Rahul1
> Subject: [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.
>
>
I think you should add NOOPT target as well. NOOPT catches more
compiler issues than debug/release given the change in optimization
flags and it is used less by developers.
Once you run a build you should also add the badge to the readme.rst
(https://github.com/tianocore/edk2/blob/master/Read
Andrew,
That’s actually what got me here. EccCheck runs as part of our CI now (but it
didn’t when I wrote these tests a year ago). I need to either figure out how to
get this code to pass EccCheck in a reasonable way, or just not contribute the
tests and say “go to Mu for the tests, if you want
Bret,
I’ve had this issue with EFI code too. It will compile with for DEBUG and
RELEASE as the optimizer removes the memcpy/memset. So you only see a build
failure when you compiler NOOPT (and there are no intrinsic libs). I mostly see
this in platform code when I try to compile a single driver
One of the things we’re really trying to do here is make a strong case for
contributing good tests, so I want them to be both:
* Good citizens of code hygiene, and
* Good examples of real-world, non-trivial tests (I actually used the new
UnitTestFrameworkPkg and test-driven design while
ERROR - EFI coding style error
ERROR - *Error code: 7001
ERROR - *There should be no use of int, unsigned, char, void, long in any .c,
.h or .asl files
ERROR - *file:
//home/corthon/_uefi/edk2_qemu_ci/edk2/MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePolicyUnitTest.c
ERRO
So for context, this is a new host-based test that should only run within a
platform OS, so intrinsics aren’t the big deal that they would be in FW code.
But we do need to figure out how to simultaneously adhere to the coding
convention while enabling test authoring.
Or we chose to not enforce q
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Wednesday, September 23, 2020 7:21 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Chen, Christine
>
> Subject: [edk2-devel] [Patch] BaseTools: Clean the ffs folder before
> generat
If the structure is a non-static local variable, most compilers will silently
inject an intrinsic call to memcpy in function initialization. This leads to
an intermittent linker error.
If the compiler you use automatically supports an intrinsic memcpy in the given
architecture or optimizes out
ERROR - EFI coding style error
ERROR - *Error code: 5007
ERROR - *There should be no initialization of a variable as part of its
declaration
ERROR - *file:
//home/corthon/_uefi/edk2_qemu_ci/edk2/MdeModulePkg/Library/VariablePolicyLib/VariablePolicyUnitTest/VariablePolicyUnitTest.c
ERROR - *Line n
Expect a few of these questions as I update 2000+ lines of test code that was
written prior to EccCheck.
“The function headers should follow Doxygen special documentation blocks in
section 2.3.5”
Doxygen doesn’t have a section 2.3.5.
Nor does the EDKII coding standard.
- Bret
-=-=-=-=-=-=-=-
I've discovered the failure was because CryptoPkg includes its own stddef.h
which is a wrapper for CrtLibSupport.h
I have added the required definitions to this file and have resolved the error:
typedef INTN ptrdiff_t;
typedef UINT32 wchar_t;
Thanks,
Christopher Zurcher
> -
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, September 23, 2020 8:37 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Chen, Christine
>
> Subject: [Patch] BaseTools: Remove CanSkip calling for incremental build
>
> REF: https://bugzilla.tianocore.o
Zurcher:
Can you specify the detail build step to reproduce the build error with
CLANGPDB tool chain?
Thanks
Liming
> -邮件原件-
> 发件人: bounce+27952+65588+4905953+8761...@groups.io
> 代表 Zurcher,
> Christopher J
> 发送时间: 2020年9月25日 8:28
> 收件人: Yao, Jiewen ; Jiang, Guomin
> ; devel@edk2.groups
https://bugzilla.tianocore.org/show_bug.cgi?id=2979
Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE
for IA32/X64 and DEBUG/RELEASE. Label this these as
FULL builds, so if additional build options are added
in the future, they can be added to these FULL builds.
Cc: Jordan Justen
Cc: Andrew
I was able to successfully build and run the non-optimized code with LLVM, but
the optimized version returns this error during build:
C:\Program Files\LLVM\lib\clang\9.0.0\include\stdatomic.h:91:17: error: unknown
type name 'wchar_t'
typedef _Atomic(wchar_t)atomic_wchar_t;
Is there
This seems like a big enough "platform" difference that we should be testing in
platform ci.
To do that you would need to add another item in the matrix here
https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L26
and here:
https://github.com/
Hi Sami,
The set of define values looks more complex than needed for single bit field
checks.
Perhaps we can simplify to just defining the bit locations and the IS_ macros
check
for 0 or non-zer0 results?
#define EFI_ACPI_EXTENDED_INTERRUPT_FLAG_PRODUCER_CONSUMER_MASK BIT0
#define EFI_ACPI_E
Hi Maciej,
Can you please review this patch?
It is sitting there for a while, looks like it slipped through the cracks.
Thank you,
Vladimir
> -Original Message-
> From: Vladimir Olovyannikov
> Sent: Friday, August 28, 2020 11:17 AM
> To: devel@edk2.groups.io
> Cc: Vladimir Olovyannikov ;
While working on the SctPkg, I noticed the Contributions.txt file in the
top of the repo still mentions the TianoCore Contribution Agreement.
Does it need updated?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65584
The mailing list has changed from lists.01.org to groups.io.
Update Maintainers.txt and Readme.md to match.
Signed-off-by: Rebecca Cran
---
uefi-sct/Maintainers.txt | 2 +-
uefi-sct/Readme.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/Maintainers.txt b/
build.sh contains a mixture of tabs and spaces, with differing
numbers of spaces used for indents. Update it so any single block only
uses one style of indentation.
Signed-off-by: Rebecca Cran
---
uefi-sct/SctPkg/build.sh | 33 -
1 file changed, 16 insertions(+),
build.sh usage indicates that "GCC5" can be specified, but it's currently
rejected due to a case statement only matching "GCC" or "gcc".
Fix this by adding a wildcard match.
Signed-off-by: Rebecca Cran
---
uefi-sct/SctPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The mailing list has changed from lists.01.org to groups.io.
Update Maintainers.txt and Readme.md to match.
Signed-off-by: Rebecca Cran
---
uefi-sct/Maintainers.txt | 2 +-
uefi-sct/Readme.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/Maintainers.txt b/
build.sh contains a mixture of tabs and spaces, with differing
numbers of spaces used for indents. Update it so any single block only
uses one style of indentation.
Signed-off-by: Rebecca Cran
---
uefi-sct/SctPkg/build.sh | 33 -
1 file changed, 16 insertions(+),
On 09/23/20 23:34, Bret Barkelew wrote:
> Agreed. It's random that the previous config worked.
Here's an idea.
Assume we have two DXE drivers (D1 and D2), each of which registers an
EndOfDxe notification function (each to be queued at TPL_CALLBACK or
TPL_NOTIFY, doesn't matter).
Assume D1 does s
I noticed the GCC5 SctPkg build was broken. This patch series
fixes it and also resolves a couple of other issues I found.
Rebecca Cran (3):
uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain
uefi-sct: Fix the mailing list address in Maintainers.txt and
Readme.md
uefi-sct/SctPk
build.sh usage indicates that "GCC5" can be specified, but it's currently
rejected due to a case statement only matching "GCC" or "gcc".
Fix this by adding a wildcard match.
Signed-off-by: Rebecca Cran
---
uefi-sct/SctPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Vladimir Olovyannikov
Cc: Zhichao Gao
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Ray Ni
Cc: Liming Gao
Cc: Nd
Cc: Laszlo Ersek
Cc: Samer El-Haj-Mahmoud
This patchset introduces an http client utilizing EDK2 HTTP protocol, to
allow fast image downloading from http/ht
Introduce an http client utilizing EDK2 HTTP protocol, to
allow fast image downloading from http/https servers.
HTTP download speed is usually faster than tftp.
The client is based on the same approach as tftp dynamic command, and
uses the same UEFI Shell command line parameters. This makes it easy
I have some comments for the items below…. And a proposed solution, I think.
Thanks,
Mike Rothman
(迈克 罗斯曼 / माइकल रोथ्मेन् / Михаил Ротман / משה רוטמן)
רועה עיקרי של חתולים
From: Ni, Ray
Sent: Thursday, September 17, 2020 9:28 PM
To: devel@edk2.groups.io
Cc: Wang, Sunny (HPS SW) ; Rothman, Micha
On 09/24/20 15:30, Tom Lendacky wrote:
> On 9/24/20 1:22 AM, Laszlo Ersek wrote:
>> On 09/23/20 20:04, Tom Lendacky wrote:
>>> From: Tom Lendacky
>>>
>>> The AP reset vector stack allocation is only required if running as an
>>> SEV-ES guest. Since the reset vector allocation is below 1MB in memor
Acked-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nikita
> Sent: Tuesday, September 22, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Nikita Ermakov
> Subject: [edk2-devel] [PATCH] BaseTools: Add RISCV64 binding
>
> - Ad
On 9/24/20 1:22 AM, Laszlo Ersek wrote:
On 09/23/20 20:04, Tom Lendacky wrote:
From: Tom Lendacky
The AP reset vector stack allocation is only required if running as an
SEV-ES guest. Since the reset vector allocation is below 1MB in memory,
eliminate the requirement for bare-metal systems and
On 09/24/20 12:21, Malgorzata Kukiello wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982
>
> The workaround in the UEFI memmap construction, near the end of the
> function CoreGetMemoryMap() [MdeModulePkg/Core/Dxe/Mem/Page.c] should
> not clear the SP and CRYPTO bits, because OSes d
OSs are now capable of treating SP and CRYPTO memory as true capabilities
and therefore these should be exposed. This requires usage of a separate
ACCESS_MASK to hide all page-access permission capabilities.
Change in masking and hiding of SP and CRYPTO was introduced in
3bd5c994c879f78e8e3d5346dc
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982
Operating systems are capable of treating SP and CRYPTO memory capabilities
and not as attributes. This means that these capabilites cannot be hidden
from OSs. For this reason, the SP and CRYPTO bits should be separated from
the bitmask that
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982
The workaround in the UEFI memmap construction, near the end of the
function CoreGetMemoryMap() [MdeModulePkg/Core/Dxe/Mem/Page.c] should
not clear the SP and CRYPTO bits, because OSes do (apparently) correctly
interpret SP and CRYPTO as capa
The field validator function provides means to validate fields
in the ACPI table structures. To print complex field types a
print formatter function is provided.
The field validator was being invoked for simple data fields
for which the default print format is used. However, the field
validator fu
This patch series:
- Addresses the feedback for v1 patch for PCCT parser.
- Fixes an issue wherein the field validation is not
invoked when a print formatter is present.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/840_pcct_parser_v2
Marc Moisson-Franckhauser (1):
S
Add missing PcdPciExpressBaseSize default on Ia32 targets analog to X64.
This adjustment relates to the changes in commit:
8028b2907e20b21cd7d69639a36ac82a77c81dc1
Signed-off-by: Marcello Sylvester Bauer
Cc: Patrick Rudolph
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
---
UefiPayloadPkg/Uef
In commit 8028b2907e20b21cd7d69639a36ac82a77c81dc1 I did forget to set the
default value for PcdPciExpressBaseSize on Ia32 Targets. This patch does
inserts it afterwards.
Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg/MMCONF_IA32
PR: https://github.com/tianocore/edk2/pull/956
From: Marc Moisson-Franckhauser
Create a new parser for the PCCT Table.
The PCCT Table is used to describe how the OSPM can
communicate with entities outside the platform. It
describes which memory spaces correspond to which
entity as well as a few of the needed information
to handle the communi
Aaron,
I understand the requirement now.
Can we avoid adding new PCD but re-interpret the ShadowMicrocode() parameter to
achieve the same result?
For example, we can say when CpuIdCount is 0 and MicrocodeCpuId == NULL, it
means all microcode need to be shadowed.
The benefit is: platform can use
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, September 23, 2020 6:52 PM
> To: devel@edk2.groups.io
> Cc: Liang, MingyueX ; Liming Gao
> ; Chen, Christine
> Subject: [PATCH] BaseTools: Add included files to deps_target file.
>
> From: Mingyue Liang
47 matches
Mail list logo
