Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

Reviewed-by: Yuwei Chen > -Original Message- > From: Feng, Bob C > Sent: Wednesday, September 23, 2020 6:58 PM > To: devel@edk2.groups.io > Cc: Liang, MingyueX ; Liming Gao > ; Chen, Christine > Subject: [PATCH] BaseTools: Normalize case of pathname when evaluating > Macros. > > From: M

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 09/23/20 20:04, Tom Lendacky wrote: > From: Tom Lendacky > > The AP reset vector stack allocation is only required if running as an > SEV-ES guest. Since the reset vector allocation is below 1MB in memory, > eliminate the requirement for bare-metal systems and non SEV-ES guests > to allocate t

Re: [edk2-devel] [PATCH] BaseTools: Add included files to deps_target file.

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Wednesday, September 23, 2020 6:52 PM To: devel@edk2.groups.io Cc: Liang, MingyueX ; Liming Gao ; Chen, Christine Subject: [edk2-devel] [PATCH] BaseTools: Add included files to deps_target f

Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Wednesday, September 23, 2020 6:58 PM To: devel@edk2.groups.io Cc: Liang, MingyueX ; Liming Gao ; Chen, Christine Subject: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when ev

Re: [edk2-devel] [Patch] BaseTools: Set section alignment as zero if its type is Auto

Reviewed-by: Yuwei Chen > -Original Message- > From: Feng, Bob C > Sent: Tuesday, September 22, 2020 7:28 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Chen, Christine > > Subject: [Patch] BaseTools: Set section alignment as zero if its type is Auto > > REF: https://bugzilla.tianocor

回复: [edk2-devel] [PATCH] BaseTools: Add RISCV64 binding

Ack-by: Liming Gao > -邮件原件- > 发件人: bounce+27952+65443+4905953+8761...@groups.io > 代表 Nikita > 发送时间: 2020年9月22日 18:38 > 收件人: devel@edk2.groups.io > 抄送: Nikita Ermakov > 主题: [edk2-devel] [PATCH] BaseTools: Add RISCV64 binding > > - Add RISCV64 ProcessorBind.h > > - Add RISCV64 to Makefi

回复: [edk2-devel] [Patch] BaseTools: Set section alignment as zero if its type is Auto

Reviewed-by: Liming Gao > -邮件原件- > 发件人: bounce+27952+65441+4905953+8761...@groups.io > 代表 Bob Feng > 发送时间: 2020年9月22日 19:28 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Yuwei Chen > > 主题: [edk2-devel] [Patch] BaseTools: Set section alignment as zero if its type > is Auto > > REF: htt

Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add PCD for shadowing all microcode.

Hi Ray, Accroding to https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20the%202nd%20Microcode%20FV%20Flash%20Region.pdf The ShadowMicrocodePei provide a FIT based shadow microcode ppi to MpInitLib. It's needed. Best, Aaron > -Original Message- > From: Ni, Ray > Sent: We

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Henz, > Patrick > Sent: Thursday, September 24, 2020 3:36 AM > To: devel@edk2.groups.io > Cc: Patrick Henz ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > > Subject: [edk2-devel] [PATCH v

回复: [edk2-devel] [PATCH 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h

Mike: Sure. Yes. This is the purpose for this change. Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2020年9月24日 0:18 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Kinney, Michael > D > 抄送: Feng, Bob C ; Chen, Christine > > 主题: RE: [edk2-devel] [PATCH 1/1] BaseTools:

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

Agreed. It's random that the previous config worked. On Wed, Sep 23, 2020 at 2:32 PM Andrew Fish wrote: > > > On Sep 23, 2020, at 2:14 PM, Bret Barkelew wrote: > > As far as I can tell, this is exposing a pre-existing race condition in > EndOfDxe. It just so HAPPENS that the old "Disable Reques

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

> On Sep 23, 2020, at 2:14 PM, Bret Barkelew wrote: > > As far as I can tell, this is exposing a pre-existing race condition in > EndOfDxe. It just so HAPPENS that the old "Disable RequestToLock" callback > executed after this TcgMor callback, whereas the new VariablePolicy callback > execut

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

As far as I can tell, this is exposing a pre-existing race condition in EndOfDxe. It just so HAPPENS that the old "Disable RequestToLock" callback executed after this TcgMor callback, whereas the new VariablePolicy callback executes first. I'm going to poke around for a solution, but this seems li

Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

Hi Samer,  (I added you, zhiguang, because you had a similar question) There’s some instructions in the patch series about how to enable RngLib to be used by OpenSSL (on the cover letter) Since this changes the dependencies of OpenSSL, this has the potential of beinga breaking change for platforms

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

Ard/Laszlo/Samer (since you reported issue with RngLib), Is now the time to start a discussion about using submodules or at least tracked dependencies in edk2-platforms. The way it stands the only thing you can use to correlate the two are the timestamp of the commit. This means that the hist

[edk2-devel] [PATCH v3 0/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

From: Patrick Henz Timeouts in the XhciDxe driver are taking longer than expected due to the timeout loops not accounting for code execution time. As en example, 5 second timeouts have been observed to take around 36 seconds to complete. Use SetTimer and Create/CheckEvent from Boot Services to de

[edk2-devel] [PATCH v3 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

From: Patrick Henz REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 Timeouts in the XhciDxe driver are taking longer than expected due to the timeout loops not accounting for code execution time. As en example, 5 second timeouts have been observed to take around 36 seconds to complete. Us

Re: [edk2-devel] [edk2-test][PATCH v1 2/4] uefi-sct/SctPkg: Add SCT User Guide Word document

Reviewed-by: G Edhaya Chandran Upstreamed by Commit ID: https://github.com/tianocore/edk2-test/commit/9655dc86702804e11d5c233596a2aaf52bbe761e -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65541): https://edk2.groups.io/g/devel/message

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

From: Tom Lendacky The AP reset vector stack allocation is only required if running as an SEV-ES guest. Since the reset vector allocation is below 1MB in memory, eliminate the requirement for bare-metal systems and non SEV-ES guests to allocate the extra stack area, which can be large if the PcdC

Re: [edk2-devel] [PATCH 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h

Liming, Thanks. This makes sense now. Can you update commit messages to help explain this. I think what you are describing is the need to share include files between BaseTools and FW packages to remove duplicate include content inside BaseTools. However, building BaseTools needs its own BaseTyp

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Correct issue with memory protection enabled.

Didn't see it at first as it was not at the top of edk2-test but under uefi-sct. CC'd maintainers Thanks, Jeff From: Laszlo Ersek Sent: Wednesday, September 23, 2020 2:59 AM To: devel@edk2.groups.io ; Jeff Brasen Subject: Re: [edk2-devel] [PATCH] uefi-sct/Sc

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 9/23/20 8:58 AM, Tom Lendacky wrote: > On 9/23/20 3:31 AM, Laszlo Ersek wrote: >> On 09/23/20 10:14, Laszlo Ersek wrote: >> >>> (3) Even better... can you modify GetApResetVectorSize() to take >>> &CpuMpData rather than &CpuMpData->AddressMap, and then check >>> CpuMpData->SevEsIsEnabled? >>> >>

Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

Yes. this bug only happens on case insensitive file systems. Thanks, Bob From: Andrew Fish Sent: Wednesday, September 23, 2020 11:31 PM To: edk2-devel-groups-io ; Feng, Bob C Cc: Liang, MingyueX ; Liming Gao ; Chen, Christine Subject: Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pat

Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

Bob, Sorry I was confused by the commit comment `inconsistent path case`. So this was only a bug on case insensitive file systems? I’m paranoid as macOS support case and case insensitive file systems and we have had a lot of strange bugs in the past. Thanks, Andrew Fish > On Sep 23, 2020,

Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

Yes. we did test on Windows and Linux. From the https://docs.python.org/3/library/os.path.html os.path.normcase(path) Normalize the case of a pathname. On Windows, convert all characters in the pathname to lowercase, and also convert forward slashes to backward slashes. On other operating s

Re: [edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

Does this work on case sensitive file systems? > On Sep 23, 2020, at 3:58 AM, Bob Feng wrote: > > From: Mingyue Liang > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2880 > > Currently, When doing the Incremental build, the directory > macros extended to absolute path in output Makefi

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 9/23/20 3:31 AM, Laszlo Ersek wrote: > On 09/23/20 10:14, Laszlo Ersek wrote: > >> (3) Even better... can you modify GetApResetVectorSize() to take >> &CpuMpData rather than &CpuMpData->AddressMap, and then check >> CpuMpData->SevEsIsEnabled? >> >> Hmmm, wait, that's not really simple, as we ca

Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

Divneil, Thanks for this patch. However, it looks like multiple edk2-platforms are broken because of the OpensslLib change. I verified at least the following are broken: - RaspberryPi/RPi3 - RaspberryPi/RPi4 - Qemu/SbsaQemu - Socionext/DeveloperBox - SolidRun/Armada80x0McBin - Hisilicon/D0* Etc.

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

Hi Bret, On 09/23/20 08:12, Bret Barkelew via groups.io wrote: > To whom it may concern, > This is as done as it’s going to get. > > Thank you all for your help! I tried to merge this via , but it failed. Please review the build report, and submit v9

[edk2-devel] [Patch] BaseTools: Remove CanSkip calling for incremental build

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2978 If a module add a new PCD, the pcd token number will be reassigned. The new Pcd token number should be updated to all module's autogen files. CanSkip can only detect a single module's change but not others. CanSkip block the pcd token number

[edk2-devel] [Patch] BaseTools: Clean the ffs folder before generating files in it

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2965 The content in Guid.xref depends on the files under the corresponding ffs folder.(refer to the commit 5e9256cd7f54ffd6f1fd9837df92a911fcd2d7c2) To make Guid.xref update in the incremental build, clean the files under that ffs folder before g

[edk2-devel] [PATCH] BaseTools: Normalize case of pathname when evaluating Macros.

From: Mingyue Liang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2880 Currently, When doing the Incremental build, the directory macros extended to absolute path in output Makefile, which is inconsistent with the output of Clean build. When we do macro replacement, we can't replace macro

[edk2-devel] [PATCH] BaseTools: Add included files to deps_target file.

From: Mingyue Liang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2882 After changing the name of the include source file, when doing incremental build, the previous source file is not covered in the. DEPs file, and a build error occurs. The root cause is that the build tools filter out s

Re: [edk2-devel] [PATCH] MdeModulePkg/Mem: Memory paging related attributes must be separated from others

On 09/23/20 10:08, Malgorzata Kukiello wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982 > > During a recent change (bda18f5ed04f5317ab2bdc9da4530c078b33cc63) that changed > the way memory attributes are handled it affected a function in Page.c that > would clear all memory attribut

Re: [edk2-devel] [PATCH] MdeModulePkg/Mem: Memory paging related attributes must be separated from others

On 09/23/20 10:08, Malgorzata Kukiello wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982 > > During a recent change (bda18f5ed04f5317ab2bdc9da4530c078b33cc63) that changed > the way memory attributes are handled it affected a function in Page.c that > would clear all memory attribute

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

On 9/23/20 12:04 PM, Laszlo Ersek wrote: On 09/23/20 11:43, Laszlo Ersek wrote: On 09/23/20 11:22, Ard Biesheuvel wrote: On 9/23/20 10:45 AM, Laszlo Ersek wrote: On 09/23/20 08:12, Bret Barkelew via groups.io wrote: To whom it may concern, This is as done as it’s going to get. Thank you all

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

On 09/23/20 11:43, Laszlo Ersek wrote: > On 09/23/20 11:22, Ard Biesheuvel wrote: >> On 9/23/20 10:45 AM, Laszlo Ersek wrote: >>> On 09/23/20 08:12, Bret Barkelew via groups.io wrote: To whom it may concern, This is as done as it’s going to get. Thank you all for your help! >>>

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

On 09/23/20 11:22, Ard Biesheuvel wrote: > On 9/23/20 10:45 AM, Laszlo Ersek wrote: >> On 09/23/20 08:12, Bret Barkelew via groups.io wrote: >>> To whom it may concern, >>> This is as done as it’s going to get. >>> >>> Thank you all for your help! >> >> Seems like it's been fully reviewed. If that'

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

On 9/23/20 10:45 AM, Laszlo Ersek wrote: On 09/23/20 08:12, Bret Barkelew via groups.io wrote: To whom it may concern, This is as done as it’s going to get. Thank you all for your help! Seems like it's been fully reviewed. If that's the case -- do you want me to merge it? (Asking because t

Re: [edk2-devel] [PATCH v7 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform

Huzzah! My hero! -- [ Insert obscure pop-culture reference here. ] > On Sep 22, 2020, at 7:47 PM, Ni, Ray wrote: > >  > Reviewed-by: Ray Ni ray...@intel.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65517): https://edk2.groups.i

[edk2-devel] [PATCH] MdeModulePkg/Mem: Memory paging related attributes must be separated from others

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982 During a recent change (bda18f5ed04f5317ab2bdc9da4530c078b33cc63) that changed the way memory attributes are handled it affected a function in Page.c that would clear all memory attributes even security related ones Signed-off-by: Malgorzata

[edk2-devel] [PATCH] MdeModulePkg/Mem: Memory paging related attributes must be separated from others

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2982 During a recent change (bda18f5ed04f5317ab2bdc9da4530c078b33cc63) that changed the way memory attributes are handled it affected a function in Page.c that would clear all memory attributes even security related ones Signed-off-by: Malgorzata

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Correct issue with memory protection enabled.

On 09/23/20 00:13, Jeff Brasen wrote: > Any comments on this change? I suggest CC'ing the maintainers responsible for reviewing this change. (I don't know who they are, unfortunately -- is there a Maintainers.txt file in the uefi-sct tree?) Thanks Laszlo > > > Thanks, > > Jeff > > __

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

On 09/23/20 08:12, Bret Barkelew via groups.io wrote: > To whom it may concern, > This is as done as it’s going to get. > > Thank you all for your help! Seems like it's been fully reviewed. If that's the case -- do you want me to merge it? (Asking because the series modifies multiple packages,

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 09/23/20 10:14, Laszlo Ersek wrote: > (3) Even better... can you modify GetApResetVectorSize() to take > &CpuMpData rather than &CpuMpData->AddressMap, and then check > CpuMpData->SevEsIsEnabled? > > Hmmm, wait, that's not really simple, as we call GetApResetVectorSize() > from MpInitLibInitia

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 09/23/20 10:14, Laszlo Ersek wrote: > On 09/22/20 21:59, Tom Lendacky wrote: >> From: Tom Lendacky >> >> The AP reset vector stack allocation is only required if running as an >> SEV-ES guest. Since the reset vector allocation is below 1MB in memory, >> eliminate the requirement for bare-metal

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 09/22/20 21:59, Tom Lendacky wrote: > From: Tom Lendacky > > The AP reset vector stack allocation is only required if running as an > SEV-ES guest. Since the reset vector allocation is below 1MB in memory, > eliminate the requirement for bare-metal systems and non SEV-ES guests > to allocate th