Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe

2020-08-26 Thread Andrei Warkentin
Reviewed-by: Andrei Warkentin From: Pete Batard Sent: Wednesday, August 26, 2020 6:23 PM To: Samer El-Haj-Mahmoud ; devel@edk2.groups.io Cc: Leif Lindholm ; Ard Biesheuvel ; Andrei Warkentin Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix

Re: [edk2-devel] [PATCH v3 edk2-platforms 5/8] SbsaQemu: AcpiDxe: Create MADT table at runtime

2020-08-26 Thread Tanmay Jagdale
Hi Graeme, On Thu, 27 Aug 2020 at 04:18, Graeme Gregory wrote: > On Wed, Aug 26, 2020 at 04:35:22PM +0100, Graeme Gregory wrote: > > On Tue, Aug 25, 2020 at 07:09:55PM +0530, Tanmay Jagdale wrote: > > > - Add support to create MADT table at runtime. > > > - Included a macro for GIC Redistributo

Re: [edk2-devel] question about EDKII_IOMMU_PROTOCOL

2020-08-26 Thread Tiger Liu(BJ-RD)
Hi, Laszlo: Got it. Thanks -邮件原件- 发件人: Laszlo Ersek 发送时间: 2020年8月26日 18:35 收件人: devel@edk2.groups.io; Tiger Liu(BJ-RD) 主题: Re: [edk2-devel] question about EDKII_IOMMU_PROTOCOL On 08/25/20 09:39, Tiger Liu(BJ-RD) wrote: > Hi, Experts: > I find EDKII_IOMMU_PROTOCOL definition in > MdeMo

回复: [edk2-devel] gEfiMdeModulePkgTokenSpaceGuid.PcdNullPointerDetectionPropertyMask and ExitBootServices

2020-08-26 Thread gaoliming
Fish: If PcdNullPointerDetectionPropertyMask BIT7 is set, it will be disabled on EndOfDxe. Do you mean to always turn off it on ExitBootServices? But, after ExitBootSerivces, there should be no memory allocation. Thanks Liming > -邮件原件- > 发件人: bounce+27952+64665+4905953+8761...@groups.

回复: [edk2-devel] [PATCH v9 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-26 Thread gaoliming
Matthew: > -邮件原件- > 发件人: bounce+27952+64654+4905953+8761...@groups.io > 代表 Matthew > Carlson > 发送时间: 2020年8月27日 4:55 > 收件人: devel@edk2.groups.io > 抄送: Ard Biesheuvel ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Matthew Carlson > > 主题: [edk2-devel] [PATCH v9 2/5] MdePkg: BaseRngLi

回复: [edk2-devel] [PATCH v9 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-26 Thread gaoliming
Matthew: > -邮件原件- > 发件人: bounce+27952+64653+4905953+8761...@groups.io > 代表 Matthew > Carlson > 发送时间: 2020年8月27日 4:55 > 收件人: devel@edk2.groups.io > 抄送: Ard Biesheuvel ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Matthew Carlson > > 主题: [edk2-devel] [PATCH v9 1/5] MdePkg: TimerRngL

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

2020-08-26 Thread Feng Libo
Hello, How about the progress of the Patch Review? Thanks -- Best Regards Feng Libo ZD Technology (Beijing) Co., Ltd 发件人:"丰立波" 发送日期:2020-08-13 10:49:33 收件人:"Jiang, Guomin" 抄送人:"devel@edk2.groups.io" ,"jeremy.lin...@arm.com" ,"Wu, Hao A" ,"Ni, Ray" ,"张超" 主题:Re:RE: [edk2-devel] [PATCH

[edk2-devel] gEfiMdeModulePkgTokenSpaceGuid.PcdNullPointerDetectionPropertyMask and ExitBootServices

2020-08-26 Thread Andrew Fish via groups.io
I think I might have found a case when grub calls ExitBootServices, PcdNullPointerDetectionPropertyMask is TRUE, and grub decided to allocate memory in the guard area…. Is there any code to turn off PcdNullPointerDetectionPropertyMask at ExitBootServices time? Seems like MemoryProtectionExitBo

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe

2020-08-26 Thread Pete Batard
On 2020.08.27 00:20, Samer El-Haj-Mahmoud wrote: Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding extern module global, but did not remove the STATIC declaration, which caused the build to break. Fix the build error by removing STATIC for that module global variable. Cc: Leif

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe

2020-08-26 Thread Samer El-Haj-Mahmoud
Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding extern module global, but did not remove the STATIC declaration, which caused the build to break. Fix the build error by removing STATIC for that module global variable. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc:

Re: [edk2-devel] [PATCH v3 edk2-platforms 5/8] SbsaQemu: AcpiDxe: Create MADT table at runtime

2020-08-26 Thread Graeme Gregory
On Wed, Aug 26, 2020 at 04:35:22PM +0100, Graeme Gregory wrote: > On Tue, Aug 25, 2020 at 07:09:55PM +0530, Tanmay Jagdale wrote: > > - Add support to create MADT table at runtime. > > - Included a macro for GIC Redistributor structure initialisation. > > > > Signed-off-by: Tanmay Jagdale > > ---

[edk2-devel] [PATCH 0/2] OvmfPkg: fix race conditions in VCPU hotplug (for edk2-stable202008)

2020-08-26 Thread Laszlo Ersek
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2929 Repo: https://pagure.io/lersek/edk2.git Branch: cpu_hotplug_races_bz_2929 Proposing these bugfixes for edk2-stable202008. We should either include them in the release, or revert commit 5ba203b54e59 ("OvmfPkg/SmmControl2Dxe: negotiate IC

[edk2-devel] [PATCH 1/2] OvmfPkg/CpuHotplugSmm: fix CPU hotplug race just before SMI broadcast

2020-08-26 Thread Laszlo Ersek
The "virsh setvcpus" (plural) command may hot-plug several VCPUs in quick succession -- it means a series of "device_add" QEMU monitor commands, back-to-back. If a "device_add" occurs *just before* ACPI raises the broadcast SMI, then: - OVMF processes the hot-added CPU well. - However, QEMU's po

[edk2-devel] [PATCH 2/2] OvmfPkg/CpuHotplugSmm: fix CPU hotplug race just after SMI broadcast

2020-08-26 Thread Laszlo Ersek
The "virsh setvcpus" (plural) command may hot-plug several VCPUs in quick succession -- it means a series of "device_add" QEMU monitor commands, back-to-back. If a "device_add" occurs *just after* ACPI raises the broadcast SMI, then: - the CPU_FOREACH() loop in QEMU's ich9_apm_ctrl_changed() cann

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

2020-08-26 Thread Joseph Hemann
gcc_version returned by compiler is a string, and needs to be converted to a integer before testing Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Cc: Samer El-Haj-Mahmoud Signed-off-by: Joseph Hemann Change-Id: I24f3f52c12660928b58e6f836fdef86890688d26 --- uefi-s

[edk2-devel] [PATCH v9 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSS

[edk2-devel] [PATCH v9 0/5] Use RngLib instead of TimerLib for OpensslLib

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on code sty

[edk2-devel] [PATCH v9 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull/8

[edk2-devel] [PATCH v9 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better so

[edk2-devel] [PATCH v9 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better s

[edk2-devel] [PATCH v9 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

2020-08-26 Thread Matthew Carlson
From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D K

Re: [edk2-devel] [PATCH] [EmbeddedPkg]:Update PrePiLib to return DxeCoreEntrypoint

2020-08-26 Thread Guo Dong
Hi Leif and Biesheuvel, Could you help review this patch? Thanks, Guo > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guo Dong > Sent: Saturday, August 1, 2020 4:53 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ard.biesheu...@arm.com > Subject: [edk2-devel] [PA

Re: [edk2-devel] Patch to improve DNS answers parser

2020-08-26 Thread Laszlo Ersek
On 08/26/20 18:24, Leandro G. B. Becker wrote: > Hello folks, > > I made an improvement to DNS client (DnsImpl.c, line 1392) that instead of > abort processing answer records when a record that is not of type PTR is > received, skip the record and goes to the next one if there is one. I had a >

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-26 Thread Laszlo Ersek
On 07/22/20 13:03, Laszlo Ersek wrote: > Hi Pierre, > > On 07/07/20 10:35, PierreGondois wrote: >> From: Pierre Gondois >> >> GCC48_ALL_CC_FLAGS has no dependency on GCC_ALL_CC_FLAGS. >> By definition, there should be such dependency. >> >> The outcomes of this patch is that GCC48_ALL_CC_FLAGS an

[edk2-devel] Patch to improve DNS answers parser

2020-08-26 Thread Leandro G. B. Becker
Hello folks, I made an improvement to DNS client (DnsImpl.c, line 1392) that instead of abort processing answer records when a record that is not of type PTR is received, skip the record and goes to the next one if there is one. I had a problem while resolving some names when DNS receives more

Re: [edk2-devel] [PATCH v3 edk2-platforms 5/8] SbsaQemu: AcpiDxe: Create MADT table at runtime

2020-08-26 Thread Graeme Gregory
On Tue, Aug 25, 2020 at 07:09:55PM +0530, Tanmay Jagdale wrote: > - Add support to create MADT table at runtime. > - Included a macro for GIC Redistributor structure initialisation. > > Signed-off-by: Tanmay Jagdale > --- > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 20

Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-08-26 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, August 26, 2020 3:03 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io; zhiguang@intel.com > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix > buffer ove

Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-26 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, No worries, please let me know if you have any comments/concerns down the road. Thank you, Vladimir > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, August 26, 2020 6:56 AM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com > Cc: Maciej Rabeda ; Zhichao

Re: [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement

2020-08-26 Thread Laszlo Ersek
On 08/18/20 08:26, Qi Zhang wrote: > v4 change: >rename FvEventLogRecordLib to TcgEventLogRecordLib. > v3 change: > add a new lib FvEventLogRecordLib for gerneric code. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 > > The EDKII BIOS calls FSP API in FSP Wrapper Pkg. > This F

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

2020-08-26 Thread Yao, Jiewen
Thank you very much, Laszlo and Liming! Thank you Yao Jiewen > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, August 26, 2020 10:49 PM > To: Yao, Jiewen ; devel@edk2.groups.io; gaoliming > ; 'Leif Lindholm' ; > af...@apple.com; Kinney, Michael D ; Guptha, > Soumya K > Cc: an

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

2020-08-26 Thread Laszlo Ersek
On 08/26/20 12:16, Yao, Jiewen wrote: > HI Laszlo > I checked the history. > > Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with > review-by on V3 patch series in August 15, with comment to rename > FvEventLogRecordLib to TcgEventLogRecordLib. You are correct: https://edk

Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-26 Thread Laszlo Ersek
Hi Vladimir, On 08/25/20 19:20, Vladimir Olovyannikov via groups.io wrote: > Signed-off-by: Vladimir Olovyannikov > Reviewed-by: Maciej Rabeda > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > Cc: Laszlo Ersek > Cc: Samer El-Ha

回复: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

2020-08-26 Thread gaoliming
Jiewen: For this patch set V3, I see you give reviewed-by on Aug 15th https://edk2.groups.io/g/devel/message/64299 For V4, https://edk2.groups.io/g/devel/message/64354, it makes the change per your comment. So, I agree you as SecurityPkg maintainter reviewed-by is OK for V4 patch set. And, I

Re: [edk2-devel] question about EDKII_IOMMU_PROTOCOL

2020-08-26 Thread Laszlo Ersek
On 08/25/20 09:39, Tiger Liu(BJ-RD) wrote: > Hi, Experts: > I find EDKII_IOMMU_PROTOCOL definition in > MdeModulePkg\Include\Protocol\IoMmu.h . > > But I didn't find its define in UEFI Spec or PI Spec. > So, is it a private protocol definition? Yes -- that's why the protocol name starts with the

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

2020-08-26 Thread Yao, Jiewen
HI Laszlo I checked the history. Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with review-by on V3 patch series in August 15, with comment to rename FvEventLogRecordLib to TcgEventLogRecordLib. Qi sent v4 series in August 17, with only naming change from FvEventLogRecordLi

Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/OpensslLib: Commit the auto-generated assembly files for X64

2020-08-26 Thread Laszlo Ersek
On 08/25/20 02:55, Andrew Fish wrote: > > >> On Aug 19, 2020, at 11:06 AM, Laszlo Ersek wrote: >> >> On 08/19/20 17:37, Andrew Fish via groups.io wrote: >>> >>> On Aug 18, 2020, at 2:22 PM, Zurcher, Christopher J wrote: Per the added header comment in process_files.pl:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

2020-08-26 Thread Laszlo Ersek
On 08/25/20 06:20, Vladimir Olovyannikov wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Monday, August 24, 2020 9:52 AM >> To: devel@edk2.groups.io; zhiguang@intel.com; >> vladimir.olovyanni...@broadcom.com >> Cc: Kinney, Michael D ; Gao, Liming >> >> Subject: Re: [edk2-d

Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for edk2-stable202008

2020-08-26 Thread Laszlo Ersek
Hi Jiewen, On 08/26/20 03:19, Yao, Jiewen wrote: > To clarify below: > I just notice this one week delay. It impacts us. > >> https://edk2.groups.io/g/devel/message/64354 >> [PATCH v4 0/8] Need add a FSP binary measurement > > The SecurityPkg patches have not been approved yet, and Bret and > Jiew