Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0

Hello Eric, hello Edhaya, probably due to a maintainer change the patch below was missed out. Could you, please, review and merge it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2438 Best regards Heinrich On 12/28/19 4:37 PM, Heinrich Schuchardt wrote: > REF: https://bugzilla.tianocor

Re: [edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

With this update, Reviewed-by: Liming Gao If no other comment, I will merge this patch set tomorrow. Thanks Liming -Original Message- From: Zhang, Shenglei Sent: 2020年7月30日 11:08 To: Gao, Liming ; devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D Subject: RE:

Re: [edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

> -Original Message- > From: Gao, Liming > Sent: Wednesday, July 29, 2020 10:02 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > > Subject: RE: [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck > > Shenglei: > > >

Re: [EXTERNAL] [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

I believe the ARM platforms already have the change. At least the ArmVirt does and some of the edk2-platforms. This is not news. It’s been broadcast repeatedly for the last 3 months. And the last 6 months. And the last 15 months. - Bret From: Gao, Liming Sent: Wedn

Re: [EXTERNAL] [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

Include Leif. This change adds new library class dependency for the variable driver. So, it requires to update the platform DSC file. It will impact ARM platforms. Thanks Liming From: devel@edk2.groups.io On Behalf Of Bret Barkelew via groups.io Sent: 2020年7月30日 3:56 To: devel@edk2.groups.io;

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixing inconsistent win32 HOME path mapping

In Python 3.8.x the method of mapping the users home path was changed to look at USERPROFILE and then HOMEDRIVE\HOMEPATH. This change removed the check of HOME generated by git BASH based on HOMEDRIVE/HOMEPATH. For users with a USERPROFILE environment variable that does not match the HOMEDRIVE\HOM

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

-Original Message- From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent: 2020年7月29日 23:22 To: edk2-devel-groups-io ; Laszlo Ersek Cc: Kinney, Michael D ; Gao, Liming ; Zhang, Shenglei ; Sean Brogan ; Bret Barkelew ; Dong, Eric ; Gao, Zhichao ; Yao, Jiewen ; Chao

Re: [edk2-devel] [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg Source Debug Page

For your convenience, you can find a rendered version of the markdown here: https://github.com/makubacki/tianocore.github.io/blob/add_ovmf_windbg_instructions/How-to-debug-OVMF-with-QEMU-using-WinDbg.md Thanks, Michael On 7/29/2020 5:08 PM, Jiang, Guomin wrote: Good Job! I will test it this w

Re: [edk2-devel] [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg Source Debug Page

Good Job! I will test it this week and update my test not late than next weekend. Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, July 30, 2020 6:53 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek

[edk2-devel] [edk2-wiki][PATCH v1 2/2] Update OVMF FAQ to include WinDbg enabling instructions

From: Michael Kubacki Includes a link to the WinDbg enabling page in the OVMF FAQ and fixes a broken link to the generic EDK II source level debug page. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- OVMF-FAQ.md | 5 - 1 fi

[edk2-devel] [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg Source Debug Page

From: Michael Kubacki This patch series provides basic information about setting up a source debug session using OvmfPkg with WinDbg and QEMU. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Michael Kubacki Michael Kubacki (2): Add OVMF WinDbg so

Re: [EXTERNAL] [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

Still waiting on some R-bs. Have a new doc that will make it into a v7, if it helps anyone with their review… https://github.com/microsoft/mu_basecore/blob/release/202005/MdeModulePkg/Universal/Variable/UefiVariablePolicy/ReadMe.md Thanks! - Bret From: Bret Barkelew via groups.io

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: pause in WaitForSemaphore() before re-fetch

Most busy waits (spinlocks) in "UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c" already call CpuPause() in their loop bodies; see SmmWaitForApArrival(), APHandler(), and SmiRendezvous(). However, the "main wait" within APHandler(): > // > // Wait for something to happen > // > WaitForSemaph

Re: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

I've attached patch with modifications suggested From: Gao, Liming Sent: Thursday, July 9, 2020 7:45 AM To: De Leon Vazquez, Lorena R ; devel@edk2.groups.io; Lohr, Paul A ; Yao, Jiewen Cc: Kinney, Michael D Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

> On Jul 29, 2020, at 2:21 AM, Laszlo Ersek wrote: > > On 07/29/20 03:32, Kinney, Michael D wrote: >> Hi Liming, >> >> There are exception to PatchCheck as well for line endings and tabs. >> >> Seems like a similar problem, and a single CI plugin could >> support all these cases. > > The ex

Re: [edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

Shenglei: > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, July 29, 2020 8:28 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck > > REF: https://bugz

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule

Reviewed-by: Liming Gao for FmpDevicePkg and MdeModulePkg. > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, July 29, 2020 5:10 PM > To: Jiang, Guomin ; devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; Kinney, > Michael D ; Yao, > Jiewen ; Wang, Jian J ; Gao, > Limi

Re: [edk2-devel] [PATCH] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

Right, so the following platforms break once this patch is merged: - AMD Overdrive, Overdrive 1000, Cello - Hisilicon D03, D05, D06 (some of these due to binary drivers in edk2-non-osi) - Marvell Armada 78x0/80x0, MacchiatoBIN - Raspberry Pi 3/4 I think this provides enough argument to push thi

[edk2-devel] [PATCH v2 01/15] .pytool/Plugin: Add a plugin LicenseCheck

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 Add a plugin to check license conflict for new added files in a patch. It will report out errors when meeting files which are now contributed under BSD-2-Clause-Patent. Cc: Sean Brogan

[edk2-devel] [PATCHv v2 00/15] Add a plugin LicenseCheck in open ci

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 LicenseCheck is now enabled in PatchCheck.py. But there's a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" to suggest revert the change.These patch series introduce a plugin

Re: [edk2-devel] [PATCH] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

Thanks Liming, Yes, this does affect several ARM platforms. Currently running a build test to determine just how many. My preference would be for a change of this magnitude to go in just after a stable tag - what, if any, are the plans for this patch? Best Regards, Leif On Wed, Jul 29, 2020 at

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

On Wed, Jul 29, 2020 at 11:12:02 +0200, Laszlo Ersek wrote: > On 07/29/20 01:33, Kinney, Michael D wrote: > > CI already runs PatchCheck. If we ported PatchCheck to > > a CI plugin, then the plugin could perform both the > > current PatchCheck features and the license check. > > > > What this op

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Socionext: rename Emmc.c to fix build error

On Wed, Jul 29, 2020 at 09:58:20 +0900, Masahisa Kojima wrote: > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/ has both an Emmc.asl > and an Emmc.c file, which the patch(edk2 commit:0a4aa20e8d446 "BaseTools: > Compile AML bytecode arrays into .obj file") both generate an Emmc.obj > in the same o

Re: [edk2-devel] acpiview error handling patches

(change of email) Hi Zhichao, I've amended the patches and respun a v3 version. Any chance you could have a look to see if I've fixed the issues correctly? Cheers, Tom -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63443): https://edk

[edk2-devel] [PATCH 2/2] IntelVTdPmrPei: Fix PMR enabling setting confilct

PMR enabling set by pre-boot DMA protection is cleared by RC when boot guard is enabled. Pre-boot DMA protection should only reset VT-d BAR when it is 0 and reset PMR region when it is not programmed to protect all memory address. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2867 Cc: Ray N

[edk2-devel] [PATCH 1/2] PlatformVTdInfoSamplePei: Install Null Root Entry Table PPI

BIOS uses TE with a null root entry table to block VT-d engine access to block any DMA traffic in pre-memory phase. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2867 Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Sheng Wei --- .../PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c

[edk2-devel] [PATCH 0/2] VTd Pei : Fix PMR enabling setting confilct

PMR enabling set by pre-boot DMA protection is cleared by RC when boot guard is enabled. Pre-boot DMA protection should only reset VT-d BAR when it is 0 and reset PMR region when it is not programmed to protect all memory address. PlatformVTdInfoSamplePei driver installs the null root entry table p

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

On 07/29/20 03:32, Kinney, Michael D wrote: > Hi Liming, > > There are exception to PatchCheck as well for line endings and tabs. > > Seems like a similar problem, and a single CI plugin could > support all these cases. The exceptions for LicenseCheck are individual files that package maintainer

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

On 07/29/20 01:33, Kinney, Michael D wrote: > CI already runs PatchCheck. If we ported PatchCheck to > a CI plugin, then the plugin could perform both the > current PatchCheck features and the license check. > > What this option evaluated? > > If we did provide PatchCheck as a CI plugin, develo

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule

On 07/29/20 09:00, Guomin Jiang wrote: > Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/. > > Signed-off-by: Guomin Jiang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Maintainers.txt | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [edk2-devel] [PATCH 00/16] OvmfPkg: support VCPU hotplug with -D SMM_REQUIRE

Hi Laszlo, Appreciate your feedback! Thank you very much. Jiaxin > -Original Message- > From: Laszlo Ersek > Sent: Saturday, July 25, 2020 12:02 AM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH 00/16] OvmfPkg: support VCPU hotplug > with -D SMM_REQUIRE

Re: [edk2-devel] [PATCH v4 2/3] MdePkg/BasePciExpressLib: Support variable size MMCONF

I only updated BasePciExpressLib because it is the only library used by UefiPayloadPkg, where the change is mandatory for the patch series. Do I have to adapt DxeRuntimePciExpressLib and SmmPciExpressLib too ? Best regards, Marcello On Tue, Jul 28, 2020 at 3:55 AM Gao, Liming wrote: > Thanks fo

Re: [edk2-devel] [PATCH] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

Include Leif and Ard. This change may impact ARM platform. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年6月9日 21:08 To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: Re: [edk2-devel] [PATCH] MdePkg: Remove code wra

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

Mike: I think this is a separate request. I submit BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2868 for it. Thanks Liming -Original Message- From: Kinney, Michael D Sent: 2020年7月29日 9:33 To: Gao, Liming ; Zhang, Shenglei ; devel@edk2.groups.io; Kinney, Michael D Cc: Sean Bro

Re: [edk2-devel] [PATCH 01/15] .pytool/Plugin: Add a plugin LicenseCheck

Shenglei: Readme mentions BSD-2-Clause Plus Patent License, but no BSD-3-Clause Plus Patent License. So, please check BSD-2-Clause Plus Patent License only. Thanks Liming -Original Message- From: Zhang, Shenglei Sent: 2020年7月29日 14:07 To: Kinney, Michael D ; devel@edk2.groups.io Cc:

[edk2-devel] [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule

Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/. Signed-off-by: Guomin Jiang Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 5504bb