Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

Signed-off-by line is too long and exceeds 80 characters requirement. But, it is valid. So, I suggest to enhance PatchCheck.py and skip the check for the lines with Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:. Thanks Liming > -Original Message- > From: devel@edk2.groups.io O

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Zhichao, Thank you for reviewing the patch. I will send v3 tomorrow addressing formatting and variable scope issues. Thank you, Vladimir -Original Message- From: Gao, Zhichao Sent: Wednesday, July 1, 2020 10:55 PM To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com Cc: Samer

Re: [edk2-devel] OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On 7/2/20 3:27 AM, Laszlo Ersek wrote: I'll look at the patches on the list. (I don't believe in reviewing before reviewing. In case I need to make comments for what I find in your repo, I could only make them without any context to quote.) Thanks, I'll wait for the changes to PatchCheck.py to

Re: [edk2-devel] [PATCH v9 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

Hi Tom, I notice that you create a nasm file, which is good for cross-OS. Why do you need to create a c file for the same function for GCC compiler when we can use nasm file in Linux? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sen

Re: [edk2-devel] [PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

Reviewed-by: Zhiguang Liu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vladimir > Olovyannikov via groups.io > Sent: Thursday, July 2, 2020 10:31 AM > To: devel@edk2.groups.io > Cc: Vladimir Olovyannikov ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang > Subject:

Re: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

Paul: This patch is missing to be merged. Lorena: I can't extract the patch from the mail. Can you send the patch to me? I can help merge it. Thanks Liming From: devel@edk2.groups.io On Behalf Of Lohr, Paul A Sent: Thursday, July 2, 2020 9:56 PM To: devel@edk2.groups.io; Yao, Jiewen ; De Le

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Thursday, July 2, 2020 10:32 PM > To: devel@edk2.groups.io; l...@nuviainc.com; Gao, Liming > > Cc: Laszlo Ersek ; Rebecca Cran ; > Andrew Fish ; Justen, Jordan L > ; Kinney, Michael D > Subject: Re:

Re: [edk2-devel] [PATCH V3] MdePkg: Add Serial Terminal Device Type Guid

Create https://github.com/tianocore/edk2/pull/757 for this patch. > -Original Message- > From: Oleksiy Yakovlev > Sent: Thursday, July 2, 2020 3:36 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; fel...@ami.com; oleks...@ami.com > Subject: [PATCH V3] MdePkg: Add S

Re: [edk2-devel] [PATCH 1/2] BaseTools/PatchCheck.py: add exception for diff orderfile

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Leif Lindholm Sent: Thursday, July 2, 2020 11:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH 1/2] BaseTools/PatchCheck.py: add exception for diff orderfile Setup

Re: [edk2-devel] UefiPayloadPkg: assert error in PciHostBridgeDxe

> On Jul 2, 2020, at 3:54 PM, King Sumo wrote: > > Hi, > > When booting UefiPayloadPkg in my system (x86 Denverton SoC, coreboot) an > assert error is generated in the PciHostBridgeDxe driver. > In the InitializePciHostBridge() function if all ASSERT's are ignored (by > commenting out the co

[edk2-devel] UefiPayloadPkg: assert error in PciHostBridgeDxe

Hi, When booting UefiPayloadPkg in my system (x86 Denverton SoC, coreboot) an assert error is generated in the PciHostBridgeDxe driver. In the InitializePciHostBridge() function if all ASSERT's are ignored (by commenting out the code) the boot can move further on until it reaches the UEFI Shell

[edk2-devel] [PATCH V3 3/4] UefiCpuPkg: Update EFI_MEMORY_CACHETYPE_MASK definition

Add EFI_MEMORY_WP attribute to EFI_MEMORY_CACHETYPE_MASK definition. Signed-off-by: Oleksiy Yakovlev --- UefiCpuPkg/CpuDxe/CpuDxe.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h index 9299eaa..b30a896 100644 --- a/Ue

[edk2-devel] [PATCH V3 2/4] MdeModulePkg: Add New Memory Attributes

Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO attributes introduced in UEFI 2.8 (UEFI 2.8, mantis 1919 and 1872) Use attributes bitmasks, defined in MdePkg. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Laszlo Ersek --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 11 ++- MdeMo

[edk2-devel] [PATCH V3 4/4] UefiCpuPkg: Add New Memory Attributes

Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO attributes introduced in UEFI 2.8. (UEFI 2.8, mantis 1919 and 1872). Use attributes bitmasks, defined in MdePkg. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Laszlo Ersek --- UefiCpuPkg/CpuDxe/CpuDxe.c | 11 ---

[edk2-devel] [PATCH V3 0/4] Add New Memory Attributes

This series of patches add usage of new memory attributes EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO, introduced in UEFI2.8 (mantis 1919 and 1872). First patch fix typos in description and introduce two bitmasks for all memory type attributes. Second and fourth patches get rid of multiple memory attr

[edk2-devel] [PATCH V3 1/4] MdePkg: Add New Memory Attributes

Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO attributes introduced in UEFI 2.8 (UEFI 2.8, mantis 1919 and 1872) Fix typos in EFI_MEMORY_CPU_CRYPTO description. Add attributes bitmasks, grouped by type. Signed-off-by: Oleksiy Yakovlev Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao ---

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

That’s also fine. Note that this is not the only place where I receive feedback, however. Some people bring up things over happy hour, too. 😉 Laszlo… whiskey Wednesday? - Bret From: Laszlo Ersek Sent: Thursday, July 2, 2020 4:06 AM To: Bret Barkelew

Re: [edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.header PatchCheck.py

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Leif Lindholm Sent: Thursday, July 2, 2020 11:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.header PatchCheck.py On Debi

[edk2-devel] [PATCH 0/2] BaseTools: minor PatchCheck.py fixes/changes

1: https://github.com/tianocore/edk2/pull/549 failed to merge, since PatchCheck.py reports an error. Add BaseTools/Conf/diff.order to the same exception clause currently used for .gitmodules to permit the merge to progress. 2: On Debian 10, PatchCheck.py fails to run with the system defau

[edk2-devel] [PATCH 2/2] BaseTools: explicitly import email.header PatchCheck.py

On Debian 10 (Buster), when running PatchCheck.py with python2, a backtrace is printed, starting from: File "../edk2/BaseTools/Scripts/PatchCheck.py", line 595, in find_patch_pieces parts = email.header.decode_header(pmail.get('subject')) AttributeError: 'module' object has no attribute

[edk2-devel] [PATCH 1/2] BaseTools/PatchCheck.py: add exception for diff orderfile

SetupGit.py adds BaseTools/Conf/diff.order as a diff orderfile, but that file currently has CRLF line endings, which causes all pattern matches to fail and the ordering remaining unaffected. Add an exception to PatchCheck.py (to the existing .gitmodules clause), so that we can merge the fix to the

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi/Drivers: Add SD card detection

Reviewed-by: Andrei Warkentin Tested-by: Andrei Warkentin Like I said, I am gonna handle the CM3 regresso, so please feel free to merge without waiting on me. A From: devel@edk2.groups.io on behalf of Andrei Warkentin via groups.io Sent: Thursday, July 2, 20

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On 7/2/20 4:13 PM, Leif Lindholm via groups.io wrote: On Thu, Jul 02, 2020 at 13:49:45 +, Gao, Liming wrote: Leif: -Original Message- From: devel@edk2.groups.io On Behalf Of Leif Lindholm Sent: Thursday, July 2, 2020 6:54 PM To: Laszlo Ersek Cc: Rebecca Cran ; edk2-devel-groups-i

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On Thu, Jul 02, 2020 at 13:49:45 +, Gao, Liming wrote: > Leif: > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > > Sent: Thursday, July 2, 2020 6:54 PM > > To: Laszlo Ersek > > Cc: Rebecca Cran ; edk2-devel-groups-io > > ; Ard Biesheuvel ; > > Andr

Re: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

Hello, It seems this did not get checked in. Is there something wrong with the patch itself? Or was this simply submitted incorrectly? I don't see a Bugzilla associated with it is why I ask. Paul A. Lohr - Server Firmware Enabling 512.239.9073 (cell) 512.794.5044 (work) From: devel@edk2.gro

Re: [edk2-devel] [PATCH 3/5] MdePkg: Remove DXE_SMM_DRIVER support for some libraries

Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, June 16, 2020 5:05 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH 3/5] MdePkg: Remove DXE_SMM_DRIVER support for some libraries > > REF: https://bugzilla.tianoc

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

Leif: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Thursday, July 2, 2020 6:54 PM > To: Laszlo Ersek > Cc: Rebecca Cran ; edk2-devel-groups-io > ; Ard Biesheuvel ; > Andrew Fish ; Justen, Jordan L ; > Kinney, Michael D > Subject: Re: [edk2-devel

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Silicon/Broadcom/Bcm283x: GpioLib enhancements

On 7/2/20 2:19 PM, Pete Batard wrote: On 2020.07.02 13:03, Ard Biesheuvel wrote: On 6/29/20 8:39 PM, Pete Batard wrote: * Add GpioPinSet () function to set a GPIO pin value * Add GpioPinGet () function to read a GPIO pin value * Add GpioSetPull () function to set pullup/down state of a GPIO pin

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Silicon/Broadcom/Bcm283x: GpioLib enhancements

On 2020.07.02 13:03, Ard Biesheuvel wrote: On 6/29/20 8:39 PM, Pete Batard wrote: * Add GpioPinSet () function to set a GPIO pin value * Add GpioPinGet () function to read a GPIO pin value * Add GpioSetPull () function to set pullup/down state of a GPIO pin GpioSetPull () supports both the lega

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Silicon/Broadcom/Bcm283x: GpioLib enhancements

On 6/29/20 8:39 PM, Pete Batard wrote: * Add GpioPinSet () function to set a GPIO pin value * Add GpioPinGet () function to read a GPIO pin value * Add GpioSetPull () function to set pullup/down state of a GPIO pin GpioSetPull () supports both the legacy method used on Bcm283[5-7] as well as the

Re: [edk2-devel] [PATCH v1-resend 1/2] ArmPlatformPkg: Fix UART divisor warning

Hi Ard, Leif, I probably have got the 'v1-resend' in subject line wrong. Basically this patch has not changed since the v1 posting. This was last submitted as part of the v3 series which can be seen at https://edk2.groups.io/g/devel/message/59738?p=,,,20,0,0,0::Created,,ArmPlatformPkg%3A+Fix+UAR

[edk2-devel] [PATCH 1/2] Revert "BaseTools/PatchCheck.py: Add LicenseCheck"

This reverts commit a4cfb842fca9693a330cb5435284c1ee8bfbbace. This commit suggests inclusion of non-edk2+license content without a contribution agreement is something the community has made a decision on, which is incorrect. Cc: Shenglei Zhang Cc: Yuwei Chen Cc: Liming Gao Signed-off-by: Leif L

[edk2-devel] [PATCH 2/2] ReadMe.rst: delete statements about other accepted licenses

In the past, the TianoCore Contribution Agreement provided equal to what the (+patent) gives us, but also for all the alternative licenses listed under "Code Contributions". When the contribution agreement was dropped, no conversation was had about this aspect. Until this issue is resolved, only c

[edk2-devel] [PATCH 0/2] Drop suggestions of alternative acceptable licenses

(Echoing https://bugzilla.tianocore.org/show_bug.cgi?id=2834:) In the past, the TianoCore Contribution Agreement provided equal to what the (+patent) gives us, but also for all the alternative licenses listed under "Code Contributions". When the contribution agreement was dropped, no conversation w

Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

On 07/02/20 08:47, Bret Barkelew wrote: > Actually, if you want to leave feedback in the CI test PR that I made for > this version, I’m happy to discuss there as well. > https://github.com/tianocore/edk2/pull/718/files Please let's not do that just yet. Once we have a flag day, we should have r

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: > This likely comes from BaseTools commit a4cfb842fca9 > ("BaseTools/PatchCheck.py: Add LicenseCheck", 2020-06-12). > > One approach would be to remove "VbeShim.h" from the tracked files under > OvmfPkg, replacing it with a PREBUILD comma

Re: [edk2-devel] [PATCH V2 3/3] UefiCpuPkg: Add New Memory Attributes

Hi Oleksiy, On 06/30/20 23:11, Oleksiy Yakovlev wrote: > Hi Laszlo. > > I think WP should be included also. Spec says that WP "typically used as a > cacheability attribute today". > > Do you want me to submit just additional patch for CpuDxe.h, or resubmit the > whole series adding this inclus

Re: [edk2-devel] [PATCH v5 0/5] Compile AML bytecode array into OBJ file

Merged. -Original Message- From: PierreGondois Sent: Wednesday, July 1, 2020 10:06 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; sami.muja...@arm.com; tomas.pi...@arm.com; Feng, Bob C ; Gao, Liming ; n...@arm.com Subject: [PATCH v5 0/5] Compile AML bytecode array into OBJ file Foll

Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Seperate the Udf handler

On 06/29/20 03:47, Gao, Zhichao wrote: > Hi Laszlo, > > Sorry, I didn't put the detail info about the issue. Let me descript here. > > The issue is not only for Red Hat. I found it with ubuntu 18.02 amd64 and > Fedora-20-x86_64 ISO image as well. I didn't view all the linux iso images. OK. Than

Re: [edk2-devel] [patch V2] MdeModulePkg/DisplayEngine: Add Debug message to show mismatch menu info

On 06/28/20 04:16, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2326 > > Currently when meet mismatch case for one-of and ordered-list > menu, just show a popup window to indicate mismatch, no more > info for debugging. This patch is to add more debug message > about mism

Re: [edk2-devel] OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

Hi Rebecca, On 06/26/20 17:38, Rebecca Cran wrote: > I've finished the work to move BhyvePkg into OvmfPkg/Bhyve, and the > changes are available at > https://github.com/bcran/edk2/commit/09cfc08b50992ed3f76459611e8a928b74ed8c8a > . > > Since it's such a large patch (over 400KB, but the vast major

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

Liming, Yes we have instructions to run plugins locally. Since they are not good enough and not easy to find. I provide the following steps. Pre-Requisites * Windows OS * Make sure you have python 3.7.x or newer available on path * Make sure you have git installed and available on path 1. Navig

Re: [edk2-devel] [PATCH v2 2/9] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

Guomin, Can you please separate the coding style change and the functionality change in different patches? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin Jiang > Sent: Thursday, July 2, 2020 1:15 PM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Dong, Eric >

Re: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero

On 7/2/20 8:22 AM, Irene Park wrote: Hello Ard, Would you please kindly review this change? Thank you, Irene Merged as #753, apologies for the delay. Please double check the version I committed - I cleaned up the code slightly -Original Message- From: Samer El-Haj-Mahmoud Sent: Mo

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi/Drivers: Add SD card detection

Testing on the CM3, I don't have MMC storage working. So that's a regression. I also tested Pi 2 and it was fine. I'll take a look (with no timeline). I am okay if you consider merging Pete's patch. I don't think there are that many CM3 UEFI users out there, and Pete's change greatly improves t

Re: [edk2-devel] [PATCH V3] MdePkg: Add Serial Terminal Device Type Guid

Reviewed-by: Zhiguang Liu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Thursday, July 2, 2020 3:36 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; fel...@ami.com; oleks...@ami.com > Subject: [edk2-devel] [PATCH V3] MdeP

Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library support for VMGEXIT

Hi Tom, We have root cause this Mac file format issue. The patch mail from your side include extra two "=0D=0D" , and our test tool convert them to "\r\r". This is Mac file line ending format. So this issue been reported. We have updated our tool to handle this special case. With that change,